July 2025 - gerrit-log - lists.osmocom.org

[M] Change in libosmocore[master]: Send multiple read/recvfrom SQEs in advance

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40494?usp=email ) Change subject: Send multiple read/recvfrom SQEs in advance ...................................................................... Patch Set 7: (1 comment) File src/core/osmo_io_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/1af64f84_ec87c2d5?… : PS7, Line 52: #define IOFD_MSGHDR_READ_SQES 32 IOFD_MSGHDR_MAX_READ_SQES -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id50a8900fa2fe6de553e5025feae7e1e8d501e30 Gerrit-Change-Number: 40494 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 23 Jul 2025 15:15:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 days, 13 hours

1
0
0 0

[M] Change in libosmocore[master]: Add multiple messages buffers to struct iofd_msghdr

by pespin

Attention is currently required from: jolly, laforge. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40491?usp=email ) Change subject: Add multiple messages buffers to struct iofd_msghdr ...................................................................... Patch Set 6: (1 comment) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/87e01b65_5f7fd98d?… : PS3, Line 406: struct msgb *msg = msghdr->msg[0]; > why is this and below always [0]? I see now, because this commit is actually not yet adding support for >1 msgb per msghdr, it's only an intermediate preparation. Please state so in the commit description. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40491?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4fb1067de4615cc22cc6caf99b481491e7f2ef92 Gerrit-Change-Number: 40491 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 23 Jul 2025 15:06:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 days, 13 hours

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/ngap: Use titan native APER enc/dec

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40730?usp=email ) Change subject: library/ngap: Use titan native APER enc/dec ...................................................................... library/ngap: Use titan native APER enc/dec Related: OS#6490 Change-Id: I07b604fbd5d3665fdb48c4193ab58cffa7dd709a --- M 5gc/regen_makefile.sh M library/ngap/NGAP_EncDec.cc 2 files changed, 8 insertions(+), 42 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/5gc/regen_makefile.sh b/5gc/regen_makefile.sh index be45468..5634e21 100755 --- a/5gc/regen_makefile.sh +++ b/5gc/regen_makefile.sh @@ -22,4 +22,4 @@ . ../_buildsystem/regen_makefile.inc.sh -sed -i -e 's/^LINUX_LIBS = -lxml2 -lsctp/LINUX_LIBS = -lxml2 -lsctp -lfftranscode -lgnutls/' Makefile +sed -i -e 's/^LINUX_LIBS = -lxml2 -lsctp/LINUX_LIBS = -lxml2 -lsctp -lgnutls/' Makefile diff --git a/library/ngap/NGAP_EncDec.cc b/library/ngap/NGAP_EncDec.cc index 55430f5..c54868a 100644 --- a/library/ngap/NGAP_EncDec.cc +++ b/library/ngap/NGAP_EncDec.cc @@ -3,62 +3,28 @@ #include <stdarg.h> #include "NGAP_PDU_Descriptions.hh" -extern "C" { -#include <fftranscode/transcode.h> -} - namespace NGAP__Types { TTCN_Module NGAP__EncDec("NGAP_EncDec", __DATE__, __TIME__); OCTETSTRING enc__NGAP__PDU(const NGAP__PDU__Descriptions::NGAP__PDU &pdu) { - uint8_t *aper_buf; - int aper_buf_len; TTCN_Buffer TTCN_buf; TTCN_buf.clear(); - - /* Encode from abstract data type into BER/DER */ pdu.encode(NGAP__PDU__Descriptions::NGAP__PDU_descr_, TTCN_buf, - TTCN_EncDec::CT_BER, BER_ENCODE_DER); - - aper_buf_len = fftranscode_ber2aper(FFTRANSC_T_NGAP, &aper_buf, TTCN_buf.get_data(), TTCN_buf.get_len()); - if (aper_buf_len < 0) { - TTCN_error("fftranscode failed."); - } - - /* make octetstring from output buffer */ - OCTETSTRING ret_val(aper_buf_len, aper_buf); - - /* release dynamically-allocated output buffer */ - fftranscode_free(aper_buf); - - return ret_val; + TTCN_EncDec::CT_PER, PER_ALIGNED); + return OCTETSTRING(TTCN_buf.get_len(), TTCN_buf.get_data()); } NGAP__PDU__Descriptions::NGAP__PDU dec__NGAP__PDU(const OCTETSTRING &stream) { - uint8_t *ber_buf; - int ber_buf_len; - - /* First, decode APER + re-encode as BER */ - ber_buf_len = fftranscode_aper2ber(FFTRANSC_T_NGAP, &ber_buf, (const unsigned char *)stream, stream.lengthof()); - if (ber_buf_len < 0) { - TTCN_error("fftranscode failed."); - } - - /* Then, re-encode from BER to TITAN representation */ - NGAP__PDU__Descriptions::NGAP__PDU ret_dcc; + NGAP__PDU__Descriptions::NGAP__PDU pdu; TTCN_Buffer TTCN_buf; TTCN_buf.clear(); - TTCN_buf.put_s(ber_buf_len, ber_buf); - - ret_dcc.decode(NGAP__PDU__Descriptions::NGAP__PDU_descr_, TTCN_buf, - TTCN_EncDec::CT_BER, BER_ACCEPT_ALL); - - fftranscode_free(ber_buf); - - return ret_dcc; + TTCN_buf.put_os(stream); + pdu.decode(NGAP__PDU__Descriptions::NGAP__PDU_descr_, TTCN_buf, + TTCN_EncDec::CT_PER, PER_ALIGNED); + return pdu; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40730?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I07b604fbd5d3665fdb48c4193ab58cffa7dd709a Gerrit-Change-Number: 40730 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 days, 14 hours

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/ngap: Use titan native APER enc/dec

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40730?usp=email ) Change subject: library/ngap: Use titan native APER enc/dec ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: @laforge@gnumonks.org here I switched to titan native enc/dec -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40730?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I07b604fbd5d3665fdb48c4193ab58cffa7dd709a Gerrit-Change-Number: 40730 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 23 Jul 2025 14:50:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

3 days, 14 hours

1
0
0 0

[M] Change in libosmocore[master]: Automatically increase io_uring, if too small.

by pespin

Attention is currently required from: jolly, laforge. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email ) Change subject: Automatically increase io_uring, if too small. ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > this was based on a discussion aeversberg and I had before he started to wrok on the patch. […] I foresee lots of weird stuff happening only in those "super-rare events" we may not think about or which may end up with undefined behavior, eg. with one socket ending up with sqes in 2 different rings. IMHO we should explore the possibility of, in case io_uring_get_sqe() fails, append the osmo_iofd to some sort of "wait_read_sqe_queue" which is re-attempted every time a completed() event happen on the queue. This sounds like a lot less trouble now and in the future. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id9230146acc8d54bfd44834e783c31b37bd64bca Gerrit-Change-Number: 40725 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 23 Jul 2025 14:39:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 days, 14 hours

1
0
0 0

[M] Change in libosmocore[master]: Send multiple read/recvfrom SQEs in advance

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40494?usp=email ) Change subject: Send multiple read/recvfrom SQEs in advance ...................................................................... Patch Set 7: (6 comments) File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/a381fd9b_75b95dab?… : PS7, Line 240: iofd->u.uring.read_msghdr = NULL; This one probably needs to be moved above around line 238? https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/61ece964_a0154af1?… : PS7, Line 216: goto submit_again; this goto can be implemented by simple recursive call: if (iofd->u.uring.read_len < g_io_uring_read_sqes) iofd_uring_submit_recv(iofd, action) And then, I actually wonder why isn't this implemented as a proper C loop? while (iofd->u.uring.read_len < g_io_uring_read_sqes) { ... } https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/52d75e18_cd0be26a?… : PS7, Line 231: LOGP(DLIO, LOGL_DEBUG, "Read SQE completion, but msghdr not found, please fix!\n"); sounds like LOGL_FATAL instead ;) https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/420f882f_f40b043d?… : PS7, Line 238: missing =NULL for last read_msghdr? https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/bf164ddc_8a678e11?… : PS7, Line 470: int idx; unsigned int https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/5d4fb40e_605814e6?… : PS7, Line 473: msghdr = iofd->u.uring.read_msghdr[idx]; iofd->u.uring.read_msghdr[idx] = NULL; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id50a8900fa2fe6de553e5025feae7e1e8d501e30 Gerrit-Change-Number: 40494 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 23 Jul 2025 14:29:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 days, 14 hours

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/ngap: Use titan native APER enc/dec

by osmith

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40730?usp=email ) Change subject: library/ngap: Use titan native APER enc/dec ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40730?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I07b604fbd5d3665fdb48c4193ab58cffa7dd709a Gerrit-Change-Number: 40730 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Jul 2025 14:22:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 days, 14 hours

1
0
0 0

[M] Change in libosmocore[master]: Add multiple messages buffers to io_uring write operations

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40493?usp=email ) Change subject: Add multiple messages buffers to io_uring write operations ...................................................................... Patch Set 7: (2 comments) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/e78c3773_ac38c49c?… : PS4, Line 444: /* Re-enqueue remaining buffers. */ > Then we must change the way the tx_queue stores. […] No, what I mean is that in here a function should be called to re-arrange msgs inside msghdrs in the list to make sure we fill the arrays of msgs of the first msghdrs enqueued. Otherwise we may end up submitting half-filled msghdr->{msg,iov}[] as a consequence of this code path. Feel free to submit a proper function to squeeze those in a follow-up commit, but at least add a TODO here in a comment explaining that. IMHO this should be implemented before doing any benchmarking. File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/426576b2_c1ebc583?… : PS7, Line 442: /* Re-enqueue the complete msgb. */ This can be moved to the top of the function before the for loop, to simplify function now that you added the loop. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40493?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8c4e0a785cf66becd7fb5b2caf718c9724b56686 Gerrit-Change-Number: 40493 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 23 Jul 2025 14:18:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 days, 14 hours

1
0
0 0

[M] Change in libosmocore[master]: Add multiple messages buffers to struct iofd_msghdr

by pespin

Attention is currently required from: jolly, laforge. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40491?usp=email ) Change subject: Add multiple messages buffers to struct iofd_msghdr ...................................................................... Patch Set 6: (4 comments) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/8fdce964_6ad3d2c2?… : PS6, Line 747: * If your osmo_io_fd is in OSMO_IO_FD_MODE_READ_WRITE mode, this API function can be used to tell the Please add proper doxygen documentation of params here. https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/155cebec_e6facfe4?… : PS6, Line 748: * osmo_io code how many buffers should be read or written with a single read or write operation. "read or write". Extra space. https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/97467d14_19cb241b?… : PS6, Line 751: int osmo_iofd_set_io_buffers(struct osmo_io_fd *iofd, int buffers) unsigned int buffers? Only reason to use an "int" here would be to allow some sort of -1=default, which I don't see documented. File src/core/osmo_io_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/03e7a402_06382545?… : PS6, Line 143: int io_len; this can also be a unsigned int. And even actually a uint8_t. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40491?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4fb1067de4615cc22cc6caf99b481491e7f2ef92 Gerrit-Change-Number: 40491 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 23 Jul 2025 14:04:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 days, 14 hours

1
0
0 0

[M] Change in libosmocore[master]: Add multiple messages buffers to struct iofd_msghdr

by pespin

Attention is currently required from: jolly, laforge. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40491?usp=email ) Change subject: Add multiple messages buffers to struct iofd_msghdr ...................................................................... Patch Set 6: (1 comment) File src/core/osmo_io_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/7f1cd00c_291ae212?… : PS5, Line 143: int io_len; > Without it, we would have extra loops. I want to avoid that. […] Fine then, just wanted to make sure whether we can simply change the existing loops to something like "while(msgb[idx]) { ....; idx++ }". -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40491?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4fb1067de4615cc22cc6caf99b481491e7f2ef92 Gerrit-Change-Number: 40491 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 23 Jul 2025 14:01:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 days, 14 hours

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2025