July 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-uecups[master]: gtp_endpoint: Avoid deadlocks logging while thread is cancelled

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-uecups/+/40788?usp=email ) Change subject: gtp_endpoint: Avoid deadlocks logging while thread is cancelled ...................................................................... Patch Set 1: Code-Review-1 (2 comments) File daemon/gtp_endpoint.c: https://gerrit.osmocom.org/c/osmo-uecups/+/40788/comment/0d8b6a5f_bda61e9b?… : PS1, Line 89: LOGEP(ep, LOGL_NOTICE, "Short GTP Message according to flags 0x%02x: %lu < len=%u\n", missing `pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &old_cancelst_unused);` before this line? https://gerrit.osmocom.org/c/osmo-uecups/+/40788/comment/93b9dcb4_5946f603?… : PS1, Line 96: LOGEP(ep, LOGL_NOTICE, "Short GTP Message according to flags 0x%02x: %lu < len=%u\n", missing `pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &old_cancelst_unused);` before this line? -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/40788?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I1e141175440402a7db34f3d246104c6ea38031fb Gerrit-Change-Number: 40788 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Jul 2025 09:44:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 month, 3 weeks

1
0
0 0

[XS] Change in osmo-uecups[master]: tun_device: Make sure struct iphdr access is 4-byte aligned

by osmith

Attention is currently required from: Hoernchen, fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-uecups/+/40787?usp=email ) Change subject: tun_device: Make sure struct iphdr access is 4-byte aligned ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/40787?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I610c8e9b150c234b7d4997e0b1c4d4a9ce4de9ec Gerrit-Change-Number: 40787 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Jul 2025 09:41:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 3 weeks

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: debian/control: add pkg-config

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40791?usp=email ) Change subject: debian/control: add pkg-config ...................................................................... debian/control: add pkg-config Fix that enftables doesn't link against nftables during the build because pkg-config was missing. Fix for: "Failed to load NIF library: '/usr/lib/osmo-s1gw/lib/enftables-0.0.0/priv/enftables.so: undefined symbol: nft_ctx_get_error_buffer'"}}} Change-Id: I327b385112daa7a9c4c9e270e8f07dbe0b70f763 --- M debian/control 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/debian/control b/debian/control index f5dda19..b0bb9b4 100644 --- a/debian/control +++ b/debian/control @@ -5,6 +5,7 @@ Build-Depends: erlang-nox, libnftables-dev, rebar3, + pkg-config, debhelper (>= 10) Standards-Version: 4.5.0 Vcs-Git: https://gitea.osmocom.org/erlang/osmo-s1gw -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40791?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I327b385112daa7a9c4c9e270e8f07dbe0b70f763 Gerrit-Change-Number: 40791 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 month, 3 weeks

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: debian/control: add pkg-config

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40791?usp=email ) Change subject: debian/control: add pkg-config ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40791?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I327b385112daa7a9c4c9e270e8f07dbe0b70f763 Gerrit-Change-Number: 40791 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Jul 2025 09:33:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 3 weeks

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: contrib/osmo-s1gw.sh: fix 'Illegal option -h'

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40792?usp=email ) Change subject: contrib/osmo-s1gw.sh: fix 'Illegal option -h' ...................................................................... contrib/osmo-s1gw.sh: fix 'Illegal option -h' Change-Id: I6a1f9cc69386de9938d841dca770a0eace95c2d4 Fixes: 9c3a38c ("contrib/osmo-s1gw.sh: add help") Related: SYS#7332 --- M contrib/osmo-s1gw.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/92/40792/1 diff --git a/contrib/osmo-s1gw.sh b/contrib/osmo-s1gw.sh index 5d3e8dd..665f110 100755 --- a/contrib/osmo-s1gw.sh +++ b/contrib/osmo-s1gw.sh @@ -33,7 +33,7 @@ } # Parse command line options, if any -while getopts "c:C:n:r:s" opt; do +while getopts "c:C:hn:r:s" opt; do case "$opt" in c) CONFIG="$OPTARG" -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40792?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I6a1f9cc69386de9938d841dca770a0eace95c2d4 Gerrit-Change-Number: 40792 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 month, 3 weeks

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: debian/control: add pkg-config

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40791?usp=email ) Change subject: debian/control: add pkg-config ...................................................................... debian/control: add pkg-config Fix that enftables doesn't link against nftables during the build because pkg-config was missing. Fix for: "Failed to load NIF library: '/usr/lib/osmo-s1gw/lib/enftables-0.0.0/priv/enftables.so: undefined symbol: nft_ctx_get_error_buffer'"}}} Change-Id: I327b385112daa7a9c4c9e270e8f07dbe0b70f763 --- M debian/control 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/91/40791/1 diff --git a/debian/control b/debian/control index f5dda19..b0bb9b4 100644 --- a/debian/control +++ b/debian/control @@ -5,6 +5,7 @@ Build-Depends: erlang-nox, libnftables-dev, rebar3, + pkg-config, debhelper (>= 10) Standards-Version: 4.5.0 Vcs-Git: https://gitea.osmocom.org/erlang/osmo-s1gw -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40791?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I327b385112daa7a9c4c9e270e8f07dbe0b70f763 Gerrit-Change-Number: 40791 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 month, 3 weeks

1
0
0 0

[S] Change in ...osmo-s1gw[master]: Add GSMTAP logging handler

by osmith

osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39415?usp=email ) Change subject: Add GSMTAP logging handler ...................................................................... Patch Set 10: Code-Review+1 (1 comment) File config/sys.config: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39415/comment/0fcdbab3_2575… : PS9, Line 39: app_name => "OsmoS1GW"}}}, > Neither we enable statsd by default, but here it's enabled ;) Acknowledged -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39415?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Iea884e2ca146b852c64bd9f135d8c71f4c925f09 Gerrit-Change-Number: 39415 Gerrit-PatchSet: 10 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Jul 2025 08:29:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 month, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: 5gc: Introduce test TC_ng_register_ping4_256

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40786?usp=email ) Change subject: 5gc: Introduce test TC_ng_register_ping4_256 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40786?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7282fa3c1a474c4b7dceeb5e358547dcdbd1fea6 Gerrit-Change-Number: 40786 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Jul 2025 07:46:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library: Comment out debugging for NGAP/5G-NAS

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40785?usp=email ) Change subject: library: Comment out debugging for NGAP/5G-NAS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40785?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4250766644742f0fd11ca5e24b1a1a581dc81b4b Gerrit-Change-Number: 40785 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Jul 2025 07:42:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: 5gc: Implement PDU Session Release procedure

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40779?usp=email ) Change subject: 5gc: Implement PDU Session Release procedure ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File 5gc/ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40779/comment/2c5d25b2_8d05… : PS2, Line 407: bit2oct(nas_cause Can you pass `cmd.pDUSessionResourceReleaseCommandTransfer` directly here? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40779/comment/c9bf011d_3202… : PS2, Line 418: li_resp := { it_resp }; I think you can do `li_resp[i] := it_resp` unconditionally here. At least this works for S1AP stuff (grep for `items[i] :=` in `S1GW_ConnHdlr`). -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40779?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If79cb0c97008e7a9885bb548a3d2e67e41ba170f Gerrit-Change-Number: 40779 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Jul 2025 07:41:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 month, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2025