July 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: NGAP_Functions.ttcn: Fix wrong offset of NGAP_ID_pair in uEContextRel...

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40780?usp=email ) Change subject: NGAP_Functions.ttcn: Fix wrong offset of NGAP_ID_pair in uEContextReleaseCommand ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40780?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2302bebf75530f574a7fe2647b1eafcc4d5fd7df Gerrit-Change-Number: 40780 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Jul 2025 06:11:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 3 weeks

1
0
0 0

[S] Change in ...osmo-s1gw[master]: Add GSMTAP logging handler

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39415?usp=email ) Change subject: Add GSMTAP logging handler ...................................................................... Add GSMTAP logging handler This patch integrates a logging handler [1][2] for Erlang's built-in logger. It sends logging messages via GSMTAP (udp/4729), allowing capture of log messages alongside with other PDUs (S1AP, PFCP) sent/received by the gateway. The new handler is added to the example configuration, sending all logging messages (DEBUG and above) to 127.0.0.1 by default. [1] https://www.erlang.org/doc/apps/kernel/logger_handler.html [2] https://gitea.osmocom.org/erlang/logger_gsmtap Change-Id: Iea884e2ca146b852c64bd9f135d8c71f4c925f09 --- M config/sys.config M rebar.config M rebar.lock M src/osmo_s1gw.app.src 4 files changed, 15 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve diff --git a/config/sys.config b/config/sys.config index f73b33f..4e5a80c 100644 --- a/config/sys.config +++ b/config/sys.config @@ -31,10 +31,15 @@ %% kernel config %% ================================================================================ {kernel, - [{logger_level, info}, + [{logger_level, debug}, {logger, - [{handler, default, logger_std_h, - #{formatter => + [{handler, gsmtap, logger_gsmtap_h, + #{level => debug, + config => #{rem_addr => "127.0.0.1", + app_name => "OsmoS1GW"}}}, + {handler, default, logger_std_h, + #{level => info, + formatter => {logger_color_formatter, #{legacy_header => false, single_line => false, template => [time, " ", color, "[", level, "]", diff --git a/rebar.config b/rebar.config index 47ff372..de8b023 100644 --- a/rebar.config +++ b/rebar.config @@ -7,6 +7,8 @@ %% run-time deps {deps, [{logger_color_formatter, {git, "https://github.com/rlipscombe/logger_color_formatter.git", {tag, "0.5.0"}}}, + {logger_gsmtap, + {git, "https://gitea.osmocom.org/erlang/logger_gsmtap.git", {branch, "master"}}}, {pfcplib, {git, "https://github.com/travelping/pfcplib.git", {branch, "master"}}}, {enftables, diff --git a/rebar.lock b/rebar.lock index ccee08d..02a4edf 100644 --- a/rebar.lock +++ b/rebar.lock @@ -21,6 +21,10 @@ {git,"https://github.com/rlipscombe/logger_color_formatter.git", {ref,"f1c96f979e6350f8cd787d27fe9ff003cbf3416b"}}, 0}, + {<<"logger_gsmtap">>, + {git,"https://gitea.osmocom.org/erlang/logger_gsmtap.git", + {ref,"e0d803fc1b1b1b66ec0c6986d1c542423ebc0320"}}, + 0}, {<<"parse_trans">>,{pkg,<<"parse_trans">>,<<"3.4.1">>},1}, {<<"pfcplib">>, {git,"https://github.com/travelping/pfcplib.git", diff --git a/src/osmo_s1gw.app.src b/src/osmo_s1gw.app.src index e64fb93..13240dd 100644 --- a/src/osmo_s1gw.app.src +++ b/src/osmo_s1gw.app.src @@ -8,6 +8,7 @@ kernel, stdlib, logger_color_formatter, + logger_gsmtap, pfcplib, enftables, exometer_core, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39415?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Iea884e2ca146b852c64bd9f135d8c71f4c925f09 Gerrit-Change-Number: 39415 Gerrit-PatchSet: 10 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 month, 3 weeks

1
0
0 0

[S] Change in ...osmo-s1gw[master]: Add GSMTAP logging handler

by fixeria

Attention is currently required from: laforge, osmith. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39415?usp=email ) Change subject: Add GSMTAP logging handler ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39415?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Iea884e2ca146b852c64bd9f135d8c71f4c925f09 Gerrit-Change-Number: 39415 Gerrit-PatchSet: 10 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 30 Jul 2025 22:19:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 3 weeks

1
0
0 0

[S] Change in ...osmo-s1gw[master]: Add GSMTAP logging handler

by fixeria

Attention is currently required from: laforge, osmith. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39415?usp=email ) Change subject: Add GSMTAP logging handler ...................................................................... Patch Set 9: (1 comment) File config/sys.config: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39415/comment/582f397d_ac15… : PS9, Line 39: app_name => "OsmoS1GW"}}}, > AFAIK we don't enable gsmtap logging by default in other Osmocom default configs. […] Neither we enable statsd by default, but here it's enabled ;) -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39415?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Iea884e2ca146b852c64bd9f135d8c71f4c925f09 Gerrit-Change-Number: 39415 Gerrit-PatchSet: 9 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 30 Jul 2025 21:57:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 month, 3 weeks

1
0
0 0

[XS] Change in osmo-uecups[master]: tun_device: Fix Tx uninitialized gtpu ext hdr fields

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-uecups/+/40790?usp=email ) Change subject: tun_device: Fix Tx uninitialized gtpu ext hdr fields ...................................................................... tun_device: Fix Tx uninitialized gtpu ext hdr fields Change-Id: Ie1d4b2d8cd659fd23811c5330d8ae0e43ff0a0d2 --- M daemon/tun_device.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-uecups refs/changes/90/40790/1 diff --git a/daemon/tun_device.c b/daemon/tun_device.c index 3444b2d..b32c08a 100644 --- a/daemon/tun_device.c +++ b/daemon/tun_device.c @@ -182,8 +182,11 @@ if (t->exthdr.pdu_sess_container.enabled) { exthdr->array[0].type = GTP1_EXTHDR_PDU_SESSION_CONTAINER; exthdr->array[0].len = 1; + exthdr->array[0].spare1 = 0; exthdr->array[0].pdu_type = t->exthdr.pdu_sess_container.pdu_type; exthdr->array[0].qos_flow_identifier = t->exthdr.pdu_sess_container.qos_flow_identifier; + exthdr->array[0].reflective_qos_indicator = 0; + exthdr->array[0].paging_policy_presence = 0; exthdr->array[1].type = 0; /* No extension headers */ } else { exthdr->array[0].type = 0; /* No extension headers */ -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/40790?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: Ie1d4b2d8cd659fd23811c5330d8ae0e43ff0a0d2 Gerrit-Change-Number: 40790 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 month, 3 weeks

1
0
0 0

[S] Change in osmo-uecups[master]: Set thread names

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-uecups/+/40789?usp=email ) Change subject: Set thread names ...................................................................... Set thread names Change-Id: I9b44dd9eeb1d8e291c35d1d4a040a1425ba7c305 --- M daemon/gtp_endpoint.c M daemon/tun_device.c 2 files changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-uecups refs/changes/89/40789/1 diff --git a/daemon/gtp_endpoint.c b/daemon/gtp_endpoint.c index 08c0f44..bcd3ce3 100644 --- a/daemon/gtp_endpoint.c +++ b/daemon/gtp_endpoint.c @@ -1,4 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0 */ + +/*pthread.h pthread_setname_np(): */ +#define _GNU_SOURCE + #include <stdint.h> #include <stdbool.h> #include <stdlib.h> @@ -135,8 +139,12 @@ { struct gtp_endpoint *ep = (struct gtp_endpoint *)arg; int old_cancelst_unused; + char thread_name[16]; uint8_t buffer[sizeof(struct gtp1_header) + sizeof(struct gtp1_exthdr) + MAX_UDP_PACKET]; + snprintf(thread_name, sizeof(thread_name), "RxGtpu%s", ep->name); + pthread_setname_np(pthread_self(), thread_name); + while (1) { int rc; diff --git a/daemon/tun_device.c b/daemon/tun_device.c index 5d71147..3444b2d 100644 --- a/daemon/tun_device.c +++ b/daemon/tun_device.c @@ -1,4 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0 */ + +/*pthread.h pthread_setname_np(): */ +#define _GNU_SOURCE + #include <unistd.h> #include <stdint.h> #include <stdbool.h> @@ -200,6 +204,7 @@ { struct tun_device *tun = (struct tun_device *)arg; struct gtp_daemon *d = tun->d; + char thread_name[16]; /* Make sure "buffer" below ends up aligned to 4byte so that it can access struct iphdr in a 4-byte aligned way. */ const size_t payload_off_4byte_aligned = ((sizeof(struct gtp1_header) + sizeof(struct gtp1_exthdr)) + 3) & (~0x3); uint8_t base_buffer[payload_off_4byte_aligned + MAX_UDP_PACKET]; @@ -211,6 +216,9 @@ * holding the logging mutex, hence causing deadlock with main (or other) * thread. */ + snprintf(thread_name, sizeof(thread_name), "Rx%s", tun->devname); + pthread_setname_np(pthread_self(), thread_name); + while (1) { struct gtp_tunnel *t; struct pkt_info pinfo; -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/40789?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I9b44dd9eeb1d8e291c35d1d4a040a1425ba7c305 Gerrit-Change-Number: 40789 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 month, 3 weeks

1
0
0 0

[XS] Change in osmo-uecups[master]: tun_device: Make sure struct iphdr access is 4-byte aligned

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-uecups/+/40787?usp=email ) Change subject: tun_device: Make sure struct iphdr access is 4-byte aligned ...................................................................... tun_device: Make sure struct iphdr access is 4-byte aligned "struct iphdr" from netinet/ip.h used in parse_pkt() is not "packed", hence compiler expects to find the struct pointer aligned to 4-bytes. Re-arrange the stack buffer to make sure iphdr ends up being stored aligned. This was caught by running osmo-uecups with --enable-sanitize in TTCN3 testsuite ttcn3-5gc-test. Change-Id: I610c8e9b150c234b7d4997e0b1c4d4a9ce4de9ec --- M daemon/tun_device.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-uecups refs/changes/87/40787/1 diff --git a/daemon/tun_device.c b/daemon/tun_device.c index 6a0d8b6..5d71147 100644 --- a/daemon/tun_device.c +++ b/daemon/tun_device.c @@ -200,7 +200,9 @@ { struct tun_device *tun = (struct tun_device *)arg; struct gtp_daemon *d = tun->d; - uint8_t base_buffer[sizeof(struct gtp1_header) + sizeof(struct gtp1_exthdr) + MAX_UDP_PACKET]; + /* Make sure "buffer" below ends up aligned to 4byte so that it can access struct iphdr in a 4-byte aligned way. */ + const size_t payload_off_4byte_aligned = ((sizeof(struct gtp1_header) + sizeof(struct gtp1_exthdr)) + 3) & (~0x3); + uint8_t base_buffer[payload_off_4byte_aligned + MAX_UDP_PACKET]; int old_cancelst_unused; pthread_cleanup_push(tun_device_pthread_cleanup_routine, tun); @@ -213,7 +215,7 @@ struct gtp_tunnel *t; struct pkt_info pinfo; int rc, nread; - uint8_t *buffer = base_buffer + sizeof(base_buffer) - MAX_UDP_PACKET; + uint8_t *buffer = base_buffer + payload_off_4byte_aligned; /* 1) read from tun */ rc = read(tun->fd, buffer, MAX_UDP_PACKET); -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/40787?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I610c8e9b150c234b7d4997e0b1c4d4a9ce4de9ec Gerrit-Change-Number: 40787 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 month, 3 weeks

1
0
0 0

[S] Change in osmo-uecups[master]: gtp_endpoint: Avoid deadlocks logging while thread is cancelled

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-uecups/+/40788?usp=email ) Change subject: gtp_endpoint: Avoid deadlocks logging while thread is cancelled ...................................................................... gtp_endpoint: Avoid deadlocks logging while thread is cancelled We cannot garantee that LOGP will not end up calling a syscall which can be a cancellation point. Since the syscall will be probably called while having the logging mutex locked, an eventual cancellation of the thread would leave the logging mutex locked forever, hence making all other threads deadlock as soon as they try to write anything to the log. Similar to what's already done in tun_device_thread(). Change-Id: I1e141175440402a7db34f3d246104c6ea38031fb --- M daemon/gtp_endpoint.c 1 file changed, 23 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-uecups refs/changes/88/40788/1 diff --git a/daemon/gtp_endpoint.c b/daemon/gtp_endpoint.c index bb417da..08c0f44 100644 --- a/daemon/gtp_endpoint.c +++ b/daemon/gtp_endpoint.c @@ -36,27 +36,36 @@ int rc, outfd; uint32_t teid; uint16_t gtp_len; + int old_cancelst_unused; if (nread < sizeof(*gtph)) { + pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &old_cancelst_unused); LOGEP(ep, LOGL_NOTICE, "Short read: %u < %lu\n", nread, sizeof(*gtph)); + pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, &old_cancelst_unused); return; } gtph = (struct gtp1_header *)buffer; /* check GTP header contents */ if ((gtph->flags & 0xf0) != 0x30) { + pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &old_cancelst_unused); LOGEP(ep, LOGL_NOTICE, "Unexpected GTP Flags: 0x%02x\n", gtph->flags); + pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, &old_cancelst_unused); return; } if (gtph->type != GTP_TPDU) { + pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &old_cancelst_unused); LOGEP(ep, LOGL_NOTICE, "Unexpected GTP Message Type: 0x%02x\n", gtph->type); + pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, &old_cancelst_unused); return; } gtp_len = ntohs(gtph->length); if (sizeof(*gtph)+gtp_len > nread) { + pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &old_cancelst_unused); LOGEP(ep, LOGL_NOTICE, "Short GTP Message: %lu < len=%u\n", sizeof(*gtph)+gtp_len, nread); + pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, &old_cancelst_unused); return; } teid = ntohl(gtph->tid); @@ -65,8 +74,10 @@ if (gtph->flags & GTP1_F_MASK) { const struct gtp1_exthdr *exthdr = (const struct gtp1_exthdr *)payload; if (gtp_len < 4) { + pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &old_cancelst_unused); LOGEP(ep, LOGL_NOTICE, "Short GTP Message according to flags 0x%02x: %lu < len=%u\n", gtph->flags, sizeof(*gtph) + gtp_len, nread); + pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, &old_cancelst_unused); return; } gtp_len -= 4; @@ -77,12 +88,14 @@ if (gtp_len < 1) { LOGEP(ep, LOGL_NOTICE, "Short GTP Message according to flags 0x%02x: %lu < len=%u\n", gtph->flags, sizeof(*gtph) + gtp_len, nread); + pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, &old_cancelst_unused); return; } ext_len = 1 + 1 + it[1] + 1; if (gtp_len < ext_len) { LOGEP(ep, LOGL_NOTICE, "Short GTP Message according to flags 0x%02x: %lu < len=%u\n", gtph->flags, sizeof(*gtph) + gtp_len, nread); + pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, &old_cancelst_unused); return; } gtp_len -= ext_len; @@ -96,7 +109,9 @@ t = _gtp_tunnel_find_r(d, teid, ep); if (!t) { pthread_rwlock_unlock(&d->rwlock); + pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &old_cancelst_unused); LOGEP(ep, LOGL_NOTICE, "Unable to find tunnel for TEID=0x%08x\n", teid); + pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, &old_cancelst_unused); return; } outfd = t->tun_dev->fd; @@ -105,16 +120,21 @@ /* 3) write to TUN device */ rc = write(outfd, payload, gtp_len); if (rc < gtp_len) { + pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &old_cancelst_unused); LOGEP(ep, LOGL_FATAL, "Error writing to tun device %s\n", strerror(errno)); exit(1); } } -/* one thread for reading from each GTP/UDP socket (GTP decapsulation -> tun) */ +/* one thread for reading from each GTP/UDP socket (GTP decapsulation -> tun) + * IMPORTANT!: All logging functions in this function block must be called with + * PTHREAD_CANCEL_DISABLE set, otherwise the thread could be cancelled while + * holding the logging mutex, hence causing deadlock with main (or other) + * thread. */ static void *gtp_endpoint_thread(void *arg) { struct gtp_endpoint *ep = (struct gtp_endpoint *)arg; - + int old_cancelst_unused; uint8_t buffer[sizeof(struct gtp1_header) + sizeof(struct gtp1_exthdr) + MAX_UDP_PACKET]; while (1) { @@ -123,6 +143,7 @@ /* 1) read GTP packet from UDP socket */ rc = recvfrom(ep->fd, buffer, sizeof(buffer), 0, (struct sockaddr *)NULL, 0); if (rc < 0) { + pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &old_cancelst_unused); LOGEP(ep, LOGL_FATAL, "Error reading from UDP socket: %s\n", strerror(errno)); exit(1); } -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/40788?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I1e141175440402a7db34f3d246104c6ea38031fb Gerrit-Change-Number: 40788 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 month, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: 5gc: Implement PDU Session Release procedure

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40779?usp=email ) Change subject: 5gc: Implement PDU Session Release procedure ...................................................................... Patch Set 2: (1 comment) File 5gc/ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40779/comment/b0ec2e44_f6b1… : PS1, Line 479: } > TODO: Tx "PDU session release complete", 3GPP TS 24.501 8.3. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40779?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If79cb0c97008e7a9885bb548a3d2e67e41ba170f Gerrit-Change-Number: 40779 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Jul 2025 16:44:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 month, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library: Comment out debugging for NGAP/5G-NAS

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40785?usp=email ) Change subject: library: Comment out debugging for NGAP/5G-NAS ...................................................................... library: Comment out debugging for NGAP/5G-NAS The current NGAP and 5G auth code is now working fine, so disable debug logging. Keep it commented out so it can be re-enabled at any time if some related topic needs to be debugged (will eventually happen). Change-Id: I4250766644742f0fd11ca5e24b1a1a581dc81b4b --- M library/NGAP_Emulation.ttcn M library/milenage/milenage.c 2 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/85/40785/1 diff --git a/library/NGAP_Emulation.ttcn b/library/NGAP_Emulation.ttcn index 4cb2f05..9fbaddc 100644 --- a/library/NGAP_Emulation.ttcn +++ b/library/NGAP_Emulation.ttcn @@ -143,7 +143,7 @@ NGapExpectTable[i].amf_id := omit; NGapExpectTable[i].ran_id := omit; NGapExpectTable[i].vc_conn := null; - log("Found Expect[", i, "] for ", msg, " handled at ", ret); + //log("Found Expect[", i, "] for ", msg, " handled at ", ret); return ret; } } @@ -222,18 +222,18 @@ template (omit) RAN_UE_NGAP_ID ran_id) runs on NGAP_Emulation_CT return boolean { var integer i; - log("f_ngap_ids_known(",amf_id,", ",ran_id,")"); + //log("f_ngap_ids_known(",amf_id,", ",ran_id,")"); for (i := 0; i < sizeof(NGapAssociationTable); i := i+1) { - log("tbl[",i,"]: amf=", NGapAssociationTable[i].amf_ue_ngap_id, - ", ran=", NGapAssociationTable[i].ran_ue_ngap_id); + //log("tbl[",i,"]: amf=", NGapAssociationTable[i].amf_ue_ngap_id, + // ", ran=", NGapAssociationTable[i].ran_ue_ngap_id); /* skip empty records */ if (NGapAssociationTable[i].amf_ue_ngap_id == omit and NGapAssociationTable[i].ran_ue_ngap_id == omit) { - log("skipping empty ", i); + //log("skipping empty ", i); continue; } if (NGapAssociationTable[i].amf_ue_ngap_id == omit) { - log("entry ", i, " has no AMF ID yet (ran=", NGapAssociationTable[i].ran_ue_ngap_id); + //log("entry ", i, " has no AMF ID yet (ran=", NGapAssociationTable[i].ran_ue_ngap_id); /* Table doesn't yet know the AMF side ID, let's look-up only * based on the eNB side ID */ if (match(NGapAssociationTable[i].ran_ue_ngap_id, ran_id)) { diff --git a/library/milenage/milenage.c b/library/milenage/milenage.c index d079a3d..f7a6f74 100644 --- a/library/milenage/milenage.c +++ b/library/milenage/milenage.c @@ -90,7 +90,7 @@ return 0; } -#define DEBUG +//#define DEBUG #ifdef DEBUG void hexdump(const char *text, const uint8_t *data, int len) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40785?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4250766644742f0fd11ca5e24b1a1a581dc81b4b Gerrit-Change-Number: 40785 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 month, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2025