Attention is currently required from: osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-dev/+/40747?usp=email )
Change subject: osmo-hnodeb: Add missing deps
......................................................................
Patch Set 1:
(1 comment)
File all.deps:
https://gerrit.osmocom.org/c/osmo-dev/+/40747/comment/4842827e_008f800a?usp… :
PS1, Line 34: osmo-hnodeb libosmocore libosmo-netif libosmo-abis osmo-iuh
> > for other entries we don't list transitive dependencies either. […]
Those are not transitivie dependencies, they are direct dependencies used actively by osmo-hnodeb.
--
To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40747?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-Change-Id: I4440583663bd2bd7643a0786792cb5339acd4d68
Gerrit-Change-Number: 40747
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 25 Jul 2025 10:11:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-dev/+/40747?usp=email )
Change subject: osmo-hnodeb: Add missing deps
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File all.deps:
https://gerrit.osmocom.org/c/osmo-dev/+/40747/comment/11872e6d_5aeecb14?usp… :
PS1, Line 34: osmo-hnodeb libosmocore libosmo-netif libosmo-abis osmo-iuh
> for other entries we don't list transitive dependencies either.
...actually we do in some cases it seems. but as I understand, Neels original intention was to not do that here.
--
To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40747?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-Change-Id: I4440583663bd2bd7643a0786792cb5339acd4d68
Gerrit-Change-Number: 40747
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 25 Jul 2025 06:47:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-dev/+/40747?usp=email )
The change is no longer submittable: Code-Review is unsatisfied now.
Change subject: osmo-hnodeb: Add missing deps
......................................................................
Patch Set 1: Code-Review-2
(1 comment)
File all.deps:
https://gerrit.osmocom.org/c/osmo-dev/+/40747/comment/37e5ee77_39a27b47?usp… :
PS1, Line 34: osmo-hnodeb libosmocore libosmo-netif libosmo-abis osmo-iuh
this should not be needed:
osmo-iuh -> libosmo-sigtran -> libosmo-netif -> libosmocore
for other entries we don't list transitive dependencies either.
--
To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40747?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-Change-Id: I4440583663bd2bd7643a0786792cb5339acd4d68
Gerrit-Change-Number: 40747
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 25 Jul 2025 06:43:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40749?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Split GTPv1U out of GTP_Emulation
......................................................................
Split GTPv1U out of GTP_Emulation
We already have a GTPv1U_Emulation, use it.
Change-Id: I5b3da248719b79d402b945904e3840a2ec387dab
---
M hnodeb/HNBGW_ConnectionHandler.ttcn
M hnodeb/HNB_Tests.ttcn
M hnodeb/gen_links.sh
M hnodeb/regen_makefile.sh
M library/GTP_Emulation.ttcn
M mme/MME_Tests.ttcn
M sgsn/BSSGP_ConnHdlr.ttcn
M sgsn/SGSN_Tests.ttcn
M sgsn/SGSN_Tests_Iu.ttcn
M sgsn/gen_links.sh
10 files changed, 99 insertions(+), 120 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/49/40749/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40749?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5b3da248719b79d402b945904e3840a2ec387dab
Gerrit-Change-Number: 40749
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40746?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: GTPv1U_Emulation: support multiple client ports per GTP1U_ConnHdlr
......................................................................
GTPv1U_Emulation: support multiple client ports per GTP1U_ConnHdlr
This feature is already present in GTP1U code of GTP_Emulation.
That part of the code will be removed and ported to use
GTPv1U_Emulation, so we need to also support this feature here.
Change-Id: I10ce33f30a2da5159f8040725df619844a71d6bc
---
M epdg/EPDG_Tests.ttcn
M library/GTPv1U_Emulation.ttcnpp
M pgw/PGW_Tests.ttcn
3 files changed, 33 insertions(+), 31 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/46/40746/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40746?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I10ce33f30a2da5159f8040725df619844a71d6bc
Gerrit-Change-Number: 40746
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>