December 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-sgsn[pespin/rel-1.13.0]: mmctx: LOGIUP: allow ue to be NULL
by pespin 04 Dec '25

04 Dec '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41576?usp=email ) Change subject: mmctx: LOGIUP: allow ue to be NULL ...................................................................... mmctx: LOGIUP: allow ue to be NULL In certain cases, the ue can be NULL. E.g. when receiving a new Iu event without a context. Change-Id: Ie569fa100abe518cb63c1b918ad7748a7ea3bb99 (cherry picked from commit 234da0eed4b6e5d372c34dc496677463650f3c97) --- M include/osmocom/sgsn/mmctx.h 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/sgsn/mmctx.h b/include/osmocom/sgsn/mmctx.h index 03bb845..8502bdf 100644 --- a/include/osmocom/sgsn/mmctx.h +++ b/include/osmocom/sgsn/mmctx.h @@ -231,7 +231,8 @@ #ifdef BUILD_IU #define LOGIUP(ue, level, fmt, args...) \ - LOGP(DMM, level, "UE(0x%x){%s} " fmt, ue->conn_id, osmo_rai_name(&(ue)->ra_id), ## args) + LOGP(DMM, level, "UE(0x%x){%s} " fmt, (ue) ? (ue)->conn_id : 0xffffffff, \ + (ue) ? osmo_rai_name(&(ue)->ra_id) : "", ## args) #else #define LOGIUP(ue, level, fmt, args...) \ LOGP(DMM, level, "UE(%p){NOTSUPPORTED} " fmt, ue, ## args) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41576?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: pespin/rel-1.13.0 Gerrit-Change-Id: Ie569fa100abe518cb63c1b918ad7748a7ea3bb99 Gerrit-Change-Number: 41576 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-sgsn[pespin/rel-1.13.0]: gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS
by pespin 04 Dec '25

04 Dec '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41575?usp=email ) Change subject: gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS ...................................................................... gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS The pdp_status is actually encoded as little endian, but there is no tlvp_val16le yet. Change-Id: Ib9bee2f8d0b1f89986d15cf3ce6404ad76378c8c (cherry picked from commit b79797d0568ffd757540f6307d538135bdfa01b8) --- M src/sgsn/gprs_gmm.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c index 7a4ea20..d70ceec 100644 --- a/src/sgsn/gprs_gmm.c +++ b/src/sgsn/gprs_gmm.c @@ -2009,7 +2009,8 @@ /* Look at PDP Context Status IE and see if MS's view of * activated/deactivated NSAPIs agrees with our view */ if (TLVP_PRESENT(&tp, GSM48_IE_GMM_PDP_CTX_STATUS)) { - uint16_t pdp_status = tlvp_val16be(&tp, GSM48_IE_GMM_PDP_CTX_STATUS); + /* TODO: Use tlvp_val16le when available */ + uint16_t pdp_status = osmo_load16le(TLVP_VAL(&tp, GSM48_IE_GMM_PDP_CTX_STATUS)); process_ms_ctx_status(ctx, pdp_status); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41575?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: pespin/rel-1.13.0 Gerrit-Change-Id: Ib9bee2f8d0b1f89986d15cf3ce6404ad76378c8c Gerrit-Change-Number: 41575 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-sgsn[pespin/rel-1.13.0]: Bump version: 1.13.0.2-dea2 → 1.13.1
by pespin 04 Dec '25

04 Dec '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41577?usp=email ) Change subject: Bump version: 1.13.0.2-dea2 → 1.13.1 ...................................................................... Bump version: 1.13.0.2-dea2 → 1.13.1 Change-Id: I016f0d2d169cf0a8a9638a19531289a91a2bc8f3 --- M debian/changelog 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/changelog b/debian/changelog index 7bc1351..c769bf4 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,11 @@ +osmo-sgsn (1.13.1) unstable; urgency=medium + + [ Alexander Couzens ] + * gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS + * mmctx: LOGIUP: allow ue to be NULL + + -- Pau Espin Pedrol <pespin(a)sysmocom.de> Thu, 04 Dec 2025 14:32:14 +0100 + osmo-sgsn (1.13.0) unstable; urgency=medium [ Pau Espin Pedrol ] -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41577?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: pespin/rel-1.13.0 Gerrit-Change-Id: I016f0d2d169cf0a8a9638a19531289a91a2bc8f3 Gerrit-Change-Number: 41577 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: ts_102_222: correct encode FILE_ID
by fixeria 04 Dec '25

04 Dec '25

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/pysim/+/41578?usp=email ) Change subject: ts_102_222: correct encode FILE_ID ...................................................................... Patch Set 1: (1 comment) File pySim/ts_102_222.py: https://gerrit.osmocom.org/c/pysim/+/41578/comment/243e04e8_9d5e54be?usp=em… : PS1, Line 148: to_bytes There're other instances of `FileIdentifier` in this file: ``` pySim/ts_102_222.py:153: ShortFileIdentifier(decoded=opts.short_file_id), pySim/ts_102_222.py:189: ies.append(FileIdentifier(decoded=opts.FILE_ID)) pySim/ts_102_222.py:221: ies = [FileIdentifier(decoded=f.fid), ``` Should they also be fixed? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41578?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I95c81f6793f1fdbaee5365355bab06a1c1107106 Gerrit-Change-Number: 41578 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 04 Dec 2025 13:48:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-sgsn[pespin/rel-1.13.0]: Bump version: 1.13.0.2-dea2 → 1.13.1
by osmith 04 Dec '25

04 Dec '25

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41577?usp=email ) Change subject: Bump version: 1.13.0.2-dea2 → 1.13.1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41577?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: pespin/rel-1.13.0 Gerrit-Change-Id: I016f0d2d169cf0a8a9638a19531289a91a2bc8f3 Gerrit-Change-Number: 41577 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Dec 2025 13:45:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-sgsn[pespin/rel-1.13.0]: mmctx: LOGIUP: allow ue to be NULL
by osmith 04 Dec '25

04 Dec '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41576?usp=email ) Change subject: mmctx: LOGIUP: allow ue to be NULL ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41576?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: pespin/rel-1.13.0 Gerrit-Change-Id: Ie569fa100abe518cb63c1b918ad7748a7ea3bb99 Gerrit-Change-Number: 41576 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Dec 2025 13:44:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-sgsn[pespin/rel-1.13.0]: gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS
by osmith 04 Dec '25

04 Dec '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41575?usp=email ) Change subject: gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41575?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: pespin/rel-1.13.0 Gerrit-Change-Id: Ib9bee2f8d0b1f89986d15cf3ce6404ad76378c8c Gerrit-Change-Number: 41575 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Dec 2025 13:44:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: ts_102_222: correct encode FILE_ID
by lynxis lazus 04 Dec '25

04 Dec '25

lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/41578?usp=email ) Change subject: ts_102_222: correct encode FILE_ID ...................................................................... Abandoned I was using an older version of pysim, because I didn't called pip without editiable. (`pip install -e .`) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41578?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I95c81f6793f1fdbaee5365355bab06a1c1107106 Gerrit-Change-Number: 41578 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder

1 0

[XS] Change in osmo-sgsn[pespin/rel-1.13.0]: gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS
by fixeria 04 Dec '25

04 Dec '25

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41575?usp=email ) Change subject: gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41575?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: pespin/rel-1.13.0 Gerrit-Change-Id: Ib9bee2f8d0b1f89986d15cf3ce6404ad76378c8c Gerrit-Change-Number: 41575 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Dec 2025 13:38:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-sgsn[pespin/rel-1.13.0]: mmctx: LOGIUP: allow ue to be NULL
by fixeria 04 Dec '25

04 Dec '25

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41576?usp=email ) Change subject: mmctx: LOGIUP: allow ue to be NULL ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41576?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: pespin/rel-1.13.0 Gerrit-Change-Id: Ie569fa100abe518cb63c1b918ad7748a7ea3bb99 Gerrit-Change-Number: 41576 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Dec 2025 13:38:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2025

2024

2023

2022

gerrit-log December 2025