December 2025 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo-epdg[master]: s2b: allow to set the restart counter/recovery field
by laforge 04 Dec '25

04 Dec '25

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email ) Change subject: s2b: allow to set the restart counter/recovery field ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I1e894a2c54dd180c0bc3a6f78d0bb7dd455cad81 Gerrit-Change-Number: 41588 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 04 Dec 2025 19:37:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...osmo-epdg[master]: s2b: answer echo requests
by laforge 04 Dec '25

04 Dec '25

Attention is currently required from: lynxis lazus, pespin. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37900?usp=email ) Change subject: s2b: answer echo requests ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37900?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I3c470bd89b9811ba269b53eb400ffc21db4fba3a Gerrit-Change-Number: 37900 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 04 Dec 2025 19:37:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...osmo-epdg[master]: s2b: allow to set the restart counter/recovery field
by lynxis lazus 04 Dec '25

04 Dec '25

lynxis lazus has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email ) Change subject: s2b: allow to set the restart counter/recovery field ...................................................................... s2b: allow to set the restart counter/recovery field The restart counter a 8 bit value is used to detect if a component has been restarted because GTPv2 is only using UDP. Use system_time by millisecond mod 256 as default. Further allow the supervisor to set it to a specific value. Change-Id: I1e894a2c54dd180c0bc3a6f78d0bb7dd455cad81 --- M src/epdg_gtpc_s2b.erl M src/osmo_epdg_sup.erl 2 files changed, 7 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/88/41588/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I1e894a2c54dd180c0bc3a6f78d0bb7dd455cad81 Gerrit-Change-Number: 41588 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder

1 0

[S] Change in ...osmo-epdg[master]: s2b: answer echo requests
by lynxis lazus 04 Dec '25

04 Dec '25

Attention is currently required from: laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37900?usp=email ) Change subject: s2b: answer echo requests ...................................................................... Patch Set 2: (1 comment) File src/epdg_gtpc_s2b.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37900/comment/cd5064d3_219a… : PS1, Line 520: IEs = [#v2_recovery{restart_counter = RCnt}], > agreeing with pespin. And indeed it's supposed to increment at every local restart. […] See the commit following this one (https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588/1) I don't think this should be within this patch, because there is already a recovery/restart counter which is always set to 0. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37900?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I3c470bd89b9811ba269b53eb400ffc21db4fba3a Gerrit-Change-Number: 37900 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Dec 2025 19:18:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in ...osmo-epdg[master]: gtpc2: allow to set the restart counter
by lynxis lazus 04 Dec '25

04 Dec '25

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email ) Change subject: gtpc2: allow to set the restart counter ...................................................................... gtpc2: allow to set the restart counter The restart counter a 8 bit value is used to detect if a component has been restarted. By the spec the IE recovery should be only present in the first PDU towards a new peer. But this is for a later improvement. Use system_time by millisecond mod 256 as default. Further allow the supervisor to set it to a specific value. Change-Id: I1e894a2c54dd180c0bc3a6f78d0bb7dd455cad81 --- M src/epdg_gtpc_s2b.erl M src/osmo_epdg_sup.erl 2 files changed, 7 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/88/41588/1 diff --git a/src/epdg_gtpc_s2b.erl b/src/epdg_gtpc_s2b.erl index aa14010..9becfdb 100644 --- a/src/epdg_gtpc_s2b.erl +++ b/src/epdg_gtpc_s2b.erl @@ -108,9 +108,13 @@ ok. init(State) -> + % Use system_time in order to ensure a fresh system wouldn't re-use always the same restart_counter + % monotonic timer could be to reproducible on systems. + Defaults = #{restart_counter => erlang:system_time(millisecond) rem 256}, lager:info("epdg_gtpc_s2b: init(): ~p", [State]), - [LocalAddr | [LocalPort | [RemoteAddr | [RemotePort | [GtpuLocalAddr | _]]]]] = State, + [LocalAddr | [LocalPort | [RemoteAddr | [RemotePort | [GtpuLocalAddr | [UserConfig, _]]]]]] = State, lager:info("epdg_gtpc_s2b: Binding to IP ~s port ~p~n", [LocalAddr, LocalPort]), + Config = maps:merge(Defaults, UserConfig), {ok, LocalAddrInet} = inet_parse:address(LocalAddr), {ok, RemoteAddrInet} = inet_parse:address(RemoteAddr), {ok, GtpuLocalAddrInet} = inet_parse:address(GtpuLocalAddr), @@ -135,7 +139,7 @@ rport = RemotePort, laddr_gtpu_str = GtpuLocalAddr, laddr_gtpu = GtpuLocalAddrInet, - restart_counter = 0, + restart_counter = maps:get(restart_counter, Config), seq_no = rand:uniform(16#FFFFFF), next_local_control_tei = rand:uniform(16#FFFFFFFE), next_local_data_tei = rand:uniform(16#FFFFFFFE) diff --git a/src/osmo_epdg_sup.erl b/src/osmo_epdg_sup.erl index 193e8e6..72cfaee 100644 --- a/src/osmo_epdg_sup.erl +++ b/src/osmo_epdg_sup.erl @@ -74,7 +74,7 @@ worker, [aaa_diameter_swm]}, %% ePDG processes: - GtpcServer = {epdg_gtpc_s2b, {epdg_gtpc_s2b,start_link, [GtpcLocalIp, GtpcLocalPort, GtpcRemoteIp, GtpcRemotePort, GtpuLocalIp, []]}, + GtpcServer = {epdg_gtpc_s2b, {epdg_gtpc_s2b,start_link, [GtpcLocalIp, GtpcLocalPort, GtpcRemoteIp, GtpcRemotePort, GtpuLocalIp, #{}]}, permanent, 5000, worker, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I1e894a2c54dd180c0bc3a6f78d0bb7dd455cad81 Gerrit-Change-Number: 41588 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in libosmocore[master]: osmo-release.sh: Fix coloring output under bash
by fixeria 04 Dec '25

04 Dec '25

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email ) Change subject: osmo-release.sh: Fix coloring output under bash ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib9e33ec8650ad8bc2e4b1893d9a7195c041c52dc Gerrit-Change-Number: 41547 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Dec 2025 18:34:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: osmo-release.sh: Fix coloring output under bash
by pespin 04 Dec '25

04 Dec '25

Attention is currently required from: fixeria, osmith, pespin. Hello Jenkins Builder, fixeria, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by osmith, Verified+1 by Jenkins Builder Change subject: osmo-release.sh: Fix coloring output under bash ...................................................................... osmo-release.sh: Fix coloring output under bash Change-Id: Ib9e33ec8650ad8bc2e4b1893d9a7195c041c52dc --- M osmo-release.sh 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/47/41547/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib9e33ec8650ad8bc2e4b1893d9a7195c041c52dc Gerrit-Change-Number: 41547 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: Bump version: 2.2.0.1-2e28-dirty → 2.2.1
by pespin 04 Dec '25

04 Dec '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41586?usp=email ) Change subject: Bump version: 2.2.0.1-2e28-dirty → 2.2.1 ...................................................................... Bump version: 2.2.0.1-2e28-dirty → 2.2.1 Change-Id: I1f615520d97cdb1ae502ea9a04f6ec34cee4c748 --- M configure.ac M debian/changelog M debian/control M src/Makefile.am 4 files changed, 9 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, approved; Verified diff --git a/configure.ac b/configure.ac index 98a6226..f1e1888 100644 --- a/configure.ac +++ b/configure.ac @@ -48,7 +48,7 @@ AC_ARG_ENABLE([tcap-loadsharing], [AS_HELP_STRING([--enable-tcap-loadsharing], [Build with TCAP loadsharing. Requires libosmo-asn1-tcap [default=no]])], [osmo_ac_tcap="$enableval"],[osmo_ac_tcap="no"]) if test "x$osmo_ac_tcap" = "xyes" ; then - PKG_CHECK_MODULES(LIBOSMOASN1TCAP, libosmo-asn1-tcap >= 0.2.0) + PKG_CHECK_MODULES(LIBOSMOASN1TCAP, libosmo-asn1-tcap >= 0.2.1) AC_DEFINE(WITH_TCAP_LOADSHARING, 1, [Define to build with TCAP LOADSHARING]) AC_SUBST(TCAP_LIBS_PC, [libosmo-asn1-tcap]) fi diff --git a/debian/changelog b/debian/changelog index 70938a8..f4cd909 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +libosmo-sigtran (2.2.1) unstable; urgency=medium + + * tcap: use libosmo-asn1-tcap public API + + -- Pau Espin Pedrol <pespin(a)sysmocom.de> Thu, 04 Dec 2025 19:00:05 +0100 + libosmo-sigtran (2.2.0) unstable; urgency=medium [ Pau Espin Pedrol ] diff --git a/debian/control b/debian/control index e8ef4aa..18d7ee0 100644 --- a/debian/control +++ b/debian/control @@ -13,7 +13,7 @@ git, doxygen, libdpkg-perl, - libosmo-asn1-tcap-dev (>= 0.2.0), + libosmo-asn1-tcap-dev (>= 0.2.1), libosmo-netif-dev (>= 1.7.0), libsctp-dev, osmo-gsm-manuals-dev (>= 1.7.0) diff --git a/src/Makefile.am b/src/Makefile.am index 4c15c8d..2ef226f 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -48,7 +48,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read Chapter 6 "Library interface versions" of the libtool # documentation before making any modification -LIBVERSION=12:0:0 +LIBVERSION=12:1:0 libosmo_sigtran_la_SOURCES = \ ipa.c \ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41586?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1f615520d97cdb1ae502ea9a04f6ec34cee4c748 Gerrit-Change-Number: 41586 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: Bump version: 2.2.0.1-2e28-dirty → 2.2.1
by pespin 04 Dec '25

04 Dec '25

Attention is currently required from: pespin. pespin has removed a vote from this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41586?usp=email ) Change subject: Bump version: 2.2.0.1-2e28-dirty → 2.2.1 ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41586?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: deleteVote Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1f615520d97cdb1ae502ea9a04f6ec34cee4c748 Gerrit-Change-Number: 41586 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: Bump version: 2.2.0.1-2e28-dirty → 2.2.1
by pespin 04 Dec '25

04 Dec '25

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41586?usp=email ) Change subject: Bump version: 2.2.0.1-2e28-dirty → 2.2.1 ...................................................................... Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41586?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1f615520d97cdb1ae502ea9a04f6ec34cee4c748 Gerrit-Change-Number: 41586 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 04 Dec 2025 18:06:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0