December 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: osmo-release.sh: Fix coloring output under bash
by pespin 05 Dec '25

05 Dec '25

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, fixeria, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: osmo-release.sh: Fix coloring output under bash ...................................................................... osmo-release.sh: Fix coloring output under bash Change-Id: Ib9e33ec8650ad8bc2e4b1893d9a7195c041c52dc --- M osmo-release.sh 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/47/41547/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib9e33ec8650ad8bc2e4b1893d9a7195c041c52dc Gerrit-Change-Number: 41547 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: ePDG: add echo request/response tests on GTPv2/S2b (ePDG <> P-GW)
by pespin 05 Dec '25

05 Dec '25

Attention is currently required from: laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41589?usp=email ) Change subject: ePDG: add echo request/response tests on GTPv2/S2b (ePDG <> P-GW) ...................................................................... Patch Set 1: (1 comment) File epdg/EPDG_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41589/comment/8a4ebd22_9de4… : PS1, Line 1210: private function f_TC_s2b_echo_requests(charstring id) runs on EPDG_ConnHdlr { extra "s" in this function at the end, which then doesn't match the testcase -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41589?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7d4fc45c72adef6db86d75f7fec3e43b86c32f2f Gerrit-Change-Number: 41589 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 05 Dec 2025 10:25:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ci[master]: lint: run clang-format only on specific projects
by osmith 05 Dec '25

05 Dec '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/41592?usp=email ) Change subject: lint: run clang-format only on specific projects ...................................................................... lint: run clang-format only on specific projects For most C projects, running checkpatch works best with the coding style we use. Run clang-format only in specific projects that seem to be fully formatted with that tool. Related: https://gerrit.osmocom.org/c/osmo-mgw/+/41529 Related: https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39470 Related: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39471 Change-Id: I2c07b30f9254b54027b721b77ab6f35249b5e2de --- M lint/lint_diff.sh 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/lint/lint_diff.sh b/lint/lint_diff.sh index d76d951..e37de17 100755 --- a/lint/lint_diff.sh +++ b/lint/lint_diff.sh @@ -61,10 +61,28 @@ } test_clang_format() { + local check_projects=" + osmo-asf4-dfu + osmo-ccid-firmware + " + local skip=true + local i + if ! [ -e ".clang-format" ] || ! command -v clang-format >/dev/null; then return fi + for i in $check_projects; do + if [ "$i" = "$PROJECT" ]; then + skip=false + break + fi + done + + if $skip; then + return + fi + echo "Running clang-format on 'git diff $COMMIT'..." echo -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41592?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2c07b30f9254b54027b721b77ab6f35249b5e2de Gerrit-Change-Number: 41592 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: osmo-release.sh: Fix coloring output under bash
by osmith 05 Dec '25

05 Dec '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email ) Change subject: osmo-release.sh: Fix coloring output under bash ...................................................................... Patch Set 2: (1 comment) File osmo-release.sh: https://gerrit.osmocom.org/c/libosmocore/+/41547/comment/0fe1bb7a_f3f72d05?… : PS2, Line 39: printf "${GREEN}OK:${RESET} $@\n" > What's wrong with current approach? the first argument to printf is the format string, just like in C it would be better practice to use %s and pass the string to be printed as second argument -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib9e33ec8650ad8bc2e4b1893d9a7195c041c52dc Gerrit-Change-Number: 41547 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Dec 2025 10:24:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ci[master]: lint: run clang-format only on specific projects
by pespin 05 Dec '25

05 Dec '25

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41592?usp=email ) Change subject: lint: run clang-format only on specific projects ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41592?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2c07b30f9254b54027b721b77ab6f35249b5e2de Gerrit-Change-Number: 41592 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Dec 2025 10:22:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: osmo-release.sh: Fix coloring output under bash
by pespin 05 Dec '25

05 Dec '25

Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email ) Change subject: osmo-release.sh: Fix coloring output under bash ...................................................................... Patch Set 2: (1 comment) File osmo-release.sh: https://gerrit.osmocom.org/c/libosmocore/+/41547/comment/7fc80951_87b986ca?… : PS2, Line 39: printf "${GREEN}OK:${RESET} $@\n" > actually this is better ("$@" would expand to multiple additional printf arguments whereas we only h […] What's wrong with current approach? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib9e33ec8650ad8bc2e4b1893d9a7195c041c52dc Gerrit-Change-Number: 41547 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Dec 2025 10:21:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-ci[master]: lint: run clang-format only on specific projects
by fixeria 05 Dec '25

05 Dec '25

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41592?usp=email ) Change subject: lint: run clang-format only on specific projects ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41592?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2c07b30f9254b54027b721b77ab6f35249b5e2de Gerrit-Change-Number: 41592 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Dec 2025 09:27:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-mgw[master]: mgcp_client: add support for VND.THEMWI.CCSD codec
by osmith 05 Dec '25

05 Dec '25

osmith has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-mgw/+/41529?usp=email ) Change subject: mgcp_client: add support for VND.THEMWI.CCSD codec ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Fix for the linter: https://gerrit.osmocom.org/c/osmo-ci/+/41592 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/41529?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6e4e15b5b3d20036aae8472bd94bc878b718ddd4 Gerrit-Change-Number: 41529 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Dec 2025 08:44:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ci[master]: lint: run clang-format only on specific projects
by osmith 05 Dec '25

05 Dec '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/41592?usp=email ) Change subject: lint: run clang-format only on specific projects ...................................................................... lint: run clang-format only on specific projects For most C projects, running checkpatch works best with the coding style we use. Run clang-format only in specific projects that seem to be fully formatted with that tool. Related: https://gerrit.osmocom.org/c/osmo-mgw/+/41529 Related: https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39470 Related: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39471 Change-Id: I2c07b30f9254b54027b721b77ab6f35249b5e2de --- M lint/lint_diff.sh 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/92/41592/1 diff --git a/lint/lint_diff.sh b/lint/lint_diff.sh index d76d951..e37de17 100755 --- a/lint/lint_diff.sh +++ b/lint/lint_diff.sh @@ -61,10 +61,28 @@ } test_clang_format() { + local check_projects=" + osmo-asf4-dfu + osmo-ccid-firmware + " + local skip=true + local i + if ! [ -e ".clang-format" ] || ! command -v clang-format >/dev/null; then return fi + for i in $check_projects; do + if [ "$i" = "$PROJECT" ]; then + skip=false + break + fi + done + + if $skip; then + return + fi + echo "Running clang-format on 'git diff $COMMIT'..." echo -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41592?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2c07b30f9254b54027b721b77ab6f35249b5e2de Gerrit-Change-Number: 41592 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: scripts: Add libosmo-asn1-tcap to OSMO_RELEASE_REPOS
by osmith 05 Dec '25

05 Dec '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ci/+/41587?usp=email ) Change subject: scripts: Add libosmo-asn1-tcap to OSMO_RELEASE_REPOS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41587?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I76703ed5c648eb50574166f8459fd0bde1720902 Gerrit-Change-Number: 41587 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Dec 2025 08:02:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0