December 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: osmo-release.sh: Fix coloring output under bash
by osmith 05 Dec '25

05 Dec '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email ) Change subject: osmo-release.sh: Fix coloring output under bash ...................................................................... Patch Set 2: (1 comment) File osmo-release.sh: https://gerrit.osmocom.org/c/libosmocore/+/41547/comment/3c447f23_d1e6e60c?… : PS2, Line 39: printf "${GREEN}OK:${RESET} $@\n" > ```suggestion […] actually this is better ("$@" would expand to multiple additional printf arguments whereas we only have one %s): ```suggestion printf "${GREEN}OK:${RESET} %s\n" "$1" ``` -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib9e33ec8650ad8bc2e4b1893d9a7195c041c52dc Gerrit-Change-Number: 41547 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Dec 2025 08:00:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: osmo-release.sh: Fix coloring output under bash
by osmith 05 Dec '25

05 Dec '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email ) Change subject: osmo-release.sh: Fix coloring output under bash ...................................................................... Patch Set 2: (1 comment) File osmo-release.sh: https://gerrit.osmocom.org/c/libosmocore/+/41547/comment/00c17890_f56f4097?… : PS2, Line 39: printf "${GREEN}OK:${RESET} $@\n" ```suggestion printf "${GREEN}OK:${RESET} %s\n" "$@" ``` -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib9e33ec8650ad8bc2e4b1893d9a7195c041c52dc Gerrit-Change-Number: 41547 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Dec 2025 07:56:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in ...osmo-epdg[master]: s2b: when socket opening fails, stop the S2b module
by lynxis lazus 04 Dec '25

04 Dec '25

Attention is currently required from: fixeria, laforge, lynxis lazus, pespin. Hello Jenkins Builder, fixeria, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: s2b: when socket opening fails, stop the S2b module ...................................................................... s2b: when socket opening fails, stop the S2b module Change-Id: I49a6a1ec0c938aa70444c19c0b7b644f2e42f1fd --- M src/epdg_gtpc_s2b.erl 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/01/37901/4 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I49a6a1ec0c938aa70444c19c0b7b644f2e42f1fd Gerrit-Change-Number: 37901 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in ...osmo-epdg[master]: s2b: allow to set the restart counter/recovery field
by lynxis lazus 04 Dec '25

04 Dec '25

Attention is currently required from: laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: s2b: allow to set the restart counter/recovery field ...................................................................... s2b: allow to set the restart counter/recovery field The restart counter is a 8 bit value, used to detect if a component has been restarted because GTPv2 is only using UDP. Use system_time by millisecond mod 256 as default. Further allow the supervisor to set it to a specific value. Change-Id: I1e894a2c54dd180c0bc3a6f78d0bb7dd455cad81 --- M src/epdg_gtpc_s2b.erl M src/osmo_epdg_sup.erl 2 files changed, 7 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/88/41588/4 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I1e894a2c54dd180c0bc3a6f78d0bb7dd455cad81 Gerrit-Change-Number: 41588 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[S] Change in ...osmo-epdg[master]: s2b: allow to set the restart counter/recovery field
by lynxis lazus 04 Dec '25

04 Dec '25

Attention is currently required from: laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email ) Change subject: s2b: allow to set the restart counter/recovery field ...................................................................... Patch Set 3: (3 comments) Commit Message: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588/comment/8e639807_1613… : PS2, Line 9: counter a 8 bit value > **is** a 8 bit value Done File src/epdg_gtpc_s2b.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588/comment/59ba705a_c5fd… : PS2, Line 112: monotonic timer could be to reproducible on systems > What do you mean here? This comment is confusing... maybe it's better now. https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588/comment/866d405b_f06f… : PS2, Line 115: UserConfig > This argument has two different names: `Options` in `start_link()` and `UserConfig` here. […] The other values are mandatory. This one is an optional one. I would like to keep it for this commit. If changes are necessary, this should go into another commit. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I1e894a2c54dd180c0bc3a6f78d0bb7dd455cad81 Gerrit-Change-Number: 41588 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 04 Dec 2025 22:41:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in ...osmo-epdg[master]: s2b: allow to set the restart counter/recovery field
by fixeria 04 Dec '25

04 Dec '25

Attention is currently required from: laforge, lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email ) Change subject: s2b: allow to set the restart counter/recovery field ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588/comment/052d9be3_029d… : PS2, Line 9: counter a 8 bit value > **is** a 8 bit value ah, it should actually be "an" because "an eight ..." -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I1e894a2c54dd180c0bc3a6f78d0bb7dd455cad81 Gerrit-Change-Number: 41588 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 04 Dec 2025 22:38:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in ...osmo-epdg[master]: s2b: when socket opening fails, stop the S2b module
by lynxis lazus 04 Dec '25

04 Dec '25

lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41591?usp=email ) Change subject: s2b: when socket opening fails, stop the S2b module ...................................................................... Abandoned dup -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41591?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I0c71c92fbcb2c10587562fe08250d9f879bd2b4e Gerrit-Change-Number: 41591 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder

1 0

[M] Change in ...osmo-epdg[master]: Makefile/jenkin.sh: adapt osmo-s1gw files
by lynxis lazus 04 Dec '25

04 Dec '25

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41590?usp=email ) Change subject: Makefile/jenkin.sh: adapt osmo-s1gw files ...................................................................... Makefile/jenkin.sh: adapt osmo-s1gw files Improve clean of files Change-Id: Ib05d66e9aef2992f687a3c547cbc2dfba04b6fb8 --- M Makefile M contrib/jenkins.sh 2 files changed, 46 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/90/41590/1 diff --git a/Makefile b/Makefile index 0470458..5f6e89f 100644 --- a/Makefile +++ b/Makefile @@ -1,25 +1,62 @@ +# where rebar3 stores build output +REBAR_BASE_DIR ?= _build +# config file used by 'run' and 'shell' +CONFIG ?= config/sys.config +# arguments passed to eunit, used by 'check' +EUNIT_ARGS ?= +# directory paths for 'install' +BINDIR ?= /usr/bin +LIBDIR ?= /usr/lib +CONFDIR ?= /etc/osmocom +SYSTEMDUNITDIR ?= /lib/systemd/system + all: build -build: +GEN_FILES = include/diameter_*.hrl src/diameter_*.erl + +src/diameter_%.erl include/diameter_%.hrl: dia/diameter_%.asn + rebar3 diameter compile + +build: $(GEN_FILES) rebar3 compile + +escript: $(GEN_FILES) rebar3 escriptize +run-escript: escript + ERL_FLAGS='-config $(CONFIG)' $(REBAR_BASE_DIR)/default/bin/osmo-epdg + run: build ERL_FLAGS='-config config/sys.config' _build/default/bin/osmo-epdg shell: build - rebar3 shell --config ./config/sys.config + rebar3 shell --config $(CONFIG) -check: - rebar3 eunit +check: $(GEN_FILES) + rebar3 eunit $(EUNIT_ARGS) + +analyze: $(GEN_FILES) + rebar3 dialyzer + +release: $(GEN_FILES) + rebar3 release + +install: release + install -d $(DESTDIR)$(LIBDIR) + cp -r $(REBAR_BASE_DIR)/default/bin/osmo-epdg $(DESTDIR)$(LIBDIR)/ + install -Dm0644 config/sys.config \ + $(DESTDIR)$(CONFDIR)/osmo-epdg.config + install -Dm0644 contrib/systemd/osmo-epdg.service \ + $(DESTDIR)$(SYSTEMDUNITDIR)/osmo-epdg.service clean: -# Avoid running rebar3 clean if _build doesn't exist, since it would try +# Avoid running rebar3 clean if $(REBAR_BASE_DIR) doesn't exist, since it would try # to fetch deps from the Internet and that may not be avaialble when in # OBS build. -ifneq ("$(wildcard _build/.*)", "") +ifneq ("$(wildcard $(REBAR_BASE_DIR)/.*)", "") + rebar3 diameter clean rebar3 clean - rm -rf _build/ + rm -rf $(REBAR_BASE_DIR) else - rm -f src/diameter_*.erl + rm -f $(GEN_FILES) endif diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index a900a5c..0d4275c 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -2,4 +2,4 @@ make clean || true make -make check +make check EUNIT_ARGS="-v" -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41590?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ib05d66e9aef2992f687a3c547cbc2dfba04b6fb8 Gerrit-Change-Number: 41590 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in ...osmo-epdg[master]: s2b: allow to set the restart counter/recovery field
by lynxis lazus 04 Dec '25

04 Dec '25

Attention is currently required from: fixeria, laforge, lynxis lazus. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review-1 by fixeria, Verified+1 by Jenkins Builder Change subject: s2b: allow to set the restart counter/recovery field ...................................................................... s2b: allow to set the restart counter/recovery field The restart counter a 8 bit value is used to detect if a component has been restarted because GTPv2 is only using UDP. Use system_time by millisecond mod 256 as default. Further allow the supervisor to set it to a specific value. Change-Id: I1e894a2c54dd180c0bc3a6f78d0bb7dd455cad81 --- M src/epdg_gtpc_s2b.erl M src/osmo_epdg_sup.erl 2 files changed, 7 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/88/41588/3 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I1e894a2c54dd180c0bc3a6f78d0bb7dd455cad81 Gerrit-Change-Number: 41588 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in ...osmo-epdg[master]: s2b: when socket opening fails, stop the S2b module
by lynxis lazus 04 Dec '25

04 Dec '25

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41591?usp=email ) Change subject: s2b: when socket opening fails, stop the S2b module ...................................................................... s2b: when socket opening fails, stop the S2b module Change-Id: I0c71c92fbcb2c10587562fe08250d9f879bd2b4e --- M src/epdg_gtpc_s2b.erl 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/91/41591/1 diff --git a/src/epdg_gtpc_s2b.erl b/src/epdg_gtpc_s2b.erl index 3bc1b6a..afff60b 100644 --- a/src/epdg_gtpc_s2b.erl +++ b/src/epdg_gtpc_s2b.erl @@ -146,7 +146,8 @@ }, {ok, St}; {error, Reason} -> - lager:error("GTPv2C UDP socket open error: ~w~n", [Reason]) + lager:error("GTPv2C UDP socket open error: ~w~n", [Reason]), + {stop, {udp_socket_open_failed, [Reason]}} end. create_session_req(Imsi, Apn, APCO, PdpTypeNr, PdpAddress, PGWAddrCandidateList) -> -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41591?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I0c71c92fbcb2c10587562fe08250d9f879bd2b4e Gerrit-Change-Number: 41591 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0