December 2025 - gerrit-log - lists.osmocom.org

[XS] Change in ...osmo-epdg[master]: s2b: when socket opening fails, stop the S2b module
by fixeria 04 Dec '25

04 Dec '25

Attention is currently required from: laforge, lynxis lazus, pespin. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email ) Change subject: s2b: when socket opening fails, stop the S2b module ...................................................................... Patch Set 3: (1 comment) File src/epdg_gtpc_s2b.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901/comment/97b39dfd_e10b… : PS3, Line 150: io_lib:format > Yes maybe true. I'm not sure what's the intended way of returning a reason is. […] Well, the general approach is that formatted strings are for humans. You already let the humans know about an error via logging, so here you're letting the process' owner the failure `Reason`. The term `udp_socket_open_failed` is self-explanatory, so having a tuple `{udp_socket_open_failed, Reason}` would allow potential consumer of the `Reason` to format it any way they want (if at all). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I49a6a1ec0c938aa70444c19c0b7b644f2e42f1fd Gerrit-Change-Number: 37901 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 04 Dec 2025 21:39:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in ...osmo-epdg[master]: s2b: allow to set the restart counter/recovery field
by fixeria 04 Dec '25

04 Dec '25

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email ) Change subject: s2b: allow to set the restart counter/recovery field ...................................................................... Patch Set 2: Code-Review-1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I1e894a2c54dd180c0bc3a6f78d0bb7dd455cad81 Gerrit-Change-Number: 41588 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 04 Dec 2025 21:33:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...osmo-epdg[master]: s2b: allow to set the restart counter/recovery field
by fixeria 04 Dec '25

04 Dec '25

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email ) Change subject: s2b: allow to set the restart counter/recovery field ...................................................................... Patch Set 2: (3 comments) Commit Message: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588/comment/a9841de3_fa82… : PS2, Line 9: counter a 8 bit value **is** a 8 bit value File src/epdg_gtpc_s2b.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588/comment/a5b06913_a4e7… : PS2, Line 112: monotonic timer could be to reproducible on systems What do you mean here? This comment is confusing... https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588/comment/9570d46b_65eb… : PS2, Line 115: UserConfig This argument has two different names: `Options` in `start_link()` and `UserConfig` here. Let's stick to either of the two, for the sake of consistency. Also, it's worth grouping/reworking all these list items into a map to avoid ugly constructions like this one. Might be an idea for a separate change. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I1e894a2c54dd180c0bc3a6f78d0bb7dd455cad81 Gerrit-Change-Number: 41588 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 04 Dec 2025 21:33:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in ...osmo-epdg[master]: s2b: when socket opening fails, stop the S2b module
by lynxis lazus 04 Dec '25

04 Dec '25

Attention is currently required from: fixeria, laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email ) Change subject: s2b: when socket opening fails, stop the S2b module ...................................................................... Patch Set 3: (1 comment) File src/epdg_gtpc_s2b.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901/comment/487936d0_16ce… : PS3, Line 150: io_lib:format > Not sure why would you want to include a formatted string here, given that above you're already logg […] Yes maybe true. I'm not sure what's the intended way of returning a reason is. Or what are good examples. IMHO: I thought more into the direction of a python exception, which both contains a type and a human understandable reason. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I49a6a1ec0c938aa70444c19c0b7b644f2e42f1fd Gerrit-Change-Number: 37901 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Dec 2025 21:23:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in ...osmo-epdg[master]: s2b: answer echo requests
by fixeria 04 Dec '25

04 Dec '25

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37900?usp=email ) Change subject: s2b: answer echo requests ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37900?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I3c470bd89b9811ba269b53eb400ffc21db4fba3a Gerrit-Change-Number: 37900 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 04 Dec 2025 21:23:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...osmo-epdg[master]: s2b: when socket opening fails, stop the S2b module
by fixeria 04 Dec '25

04 Dec '25

Attention is currently required from: laforge, lynxis lazus, pespin. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email ) Change subject: s2b: when socket opening fails, stop the S2b module ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/epdg_gtpc_s2b.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901/comment/85208e2d_632e… : PS3, Line 150: io_lib:format Not sure why would you want to include a formatted string here, given that above you're already logging an error. Returning `{udp_socket_open_failed, Reason}` looks more practical to me, but even this feels redundant... The question is, who is supposed to consume this pretty-printed string value? Not blocking, just raising a concern. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I49a6a1ec0c938aa70444c19c0b7b644f2e42f1fd Gerrit-Change-Number: 37901 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 04 Dec 2025 21:20:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...osmo-epdg[master]: s2b: when socket opening fails, stop the S2b module
by lynxis lazus 04 Dec '25

04 Dec '25

Attention is currently required from: fixeria, laforge, lynxis lazus, pespin. Hello Jenkins Builder, fixeria, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: s2b: when socket opening fails, stop the S2b module ...................................................................... s2b: when socket opening fails, stop the S2b module Change-Id: I49a6a1ec0c938aa70444c19c0b7b644f2e42f1fd --- M src/epdg_gtpc_s2b.erl 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/01/37901/3 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I49a6a1ec0c938aa70444c19c0b7b644f2e42f1fd Gerrit-Change-Number: 37901 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in ...osmo-epdg[master]: s2b: add PDN type to the create session request
by lynxis lazus 04 Dec '25

04 Dec '25

lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37903?usp=email ) Change subject: s2b: add PDN type to the create session request ...................................................................... Abandoned Superseeded -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37903?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I52c9b2db38489404dbe2aac907089a0a6414c9b0 Gerrit-Change-Number: 37903 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in ...osmo-epdg[master]: s2b: when socket opening fails, stop the S2b module
by lynxis lazus 04 Dec '25

04 Dec '25

Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, fixeria, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Code-Review+2 by laforge, Code-Review-1 by fixeria, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: s2b: when socket opening fails, stop the S2b module ...................................................................... s2b: when socket opening fails, stop the S2b module Change-Id: I49a6a1ec0c938aa70444c19c0b7b644f2e42f1fd --- M src/epdg_gtpc_s2b.erl 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/01/37901/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I49a6a1ec0c938aa70444c19c0b7b644f2e42f1fd Gerrit-Change-Number: 37901 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: ePDG: add echo request/response tests on GTPv2/S2b (ePDG <> P-GW)
by lynxis lazus 04 Dec '25

04 Dec '25

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41589?usp=email ) Change subject: ePDG: add echo request/response tests on GTPv2/S2b (ePDG <> P-GW) ...................................................................... ePDG: add echo request/response tests on GTPv2/S2b (ePDG <> P-GW) Change-Id: I7d4fc45c72adef6db86d75f7fec3e43b86c32f2f --- M epdg/EPDG_Tests.ttcn M epdg/expected-results.xml 2 files changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/89/41589/1 diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn index e4aed42..05c089c 100644 --- a/epdg/EPDG_Tests.ttcn +++ b/epdg/EPDG_Tests.ttcn @@ -873,6 +873,25 @@ as_GTP2C_DeleteBearer_success(); } +private function f_GTP2C_echo_request_response(integer recovery := 23) runs on EPDG_ConnHdlr { + timer T := 5.0; + var PDU_GTPCv2 rx_msg; + + GTP2.send(ts_GTP2C_EchoReq(recovery)); + T.start; + alt { + [] GTP2.receive(tr_GTP2C_EchoResp) -> value rx_msg { + setverdict(pass); + } + [] GTP2.receive { + repeat; + } + [] T.timeout { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "timeout waiting for Echo Response"); + } + } +} + private template (value) Gtp1uPeer ts_GtpPeerU(octetstring ip) := { connId := 1, remName := f_inet_ntoa(ip), @@ -1188,6 +1207,20 @@ setverdict(pass); } +private function f_TC_s2b_echo_requests(charstring id) runs on EPDG_ConnHdlr { + f_initial_attach(); + /* Transmit Echo Request from the P-GW towards ePDG on s2b */ + f_GTP2C_echo_request_response(); +} +testcase TC_s2b_echo_request() runs on MTC_CT { + var EPDG_ConnHdlrPars pars := f_init_pars(); + var EPDG_ConnHdlr vc_conn; + f_init(); + vc_conn := f_start_handler(refers(f_TC_s2b_echo_requests), pars); + vc_conn.done; + setverdict(pass); +} + /* 3GPP TS 29.273 Network Initiated De-Registration by HSS, Administrative */ private function f_TC_hss_initiated_deregister_new_server_assigned(charstring id) runs on EPDG_ConnHdlr { f_initial_attach(); @@ -1356,6 +1389,7 @@ execute ( TC_ho_lte_to_wifi() ); execute ( TC_ho_wifi_to_lte() ); execute ( TC_s2b_CreateSession_rejected() ); + execute ( TC_s2b_echo_request() ); execute ( TC_hss_initiated_deregister_new_server_assigned() ); execute ( TC_hss_initiated_deregister_permanent_termination() ); execute ( TC_hss_initiated_update_user_profile() ); diff --git a/epdg/expected-results.xml b/epdg/expected-results.xml index 6b37b8d..7c37609 100644 --- a/epdg/expected-results.xml +++ b/epdg/expected-results.xml @@ -7,6 +7,7 @@ <testcase classname='EPDG_Tests' name='TC_ho_lte_to_wifi' time='MASKED'/> <testcase classname='EPDG_Tests' name='TC_ho_wifi_to_lte' time='MASKED'/> <testcase classname='EPDG_Tests' name='TC_s2b_CreateSession_rejected' time='MASKED'/> + <testcase classname='EPDG_Tests' name='TC_s2b_echo_request' time='MASKED'/> <testcase classname='EPDG_Tests' name='TC_hss_initiated_deregister_new_server_assigned' time='MASKED'/> <testcase classname='EPDG_Tests' name='TC_hss_initiated_deregister_permanent_termination' time='MASKED'/> <testcase classname='EPDG_Tests' name='TC_hss_initiated_update_user_profile' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41589?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7d4fc45c72adef6db86d75f7fec3e43b86c32f2f Gerrit-Change-Number: 41589 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0