Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email ) Change subject: s2b: allow to set the restart counter/recovery field ...................................................................... Patch Set 2: (3 comments) Commit Message: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588/comment/a9841de3_fa827... : PS2, Line 9: counter a 8 bit value **is** a 8 bit value File src/epdg_gtpc_s2b.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588/comment/a5b06913_a4e78... : PS2, Line 112: monotonic timer could be to reproducible on systems What do you mean here? This comment is confusing... https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588/comment/9570d46b_65eb8... : PS2, Line 115: UserConfig This argument has two different names: `Options` in `start_link()` and `UserConfig` here. Let's stick to either of the two, for the sake of consistency. Also, it's worth grouping/reworking all these list items into a map to avoid ugly constructions like this one. Might be an idea for a separate change. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I1e894a2c54dd180c0bc3a6f78d0bb7dd455cad81 Gerrit-Change-Number: 41588 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Thu, 04 Dec 2025 21:33:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No