Attention is currently required from: lynxis lazus.

View Change

3 comments:

• Commit Message:

  • Patch Set #2, Line 9: counter a 8 bit value

    **is** a 8 bit value

• File src/epdg_gtpc_s2b.erl:

  • Patch Set #2, Line 112: monotonic timer could be to reproducible on systems

    What do you mean here? This comment is confusing...

  • Patch Set #2, Line 115: UserConfig

    This argument has two different names: `Options` in `start_link()` and `UserConfig` here. Let's stick to either of the two, for the sake of consistency.

    Also, it's worth grouping/reworking all these list items into a map to avoid ugly constructions like this one. Might be an idea for a separate change.

To view, visit change 41588. To unsubscribe, or for help writing mail filters, visit settings.