December 2025 - gerrit-log - lists.osmocom.org

[XS] Change in pysim[master]: ts_102_222: correct encode FILE_ID
by fixeria 04 Dec '25

04 Dec '25

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/pysim/+/41578?usp=email ) Change subject: ts_102_222: correct encode FILE_ID ...................................................................... Patch Set 1: (1 comment) File pySim/ts_102_222.py: https://gerrit.osmocom.org/c/pysim/+/41578/comment/243e04e8_9d5e54be?usp=em… : PS1, Line 148: to_bytes There're other instances of `FileIdentifier` in this file: ``` pySim/ts_102_222.py:153: ShortFileIdentifier(decoded=opts.short_file_id), pySim/ts_102_222.py:189: ies.append(FileIdentifier(decoded=opts.FILE_ID)) pySim/ts_102_222.py:221: ies = [FileIdentifier(decoded=f.fid), ``` Should they also be fixed? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41578?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I95c81f6793f1fdbaee5365355bab06a1c1107106 Gerrit-Change-Number: 41578 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 04 Dec 2025 13:48:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-sgsn[pespin/rel-1.13.0]: Bump version: 1.13.0.2-dea2 → 1.13.1
by osmith 04 Dec '25

04 Dec '25

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41577?usp=email ) Change subject: Bump version: 1.13.0.2-dea2 → 1.13.1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41577?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: pespin/rel-1.13.0 Gerrit-Change-Id: I016f0d2d169cf0a8a9638a19531289a91a2bc8f3 Gerrit-Change-Number: 41577 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Dec 2025 13:45:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-sgsn[pespin/rel-1.13.0]: mmctx: LOGIUP: allow ue to be NULL
by osmith 04 Dec '25

04 Dec '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41576?usp=email ) Change subject: mmctx: LOGIUP: allow ue to be NULL ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41576?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: pespin/rel-1.13.0 Gerrit-Change-Id: Ie569fa100abe518cb63c1b918ad7748a7ea3bb99 Gerrit-Change-Number: 41576 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Dec 2025 13:44:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-sgsn[pespin/rel-1.13.0]: gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS
by osmith 04 Dec '25

04 Dec '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41575?usp=email ) Change subject: gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41575?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: pespin/rel-1.13.0 Gerrit-Change-Id: Ib9bee2f8d0b1f89986d15cf3ce6404ad76378c8c Gerrit-Change-Number: 41575 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Dec 2025 13:44:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: ts_102_222: correct encode FILE_ID
by lynxis lazus 04 Dec '25

04 Dec '25

lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/41578?usp=email ) Change subject: ts_102_222: correct encode FILE_ID ...................................................................... Abandoned I was using an older version of pysim, because I didn't called pip without editiable. (`pip install -e .`) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41578?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I95c81f6793f1fdbaee5365355bab06a1c1107106 Gerrit-Change-Number: 41578 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder

1 0

[XS] Change in osmo-sgsn[pespin/rel-1.13.0]: gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS
by fixeria 04 Dec '25

04 Dec '25

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41575?usp=email ) Change subject: gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41575?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: pespin/rel-1.13.0 Gerrit-Change-Id: Ib9bee2f8d0b1f89986d15cf3ce6404ad76378c8c Gerrit-Change-Number: 41575 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Dec 2025 13:38:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-sgsn[pespin/rel-1.13.0]: mmctx: LOGIUP: allow ue to be NULL
by fixeria 04 Dec '25

04 Dec '25

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41576?usp=email ) Change subject: mmctx: LOGIUP: allow ue to be NULL ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41576?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: pespin/rel-1.13.0 Gerrit-Change-Id: Ie569fa100abe518cb63c1b918ad7748a7ea3bb99 Gerrit-Change-Number: 41576 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Dec 2025 13:38:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-sgsn[pespin/rel-1.13.0]: gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS
by fixeria 04 Dec '25

04 Dec '25

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41575?usp=email ) Change subject: gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41575?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: pespin/rel-1.13.0 Gerrit-Change-Id: Ib9bee2f8d0b1f89986d15cf3ce6404ad76378c8c Gerrit-Change-Number: 41575 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Dec 2025 13:37:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-sgsn[pespin/rel-1.13.0]: Bump version: 1.13.0.2-dea2 → 1.13.1
by fixeria 04 Dec '25

04 Dec '25

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41577?usp=email ) Change subject: Bump version: 1.13.0.2-dea2 → 1.13.1 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41577?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: pespin/rel-1.13.0 Gerrit-Change-Id: I016f0d2d169cf0a8a9638a19531289a91a2bc8f3 Gerrit-Change-Number: 41577 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Dec 2025 13:37:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: ts_102_222: correct encode FILE_ID
by lynxis lazus 04 Dec '25

04 Dec '25

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41578?usp=email ) Change subject: ts_102_222: correct encode FILE_ID ...................................................................... ts_102_222: correct encode FILE_ID Fix an exception with FILE_ID. When creating ADF.USIM/DF.5GS: > create_df --ef-arr-record-nr 2 --ef-arr-file-id 2f06 5FC0 EXCEPTION of type 'StringError' occurred with message: Error in path (building) given non-bytes value, perhaps unicode? '5fc0 [..] File "/home/lynxis/projects/osmocom/repos/pysim/pySim/ts_102_222.py", line 207, in do_create_df (_data, _sw) = self._cmd.lchan.scc.create_file(b2h(fcp.to_tlv())) [..] File "/usr/lib/python3.13/site-packages/construct/core.py", line 191, in stream_write raise StringError("given non-bytes value, perhaps unicode? %r" % (data,), path=path) construct.core.StringError: Error in path (building) given non-bytes value, perhaps unicode? '5fc0' Change-Id: I95c81f6793f1fdbaee5365355bab06a1c1107106 --- M pySim/ts_102_222.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/78/41578/1 diff --git a/pySim/ts_102_222.py b/pySim/ts_102_222.py index 74eb2c3..5960359 100644 --- a/pySim/ts_102_222.py +++ b/pySim/ts_102_222.py @@ -145,7 +145,7 @@ elif opts.structure == 'ber_tlv': self._cmd.perror("BER-TLV creation not yet fully supported, sorry") return - ies = [FileDescriptor(decoded=file_descriptor), FileIdentifier(decoded=opts.FILE_ID), + ies = [FileDescriptor(decoded=file_descriptor), FileIdentifier(decoded=opts.FILE_ID.to_bytes()), LifeCycleStatusInteger(decoded='operational_activated'), SecurityAttribReferenced(decoded={'ef_arr_file_id': opts.ef_arr_file_id, 'ef_arr_record_nr': opts.ef_arr_record_nr }), -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41578?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I95c81f6793f1fdbaee5365355bab06a1c1107106 Gerrit-Change-Number: 41578 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0