Attention is currently required from: lynxis lazus.
fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/pysim/+/41578?usp=email )
Change subject: ts_102_222: correct encode FILE_ID
......................................................................
Patch Set 1:
(1 comment)
File pySim/ts_102_222.py:
https://gerrit.osmocom.org/c/pysim/+/41578/comment/243e04e8_9d5e54be?usp=em… :
PS1, Line 148: to_bytes
There're other instances of `FileIdentifier` in this file:
```
pySim/ts_102_222.py:153: ShortFileIdentifier(decoded=opts.short_file_id),
pySim/ts_102_222.py:189: ies.append(FileIdentifier(decoded=opts.FILE_ID))
pySim/ts_102_222.py:221: ies = [FileIdentifier(decoded=f.fid),
```
Should they also be fixed?
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41578?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I95c81f6793f1fdbaee5365355bab06a1c1107106
Gerrit-Change-Number: 41578
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 04 Dec 2025 13:48:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/41578?usp=email )
Change subject: ts_102_222: correct encode FILE_ID
......................................................................
Abandoned
I was using an older version of pysim, because I didn't called pip without editiable. (`pip install -e .`)
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41578?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I95c81f6793f1fdbaee5365355bab06a1c1107106
Gerrit-Change-Number: 41578
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: Jenkins Builder