December 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-abis[master]: trau_frame cosmetic: rm dead/invalid definitions
by falconia 22 Dec '25

22 Dec '25

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41750?usp=email ) Change subject: trau_frame cosmetic: rm dead/invalid definitions ...................................................................... trau_frame cosmetic: rm dead/invalid definitions All 3 module-internal C preprocessor definitions removed here have never been used, and it is not clear where or how they were ever intended to be used. (The present trau_frame layer is concerned with low-level de/encoding; high-level de/encoding of AMR frames happens in the new AMR TRAU frame interworking facility.) Furthermore, one of these never-used preprocessor definitions expands to invalid C code. Remove the bogon. Change-Id: Icd96220455888ec5e1d03402b750da6945aaf095 --- M src/trau/trau_frame.c 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/50/41750/1 diff --git a/src/trau/trau_frame.c b/src/trau/trau_frame.c index d8541c5..c5f234f 100644 --- a/src/trau/trau_frame.c +++ b/src/trau/trau_frame.c @@ -1640,10 +1640,6 @@ } } -#define TRAU8_FT_AMR_NO_SPEECH_CMI 0x10 /* 1, 0, 0, 0, 0 */ -#define TRAU8_FT_AMR_NO_SPEECH_CMR 0x14 /* 1, 0, 1, 0, 0 */ -#define TRAU8_FT_AMR_475_515_590 0..7 - static const uint8_t bit8_0[8] = { 0, }; /*!< check sync pattern for hr/data/oam */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41750?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Icd96220455888ec5e1d03402b750da6945aaf095 Gerrit-Change-Number: 41750 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org>

1 0

[XS] Change in pysim[master]: pySim-shell: do not show user home path in help text
by daniel 22 Dec '25

22 Dec '25

Attention is currently required from: dexter. daniel has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41748?usp=email ) Change subject: pySim-shell: do not show user home path in help text ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: > I bet it works for --script annd --card_handler because the ~ is resolved by the shell before the pa […] That was it. Quoting the script and card_handler arguments with '"' doesn't expand '~'. So it would be nice to use expandpath for those as well. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41748?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ied8b1e553de8f5370369c4485a2360906c874ed2 Gerrit-Change-Number: 41748 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Dec 2025 17:12:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: pySim-shell: do not show user home path in help text
by dexter 22 Dec '25

22 Dec '25

Attention is currently required from: daniel. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41748?usp=email ) Change subject: pySim-shell: do not show user home path in help text ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I was just about to propose that --script and --card_handler should also use expanduser, but after t […] I bet it works for --script annd --card_handler because the ~ is resolved by the shell before the path is passed to python? I have tried it out it stops working when i remove os.path.expanduser() -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41748?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ied8b1e553de8f5370369c4485a2360906c874ed2 Gerrit-Change-Number: 41748 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Dec 2025 16:39:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>

1 0

[S] Change in pysim[master]: pySim.ts_51_011.EF_SMSP: Properly handle odd-length ScAddr / TpAddr
by dexter 22 Dec '25

22 Dec '25

Attention is currently required from: laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41733?usp=email ) Change subject: pySim.ts_51_011.EF_SMSP: Properly handle odd-length ScAddr / TpAddr ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41733?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1e9865e172bc29b8a31c281106d903934e81c686 Gerrit-Change-Number: 41733 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 22 Dec 2025 16:29:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: TEST, please ignore
by dexter 22 Dec '25

22 Dec '25

dexter has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/38526?usp=email ) Change subject: TEST, please ignore ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38526?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I02934ed3eb8728e0f9f5a6cfb2b020b73def7174 Gerrit-Change-Number: 38526 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[XS] Change in pysim[master]: esim.saip.FsProfileElement: Add file2pe() for single file conversion
by dexter 22 Dec '25

22 Dec '25

Attention is currently required from: laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41734?usp=email ) Change subject: esim.saip.FsProfileElement: Add file2pe() for single file conversion ...................................................................... Patch Set 3: Code-Review-1 (3 comments) Patchset: PS3: I have the feeling that file2pe method might bear a risk to cause inconsistencies. File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/41734/comment/1bfc32fc_48031ac1?usp=em… : PS3, Line 636: def file2pe(self, f: File): Maybe replace "f" with "file" to make it more uniform to the add_file method? https://gerrit.osmocom.org/c/pysim/+/41734/comment/8b68b5b9_6ab4f070?usp=em… : PS3, Line 638: self.decoded[f.pe_name] = f.to_tuples() There is something I am struggling with. There is already the add_file() method. This method adds files to self.files and does a couple of other things as well. When we now use file2pe to put a file from whatever source into self.decoded. Then the rest of the class members (self.files, etc.) know nothing about the update. For example, the next time we run files2pe, the updated file gets overwritten with the old content. Maybe we need a more elaborated update function, similar to add_file? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41734?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7b7f61aae6b7df6946dadf2f78fddf92995603ec Gerrit-Change-Number: 41734 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 22 Dec 2025 16:22:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: Fix more odd-length digit sequences via PaddedBcdAdapter
by dexter 22 Dec '25

22 Dec '25

Attention is currently required from: fixeria, laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41742?usp=email ) Change subject: Fix more odd-length digit sequences via PaddedBcdAdapter ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: I have tested the patch and I can indeed confirm the problem. Also writing seemed to be problematic. Writing 123 resulted in 12. With the patch, this is fixed. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4571482da924a3d645caa297108279d182448d21 Gerrit-Change-Number: 41742 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Dec 2025 15:59:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: set different mgcp_params ports and ids for each subscriber
by pespin 22 Dec '25

22 Dec '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41749?usp=email ) Change subject: hnbgw: set different mgcp_params ports and ids for each subscriber ...................................................................... hnbgw: set different mgcp_params ports and ids for each subscriber Change-Id: I32f644038d7e29b261ba3852583170a63544dae5 --- M hnbgw/ConnHdlr.ttcn 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/49/41749/1 diff --git a/hnbgw/ConnHdlr.ttcn b/hnbgw/ConnHdlr.ttcn index 91c7878..7f557c9 100644 --- a/hnbgw/ConnHdlr.ttcn +++ b/hnbgw/ConnHdlr.ttcn @@ -137,22 +137,22 @@ resp := 1, mgw_rtp_ip := "127.1.2.1", mgw_rtp_ip_mdcx := omit, - mgw_rtp_port := 10000, - mgcp_connection_id := '11111'H + mgw_rtp_port := 10000 + endp_idx, + mgcp_connection_id := int2hex(hex2int('11111'H) + endp_idx, 32) }, mgw_conn_cn := { resp := 1, mgw_rtp_ip := "127.1.2.2", mgw_rtp_ip_mdcx := omit, - mgw_rtp_port := 20000, - mgcp_connection_id := '22222'H + mgw_rtp_port := 20000 + endp_idx, + mgcp_connection_id := int2hex(hex2int('22222'H) + endp_idx, 32) }, rtp_payload_type := 112, rtp_sdp_format := "VND.3GPP.IUFP", hnb_rtp_ip := "127.1.1.1", - hnb_rtp_port := 10001, + hnb_rtp_port := 10001 + endp_idx, cn_rtp_ip := "127.1.3.1", - cn_rtp_port := 20001, + cn_rtp_port := 20001 + endp_idx, use_osmux := false, got_osmux_count := 0 } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41749?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I32f644038d7e29b261ba3852583170a63544dae5 Gerrit-Change-Number: 41749 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: setup.py: Align cmd2 minimum version with requirements.txt
by dexter 22 Dec '25

22 Dec '25

Attention is currently required from: fixeria, laforge, neels, osmith. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41642?usp=email ) Change subject: setup.py: Align cmd2 minimum version with requirements.txt ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: > well, actually after some more thought, option 2 sounds like it causes less problems for users, so l […] I am currently using pySim-shell with 2.5.0, no issues to far. I bet 2.6.2 will also work well. I think that raising the version requirements would be good because we could get rid of backward compatibility workarounds (e.g. the colors in pySim-shell.py). But I also see the point that there might be users out there that are still bound to cmd2 1.5 for some reason. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41642?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I71cee0ec3ed2abec68ec567beaab13c868721dad Gerrit-Change-Number: 41642 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Dec 2025 15:15:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in pysim[master]: ts_51_011: Improve testing of EF_SMSP
by dexter 22 Dec '25

22 Dec '25

Attention is currently required from: laforge, neels. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41677?usp=email ) Change subject: ts_51_011: Improve testing of EF_SMSP ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41677?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8d16e195641bb59b2c26072008f88434692c0cab Gerrit-Change-Number: 41677 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 22 Dec 2025 15:03:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0