December 2025 - gerrit-log - lists.osmocom.org

[XS] Change in pysim[master]: TEST, please ignore
by dexter 22 Dec '25

22 Dec '25

dexter has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/38526?usp=email ) Change subject: TEST, please ignore ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38526?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I02934ed3eb8728e0f9f5a6cfb2b020b73def7174 Gerrit-Change-Number: 38526 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[XS] Change in pysim[master]: esim.saip.FsProfileElement: Add file2pe() for single file conversion
by dexter 22 Dec '25

22 Dec '25

Attention is currently required from: laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41734?usp=email ) Change subject: esim.saip.FsProfileElement: Add file2pe() for single file conversion ...................................................................... Patch Set 3: Code-Review-1 (3 comments) Patchset: PS3: I have the feeling that file2pe method might bear a risk to cause inconsistencies. File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/41734/comment/1bfc32fc_48031ac1?usp=em… : PS3, Line 636: def file2pe(self, f: File): Maybe replace "f" with "file" to make it more uniform to the add_file method? https://gerrit.osmocom.org/c/pysim/+/41734/comment/8b68b5b9_6ab4f070?usp=em… : PS3, Line 638: self.decoded[f.pe_name] = f.to_tuples() There is something I am struggling with. There is already the add_file() method. This method adds files to self.files and does a couple of other things as well. When we now use file2pe to put a file from whatever source into self.decoded. Then the rest of the class members (self.files, etc.) know nothing about the update. For example, the next time we run files2pe, the updated file gets overwritten with the old content. Maybe we need a more elaborated update function, similar to add_file? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41734?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7b7f61aae6b7df6946dadf2f78fddf92995603ec Gerrit-Change-Number: 41734 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 22 Dec 2025 16:22:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: Fix more odd-length digit sequences via PaddedBcdAdapter
by dexter 22 Dec '25

22 Dec '25

Attention is currently required from: fixeria, laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41742?usp=email ) Change subject: Fix more odd-length digit sequences via PaddedBcdAdapter ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: I have tested the patch and I can indeed confirm the problem. Also writing seemed to be problematic. Writing 123 resulted in 12. With the patch, this is fixed. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4571482da924a3d645caa297108279d182448d21 Gerrit-Change-Number: 41742 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Dec 2025 15:59:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: set different mgcp_params ports and ids for each subscriber
by pespin 22 Dec '25

22 Dec '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41749?usp=email ) Change subject: hnbgw: set different mgcp_params ports and ids for each subscriber ...................................................................... hnbgw: set different mgcp_params ports and ids for each subscriber Change-Id: I32f644038d7e29b261ba3852583170a63544dae5 --- M hnbgw/ConnHdlr.ttcn 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/49/41749/1 diff --git a/hnbgw/ConnHdlr.ttcn b/hnbgw/ConnHdlr.ttcn index 91c7878..7f557c9 100644 --- a/hnbgw/ConnHdlr.ttcn +++ b/hnbgw/ConnHdlr.ttcn @@ -137,22 +137,22 @@ resp := 1, mgw_rtp_ip := "127.1.2.1", mgw_rtp_ip_mdcx := omit, - mgw_rtp_port := 10000, - mgcp_connection_id := '11111'H + mgw_rtp_port := 10000 + endp_idx, + mgcp_connection_id := int2hex(hex2int('11111'H) + endp_idx, 32) }, mgw_conn_cn := { resp := 1, mgw_rtp_ip := "127.1.2.2", mgw_rtp_ip_mdcx := omit, - mgw_rtp_port := 20000, - mgcp_connection_id := '22222'H + mgw_rtp_port := 20000 + endp_idx, + mgcp_connection_id := int2hex(hex2int('22222'H) + endp_idx, 32) }, rtp_payload_type := 112, rtp_sdp_format := "VND.3GPP.IUFP", hnb_rtp_ip := "127.1.1.1", - hnb_rtp_port := 10001, + hnb_rtp_port := 10001 + endp_idx, cn_rtp_ip := "127.1.3.1", - cn_rtp_port := 20001, + cn_rtp_port := 20001 + endp_idx, use_osmux := false, got_osmux_count := 0 } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41749?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I32f644038d7e29b261ba3852583170a63544dae5 Gerrit-Change-Number: 41749 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: setup.py: Align cmd2 minimum version with requirements.txt
by dexter 22 Dec '25

22 Dec '25

Attention is currently required from: fixeria, laforge, neels, osmith. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41642?usp=email ) Change subject: setup.py: Align cmd2 minimum version with requirements.txt ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: > well, actually after some more thought, option 2 sounds like it causes less problems for users, so l […] I am currently using pySim-shell with 2.5.0, no issues to far. I bet 2.6.2 will also work well. I think that raising the version requirements would be good because we could get rid of backward compatibility workarounds (e.g. the colors in pySim-shell.py). But I also see the point that there might be users out there that are still bound to cmd2 1.5 for some reason. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41642?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I71cee0ec3ed2abec68ec567beaab13c868721dad Gerrit-Change-Number: 41642 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Dec 2025 15:15:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in pysim[master]: ts_51_011: Improve testing of EF_SMSP
by dexter 22 Dec '25

22 Dec '25

Attention is currently required from: laforge, neels. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41677?usp=email ) Change subject: ts_51_011: Improve testing of EF_SMSP ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41677?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8d16e195641bb59b2c26072008f88434692c0cab Gerrit-Change-Number: 41677 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 22 Dec 2025 15:03:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN: Remove unsupport test cases
by dexter 22 Dec '25

22 Dec '25

Attention is currently required from: laforge, lynxis lazus. dexter has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39261?usp=email ) Change subject: SGSN: Remove unsupport test cases ...................................................................... Patch Set 14: (1 comment) Patchset: PS14: It might be good to explain a bit more why those test cases are removed. Is it because we do not support those features? Or are they removed in later specs? Or have we decided that we will never support them? - I am not very deep into that matter but maybe the commit message should answer those questions? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39261?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1506324300fe3864069706d5b05860e7b44cd895 Gerrit-Change-Number: 39261 Gerrit-PatchSet: 14 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 22 Dec 2025 15:00:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmocore[master]: msgb: Also copy msgb {dst, lchan, cb} during msgb_copy_*
by dexter 22 Dec '25

22 Dec '25

Attention is currently required from: laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/36324?usp=email ) Change subject: msgb: Also copy msgb {dst, lchan, cb} during msgb_copy_* ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/core/msgb.c: https://gerrit.osmocom.org/c/libosmocore/+/36324/comment/63c57054_58af55e5?… : PS1, Line 320: * and adjusts the pointers (incl l1h-l4h) accordingly. The cb part is not copied. > I think the cb was not copied as a performance reason, since lots of code doesn't use cb at all. […] I wonder how much the performance impact of copying the cb buffer would be. The additional effort should be neglectable. While the function was specified not to copy the cb, it thereis nothing said about msg->lchan and msg->dst. Maybe we could just drop the memcpy line? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36324?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I68328adb952ca8833ba047cb3b49ccc6f8a1f1b5 Gerrit-Change-Number: 36324 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 22 Dec 2025 14:56:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: pySim.esim.saip.personalization: Support for EF.SMSP personalization
by dexter 22 Dec '25

22 Dec '25

Attention is currently required from: laforge, neels. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41735?usp=email ) Change subject: pySim.esim.saip.personalization: Support for EF.SMSP personalization ...................................................................... Patch Set 5: Code-Review+2 (4 comments) Patchset: PS5: I have now carefully looked at this. To my eyes, everything looks fine. I also thing that you have already tried that out somewhere. File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/41735/comment/904ba84c_cfcd40a4?usp=em… : PS5, Line 129: for pe in pes.get_pes_for_type('usim'): I am not 100% sure here, maybe our application does not even require this. But in "eUICC Profile Package: Interoperable Format Technical Specification" I see that the ED.SMSP not only appears in USIM, it appears in ISIM and CSIM as well, but as optional files. https://gerrit.osmocom.org/c/pysim/+/41735/comment/6ee93085_3a48a739?usp=em… : PS5, Line 131: f_smsp = pe.files['ef-smsp'] This should be ok, in "eUICC Profile Package: Interoperable Format Technical Specification", section 9.5.1 I can see that EF.SMSP is on the list with the mandatory files, so it should be always there. https://gerrit.osmocom.org/c/pysim/+/41735/comment/b5f6fa0e_5631de6b?usp=em… : PS5, Line 132: #print("SMSP (orig): %s" % f_smsp.body) Do you want to keep this commented out debug print? (there is another one below) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41735?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6b0776c2e753e0a6d158a8cf65cb030977782ec2 Gerrit-Change-Number: 41735 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 22 Dec 2025 14:42:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: ts_31_102.EF_ECC: Use PaddedBcdAdapter to skip trailing 'f'
by dexter 22 Dec '25

22 Dec '25

Attention is currently required from: laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41741?usp=email ) Change subject: ts_31_102.EF_ECC: Use PaddedBcdAdapter to skip trailing 'f' ...................................................................... Patch Set 2: Code-Review+2 Verified+1 (1 comment) Patchset: PS2: I have tested this on a SysmoISIM, the phoe number (911) is properly displayed. I think we can merge this. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41741?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibfe1e23431aa803b936dd8529e0542e93d9df0b9 Gerrit-Change-Number: 41741 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 22 Dec 2025 14:15:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2025

2024

2023

2022

gerrit-log December 2025