December 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-hnbgw[master]: nft_kpi: add udp/2152 filtering rules separately
by fixeria 23 Dec '25

23 Dec '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/41752?usp=email ) Change subject: nft_kpi: add udp/2152 filtering rules separately ...................................................................... nft_kpi: add udp/2152 filtering rules separately Change-Id: I36eb3b18751fc029297fb91545af2d28e61067fd Related: SYS#7808 --- M src/osmo-hnbgw/nft_kpi.c 1 file changed, 31 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/52/41752/1 diff --git a/src/osmo-hnbgw/nft_kpi.c b/src/osmo-hnbgw/nft_kpi.c index f8671fc..5121320 100644 --- a/src/osmo-hnbgw/nft_kpi.c +++ b/src/osmo-hnbgw/nft_kpi.c @@ -325,33 +325,50 @@ } /* worker thread */ -static int do_init_table(void) +static int do_add_chain(bool uplink) { char cmd[1024]; struct osmo_strbuf sb = { .buf = cmd, .len = sizeof(cmd) }; /* add global nftables structures */ - OSMO_STRBUF_PRINTF(sb, "add table inet %s { flags owner; };\n", g_nft_thread->table_name); OSMO_STRBUF_PRINTF(sb, - "add chain inet %s gtpu-ul {" - " type filter hook prerouting priority 0; policy accept;" - " ip protocol != udp accept;" - " udp dport != 2152 accept;" + "add chain inet %s gtpu-%s {" + " type filter hook %srouting priority 0; policy accept;" "};\n", - g_nft_thread->table_name); - OSMO_STRBUF_PRINTF(sb, - "add chain inet %s gtpu-dl {" - " type filter hook postrouting priority 0; policy accept;" - " ip protocol != udp accept;" - " udp dport != 2152 accept;" - "};\n", - g_nft_thread->table_name); + g_nft_thread->table_name, + uplink ? "ul" : "dl", + uplink ? "pre" : "post"); + OSMO_STRBUF_PRINTF(sb, "add rule inet %s gtpu-%s ip protocol != udp accept;\n", + g_nft_thread->table_name, + uplink ? "ul" : "dl"); + OSMO_STRBUF_PRINTF(sb, "add rule inet %s gtpu-%s udp dport != 2152 accept;\n", + g_nft_thread->table_name, + uplink ? "ul" : "dl"); OSMO_ASSERT(sb.chars_needed < sizeof(cmd)); return nft_run_now(cmd, NULL, NULL); } /* worker thread */ +static int do_init_table(void) +{ + int rc; + char cmd[1024]; + struct osmo_strbuf sb = { .buf = cmd, .len = sizeof(cmd) }; + + /* add global nftables structures */ + OSMO_STRBUF_PRINTF(sb, "add table inet %s { flags owner; };\n", g_nft_thread->table_name); + OSMO_ASSERT(sb.chars_needed < sizeof(cmd)); + if ((rc = nft_run_now(cmd, NULL, NULL)) != 0) + return rc; + if ((rc = do_add_chain(true)) != 0) /* gtpu-ul */ + return rc; + if ((rc = do_add_chain(false)) != 0) /* gtpu-dl */ + return rc; + return 0; +} + +/* worker thread */ static void nft_t2m_enqueue(struct nft_thread *t, struct nft_thread_req *req) { LOGP(DNFT, LOGL_DEBUG, "main() <- %s: %s rc=%d\n", t->label, nft_thread_req_type_name[req->type], req->rc); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/41752?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I36eb3b18751fc029297fb91545af2d28e61067fd Gerrit-Change-Number: 41752 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: esim.saip.FsProfileElement: Add file2pe() for single file conversion
by laforge 23 Dec '25

23 Dec '25

Attention is currently required from: dexter. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41734?usp=email ) Change subject: esim.saip.FsProfileElement: Add file2pe() for single file conversion ...................................................................... Patch Set 3: (1 comment) File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/41734/comment/df7e1368_78bda566?usp=em… : PS3, Line 638: self.decoded[f.pe_name] = f.to_tuples() > There is something I am struggling with. There is already the add_file() method. […] we could a) make sure that the caller-provided file is actually contained in self.files (which is how I intended it to be used) and not some completely different source b) pass a path into this function, resolve the File from self.files and then update it. This would incur the look-up cost, which is why I decided to permit passing the file instance directly In any case, the fundamental problem is: * we have the decoded representation in self.files. It may not always be 100% correct yet as the code matures * we have very basic/inclomplete encoder capabilities, so re-encoding all the content (like files2pe below) is very likely to incur some losses in translation * during personalization, we still want to modify individual files. In case of EF.SMSP we want to replace the entire file contents, so calling a single-file `file2pe` sounds like the approach where at least we don't corrupt any other files Due to the many nasty details of the SAIP file format, and it's various encoding options, referral to [various differnt versions of] templates with default content, etc. I think it will be a long time until we have code that can reliably and loss-free translate decoded -> files -> decoded for the whole PE. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41734?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7b7f61aae6b7df6946dadf2f78fddf92995603ec Gerrit-Change-Number: 41734 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Dec 2025 10:02:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[L] Change in pysim[master]: card_key_provider: add PostgreSQL support
by laforge 23 Dec '25

23 Dec '25

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41508?usp=email ) Change subject: card_key_provider: add PostgreSQL support ...................................................................... Patch Set 9: Code-Review-1 (1 comment) File contrib/csv-to-pgsql.py: https://gerrit.osmocom.org/c/pysim/+/41508/comment/0cd7fc66_a624270a?usp=em… : PS8, Line 261: str(Path.home()) + "/.osmocom/pysim/card_data_pqsql.cfg" > Thanks, having the user name in the helptext is indeed something we should avoid. […] thanks - but why is it still called pqsql? As I commented earlier, pgsql or psql are industry standard abbreviations; I've never seen pqsql. Also, what should the first 'q' stand for? It's PostGreSQL and not postQreSQL. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41508?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icba625c02a60d7e1f519b506a46bda5ded0537d3 Gerrit-Change-Number: 41508 Gerrit-PatchSet: 9 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Dec 2025 09:55:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: pySim-shell: output git hash in case get_distribution fails
by dexter 23 Dec '25

23 Dec '25

Attention is currently required from: dexter, fixeria, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41738?usp=email ) Change subject: pySim-shell: output git hash in case get_distribution fails ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: I wonder if pySim-shell could benefit from a --version command line option. Then scripts also could retrieve the version string. On the other hand, if someone really needs the version on sh level, there is always --noprompt and command. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41738?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2b9038f88cfcaa07894a2f09c7f5ad8a5474083d Gerrit-Change-Number: 41738 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Dec 2025 09:47:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in pysim[master]: pySim-shell: output git hash in case get_distribution fails
by dexter 23 Dec '25

23 Dec '25

Attention is currently required from: dexter, fixeria, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41738?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by laforge Change subject: pySim-shell: output git hash in case get_distribution fails ...................................................................... pySim-shell: output git hash in case get_distribution fails In case pySim-shell is used directly from the git repository (not installed via a package manager), the version command fails with an exception because pkg_resources.get_distribution('pySim') fails. In that case, let's check if pySim-shell.py is inside a git repository and if so, get the HEAD commit hash and display it instead. Related: OS#6830 Change-Id: I2b9038f88cfcaa07894a2f09c7f5ad8a5474083d --- M pySim-shell.py 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/38/41738/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41738?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2b9038f88cfcaa07894a2f09c7f5ad8a5474083d Gerrit-Change-Number: 41738 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: pySim-shell/cosmetic: remove unnecessary brackets
by dexter 23 Dec '25

23 Dec '25

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41751?usp=email ) Change subject: pySim-shell/cosmetic: remove unnecessary brackets ...................................................................... pySim-shell/cosmetic: remove unnecessary brackets Change-Id: I6929aa4fa189414217c05a4ef5180d4ed44eb3a4 --- M pySim-shell.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/51/41751/1 diff --git a/pySim-shell.py b/pySim-shell.py index a8b15d5..75b7ef7 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -1164,7 +1164,7 @@ # Ensure that we are able to print formatted warnings from the beginning. PySimLogger.setup(print, {logging.WARN: YELLOW}) - if (opts.verbose): + if opts.verbose: PySimLogger.set_verbose(True) PySimLogger.set_level(logging.DEBUG) else: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41751?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6929aa4fa189414217c05a4ef5180d4ed44eb3a4 Gerrit-Change-Number: 41751 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: pySim-shell: do not show user home path in help text
by laforge 23 Dec '25

23 Dec '25

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41748?usp=email ) Change subject: pySim-shell: do not show user home path in help text ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41748?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ied8b1e553de8f5370369c4485a2360906c874ed2 Gerrit-Change-Number: 41748 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Dec 2025 09:40:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-abis[master]: trau_frame cosmetic: rm dead/invalid definitions
by laforge 23 Dec '25

23 Dec '25

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41750?usp=email ) Change subject: trau_frame cosmetic: rm dead/invalid definitions ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41750?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Icd96220455888ec5e1d03402b750da6945aaf095 Gerrit-Change-Number: 41750 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 23 Dec 2025 09:39:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: pySim-shell: output git hash in case get_distribution fails
by laforge 23 Dec '25

23 Dec '25

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41738?usp=email ) Change subject: pySim-shell: output git hash in case get_distribution fails ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41738?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2b9038f88cfcaa07894a2f09c7f5ad8a5474083d Gerrit-Change-Number: 41738 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Dec 2025 09:39:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: pySim-shell: output git hash in case get_distribution fails
by dexter 23 Dec '25

23 Dec '25

Attention is currently required from: fixeria, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41738?usp=email ) Change subject: pySim-shell: output git hash in case get_distribution fails ...................................................................... Patch Set 3: (1 comment) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/41738/comment/e393a352_e67c885b?usp=em… : PS2, Line 530: cwd + "/.git" > AFAIK os.path. […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41738?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2b9038f88cfcaa07894a2f09c7f5ad8a5474083d Gerrit-Change-Number: 41738 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Dec 2025 09:25:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

2025

2024

2023

2022

gerrit-log December 2025