December 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: SGSN: Remove unsupport test cases
by dexter 22 Dec '25

22 Dec '25

Attention is currently required from: laforge, lynxis lazus. dexter has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39261?usp=email ) Change subject: SGSN: Remove unsupport test cases ...................................................................... Patch Set 14: (1 comment) Patchset: PS14: It might be good to explain a bit more why those test cases are removed. Is it because we do not support those features? Or are they removed in later specs? Or have we decided that we will never support them? - I am not very deep into that matter but maybe the commit message should answer those questions? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39261?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1506324300fe3864069706d5b05860e7b44cd895 Gerrit-Change-Number: 39261 Gerrit-PatchSet: 14 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 22 Dec 2025 15:00:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmocore[master]: msgb: Also copy msgb {dst, lchan, cb} during msgb_copy_*
by dexter 22 Dec '25

22 Dec '25

Attention is currently required from: laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/36324?usp=email ) Change subject: msgb: Also copy msgb {dst, lchan, cb} during msgb_copy_* ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/core/msgb.c: https://gerrit.osmocom.org/c/libosmocore/+/36324/comment/63c57054_58af55e5?… : PS1, Line 320: * and adjusts the pointers (incl l1h-l4h) accordingly. The cb part is not copied. > I think the cb was not copied as a performance reason, since lots of code doesn't use cb at all. […] I wonder how much the performance impact of copying the cb buffer would be. The additional effort should be neglectable. While the function was specified not to copy the cb, it thereis nothing said about msg->lchan and msg->dst. Maybe we could just drop the memcpy line? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36324?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I68328adb952ca8833ba047cb3b49ccc6f8a1f1b5 Gerrit-Change-Number: 36324 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 22 Dec 2025 14:56:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: pySim.esim.saip.personalization: Support for EF.SMSP personalization
by dexter 22 Dec '25

22 Dec '25

Attention is currently required from: laforge, neels. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41735?usp=email ) Change subject: pySim.esim.saip.personalization: Support for EF.SMSP personalization ...................................................................... Patch Set 5: Code-Review+2 (4 comments) Patchset: PS5: I have now carefully looked at this. To my eyes, everything looks fine. I also thing that you have already tried that out somewhere. File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/41735/comment/904ba84c_cfcd40a4?usp=em… : PS5, Line 129: for pe in pes.get_pes_for_type('usim'): I am not 100% sure here, maybe our application does not even require this. But in "eUICC Profile Package: Interoperable Format Technical Specification" I see that the ED.SMSP not only appears in USIM, it appears in ISIM and CSIM as well, but as optional files. https://gerrit.osmocom.org/c/pysim/+/41735/comment/6ee93085_3a48a739?usp=em… : PS5, Line 131: f_smsp = pe.files['ef-smsp'] This should be ok, in "eUICC Profile Package: Interoperable Format Technical Specification", section 9.5.1 I can see that EF.SMSP is on the list with the mandatory files, so it should be always there. https://gerrit.osmocom.org/c/pysim/+/41735/comment/b5f6fa0e_5631de6b?usp=em… : PS5, Line 132: #print("SMSP (orig): %s" % f_smsp.body) Do you want to keep this commented out debug print? (there is another one below) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41735?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6b0776c2e753e0a6d158a8cf65cb030977782ec2 Gerrit-Change-Number: 41735 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 22 Dec 2025 14:42:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: ts_31_102.EF_ECC: Use PaddedBcdAdapter to skip trailing 'f'
by dexter 22 Dec '25

22 Dec '25

Attention is currently required from: laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41741?usp=email ) Change subject: ts_31_102.EF_ECC: Use PaddedBcdAdapter to skip trailing 'f' ...................................................................... Patch Set 2: Code-Review+2 Verified+1 (1 comment) Patchset: PS2: I have tested this on a SysmoISIM, the phoe number (911) is properly displayed. I think we can merge this. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41741?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibfe1e23431aa803b936dd8529e0542e93d9df0b9 Gerrit-Change-Number: 41741 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 22 Dec 2025 14:15:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: pySim-shell: do not show user home path in help text
by daniel 22 Dec '25

22 Dec '25

Attention is currently required from: dexter. daniel has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41748?usp=email ) Change subject: pySim-shell: do not show user home path in help text ...................................................................... Patch Set 1: -Code-Review (1 comment) Patchset: PS1: I was just about to propose that --script and --card_handler should also use expanduser, but after testing this seems to already work. Are you sure that FILE and PATH metavars don't already expand '~'? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41748?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ied8b1e553de8f5370369c4485a2360906c874ed2 Gerrit-Change-Number: 41748 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Dec 2025 14:05:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-ttcn3-hacks[master]: 5gc: Test UE Triggered Service Request
by pespin 22 Dec '25

22 Dec '25

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41747?usp=email ) Change subject: 5gc: Test UE Triggered Service Request ...................................................................... 5gc: Test UE Triggered Service Request Related: SYS#7073 Change-Id: I65cf7844d11be55d9d5c8e31fd87a3c72e6a607b --- M 5gc/C5G_Tests.ttcn M 5gc/ConnHdlr.ttcn M 5gc/expected-results.xml M library/NGAP_Functions.ttcn M library/NG_NAS_Osmo_Templates.ttcn M library/NG_NAS_Osmo_Types.ttcn 6 files changed, 345 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/47/41747/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41747?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I65cf7844d11be55d9d5c8e31fd87a3c72e6a607b Gerrit-Change-Number: 41747 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: pySim-shell: do not show user home path in help text
by daniel 22 Dec '25

22 Dec '25

Attention is currently required from: dexter. daniel has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41748?usp=email ) Change subject: pySim-shell: do not show user home path in help text ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41748?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ied8b1e553de8f5370369c4485a2360906c874ed2 Gerrit-Change-Number: 41748 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Dec 2025 13:59:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in pysim[master]: card_key_provider: add PostgreSQL support
by daniel 22 Dec '25

22 Dec '25

Attention is currently required from: dexter, fixeria, laforge. daniel has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41508?usp=email ) Change subject: card_key_provider: add PostgreSQL support ...................................................................... Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41508?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icba625c02a60d7e1f519b506a46bda5ded0537d3 Gerrit-Change-Number: 41508 Gerrit-PatchSet: 9 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Dec 2025 13:58:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: pySim-shell: do not show user home path in help text
by dexter 22 Dec '25

22 Dec '25

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41748?usp=email ) Change subject: pySim-shell: do not show user home path in help text ...................................................................... pySim-shell: do not show user home path in help text At the moment, the help text for the --csv option shows the path to the users home. This is due to the default value, which is dynamically generated. Let's use a static string with "~/" and resolve the full path later when we need it. Related: SYS#7725 Change-Id: Ied8b1e553de8f5370369c4485a2360906c874ed2 --- M pySim-shell.py 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/48/41748/1 diff --git a/pySim-shell.py b/pySim-shell.py index a8b15d5..26bf12c 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -1138,7 +1138,7 @@ card_key_group = option_parser.add_argument_group('Card Key Provider Options') card_key_group.add_argument('--csv', metavar='FILE', - default=str(Path.home()) + "/.osmocom/pysim/card_data.csv", + default="~/.osmocom/pysim/card_data.csv", help='Read card data from CSV file') card_key_group.add_argument('--csv-column-key', metavar='FIELD:AES_KEY_HEX', default=[], action='append', help=argparse.SUPPRESS, dest='column_key') @@ -1177,8 +1177,8 @@ for par in opts.column_key: name, key = par.split(':') column_keys[name] = key - if os.path.isfile(opts.csv): - card_key_provider_register(CardKeyProviderCsv(opts.csv, column_keys)) + if os.path.isfile(os.path.expanduser(opts.csv)): + card_key_provider_register(CardKeyProviderCsv(os.path.expanduser(opts.csv), column_keys)) # Init card reader driver sl = init_reader(opts, proactive_handler = Proact()) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41748?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ied8b1e553de8f5370369c4485a2360906c874ed2 Gerrit-Change-Number: 41748 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[L] Change in pysim[master]: card_key_provider: add PostgreSQL support
by dexter 22 Dec '25

22 Dec '25

Attention is currently required from: daniel, fixeria, laforge. Hello Jenkins Builder, daniel, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41508?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: card_key_provider: add PostgreSQL support ...................................................................... card_key_provider: add PostgreSQL support The Card Key Provider currently only has support for CSV files as input. Unfortunately using CSV files does not scale very well when the card inventory is very large and continously updated. In this case a centralized storage in the form of a database is the more suitable approach. This patch adds PostgreSQL support next to the existing CSV file support. It also adds an importer tool to import existing CSV files into the database. Change-Id: Icba625c02a60d7e1f519b506a46bda5ded0537d3 Related: SYS#7725 --- A contrib/csv-to-pgsql.py M docs/card-key-provider.rst M pySim-shell.py M pySim/card_key_provider.py M setup.py 5 files changed, 587 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/08/41508/9 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41508?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icba625c02a60d7e1f519b506a46bda5ded0537d3 Gerrit-Change-Number: 41508 Gerrit-PatchSet: 9 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0