December 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: gbproxy: Fix several tests on titan 11
by fixeria 22 Dec '25

22 Dec '25

Attention is currently required from: daniel, laforge, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740?usp=email ) Change subject: gbproxy: Fix several tests on titan 11 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib17c7dcb3d224a6b9e75ce5f9121a05126f81909 Gerrit-Change-Number: 41740 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Dec 2025 10:09:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: library/NGAP_Templates: PDUSessionResourceSetupRequest: Fix criticali...
by pespin 22 Dec '25

22 Dec '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41692?usp=email ) Change subject: library/NGAP_Templates: PDUSessionResourceSetupRequest: Fix criticality of SetupList IE ...................................................................... library/NGAP_Templates: PDUSessionResourceSetupRequest: Fix criticality of SetupList IE 3GPP TS 38.413 version 18.5.0 Release 18 describes id-PDUSessionResourceSetupListSUReq in PDUSessionResourceSetupRequestIEs as "reject", and open5gs si sending tu us accordinginly. Related: SYS#7073 Change-Id: I727876facc2c019b6a83335faf361a5d2e12fb10 --- M library/ngap/NGAP_Templates.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/library/ngap/NGAP_Templates.ttcn b/library/ngap/NGAP_Templates.ttcn index 8748d0f..1910120 100644 --- a/library/ngap/NGAP_Templates.ttcn +++ b/library/ngap/NGAP_Templates.ttcn @@ -130,7 +130,7 @@ }, { id := id_PDUSessionResourceSetupListSUReq, - criticality := ignore, + criticality := reject, value_ := { PDUSessionResourceSetupListSUReq := p_pDUSessionResourceSetupListSUReq } } } @@ -167,7 +167,7 @@ }, { id := id_PDUSessionResourceSetupListSUReq, - criticality := ignore, + criticality := reject, value_ := { PDUSessionResourceSetupListSUReq := p_pDUSessionResourceSetupListSUReq } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41692?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I727876facc2c019b6a83335faf361a5d2e12fb10 Gerrit-Change-Number: 41692 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: library/NGAP_Templates: PDUSessionResourceSetupRequest: Fix criticali...
by fixeria 22 Dec '25

22 Dec '25

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41692?usp=email ) Change subject: library/NGAP_Templates: PDUSessionResourceSetupRequest: Fix criticality of SetupList IE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41692?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I727876facc2c019b6a83335faf361a5d2e12fb10 Gerrit-Change-Number: 41692 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Dec 2025 09:56:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: gbproxy: Fix several tests on titan 11
by pespin 22 Dec '25

22 Dec '25

Attention is currently required from: daniel, fixeria, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740?usp=email ) Change subject: gbproxy: Fix several tests on titan 11 ...................................................................... Patch Set 1: (6 comments) File gbproxy/GBProxy_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740/comment/ec1c1ca7_63fb… : PS1, Line 2722: [] pt.receive(BssgpStatusIndication:?) { repeat; } > cosmetic: shift right Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740/comment/8a3ac142_8e06… : PS1, Line 2744: defaults > It's only one now. […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740/comment/ac4eddea_be44… : PS1, Line 2753: PESPIN > debugging leftovers Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740/comment/a22b5aed_36af… : PS1, Line 2921: f_get_pcu_idx_ct > BTW, you can use `__SCOPE__` to print an function/altstep name, i.e. `log(__SCOPE__, "(): ...)`. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740/comment/b317acf0_6937… : PS1, Line 2954: defaults > Likewise, don't you need to `deactivate()` it anymore? Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740/comment/2d6a3a6f_9716… : PS1, Line 2956: /* Activate one altsteps for all PCU NSE */ : var default d := activate(as_count_bvc0_block(g_roi)); : : f_sleep(3.0); : : d > Does not look like we need to activate altsteps in background here? […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib17c7dcb3d224a6b9e75ce5f9121a05126f81909 Gerrit-Change-Number: 41740 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Dec 2025 09:40:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: gbproxy: Fix several tests on titan 11
by pespin 22 Dec '25

22 Dec '25

Attention is currently required from: daniel, laforge, osmith, pespin. Hello Jenkins Builder, daniel, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: gbproxy: Fix several tests on titan 11 ...................................................................... gbproxy: Fix several tests on titan 11 Rework altsteps to avoid race condition showing up under titan 11.1.0. It's not really clear whether the previous implementation is actually expected/permitted by TTCN-3, where an altstep variable is initialized multiple times with different values through activate(). In any case, the new implementation is much cleaner, only requiring 1 altstep instead of N. Related: OS#6800 Change-Id: Ib17c7dcb3d224a6b9e75ce5f9121a05126f81909 --- M gbproxy/GBProxy_Tests.ttcn M gbproxy/testenv.cfg 2 files changed, 77 insertions(+), 73 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/40/41740/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib17c7dcb3d224a6b9e75ce5f9121a05126f81909 Gerrit-Change-Number: 41740 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[S] Change in pysim[master]: pySim-shell: output git hash in case get_distribution fails
by dexter 22 Dec '25

22 Dec '25

Attention is currently required from: dexter, fixeria, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41738?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified-1 by Jenkins Builder Change subject: pySim-shell: output git hash in case get_distribution fails ...................................................................... pySim-shell: output git hash in case get_distribution fails In case pySim-shell is used directly from the git repository (not installed via a package manager), the version command fails with an exception because pkg_resources.get_distribution('pySim') fails. In that case, let's check if pySim-shell.py is inside a git repository and if so, get the HEAD commit hash and display it instead. Related: OS#6830 Change-Id: I2b9038f88cfcaa07894a2f09c7f5ad8a5474083d --- M pySim-shell.py 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/38/41738/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41738?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2b9038f88cfcaa07894a2f09c7f5ad8a5474083d Gerrit-Change-Number: 41738 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in libosmo-abis[master]: trau_rtp cosmetic: rm dead const lines
by pespin 22 Dec '25

22 Dec '25

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41745?usp=email ) Change subject: trau_rtp cosmetic: rm dead const lines ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41745?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ic1b091ec96eafc8759d90d14201c8698ef251761 Gerrit-Change-Number: 41745 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 22 Dec 2025 08:14:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-abis[master]: trau cosmetic: update osmo_trau2rtp API comments
by pespin 22 Dec '25

22 Dec '25

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41743?usp=email ) Change subject: trau cosmetic: update osmo_trau2rtp API comments ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41743?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Id287474c5824ab334da244701700051f9f014e66 Gerrit-Change-Number: 41743 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 22 Dec 2025 08:13:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-abis[master]: trau2rtp: rm defunct AMR WIP code
by pespin 22 Dec '25

22 Dec '25

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41744?usp=email ) Change subject: trau2rtp: rm defunct AMR WIP code ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41744?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ieeee8eb6dbf9c753458a91e13f2bf22311936259 Gerrit-Change-Number: 41744 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 22 Dec 2025 08:11:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: ts_31_102.EF_ECC: Use PaddedBcdAdapter to skip trailing 'f'
by fixeria 21 Dec '25

21 Dec '25

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41741?usp=email ) Change subject: ts_31_102.EF_ECC: Use PaddedBcdAdapter to skip trailing 'f' ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41741?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibfe1e23431aa803b936dd8529e0542e93d9df0b9 Gerrit-Change-Number: 41741 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 21 Dec 2025 10:20:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0