December 2025 - gerrit-log - lists.osmocom.org

[S] Change in ...pyosmocom[master]: Bump version: 0.0.12
by pespin 19 Dec '25

19 Dec '25

Attention is currently required from: fixeria, laforge, osmith. pespin has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41739?usp=email ) Change subject: Bump version: 0.0.12 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41739?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I0bbbfec06c45a4355b523b898063e0be161eb21f Gerrit-Change-Number: 41739 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Dec 2025 17:27:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: bts: properly set BTS_Tests.mp_trx_pars for hopping cfg
by pespin 19 Dec '25

19 Dec '25

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41697?usp=email ) Change subject: bts: properly set BTS_Tests.mp_trx_pars for hopping cfg ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41697?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib8861c3eee5157436fb213da212f22477639883f Gerrit-Change-Number: 41697 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Dec 2025 17:25:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: gbproxy: Fix several tests on titan 11
by pespin 19 Dec '25

19 Dec '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740?usp=email ) Change subject: gbproxy: Fix several tests on titan 11 ...................................................................... gbproxy: Fix several tests on titan 11 Rework altsteps to avoid race condition showing up under titan 11.1.0. It's not really clear whether the previous implementation is actually expected/permitted by TTCN-3, where an altstep variable is initialized multiple times with different values through activate(). In any case, the new implementation is much cleaner, only requiring 1 altstep instead of N. Related: OS#6800 Change-Id: Ib17c7dcb3d224a6b9e75ce5f9121a05126f81909 --- M gbproxy/GBProxy_Tests.ttcn M gbproxy/testenv.cfg 2 files changed, 74 insertions(+), 60 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/40/41740/1 diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn index 7f70f96..4a9605f 100644 --- a/gbproxy/GBProxy_Tests.ttcn +++ b/gbproxy/GBProxy_Tests.ttcn @@ -2683,25 +2683,45 @@ /*********************************************************************** * BVC-RESET procedure ***********************************************************************/ -private altstep as_count_bvc_reset(integer sgsn_idx, BssgpBvci bvci, inout roro_integer roroi) -runs on test_CT { - var BSSGP_BVC_CT sgsn_bvc_ct := f_get_sgsn_bvc_ct(sgsn_idx, bvci); - [] SGSN_MGMT.receive(BssgpResetIndication:{bvci}) from sgsn_bvc_ct { - roroi[sgsn_idx] := roroi[sgsn_idx] & { bvci }; - repeat; - } -} -private altstep as_ignore_status(BSSGP_BVC_MGMT_PT pt) { -[] pt.receive(BssgpStatusIndication:?) { repeat; } -} private function f_get_sgsn_bvc_ct(integer sgsn_idx, BssgpBvci bvci) runs on test_CT return BSSGP_BVC_CT { for (var integer i := 0; i < lengthof(g_sgsn[sgsn_idx].cfg.bvc); i := i+1) { if (g_sgsn[sgsn_idx].cfg.bvc[i].bvci == bvci) { return g_sgsn[sgsn_idx].vc_BSSGP_BVC[i]; } } + log("f_get_sgsn_bvc_ct(", sgsn_idx, ", ", bvci, "): null"); return null; } + +private function f_get_sgsn_idx_bvc_ct(BSSGP_BVC_CT sgsn_bvc_ct, BssgpBvci bvci) runs on test_CT return integer { + for (var integer i := 0; i < lengthof(g_sgsn); i := i+1) { + for (var integer j := 0; j < lengthof(g_sgsn[i].vc_BSSGP_BVC); j := j+1) { + if (g_sgsn[i].cfg.bvc[j].bvci == bvci and + g_sgsn[i].vc_BSSGP_BVC[j] == sgsn_bvc_ct) { + return i; + } + } + } + log("f_get_sgsn_idx_bvc_ct(ct=", sgsn_bvc_ct, ", bvci=", bvci, "): -1"); + return -1; +} + +private altstep as_count_bvc_reset(inout roro_integer roroi) +runs on test_CT { + var BssgpResetIndication rx_bssgp_reset_ind; + var BSSGP_BVC_CT sgsn_bvc_ct; + [] SGSN_MGMT.receive(BssgpResetIndication:?) -> value rx_bssgp_reset_ind sender sgsn_bvc_ct { + var integer sgsn_idx := f_get_sgsn_idx_bvc_ct(sgsn_bvc_ct, rx_bssgp_reset_ind.bvci); + if (sgsn_idx >= 0) { + roroi[sgsn_idx] := roroi[sgsn_idx] & { rx_bssgp_reset_ind.bvci }; + } + repeat; + } +} +private altstep as_ignore_status(BSSGP_BVC_MGMT_PT pt) { +[] pt.receive(BssgpStatusIndication:?) { repeat; } +} + private function f_reset_ptp_bvc_from_pcu(integer pcu_idx, integer bvc_idx) runs on test_CT { var BSSGP_BVC_CT pcu_bvc_ct := g_pcu[pcu_idx].vc_BSSGP_BVC[bvc_idx]; @@ -2723,30 +2743,25 @@ /* expect state on both PCU and SGSN side to change */ defaults := { activate(as_ignore_status(SGSN_MGMT)) }; - /* Activate altsteps: One for each SGSN */ - for (i := 0; i < lengthof(g_sgsn); i := i+1) { - var default d := activate(as_count_bvc_reset(i, bvc_cfg.bvci, g_roroi)); - defaults := defaults & { d }; - } - + /* Activate one altestep for all SGSNs: */ + var default d := activate(as_count_bvc_reset(g_roroi)); timer T := 3.0; T.start; alt { - [] PCU_MGMT.receive(tr_BssgpStsInd(nsei_pcu, bvc_cfg.bvci, BVC_S_BLOCKED)) from pcu_bvc_ct { + [] PCU_MGMT.receive(tr_BssgpStsInd(nsei_pcu, bvc_cfg.bvci, BVC_S_BLOCKED)) -> sender pcu_bvc_ct { g_roi := g_roi & { bvc_cfg.bvci }; + log("PESPIN: append(g_roi, ", bvc_cfg.bvci, "):", g_roi); repeat; } [] T.timeout; } - - for (i := 0; i < lengthof(defaults); i := i+1) { - deactivate(defaults[i]); - } + deactivate(d); /* Check if BVC-RESET was received at all SGSNs */ for (i := 0; i < lengthof(g_sgsn); i := i+1) { if (not ro_integer_contains(g_roroi[i], bvc_cfg.bvci)) { - setverdict(fail, "Missing SGSN[", i, "] BVC-BLOCK of BVCI=", bvc_cfg.bvci); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Missing SGSN[", i, "] BVC-BLOCK of BVCI=", bvc_cfg.bvci, ", got ", g_roroi)); } } @@ -2762,24 +2777,27 @@ f_cleanup(); } -private altstep as_count_bvc_sts(integer sgsn_idx, BssgpBvci bvci, - template (present) BvcState exp_bvc_state, inout roro_integer roroi) +private altstep as_count_bvc_sts(template (present) BvcState exp_bvc_state, inout roro_integer roroi) runs on test_CT { - var BSSGP_BVC_CT sgsn_bvc_ct := f_get_sgsn_bvc_ct(sgsn_idx, bvci); - [] SGSN_MGMT.receive(tr_BssgpStsInd(?, bvci, exp_bvc_state)) from sgsn_bvc_ct { - roroi[sgsn_idx] := roroi[sgsn_idx] & { bvci }; + var BssgpStatusIndication rx_bssgp_st_ind; + var BSSGP_BVC_CT sgsn_bvc_ct; + [] SGSN_MGMT.receive(tr_BssgpStsInd(?, ?, exp_bvc_state)) -> value rx_bssgp_st_ind sender sgsn_bvc_ct { + var integer sgsn_idx := f_get_sgsn_idx_bvc_ct(sgsn_bvc_ct, rx_bssgp_st_ind.bvci); + if (sgsn_idx >= 0) { + roroi[sgsn_idx] := roroi[sgsn_idx] & { rx_bssgp_st_ind.bvci }; + } repeat; } } -private altstep as_count_bvc_block(integer sgsn_idx, BssgpBvci bvci, inout roro_integer roroi) +private altstep as_count_bvc_block(inout roro_integer roroi) runs on test_CT { - [] as_count_bvc_sts(sgsn_idx, bvci, BVC_S_BLOCKED, roroi); + [] as_count_bvc_sts(BVC_S_BLOCKED, roroi); } -private altstep as_count_bvc_unblock(integer sgsn_idx, BssgpBvci bvci, inout roro_integer roroi) +private altstep as_count_bvc_unblock(inout roro_integer roroi) runs on test_CT { - [] as_count_bvc_sts(sgsn_idx, bvci, BVC_S_UNBLOCKED, roroi); + [] as_count_bvc_sts(BVC_S_UNBLOCKED, roroi); } /* reset the signaling BVC from one BSS; expect no signaling BVC reset on SGSN; but BVC-BLOCK for PTP */ @@ -2796,15 +2814,7 @@ PCU_MGMT.send(BssgpResetRequest:{cause:=BSSGP_CAUSE_OM_INTERVENTION}) to g_pcu[0].vc_BSSGP; /* Activate altsteps: One for each PTP BVC and SGSN within that PCUs NSE */ - var ro_default defaults := {}; - for (var integer i := 0; i < lengthof(g_pcu[0].cfg.bvc); i := i+1) { - var BssgpBvcConfig bvcc := g_pcu[0].cfg.bvc[i]; - for (var integer j := 0; j < lengthof(g_sgsn); j := j+1) { - var default d := activate(as_count_bvc_block(j, bvcc.bvci, g_roroi)); - defaults := defaults & { d }; - } - } - + var default d := activate(as_count_bvc_block(g_roroi)); timer T := 3.0; T.start; alt { @@ -2813,10 +2823,7 @@ } [] T.timeout; } - - for (var integer i := 0; i < lengthof(defaults); i := i+1) { - deactivate(defaults[i]); - } + deactivate(d); /* check if BVC-block was received on all expected BVC/SGSN */ for (var integer i := 0; i < lengthof(g_pcu[0].cfg.bvc); i := i+1) { @@ -2905,11 +2912,25 @@ [] pt.receive {repeat; } } -private altstep as_count_bvc0_block(integer pcu_idx, Nsei nsei, inout ro_integer roi) +private function f_get_pcu_idx_ct(BSSGP_CT pcu_ct) runs on test_CT return integer { + for (var integer i := 0; i < lengthof(g_pcu); i := i+1) { + if (g_pcu[i].vc_BSSGP == pcu_ct) { + return i; + } + } + log("f_get_pcu_idx_ct(ct=", pcu_ct, "): -1"); + return -1; +} + +private altstep as_count_bvc0_block(inout ro_integer roi) runs on test_CT { - var BSSGP_CT pcu_ct := g_pcu[pcu_idx].vc_BSSGP; - [] PCU_MGMT.receive(BssgpResetIndication:{0}) from pcu_ct { - roi := roi & { nsei }; + var BSSGP_CT pcu_ct; + [] PCU_MGMT.receive(BssgpResetIndication:{0}) -> sender pcu_ct { + var integer pcu_idx := f_get_pcu_idx_ct(pcu_ct); + if (pcu_idx >= 0) { + var NSConfiguration nscfg := mp_nsconfig_pcu[pcu_idx]; + roi := roi & { nscfg.nsei }; + } repeat; } } @@ -2932,18 +2953,12 @@ */ var ro_default defaults := { activate(as_ignore_mgmt(PCU_MGMT)) }; - /* Activate altsteps: One for each PCU NSE */ - for (var integer i := 0; i < lengthof(g_pcu); i := i+1) { - var NSConfiguration nscfg := mp_nsconfig_pcu[i]; - var default d := activate(as_count_bvc0_block(i, nscfg.nsei, g_roi)); - defaults := defaults & { d }; - } + /* Activate one altsteps for all PCU NSE */ + var default d := activate(as_count_bvc0_block(g_roi)); f_sleep(3.0); - for (var integer i := 0; i < lengthof(defaults); i := i+1) { - deactivate(defaults[i]); - } + deactivate(d); /* check if BVC-block was received on all expected BVC */ for (var integer i := 0; i < lengthof(g_pcu); i := i+1) { diff --git a/gbproxy/testenv.cfg b/gbproxy/testenv.cfg index 7d3b41a..7adb482 100644 --- a/gbproxy/testenv.cfg +++ b/gbproxy/testenv.cfg @@ -1,6 +1,5 @@ [testsuite] -# Some tests fail with titan 11.1.0 (OS#6800) -titan_min=9.0.0 +titan_min=11.1.0 program=GBProxy_Tests config=GBProxy_Tests.cfg -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib17c7dcb3d224a6b9e75ce5f9121a05126f81909 Gerrit-Change-Number: 41740 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in ...pyosmocom[master]: Bump version: 0.0.12
by laforge 19 Dec '25

19 Dec '25

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41739?usp=email ) Change subject: Bump version: 0.0.12 ...................................................................... Bump version: 0.0.12 Change-Id: I0bbbfec06c45a4355b523b898063e0be161eb21f --- M debian/changelog M pyproject.toml 2 files changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/python/pyosmocom refs/changes/39/41739/1 diff --git a/debian/changelog b/debian/changelog index bbce47e..d3296f1 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,16 @@ +pyosmocom (0.0.12) unstable; urgency=medium + + [ Oliver Smith ] + * README: mention the pypi package + * Fix lint errors: unused imports + * Fix lint errors: remove unnecessary semicolons + * Fix lint errors: do not use bare except + + [ Harald Welte ] + * osmocom.construct.PaddedBcdAdapter: Support zero-length strings + + -- Harald Welte <lafore(a)gnumonks.org> Fri, 19 Dec 2025 18:19:53 +0100 + pyosmocom (0.0.11) unstable; urgency=medium * pyproject: use SPDX license identifier diff --git a/pyproject.toml b/pyproject.toml index c844a11..3fafdd4 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -4,7 +4,7 @@ [project] name = "pyosmocom" -version = "0.0.11" +version = "0.0.12" dependencies = [ "gsm0338", "construct >= 2.9.51" -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41739?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I0bbbfec06c45a4355b523b898063e0be161eb21f Gerrit-Change-Number: 41739 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: pysim/log: also accept ANSI strings to specify the log message colors
by laforge 19 Dec '25

19 Dec '25

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41713?usp=email ) Change subject: pysim/log: also accept ANSI strings to specify the log message colors ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41713?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I93543e19649064043ae8323f82ecd8c423d1d921 Gerrit-Change-Number: 41713 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Dec 2025 17:04:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: pySim-shell: output git hash in case get_distribution fails
by laforge 19 Dec '25

19 Dec '25

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41738?usp=email ) Change subject: pySim-shell: output git hash in case get_distribution fails ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41738?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2b9038f88cfcaa07894a2f09c7f5ad8a5474083d Gerrit-Change-Number: 41738 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Dec 2025 17:04:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...pyosmocom[master]: osmocom.construct.PaddedBcdAdapter: Support zero-length strings
by laforge 19 Dec '25

19 Dec '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41731?usp=email ) Change subject: osmocom.construct.PaddedBcdAdapter: Support zero-length strings ...................................................................... osmocom.construct.PaddedBcdAdapter: Support zero-length strings We cannot use the [-1] slicing if the input string has zero length. Fix typo in docstring while we're touching that class anyway. Change-Id: Ib5afb5ab5c2bc9b519dc92818fc6974f7eecba16 --- M src/osmocom/construct.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmocom/construct.py b/src/osmocom/construct.py index d369bc7..548f22d 100644 --- a/src/osmocom/construct.py +++ b/src/osmocom/construct.py @@ -262,11 +262,11 @@ return h2b(swap_nibbles(obj)) class PaddedBcdAdapter(BcdAdapter): - """Representatin of a BCD string of potentially odd number of BCD digits, + """Representation of a BCD string of potentially odd number of BCD digits, which then need to be padded at the end with an 'f' nibble.""" def _decode(self, obj, context, path): r = super()._decode(obj, context, path) - if r[-1] == 'f': + if len(r) >= 1 and r[-1] == 'f': return r[:-1] else: return r -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41731?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Ib5afb5ab5c2bc9b519dc92818fc6974f7eecba16 Gerrit-Change-Number: 41731 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in ...pyosmocom[master]: osmocom.construct.PaddedBcdAdapter: Support zero-length strings
by laforge 19 Dec '25

19 Dec '25

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41731?usp=email ) Change subject: osmocom.construct.PaddedBcdAdapter: Support zero-length strings ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41731?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Ib5afb5ab5c2bc9b519dc92818fc6974f7eecba16 Gerrit-Change-Number: 41731 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 19 Dec 2025 17:03:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: ts_51_011: Improve testing of EF_SMSP
by laforge 19 Dec '25

19 Dec '25

Attention is currently required from: dexter, neels. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41677?usp=email ) Change subject: ts_51_011: Improve testing of EF_SMSP ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41677?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8d16e195641bb59b2c26072008f88434692c0cab Gerrit-Change-Number: 41677 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Dec 2025 17:02:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: pySim.ts_51_011.EF_SMSP: Properly handle odd-length ScAddr / TpAddr
by laforge 19 Dec '25

19 Dec '25

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41733?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: pySim.ts_51_011.EF_SMSP: Properly handle odd-length ScAddr / TpAddr ...................................................................... pySim.ts_51_011.EF_SMSP: Properly handle odd-length ScAddr / TpAddr As the input phone number ("address") might be of an odd length of digits, let's use PaddedBcdAdapter to fix two problems: 1) strip any potential trailing f in decoding 2) fix truncation of last digit during encoding Change-Id: I1e9865e172bc29b8a31c281106d903934e81c686 Depends: pyosmocom Ib5afb5ab5c2bc9b519dc92818fc6974f7eecba16 --- M pySim/ts_51_011.py M tests/pySim-trace_test/pySim-trace_test_gsmtap.pcapng.ok 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/33/41733/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41733?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1e9865e172bc29b8a31c281106d903934e81c686 Gerrit-Change-Number: 41733 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0