December 2025 - gerrit-log - lists.osmocom.org

[XS] Change in ...pyosmocom[master]: osmocom.construct.PaddedBcdAdapter: Support zero-length strings
by laforge 19 Dec '25

19 Dec '25

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41731?usp=email ) Change subject: osmocom.construct.PaddedBcdAdapter: Support zero-length strings ...................................................................... osmocom.construct.PaddedBcdAdapter: Support zero-length strings We cannot use the [-1] slicing if the input string has zero length. Fix typo in docstring while we're touching that class anyway. Change-Id: Ib5afb5ab5c2bc9b519dc92818fc6974f7eecba16 --- M src/osmocom/construct.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/python/pyosmocom refs/changes/31/41731/1 diff --git a/src/osmocom/construct.py b/src/osmocom/construct.py index d369bc7..548f22d 100644 --- a/src/osmocom/construct.py +++ b/src/osmocom/construct.py @@ -262,11 +262,11 @@ return h2b(swap_nibbles(obj)) class PaddedBcdAdapter(BcdAdapter): - """Representatin of a BCD string of potentially odd number of BCD digits, + """Representation of a BCD string of potentially odd number of BCD digits, which then need to be padded at the end with an 'f' nibble.""" def _decode(self, obj, context, path): r = super()._decode(obj, context, path) - if r[-1] == 'f': + if len(r) >= 1 and r[-1] == 'f': return r[:-1] else: return r -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41731?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Ib5afb5ab5c2bc9b519dc92818fc6974f7eecba16 Gerrit-Change-Number: 41731 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: pysim/log: also accept ANSI strings to specify the log message colors
by dexter 19 Dec '25

19 Dec '25

Attention is currently required from: fixeria, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41713?usp=email ) Change subject: pysim/log: also accept ANSI strings to specify the log message colors ...................................................................... Patch Set 3: (1 comment) File pySim/log.py: https://gerrit.osmocom.org/c/pysim/+/41713/comment/98801bb5_2bb58a62?usp=em… : PS1, Line 111: if type(color) is str: > I believe Harald's suggestion was to do `isinstance(color, str)` instead of `type(color) is str`, bu […] I think I missed the line - it worked when I tested it with an ANSI string ;-/ -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41713?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I93543e19649064043ae8323f82ecd8c423d1d921 Gerrit-Change-Number: 41713 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Dec 2025 15:26:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[L] Change in pysim[master]: card_key_provider: add PostgreSQL support
by dexter 19 Dec '25

19 Dec '25

Attention is currently required from: daniel, fixeria, laforge. Hello Jenkins Builder, daniel, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41508?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: card_key_provider: add PostgreSQL support ...................................................................... card_key_provider: add PostgreSQL support The Card Key Provider currently only has support for CSV files as input. Unfortunately using CSV files does not scale very well when the card inventory is very large and continously updated. In this case a centralized storage in the form of a database is the more suitable approach. This patch adds PostgreSQL support next to the existing CSV file support. It also adds an importer tool to import existing CSV files into the database. Change-Id: Icba625c02a60d7e1f519b506a46bda5ded0537d3 Related: SYS#7725 --- A contrib/csv-to-pgsql.py M docs/card-key-provider.rst M pySim-shell.py M pySim/card_key_provider.py M setup.py 5 files changed, 586 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/08/41508/8 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41508?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icba625c02a60d7e1f519b506a46bda5ded0537d3 Gerrit-Change-Number: 41508 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: pysim/log: also accept ANSI strings to specify the log message colors
by dexter 19 Dec '25

19 Dec '25

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41713?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review-1 by fixeria, Verified+1 by Jenkins Builder Change subject: pysim/log: also accept ANSI strings to specify the log message colors ...................................................................... pysim/log: also accept ANSI strings to specify the log message colors the PySimLogger class currently only accepts cmd2 color enum values. This is what we need for pySim-shell.py. However, in case we want to use the PySimLogger in stand-alone programs that do not use cmd2, this is a bit bulky. Let's add some flexibility to PySimLogger, so that we can specify the colors as raw ANSI strings as well. Change-Id: I93543e19649064043ae8323f82ecd8c423d1d921 Related: SYS#7725 --- M pySim/log.py 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/13/41713/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41713?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I93543e19649064043ae8323f82ecd8c423d1d921 Gerrit-Change-Number: 41713 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[L] Change in pysim[master]: card_key_provider: add PostgreSQL support
by dexter 19 Dec '25

19 Dec '25

Attention is currently required from: daniel, fixeria, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41508?usp=email ) Change subject: card_key_provider: add PostgreSQL support ...................................................................... Patch Set 8: (3 comments) File contrib/csv-to-pgsql.py: https://gerrit.osmocom.org/c/pysim/+/41508/comment/5aab183d_35a2f0b1?usp=em… : PS5, Line 38: table_name > Consistency with what? Now that you have `.lower()` here, I see no point doing this below. Done File contrib/csv-to-pgsql.py: https://gerrit.osmocom.org/c/pysim/+/41508/comment/59f3f933_945e2466?usp=em… : PS7, Line 80: self.table > Shouldn't this be `table_names`? This detects the type of the table. If the table is called something like "my_euicc_keys_for_something" the program knows that it has to create a table for eUICC cards. When the table is called something like "all_my_uicc_keys", then it knows that it has to create a table for UICC cards. https://gerrit.osmocom.org/c/pysim/+/41508/comment/ae58843e_c8526744?usp=em… : PS7, Line 117: str(self.table.lower())) > ```suggestion […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41508?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icba625c02a60d7e1f519b506a46bda5ded0537d3 Gerrit-Change-Number: 41508 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Dec 2025 15:26:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-bsc[master]: vty: rm misleading warnings about DTX on E1 BTS
by falconia 19 Dec '25

19 Dec '25

falconia has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41726?usp=email ) Change subject: vty: rm misleading warnings about DTX on E1 BTS ...................................................................... vty: rm misleading warnings about DTX on E1 BTS Since the days of pre-split OpenBSC, whenever an operator would enable DTX (either UL or DL) in BSC vty on an E1 BTS, there was a warning message emitted, saying that this configuration is "neither supported nor tested". While those statements may have been correct in 2016 when that code was added (commit 6079528b), they are no longer correct in the present: both DTXu and DTXd work correctly now on E1 BTS that follow TS 48.060 or 48.061, with all 4 supported speech codecs: FR, HR, EFR and AMR. Full-featured, production-quality operation with E1 BTS requires use of tw-e1abis-mgw in the place of osmo-mgw - but even when legacy OsmoMGW-E1 is used, it is misleading to say that DTX is "neither supported nor tested", as the architectural shortcomings of OsmoMGW-E1 (lack of TFO transform for non-AMR codecs and lack of any support for AMR) are not specific to DTX per se. Change-Id: I63626b554d38b1ab094838374968e64193da1c11 --- M src/osmo-bsc/bts_vty.c 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index bbee866..d69fb1f 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -210,9 +210,6 @@ struct gsm_bts *bts = vty->index; bts->dtxu = (argc > 0) ? GSM48_DTX_SHALL_BE_USED : GSM48_DTX_MAY_BE_USED; - if (!is_ipa_abisip_bts(bts)) - vty_out(vty, "%% DTX enabled on non-IP BTS: this configuration " - "neither supported nor tested!%s", VTY_NEWLINE); return CMD_SUCCESS; } @@ -240,9 +237,6 @@ struct gsm_bts *bts = vty->index; bts->dtxd = true; - if (!is_ipa_abisip_bts(bts)) - vty_out(vty, "%% DTX enabled on non-IP BTS: this configuration " - "neither supported nor tested!%s", VTY_NEWLINE); return CMD_SUCCESS; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41726?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I63626b554d38b1ab094838374968e64193da1c11 Gerrit-Change-Number: 41726 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-msc[master]: add vty setting for ThemWi RTP formats
by falconia 19 Dec '25

19 Dec '25

falconia has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/41698?usp=email ) Change subject: add vty setting for ThemWi RTP formats ...................................................................... add vty setting for ThemWi RTP formats For every GSM speech codec and for CSD, Osmocom BSS supports both the standard RTP format prescribed by 3GPP and an alternative enhanced RTP format invented by Themyscira Wireless: TW-TS-001, TW-TS-002, TW-TS-006 and TW-TS-007. In order to enable these enhanced RTP formats, the MSC needs to include an extension IE in the Assignment Request it sends to the BSS. Until now there was no way to do so in mainline OsmoMSC, only via local code patches - fix this omission. The following considerations apply to this new tw-rtp-formats vty setting: * When internal MNCC is used, it is beneficial to enable enhanced TW RTP formats, especially when using E1 BTS with tw-e1abis-mgw: the DL call leg receives more complete information content from the UL call leg in each direction. * When external MNCC is used with non-ThemWi CN software (e.g., with a PBX via osmo-sip-connector), tw-rtp-formats should NOT be enabled - off-the-shelf PBX etc software won't understand them. * Future patches will allow osmo-msc to operate with a ThemWi transcoding MGW (TC to G.711) in the place of non-TC osmo-mgw; in that configuration TW RTP formats will become mandatory, as they are strictly required by ThemWi TC implementation. Depends: I4c184db53bec28ab42bcd45e033733d850eea5d2 (libosmocore.git) Change-Id: Icea152f5f2cdbcb0df09ef5b7211d1461b499f14 --- M TODO-RELEASE M include/osmocom/msc/gsm_data.h M include/osmocom/msc/ran_msg.h M src/libmsc/msc_a.c M src/libmsc/msc_vty.c M src/libmsc/ran_msg_a.c M tests/test_nodes.vty 7 files changed, 79 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index 0ed7189..65aa9d2 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +libosmovty >=1.12.1 working optional-multi-choice diff --git a/include/osmocom/msc/gsm_data.h b/include/osmocom/msc/gsm_data.h index 36149e1..80a7854 100644 --- a/include/osmocom/msc/gsm_data.h +++ b/include/osmocom/msc/gsm_data.h @@ -265,6 +265,24 @@ /* Whether we want to use Osmux against BSCs. Controlled via VTY */ enum osmux_usage use_osmux; + /* For every GSM speech codec supported in Osmocom, there are two + * possible RTP representations: the standard one originally invented + * by IETF and then adopted by 3GPP in Rel8 (globally recognized + * standard, but suffers from information loss relative to TRAU frame + * formats of previous GSM/3GPP releases), and an alternative format + * invented by Themyscira Wireless that restores TRAU-like information + * content at the price of non-standard RTP format. A similar + * situation exists for GSM CSD, although here the diff between + * 3GPP-standard and ThemWi RTP formats is a matter of encoding + * efficiency and payload size economy rather than information content. + * Osmocom BSS supports these AoIP RTP extensions, requested via a + * BSSMAP extension IE, and if they are desired, they need to be + * enabled from the MSC. The RTP extension selection octet sent via + * that BSSMAP extension (TW-TS-003) is a bit mask - allow it to be + * configured via vty. + */ + uint8_t tw_rtp_formats; + /* Whether to use call waiting on the network */ bool call_waiting; diff --git a/include/osmocom/msc/ran_msg.h b/include/osmocom/msc/ran_msg.h index dc1483c..799dff3 100644 --- a/include/osmocom/msc/ran_msg.h +++ b/include/osmocom/msc/ran_msg.h @@ -106,6 +106,7 @@ enum nsap_addr_enc rab_assign_addr_enc; bool osmux_present; uint8_t osmux_cid; + uint8_t rtp_extensions; bool call_id_present; uint32_t call_id; struct osmo_lcls *lcls; diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c index 97f723c..c682004 100644 --- a/src/libmsc/msc_a.c +++ b/src/libmsc/msc_a.c @@ -682,6 +682,7 @@ struct ran_msg msg; struct gsm_trans *cc_trans = msc_a->cc.active_trans; struct gsm0808_channel_type channel_type; + struct gsm_network *net = msc_a_net(msc_a); /* Do not dispatch another Assignment Command before an earlier assignment is completed. This is a sanity * safeguard, ideally callers should not even invoke this function when an Assignment is already ongoing. @@ -756,6 +757,7 @@ .channel_type = &channel_type, .osmux_present = msc_a->cc.call_leg->rtp[RTP_TO_RAN]->use_osmux, .osmux_cid = msc_a->cc.call_leg->rtp[RTP_TO_RAN]->local_osmux_cid, + .rtp_extensions = net->tw_rtp_formats, .call_id_present = true, .call_id = cc_trans->call_id, .lcls = cc_trans->cc.lcls, diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c index cbcad24..cacf501 100644 --- a/src/libmsc/msc_vty.c +++ b/src/libmsc/msc_vty.c @@ -34,6 +34,7 @@ #include <osmocom/gsm/protocol/gsm_04_14.h> #include <osmocom/gsm/protocol/gsm_08_08.h> #include <osmocom/gsm/gsm23236.h> +#include <osmocom/gsm/rtp_extensions.h> #include <osmocom/sigtran/sccp_helpers.h> @@ -684,6 +685,43 @@ return CMD_SUCCESS; } +#define TWFORMAT_STR "Use ThemWi RTP formats\n" +#define TWCODEC_MULT "(fr|hr|amr|csd)" +#define TWCODEC_OPT " [" TWCODEC_MULT "]" +#define TWCODEC_STR "TW-TS-001 for FR & EFR\nTW-TS-002 for HRv1\n" \ + "TW-TS-006 for AMR\nTW-TS-007 for CSD\n" + +DEFUN(cfg_msc_twformat, + cfg_msc_twformat_cmd, + "tw-rtp-formats " TWCODEC_MULT TWCODEC_OPT TWCODEC_OPT TWCODEC_OPT, + TWFORMAT_STR TWCODEC_STR TWCODEC_STR TWCODEC_STR TWCODEC_STR) +{ + uint8_t mask = 0; + int i; + + for (i = 0; i < argc; i++) { + if (!strcmp(argv[i], "fr")) + mask |= OSMO_RTP_EXT_TWTS001; + else if (!strcmp(argv[i], "hr")) + mask |= OSMO_RTP_EXT_TWTS002; + else if (!strcmp(argv[i], "amr")) + mask |= OSMO_RTP_EXT_TWTS006; + else if (!strcmp(argv[i], "csd")) + mask |= OSMO_RTP_EXT_TWTS007; + } + gsmnet->tw_rtp_formats = mask; + return CMD_SUCCESS; +} + +DEFUN(cfg_msc_no_twformat, + cfg_msc_no_twformat_cmd, + "no tw-rtp-formats", + NO_STR TWFORMAT_STR) +{ + gsmnet->tw_rtp_formats = 0; + return CMD_SUCCESS; +} + #define NRI_STR "Mapping of Network Resource Indicators to this MSC, for MSC pooling\n" DEFUN(cfg_msc_nri_bitlen, cfg_msc_nri_bitlen_cmd, "nri bitlen <0-15>", @@ -810,6 +848,19 @@ VTY_NEWLINE); } + if (gsmnet->tw_rtp_formats) { + vty_out(vty, " tw-rtp-formats"); + if (gsmnet->tw_rtp_formats & OSMO_RTP_EXT_TWTS001) + vty_out(vty, " fr"); + if (gsmnet->tw_rtp_formats & OSMO_RTP_EXT_TWTS002) + vty_out(vty, " hr"); + if (gsmnet->tw_rtp_formats & OSMO_RTP_EXT_TWTS006) + vty_out(vty, " amr"); + if (gsmnet->tw_rtp_formats & OSMO_RTP_EXT_TWTS007) + vty_out(vty, " csd"); + vty_out(vty, "%s", VTY_NEWLINE); + } + mgcp_client_config_write(vty, " "); neighbor_ident_vty_write(vty); @@ -2108,6 +2159,8 @@ install_element(MSC_NODE, &cfg_msc_sms_over_gsup_cmd); install_element(MSC_NODE, &cfg_msc_no_sms_over_gsup_cmd); install_element(MSC_NODE, &cfg_msc_osmux_cmd); + install_element(MSC_NODE, &cfg_msc_twformat_cmd); + install_element(MSC_NODE, &cfg_msc_no_twformat_cmd); install_element(MSC_NODE, &cfg_msc_handover_number_range_cmd); install_element(MSC_NODE, &cfg_msc_nri_bitlen_cmd); install_element(MSC_NODE, &cfg_msc_nri_add_cmd); diff --git a/src/libmsc/ran_msg_a.c b/src/libmsc/ran_msg_a.c index d904120..8d649fd 100644 --- a/src/libmsc/ran_msg_a.c +++ b/src/libmsc/ran_msg_a.c @@ -1465,6 +1465,8 @@ gsm0808_enc_group_callref(msg, &ac->callref); if (ac->osmux_present) msgb_tv_put(msg, GSM0808_IE_OSMO_OSMUX_CID, ac->osmux_cid); + if (ac->rtp_extensions) + msgb_tlv_put(msg, GSM0808_IE_THEMWI_RTP_EXTENSIONS, 1, &ac->rtp_extensions); msg->l3h[1] = msgb_l3len(msg) - 2; return msg; } diff --git a/tests/test_nodes.vty b/tests/test_nodes.vty index 5e4b793..7ce141a 100644 --- a/tests/test_nodes.vty +++ b/tests/test_nodes.vty @@ -67,6 +67,8 @@ sms-over-gsup no sms-over-gsup osmux (on|off|only) + tw-rtp-formats (fr|hr|amr|csd) [(fr|hr|amr|csd)] [(fr|hr|amr|csd)] [(fr|hr|amr|csd)] + no tw-rtp-formats handover-number range MSISDN_FIRST MSISDN_LAST nri bitlen <0-15> nri add <0-32767> [<0-32767>] -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41698?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Icea152f5f2cdbcb0df09ef5b7211d1461b499f14 Gerrit-Change-Number: 41698 Gerrit-PatchSet: 7 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: pysim/log: also accept ANSI strings to specify the log message colors
by fixeria 19 Dec '25

19 Dec '25

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41713?usp=email ) Change subject: pysim/log: also accept ANSI strings to specify the log message colors ...................................................................... Patch Set 2: Code-Review-1 (1 comment) File pySim/log.py: https://gerrit.osmocom.org/c/pysim/+/41713/comment/549fa4f7_543a1d35?usp=em… : PS1, Line 111: if type(color) is str: > Thanks for the hint. I haven't had that in mind. I believe Harald's suggestion was to do `isinstance(color, str)` instead of `type(color) is str`, but you are now doing both? ``` >>> cmd2.Fg.RED <Fg.RED: 31> >>> type(cmd2.Fg.RED) <enum 'Fg'> >>> isinstance(cmd2.Fg.RED, str) False ``` This patch most likely breaks passing cmd2 color. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41713?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I93543e19649064043ae8323f82ecd8c423d1d921 Gerrit-Change-Number: 41713 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Dec 2025 14:16:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: bts: properly set BTS_Tests.mp_trx_pars for hopping cfg
by fixeria 19 Dec '25

19 Dec '25

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41697?usp=email ) Change subject: bts: properly set BTS_Tests.mp_trx_pars for hopping cfg ...................................................................... Patch Set 1: (1 comment) File bts/BTS_Tests_FH.cfg: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41697/comment/c7daa07a_d8f0… : PS1, Line 7: * NOTE: the pchan assignment is *different* from non-hopping configuration. > Maybe append "(BTS_Tests. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41697?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib8861c3eee5157436fb213da212f22477639883f Gerrit-Change-Number: 41697 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Dec 2025 14:09:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: bts: properly set BTS_Tests.mp_trx_pars for hopping cfg
by fixeria 19 Dec '25

19 Dec '25

Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41697?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: bts: properly set BTS_Tests.mp_trx_pars for hopping cfg ...................................................................... bts: properly set BTS_Tests.mp_trx_pars for hopping cfg The pchan assignment is *different* for the hopping and non-hopping configurations, so let's override it in the BTS_Tests_FH.cfg. Change-Id: Ib8861c3eee5157436fb213da212f22477639883f --- M bts/BTS_Tests_FH.cfg 1 file changed, 55 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/97/41697/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41697?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib8861c3eee5157436fb213da212f22477639883f Gerrit-Change-Number: 41697 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0