December 2025 - gerrit-log - lists.osmocom.org

[XS] Change in pysim[master]: RFC: saip: templates: fix naming of EF.SUPI_NAI
by laforge 19 Dec '25

19 Dec '25

Attention is currently required from: lynxis lazus, neels. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/pysim/+/41689?usp=email ) Change subject: RFC: saip: templates: fix naming of EF.SUPI_NAI ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/pysim/+/41689/comment/13c3ed3d_d67fce63?usp=em… : PS1, Line 11: NSI, but somehow it's working > V2.3 of the SAIP ASN.1: […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41689?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3cde1093156db274458d76e2c1c2e304d55a8466 Gerrit-Change-Number: 41689 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 19 Dec 2025 12:07:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: RFC: saip: templates: fix naming of EF.SUPI_NAI
by laforge 19 Dec '25

19 Dec '25

Attention is currently required from: lynxis lazus, neels. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/pysim/+/41689?usp=email ) Change subject: RFC: saip: templates: fix naming of EF.SUPI_NAI ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://gerrit.osmocom.org/c/pysim/+/41689/comment/44f91d63_85caf54c?usp=em… : PS1, Line 11: NSI, but somehow it's working V2.3 of the SAIP ASN.1: ``` ef-nsi { fileDescriptor : { efFileSize '14'H -- 20 bytes }, fillFileContent : 'FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF'H }, ``` V3.3.1 of the SAPI ASN.1 (whcih we use in pySim): ``` ef-supinai { fileDescriptor : { efFileSize '14'H -- 20 bytes }, fillFileContent : 'FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF'H }, ``` -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41689?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3cde1093156db274458d76e2c1c2e304d55a8466 Gerrit-Change-Number: 41689 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 19 Dec 2025 12:07:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in pysim[master]: card_key_provider: add PostgreSQL support
by dexter 19 Dec '25

19 Dec '25

Attention is currently required from: daniel, fixeria, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41508?usp=email ) Change subject: card_key_provider: add PostgreSQL support ...................................................................... Patch Set 7: (2 comments) File contrib/csv-to-pgsql.py: https://gerrit.osmocom.org/c/pysim/+/41508/comment/bb352254_c969d0db?usp=em… : PS5, Line 38: table_name > Maybe do the `self. […] I am not sure, yes we could do the .lower() here. I think its ok to keep the .lower() calls in the queries for consistency. https://gerrit.osmocom.org/c/pysim/+/41508/comment/93780c15_6ce6f79b?usp=em… : PS5, Line 132: %s;", (self.table.lower(),)) > Why not using `SQL("...").format(... […] In this case it was possible to spare the SQL(). The escaping for values is done by the execute method. However, identifier names cannot be run through the escaping of the execute method. That is what SQL().format is then used for. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41508?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icba625c02a60d7e1f519b506a46bda5ded0537d3 Gerrit-Change-Number: 41508 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Dec 2025 12:00:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[L] Change in pysim[master]: card_key_provider: add PostgreSQL support
by dexter 19 Dec '25

19 Dec '25

Attention is currently required from: daniel, fixeria, laforge. Hello Jenkins Builder, daniel, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41508?usp=email to look at the new patch set (#7). Change subject: card_key_provider: add PostgreSQL support ...................................................................... card_key_provider: add PostgreSQL support The Card Key Provider currently only has support for CSV files as input. Unfortunately using CSV files does not scale very well when the card inventory is very large and continously updated. In this case a centralized storage in the form of a database is the more suitable approach. This patch adds PostgreSQL support next to the existing CSV file support. It also adds an importer tool to import existing CSV files into the database. Change-Id: Icba625c02a60d7e1f519b506a46bda5ded0537d3 Related: SYS#7725 --- A contrib/csv-to-pgsql.py M docs/card-key-provider.rst M pySim-shell.py M pySim/card_key_provider.py M setup.py 5 files changed, 586 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/08/41508/7 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41508?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icba625c02a60d7e1f519b506a46bda5ded0537d3 Gerrit-Change-Number: 41508 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: fix
by dexter 19 Dec '25

19 Dec '25

dexter has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/41729?usp=email ) Change subject: fix ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41729?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib9f729cf7bff97da402cdb08799ded420864b630 Gerrit-Change-Number: 41729 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-CC: Jenkins Builder

1 0

[XS] Change in pysim[master]: fix
by dexter 19 Dec '25

19 Dec '25

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41729?usp=email ) Change subject: fix ...................................................................... fix Change-Id: Ib9f729cf7bff97da402cdb08799ded420864b630 --- M contrib/csv-to-pgsql.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/29/41729/1 diff --git a/contrib/csv-to-pgsql.py b/contrib/csv-to-pgsql.py index a8a2a27..bb5f8a2 100755 --- a/contrib/csv-to-pgsql.py +++ b/contrib/csv-to-pgsql.py @@ -35,7 +35,7 @@ return user.get('name'), user.get('pass') log = PySimLogger.get("PQSQL") - self.table = table_name + self.table = table_name.lower() self.cols = None # Depending on the table type, the table name must contain either the substring "uicc_keys" or "euicc_keys". -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41729?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib9f729cf7bff97da402cdb08799ded420864b630 Gerrit-Change-Number: 41729 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: pysim/log: also accept ANSI strings to specify the log message colors
by dexter 19 Dec '25

19 Dec '25

Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41713?usp=email ) Change subject: pysim/log: also accept ANSI strings to specify the log message colors ...................................................................... Patch Set 2: (1 comment) File pySim/log.py: https://gerrit.osmocom.org/c/pysim/+/41713/comment/8914a10f_dded18f6?usp=em… : PS1, Line 111: if type(color) is str: > I think isinstance(color, str) would be the more appropriate, as the above only matches if it's *exa […] Thanks for the hint. I haven't had that in mind. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41713?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I93543e19649064043ae8323f82ecd8c423d1d921 Gerrit-Change-Number: 41713 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 19 Dec 2025 11:49:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[L] Change in pysim[master]: card_key_provider: add PostgreSQL support
by dexter 19 Dec '25

19 Dec '25

Attention is currently required from: daniel, fixeria, laforge. Hello Jenkins Builder, daniel, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41508?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: card_key_provider: add PostgreSQL support ...................................................................... card_key_provider: add PostgreSQL support The Card Key Provider currently only has support for CSV files as input. Unfortunately using CSV files does not scale very well when the card inventory is very large and continously updated. In this case a centralized storage in the form of a database is the more suitable approach. This patch adds PostgreSQL support next to the existing CSV file support. It also adds an importer tool to import existing CSV files into the database. Change-Id: Icba625c02a60d7e1f519b506a46bda5ded0537d3 Related: SYS#7725 --- A contrib/csv-to-pgsql.py M docs/card-key-provider.rst M pySim-shell.py M pySim/card_key_provider.py M setup.py 5 files changed, 586 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/08/41508/6 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41508?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icba625c02a60d7e1f519b506a46bda5ded0537d3 Gerrit-Change-Number: 41508 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: pysim/log: also accept ANSI strings to specify the log message colors
by dexter 19 Dec '25

19 Dec '25

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41713?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: pysim/log: also accept ANSI strings to specify the log message colors ...................................................................... pysim/log: also accept ANSI strings to specify the log message colors the PySimLogger class currently only accepts cmd2 color enum values. This is what we need for pySim-shell.py. However, in case we want to use the PySimLogger in stand-alone programs that do not use cmd2, this is a bit bulky. Let's add some flexibility to PySimLogger, so that we can specify the colors as raw ANSI strings as well. Change-Id: I93543e19649064043ae8323f82ecd8c423d1d921 Related: SYS#7725 --- M pySim/log.py 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/13/41713/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41713?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I93543e19649064043ae8323f82ecd8c423d1d921 Gerrit-Change-Number: 41713 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[L] Change in pysim[master]: card_key_provider: add PostgreSQL support
by dexter 19 Dec '25

19 Dec '25

Attention is currently required from: daniel, fixeria, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41508?usp=email ) Change subject: card_key_provider: add PostgreSQL support ...................................................................... Patch Set 6: (1 comment) File setup.py: https://gerrit.osmocom.org/c/pysim/+/41508/comment/a511ced0_ca5413f9?usp=em… : PS4, Line 37: psycopg2-binary > I agree it should be extras_require Acknowledged -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41508?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icba625c02a60d7e1f519b506a46bda5ded0537d3 Gerrit-Change-Number: 41508 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Dec 2025 11:49:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0