Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ci/+/41718?usp=email
to look at the new patch set (#2).
Change subject: jobs/ttcn3-testsuites: set RUN_BPFTRACE=1
......................................................................
jobs/ttcn3-testsuites: set RUN_BPFTRACE=1
Allow better analysis of instabilities with the ttcn3-bts-test jobs in
jenkins by running bpftrace scripts along with osmo-bts.
Only the ttcn3-bts-test scripts make use of the RUN_BPFTRACE environment
variable, so this does not affect how any other testsuite runs.
See the related docker-playground commit for details.
Related: OS#6794
Related: docker-playground I5c22cdbb08fe797be936ca174f65ade626fa4895
Change-Id: Iaa960772fb0b09722594747006890e5e43752d43
---
M jobs/ttcn3-testsuites.yml
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/18/41718/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41718?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Iaa960772fb0b09722594747006890e5e43752d43
Gerrit-Change-Number: 41718
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41723?usp=email )
Change subject: RAN_Emulation: Support Tx RESET retries in RANAP
......................................................................
Patch Set 1:
(1 comment)
File library/RAN_Emulation.ttcnpp:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41723/comment/674b317c_be04… :
PS1, Line 821: [] as_reset_ack();
> oh nvm, given that we make another retry only after 5s, then we do need to reschedule the timer. […]
given that everything runs on localhost: how about retrying 10 times with 0.5s between the retries? Then we minimize the time users have to wait who are actively developing and running just one test at a time.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41723?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I84553ae7aee19efa007bae060d7f7ca218a5f306
Gerrit-Change-Number: 41723
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 19 Dec 2025 09:49:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41724?usp=email )
Change subject: BSSAP_LE_Emulation: Support Tx RESET retries
......................................................................
Patch Set 1:
(1 comment)
File bsc/MSC_ConnectionHandler.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41724/comment/25242cdb_c9b3… :
PS1, Line 644: bssap_le_reset_retries := 1,
> maybe use 2 by default, so it is unlikely to fail for users?
ah I see in the next patch you are fixing it, "N retries means N+1 attempts."
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41724?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I475f93ff0b8cbfa5aa4900d02ddcb2e97fa5ca6a
Gerrit-Change-Number: 41724
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 19 Dec 2025 09:46:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41724?usp=email )
Change subject: BSSAP_LE_Emulation: Support Tx RESET retries
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File bsc/MSC_ConnectionHandler.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41724/comment/73db80d2_b9e5… :
PS1, Line 644: bssap_le_reset_retries := 1,
maybe use 2 by default, so it is unlikely to fail for users?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41724?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I475f93ff0b8cbfa5aa4900d02ddcb2e97fa5ca6a
Gerrit-Change-Number: 41724
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 19 Dec 2025 09:45:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41723?usp=email )
Change subject: RAN_Emulation: Support Tx RESET retries in RANAP
......................................................................
Patch Set 1:
(1 comment)
File library/RAN_Emulation.ttcnpp:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41723/comment/1ee2813d_b9bc… :
PS1, Line 821: [] as_reset_ack();
> > Otherwise we are not rescheduling the timer properly. […]
oh nvm, given that we make another retry only after 5s, then we do need to reschedule the timer. (it might make sense to wait less than 5s before retrying?)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41723?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I84553ae7aee19efa007bae060d7f7ca218a5f306
Gerrit-Change-Number: 41723
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 19 Dec 2025 09:41:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41723?usp=email )
Change subject: RAN_Emulation: Support Tx RESET retries in RANAP
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Patchset:
PS1:
Thanks for adding this, I ran into such reset errors because of no retries quite a lot!
File library/RAN_Emulation.ttcnpp:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41723/comment/0ce4fdb9_4fc9… :
PS1, Line 821: [] as_reset_ack();
> Otherwise we are not rescheduling the timer properly.
Not sure if this means rescheduling T (5s), but if yes, then it probably doesn't make sense to reschedule it? It seems to me that if the whole reset routine takes more than 5s, we should get an error instead of retrying.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41723?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I84553ae7aee19efa007bae060d7f7ca218a5f306
Gerrit-Change-Number: 41723
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 19 Dec 2025 09:31:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/41719?usp=email )
Change subject: ttcn3-bts-test/jenkins.sh: tweak local vars
......................................................................
ttcn3-bts-test/jenkins.sh: tweak local vars
Make it consistent.
Change-Id: I8c5597f20428f8f274ea15f62e561562e5768460
---
M ttcn3-bts-test/jenkins.sh
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
pespin: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh
index bfb92aa..49d5cf3 100755
--- a/ttcn3-bts-test/jenkins.sh
+++ b/ttcn3-bts-test/jenkins.sh
@@ -42,9 +42,9 @@
}
start_bts() {
- local variant
- variant="$1"
- sleep_time_respawn="$2"
+ local variant="$1"
+ local sleep_time_respawn="$2"
+
echo Starting container with BTS
if [ -z "$variant" ]; then
echo ERROR: You have to specify a BTS variant
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41719?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I8c5597f20428f8f274ea15f62e561562e5768460
Gerrit-Change-Number: 41719
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/41721?usp=email )
Change subject: common/respawn: improve logging
......................................................................
common/respawn: improve logging
Add "[$(date)] respawn:" infront of all log messages, so it is clear
that they come from this script and so we have timestamps that we can
compare. This will be useful when running the bpftrace scripts along
with osmo-bts-*, which will get restarted at the same time as the
osmo-bts-* processes.
Change-Id: I641f17f6988eced12c9b301042fb5c5cfd757511
---
M common/respawn.sh
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
diff --git a/common/respawn.sh b/common/respawn.sh
index d9bf641..1040408 100755
--- a/common/respawn.sh
+++ b/common/respawn.sh
@@ -7,15 +7,15 @@
i=0
max_i=500
while [ $i -lt $max_i ]; do
- echo "respawn: $i: starting: $*"
+ echo "[$(date)] respawn: $i: starting: $*"
$* &
LAST_PID=$!
wait $LAST_PID
- echo "$i: stopped pid $LAST_PID with status $?"
+ echo "[$(date)] respawn: $i: stopped pid $LAST_PID with status $?"
if [ $SLEEP_BEFORE_RESPAWN -gt 0 ]; then
- echo "sleeping $SLEEP_BEFORE_RESPAWN seconds..."
+ echo "[$(date)] respawn: sleeping $SLEEP_BEFORE_RESPAWN seconds..."
sleep $SLEEP_BEFORE_RESPAWN
fi
i=$(expr $i + 1)
done
-echo "exiting after $max_i runs"
+echo "[$(date)] respawn: exiting after $max_i runs"
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41721?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I641f17f6988eced12c9b301042fb5c5cfd757511
Gerrit-Change-Number: 41721
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>