lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

December 2025

  • 1 participants
  • 1175 discussions
[S] Change in osmo-ttcn3-hacks[master]: BSSAP_LE_Emulation: Support Tx RESET retries
by osmith 19 Dec '25

19 Dec '25
Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41724?usp=email ) Change subject: BSSAP_LE_Emulation: Support Tx RESET retries ...................................................................... Patch Set 1: (1 comment) File bsc/MSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41724/comment/25242cdb_c9b3… : PS1, Line 644: bssap_le_reset_retries := 1, > maybe use 2 by default, so it is unlikely to fail for users? ah I see in the next patch you are fixing it, "N retries means N+1 attempts." -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41724?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I475f93ff0b8cbfa5aa4900d02ddcb2e97fa5ca6a Gerrit-Change-Number: 41724 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Dec 2025 09:46:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: BSSAP_LE_Emulation: Support Tx RESET retries
by osmith 19 Dec '25

19 Dec '25
Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41724?usp=email ) Change subject: BSSAP_LE_Emulation: Support Tx RESET retries ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File bsc/MSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41724/comment/73db80d2_b9e5… : PS1, Line 644: bssap_le_reset_retries := 1, maybe use 2 by default, so it is unlikely to fail for users? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41724?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I475f93ff0b8cbfa5aa4900d02ddcb2e97fa5ca6a Gerrit-Change-Number: 41724 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Dec 2025 09:45:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: RAN_Emulation: Support Tx RESET retries in RANAP
by osmith 19 Dec '25

19 Dec '25
Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41723?usp=email ) Change subject: RAN_Emulation: Support Tx RESET retries in RANAP ...................................................................... Patch Set 1: (1 comment) File library/RAN_Emulation.ttcnpp: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41723/comment/1ee2813d_b9bc… : PS1, Line 821: [] as_reset_ack(); > > Otherwise we are not rescheduling the timer properly. […] oh nvm, given that we make another retry only after 5s, then we do need to reschedule the timer. (it might make sense to wait less than 5s before retrying?) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41723?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I84553ae7aee19efa007bae060d7f7ca218a5f306 Gerrit-Change-Number: 41723 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Dec 2025 09:41:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: RAN_Emulation: Support Tx RESET retries in RANAP
by osmith 19 Dec '25

19 Dec '25
Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41723?usp=email ) Change subject: RAN_Emulation: Support Tx RESET retries in RANAP ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Patchset: PS1: Thanks for adding this, I ran into such reset errors because of no retries quite a lot! File library/RAN_Emulation.ttcnpp: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41723/comment/0ce4fdb9_4fc9… : PS1, Line 821: [] as_reset_ack(); > Otherwise we are not rescheduling the timer properly. Not sure if this means rescheduling T (5s), but if yes, then it probably doesn't make sense to reschedule it? It seems to me that if the whole reset routine takes more than 5s, we should get an error instead of retrying. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41723?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I84553ae7aee19efa007bae060d7f7ca218a5f306 Gerrit-Change-Number: 41723 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Dec 2025 09:31:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[XS] Change in docker-playground[master]: common/respawn: improve logging
by osmith 19 Dec '25

19 Dec '25
osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/41721?usp=email ) Change subject: common/respawn: improve logging ...................................................................... common/respawn: improve logging Add "[$(date)] respawn:" infront of all log messages, so it is clear that they come from this script and so we have timestamps that we can compare. This will be useful when running the bpftrace scripts along with osmo-bts-*, which will get restarted at the same time as the osmo-bts-* processes. Change-Id: I641f17f6988eced12c9b301042fb5c5cfd757511 --- M common/respawn.sh 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/common/respawn.sh b/common/respawn.sh index d9bf641..1040408 100755 --- a/common/respawn.sh +++ b/common/respawn.sh @@ -7,15 +7,15 @@ i=0 max_i=500 while [ $i -lt $max_i ]; do - echo "respawn: $i: starting: $*" + echo "[$(date)] respawn: $i: starting: $*" $* & LAST_PID=$! wait $LAST_PID - echo "$i: stopped pid $LAST_PID with status $?" + echo "[$(date)] respawn: $i: stopped pid $LAST_PID with status $?" if [ $SLEEP_BEFORE_RESPAWN -gt 0 ]; then - echo "sleeping $SLEEP_BEFORE_RESPAWN seconds..." + echo "[$(date)] respawn: sleeping $SLEEP_BEFORE_RESPAWN seconds..." sleep $SLEEP_BEFORE_RESPAWN fi i=$(expr $i + 1) done -echo "exiting after $max_i runs" +echo "[$(date)] respawn: exiting after $max_i runs" -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41721?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I641f17f6988eced12c9b301042fb5c5cfd757511 Gerrit-Change-Number: 41721 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[M] Change in docker-playground[master]: ttcn3-bts-test: run bpftrace scripts
by osmith 19 Dec '25

19 Dec '25
osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/41720?usp=email ) Change subject: ttcn3-bts-test: run bpftrace scripts ...................................................................... ttcn3-bts-test: run bpftrace scripts Add logic to run bpftrace scripts attached to osmo-bts-* while the testsuite runs. The initial script is from Vadim: https://gitea.osmocom.org/osmocom/bpftrace-scripts/src/branch/master/udp_se… Change-Id: I5c22cdbb08fe797be936ca174f65ade626fa4895 --- M README.md M osmo-bts-latest/Dockerfile M osmo-bts-master/Dockerfile A ttcn3-bts-test/bpftrace/udp_sendmsg_delay.bt M ttcn3-bts-test/jenkins.sh 5 files changed, 82 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/README.md b/README.md index eeb9272..3f55e3e 100644 --- a/README.md +++ b/README.md @@ -39,6 +39,7 @@ * `TEST_CONFIGS`: for tests that can run with multiple config sets (e.g. `ttcn3-bts-test`), run only some of them. See `TEST_CONFIGS_ALL` in the `jenkins.sh` for possible values. +* `RUN_BPFTRACE`: when set to `1`, run bpftrace scripts in `ttcn3-bts-test`. ### Run only one test diff --git a/osmo-bts-latest/Dockerfile b/osmo-bts-latest/Dockerfile index ad79cb3..6449829 100644 --- a/osmo-bts-latest/Dockerfile +++ b/osmo-bts-latest/Dockerfile @@ -9,6 +9,7 @@ debian*) \ apt-get update && \ apt-get install -y --no-install-recommends \ + bpftrace \ osmo-bts-trx \ osmo-bts-virtual && \ apt-get clean \ diff --git a/osmo-bts-master/Dockerfile b/osmo-bts-master/Dockerfile index 2e1b628..e081471 100644 --- a/osmo-bts-master/Dockerfile +++ b/osmo-bts-master/Dockerfile @@ -8,6 +8,7 @@ debian*) \ apt-get update && \ apt-get install -y --no-install-recommends \ + bpftrace \ libosmocore-dev \ libosmo-abis-dev \ libosmo-netif-dev && \ diff --git a/ttcn3-bts-test/bpftrace/udp_sendmsg_delay.bt b/ttcn3-bts-test/bpftrace/udp_sendmsg_delay.bt new file mode 100644 index 0000000..8525413 --- /dev/null +++ b/ttcn3-bts-test/bpftrace/udp_sendmsg_delay.bt @@ -0,0 +1,42 @@ +#!/usr/bin/env bpftrace + +/* Script to obtain udp_sendmsg() latency histograms. + * It will measure time between entry and exit and plot one histogram + * for each destination port number, indicating the amount of time spent. + * + * Implemented 2025 by Vadim Yanitskiy <fixeria(a)osmocom.org> + * SPDX-License-Identifier: CC0 + * + * As no filtering on PID etc. is done, you will likely use this with 'bpftrace -p' like + * + * bpftrace ./udp_sendmsg_delay.bt -p PID + * + * (where PID is the PID of the process, like osmo-bts-trx) + */ + +BEGIN +{ + printf("Tracing udp_sendmsg() latency... Hit Ctrl-C to end.\n"); +} + +kprobe:udp_sendmsg +{ + $sk = (struct sock *)arg0; + /* poor man's ntohs() */ + $dport = ($sk->__sk_common.skc_dport & 0xff) << 8; + $dport |= ($sk->__sk_common.skc_dport >> 8) & 0xff; + + @start[tid] = nsecs; + @dport[tid] = $dport; +} + +kretprobe:udp_sendmsg / @start[tid] / +{ + $delta_us = (nsecs - @start[tid]) / 1000; + @latency[@dport[tid]] = hist($delta_us); + + delete(@start[tid]); + delete(@dport[tid]); +} + +/* vim:set ts=2 sw=2 et: */ diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index 49d5cf3..24a91a5 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -44,8 +44,17 @@ start_bts() { local variant="$1" local sleep_time_respawn="$2" + local extra_args="" echo Starting container with BTS + if [ "$RUN_BPFTRACE" = "1" ]; then + if ! mount | grep -q /sys/kernel/tracing; then + echo "ERROR: mount /sys/kernel/tracing first!" + echo "https://www.kernel.org/doc/html/latest/trace/ftrace.html#the-file-system" + exit 1 + fi + extra_args="--ulimit memlock=-1 --privileged" + fi if [ -z "$variant" ]; then echo ERROR: You have to specify a BTS variant exit 23 @@ -55,13 +64,41 @@ --cap-add=SYS_ADMIN \ --ulimit rtprio=99 \ --ulimit core=-1 \ + -v /sys/kernel/tracing:/sys/kernel/tracing \ -v $VOL_BASE_DIR/bts:/data \ -v $VOL_BASE_DIR/unix:/data/unix \ -e "SLEEP_BEFORE_RESPAWN=$sleep_time_respawn" \ --name ${BUILD_TAG}-bts -d \ $DOCKER_ARGS \ + $extra_args \ $REPO_USER/osmo-bts-$IMAGE_SUFFIX \ /bin/sh -c "/usr/local/bin/respawn.sh osmo-bts-$variant -c /data/osmo-bts.gen.cfg >>/data/osmo-bts.log 2>&1" + + # Run bpftrace scripts (OS#6794#note-16) + if [ "$RUN_BPFTRACE" = "1" ]; then + local script + mkdir -p "$VOL_BASE_DIR"/bts/bpftrace + for script in bpftrace/*.bt; do + if ! [ -e "$script" ]; then + # Avoid unexpected behavior when there are no scripts + continue + fi + + local logfile="$VOL_BASE_DIR"/bts/bpftrace/$(basename "$script" | sed s/\.bt/.log/) + local startscript="$VOL_BASE_DIR"/bts/bpftrace/$(basename "$script" | sed s/\.bt/.sh/) + + cp "$script" "$VOL_BASE_DIR"/bts/bpftrace + + ( echo "#!/bin/sh -ex" + echo "bpftrace /data/bpftrace/$(basename "$script") -p \$(pidof osmo-bts-$variant)" ) >"$startscript" + chmod +x "$startscript" + + docker exec \ + "${BUILD_TAG}-bts" \ + /usr/local/bin/respawn.sh /data/bpftrace/"$(basename "$startscript")" \ + >>"$logfile" 2>&1 & + done + fi } start_fake_trx() { -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41720?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5c22cdbb08fe797be936ca174f65ade626fa4895 Gerrit-Change-Number: 41720 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in docker-playground[master]: ttcn3-bts-test/jenkins.sh: tweak local vars
by osmith 19 Dec '25

19 Dec '25
osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/41719?usp=email ) Change subject: ttcn3-bts-test/jenkins.sh: tweak local vars ...................................................................... ttcn3-bts-test/jenkins.sh: tweak local vars Make it consistent. Change-Id: I8c5597f20428f8f274ea15f62e561562e5768460 --- M ttcn3-bts-test/jenkins.sh 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index bfb92aa..49d5cf3 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -42,9 +42,9 @@ } start_bts() { - local variant - variant="$1" - sleep_time_respawn="$2" + local variant="$1" + local sleep_time_respawn="$2" + echo Starting container with BTS if [ -z "$variant" ]; then echo ERROR: You have to specify a BTS variant -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41719?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8c5597f20428f8f274ea15f62e561562e5768460 Gerrit-Change-Number: 41719 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in meta-telephony[201705]: libosmocore: upgrade to 1.12.1
by osmith 19 Dec '25

19 Dec '25
Attention is currently required from: daniel, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/meta-telephony/+/41722?usp=email ) Change subject: libosmocore: upgrade to 1.12.1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/41722?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I0f07f52312739fc8c1dd985f1ccf6d379daed760 Gerrit-Change-Number: 41722 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Dec 2025 09:12:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in pysim[master]: pyshark_gsmtap: Adjust display filter for some wireshark versions
by fixeria 19 Dec '25

19 Dec '25
Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41712?usp=email ) Change subject: pyshark_gsmtap: Adjust display filter for some wireshark versions ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41712?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I53c1c8ed58a82c37cd4be4af3890af21da839e86 Gerrit-Change-Number: 41712 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Dec 2025 08:33:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in osmo-msc[master]: add vty setting for ThemWi RTP formats
by fixeria 19 Dec '25

19 Dec '25
Attention is currently required from: falconia, laforge, pespin. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-msc/+/41698?usp=email ) Change subject: add vty setting for ThemWi RTP formats ...................................................................... Patch Set 7: Code-Review+2 (1 comment) File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/c/osmo-msc/+/41698/comment/1bfa028d_d8220786?usp… : PS6, Line 689: #define TWCODEC_OPT " [(fr|hr|amr|csd)]" > Please see Patchset 7 - is it satisfactory now? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41698?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Icea152f5f2cdbcb0df09ef5b7211d1461b499f14 Gerrit-Change-Number: 41698 Gerrit-PatchSet: 7 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Dec 2025 08:33:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 20
  • 21
  • 22
  • 23
  • 24
  • 25
  • 26
  • ...
  • 118
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.