Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41713?usp=email ) Change subject: pysim/log: also accept ANSI strings to specify the log message colors ...................................................................... Patch Set 2: Code-Review-1 (1 comment) File pySim/log.py: https://gerrit.osmocom.org/c/pysim/+/41713/comment/549fa4f7_543a1d35?usp=ema... : PS1, Line 111: if type(color) is str:

Thanks for the hint. I haven't had that in mind. I believe Harald's suggestion was to do `isinstance(color, str)` instead of `type(color) is str`, but you are now doing both?

```

...

...

cmd2.Fg.RED <Fg.RED: 31> type(cmd2.Fg.RED) <enum 'Fg'> isinstance(cmd2.Fg.RED, str) False

This patch most likely breaks passing cmd2 color.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/41713?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I93543e19649064043ae8323f82ecd8c423d1d921
Gerrit-Change-Number: 41713
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: dexter <pmaier@sysmocom.de>
Gerrit-Comment-Date: Fri, 19 Dec 2025 14:16:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Comment-In-Reply-To: dexter <pmaier@sysmocom.de>