Attention is currently required from: dexter, laforge.

Patch set 2:Code-Review -1

View Change

1 comment:

• File pySim/log.py:

  • Patch Set #1, Line 111: if type(color) is str:

    Thanks for the hint. I haven't had that in mind.

    I believe Harald's suggestion was to do `isinstance(color, str)` instead of `type(color) is str`, but you are now doing both?

    ```
    >>> cmd2.Fg.RED
    <Fg.RED: 31>
    >>> type(cmd2.Fg.RED)
    <enum 'Fg'>
    >>> isinstance(cmd2.Fg.RED, str)
    False
    ```

    This patch most likely breaks passing cmd2 color.

To view, visit change 41713. To unsubscribe, or for help writing mail filters, visit settings.