falconia has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41726?usp=email ) Change subject: vty: rm misleading warnings about DTX on E1 BTS ...................................................................... vty: rm misleading warnings about DTX on E1 BTS Since the days of pre-split OpenBSC, whenever an operator would enable DTX (either UL or DL) in BSC vty on an E1 BTS, there was a warning message emitted, saying that this configuration is "neither supported nor tested". While those statements may have been correct in 2016 when that code was added (commit 6079528b), they are no longer correct in the present: both DTXu and DTXd work correctly now on E1 BTS that follow TS 48.060 or 48.061, with all 4 supported speech codecs: FR, HR, EFR and AMR. Full-featured, production-quality operation with E1 BTS requires use of tw-e1abis-mgw in the place of osmo-mgw - but even when legacy OsmoMGW-E1 is used, it is misleading to say that DTX is "neither supported nor tested", as the architectural shortcomings of OsmoMGW-E1 (lack of TFO transform for non-AMR codecs and lack of any support for AMR) are not specific to DTX per se. Change-Id: I63626b554d38b1ab094838374968e64193da1c11 --- M src/osmo-bsc/bts_vty.c 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index bbee866..d69fb1f 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -210,9 +210,6 @@ struct gsm_bts *bts = vty->index; bts->dtxu = (argc > 0) ? GSM48_DTX_SHALL_BE_USED : GSM48_DTX_MAY_BE_USED; - if (!is_ipa_abisip_bts(bts)) - vty_out(vty, "%% DTX enabled on non-IP BTS: this configuration " - "neither supported nor tested!%s", VTY_NEWLINE); return CMD_SUCCESS; } @@ -240,9 +237,6 @@ struct gsm_bts *bts = vty->index; bts->dtxd = true; - if (!is_ipa_abisip_bts(bts)) - vty_out(vty, "%% DTX enabled on non-IP BTS: this configuration " - "neither supported nor tested!%s", VTY_NEWLINE); return CMD_SUCCESS; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41726?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I63626b554d38b1ab094838374968e64193da1c11 Gerrit-Change-Number: 41726 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon@freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon@freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de>