November 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: gsm/gsm_utils: Support the ER-GSM band (ARFCN 940..954)
by osmith 03 Nov '25

03 Nov '25

Attention is currently required from: jolly, laforge. osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/41295?usp=email ) Change subject: gsm/gsm_utils: Support the ER-GSM band (ARFCN 940..954) ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41295?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2f17bca405403ee12cfe7c5c804c135ab021b369 Gerrit-Change-Number: 41295 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 03 Nov 2025 12:39:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: gsm/gsm_utils: Support the ER-GSM band (ARFCN 940..954)
by laforge 03 Nov '25

03 Nov '25

Attention is currently required from: jolly. Hello Jenkins Builder, jolly, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41295?usp=email to look at the new patch set (#3). Change subject: gsm/gsm_utils: Support the ER-GSM band (ARFCN 940..954) ...................................................................... gsm/gsm_utils: Support the ER-GSM band (ARFCN 940..954) So far we've supported R-GSM (ARFCN 955-974) and E-GSM (ARFCN 975..1023) but not yet the ER-GSM range (ARFCN 940..954) in the gsm_arfcn2freq10() and gsm_freq102arfcn() functions. This patch fixes this. Change-Id: I2f17bca405403ee12cfe7c5c804c135ab021b369 --- M src/gsm/gsm_utils.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/95/41295/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41295?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2f17bca405403ee12cfe7c5c804c135ab021b369 Gerrit-Change-Number: 41295 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu>

1 0

[XS] Change in libosmocore[master]: gsm/gsm_utils: Support the ER-GSM band (ARFCN 940..954)
by laforge 03 Nov '25

03 Nov '25

Attention is currently required from: jolly. Hello Jenkins Builder, jolly, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41295?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: gsm/gsm_utils: Support the ER-GSM band (ARFCN 940..954) ...................................................................... gsm/gsm_utils: Support the ER-GSM band (ARFCN 940..954) So far we've supported R-GSM (ARFCN 955-974) and E-GSM (ARFCN 975..1023) but not yet the ER-GSM range (ARFCN 940..954) in the gsm_arfcn2freq10() and gsm_freq102arfcn() functions. This patch fixes this. Change-Id: I2f17bca405403ee12cfe7c5c804c135ab021b369 --- M src/gsm/gsm_utils.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/95/41295/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41295?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2f17bca405403ee12cfe7c5c804c135ab021b369 Gerrit-Change-Number: 41295 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu>

1 0

[XS] Change in libosmocore[master]: gsm/gsm_utils: Support the ER-GSM band (ARFCN 940..954)
by laforge 03 Nov '25

03 Nov '25

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41295?usp=email ) Change subject: gsm/gsm_utils: Support the ER-GSM band (ARFCN 940..954) ...................................................................... gsm/gsm_utils: Support the ER-GSM band (ARFCN 940..954) So far we've supported R-GSM (ARFCN 955-974) and E-GSM (ARFCN 975..1023) but not yet the ER-GSM range (ARFCN 940..954) in the gsm_arfcn2freq10() and gsm_freq102arfcn() functions. This patch fixes this. Change-Id: I2f17bca405403ee12cfe7c5c804c135ab021b369 --- M src/gsm/gsm_utils.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/95/41295/1 diff --git a/src/gsm/gsm_utils.c b/src/gsm/gsm_utils.c index 64fbd63..15102b3 100644 --- a/src/gsm/gsm_utils.c +++ b/src/gsm/gsm_utils.c @@ -790,7 +790,7 @@ static struct gsm_freq_range gsm_ranges[] = { { 512, 810, 18502, 800, ARFCN_PCS }, /* PCS 1900 */ { 0, 124, 8900, 450, 0 }, /* P-GSM + E-GSM ARFCN 0 */ - { 955, 1023, 8762, 450, 0 }, /* E-GSM + R-GSM */ + { 940, 1023, 8732, 450, 0 }, /* E-GSM + R-GSM + ER-GSM */ { 128, 251, 8242, 450, 0 }, /* GSM 850 */ { 512, 885, 17102, 950, 0 }, /* DCS 1800 */ { 259, 293, 4506, 100, 0 }, /* GSM 450 */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41295?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2f17bca405403ee12cfe7c5c804c135ab021b369 Gerrit-Change-Number: 41295 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in libosmocore[master]: Correctly calculate size iofd_msgb_alloc2()
by laforge 03 Nov '25

03 Nov '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41138?usp=email ) Change subject: Correctly calculate size iofd_msgb_alloc2() ...................................................................... Correctly calculate size iofd_msgb_alloc2() The storage size of 'headroom' must be larger than 16 bits. Otherwise a value above 65535 cannot be stored correctly and cause wrong calculation of msgb size. Related: Coverity CID#548925 Change-Id: I16c1e08fb64a1fafaeee1844fd8c00ecc2861d12 --- M src/core/osmo_io.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index 399a604..10e6e3f 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -187,10 +187,10 @@ /*! convenience wrapper to call msgb_alloc with parameters from osmo_io_fd (of given size) */ struct msgb *iofd_msgb_alloc2(struct osmo_io_fd *iofd, size_t size) { - uint16_t headroom = iofd->msgb_alloc.headroom; + size_t headroom = iofd->msgb_alloc.headroom; - OSMO_ASSERT(size <= 0xffff - headroom); - return msgb_alloc_headroom_c(iofd, size + headroom, headroom, "osmo_io_msgb"); + OSMO_ASSERT(size + headroom <= 0xffff); + return msgb_alloc_headroom_c(iofd, (uint16_t)(size + headroom), (uint16_t)headroom, "osmo_io_msgb"); } /*! convenience wrapper to call msgb_alloc with parameters from osmo_io_fd */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41138?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I16c1e08fb64a1fafaeee1844fd8c00ecc2861d12 Gerrit-Change-Number: 41138 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: library: TCAP: add tr_TCAP_N_NOTICE_ind
by laforge 03 Nov '25

03 Nov '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41292?usp=email ) Change subject: library: TCAP: add tr_TCAP_N_NOTICE_ind ...................................................................... library: TCAP: add tr_TCAP_N_NOTICE_ind A SCCP UTDS will be passed to the TCAP layer as TCAP_N_NOTICE_ind. Will be used by utds testsing of tcap loadsharing. Related: SYS#5423 Change-Id: I002afabb8e827dc35cd9f4e37a6970d91600ee37 --- M library/tcap/TCAP_CodecPort.ttcn 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/library/tcap/TCAP_CodecPort.ttcn b/library/tcap/TCAP_CodecPort.ttcn index 882a288..cb52814 100644 --- a/library/tcap/TCAP_CodecPort.ttcn +++ b/library/tcap/TCAP_CodecPort.ttcn @@ -230,6 +230,16 @@ SCCP_PAR_Importance importance optional } +template (present) TCAP_N_NOTICE_ind tr_TCAP_N_NOTICE_ind(template SCCP_PAR_Address called, + template SCCP_PAR_Address calling, + template SCCP_PAR_Reason_For_Return reason, + template TCMessage payload) := { + calledAddress := called, + callingAddress := calling, + reasonForReturn := reason, + userData := payload, + importance := * +} private function f_dec_ConnectInd(in ASP_SCCP_N_CONNECT_ind pin, out TCAP_N_CONNECT_ind pout) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41292?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I002afabb8e827dc35cd9f4e37a6970d91600ee37 Gerrit-Change-Number: 41292 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: library: TCAP: ts_TCAP_UNITDATA_req: allow to define the returnOption
by laforge 03 Nov '25

03 Nov '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41291?usp=email ) Change subject: library: TCAP: ts_TCAP_UNITDATA_req: allow to define the returnOption ...................................................................... library: TCAP: ts_TCAP_UNITDATA_req: allow to define the returnOption TCAP loadsharing will use RETURN_OPTION_ON_ERROR option to test UDTS when no TCAP ranges matches. Related: SYS#5423 Change-Id: Ie4f6d9e02f65687c3158cae41f28aa30b95f85f8 --- M library/tcap/TCAP_CodecPort.ttcn 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/tcap/TCAP_CodecPort.ttcn b/library/tcap/TCAP_CodecPort.ttcn index 50b0eed..882a288 100644 --- a/library/tcap/TCAP_CodecPort.ttcn +++ b/library/tcap/TCAP_CodecPort.ttcn @@ -20,6 +20,9 @@ import from TCAPMessages language "ASN.1:1997" all; import from TCAP_Types all; +const BIT8n RETURN_OPTION_DISCARD := '00000000'B; +const BIT8n RETURN_OPTION_ON_ERROR := '00000001'B; + type record TCAP_N_CONNECT_req { SCCP_PAR_Address calledAddress, @@ -187,11 +190,12 @@ template (value) TCAP_N_UNITDATA_req ts_TCAP_UNITDATA_req(SCCP_PAR_Address called, SCCP_PAR_Address calling, - template (value) TCMessage payload) := { + template (value) TCMessage payload, + template (omit) SCCP_PAR_Return_Option returns := omit) := { calledAddress := called, callingAddress := calling, sequenceControl := omit, - returnOption := omit, + returnOption := returns, userData := payload, importance := omit } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41291?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie4f6d9e02f65687c3158cae41f28aa30b95f85f8 Gerrit-Change-Number: 41291 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XL] Change in osmo-ttcn3-hacks[master]: stp: Introduce STP_Tests_TCAP
by laforge 03 Nov '25

03 Nov '25

Attention is currently required from: fixeria, lynxis lazus. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136?usp=email ) Change subject: stp: Introduce STP_Tests_TCAP ...................................................................... Patch Set 6: -Code-Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4340bdf126118c66af861f5a447e90883783920e Gerrit-Change-Number: 41136 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 03 Nov 2025 10:34:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in osmo-ttcn3-hacks[master]: stp: Introduce STP_Tests_TCAP
by pespin 03 Nov '25

03 Nov '25

Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: stp: Introduce STP_Tests_TCAP ...................................................................... Patch Set 6: Code-Review-2 (1 comment) File stp/expected-results.xml: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136/comment/d407f0d1_8233… : PS6, Line 75: <testcase classname='STP_Tests_TCAP' name='TC_tcap_loadshare_ipa_tcap_range_fail_overlap' time='MASKED'/> : <testcase classname='STP_Tests_TCAP' name='TC_tcap_loadshare_ipa_tcap_range_fail_overlap' time='MASKED'/> : <testcase classname='STP_Tests_TCAP' name='TC_tcap_loadshare_ipa_tcap_range_fail_overlap' time='MASKED'/> : > Ok, I see you're executing the same testcase with different parameters. […] This should IMHO be fixed, ie we shouldn't have a test being run multiple times with the same name. It will make it more difficult to figure out which one failed, etc. We always have 1 specific naming for one specific testcase everywhere. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4340bdf126118c66af861f5a447e90883783920e Gerrit-Change-Number: 41136 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 03 Nov 2025 00:20:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XL] Change in osmo-ttcn3-hacks[master]: stp: Introduce STP_Tests_TCAP
by fixeria 02 Nov '25

02 Nov '25

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136?usp=email ) Change subject: stp: Introduce STP_Tests_TCAP ...................................................................... Patch Set 6: (2 comments) File stp/STP_Tests_TCAP.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136/comment/5d20c3c7_a836… : PS6, Line 48: import from STP_Tests_Common all; duplicate (already imported above) File stp/expected-results.xml: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136/comment/7f9e30d9_9e70… : PS6, Line 75: <testcase classname='STP_Tests_TCAP' name='TC_tcap_loadshare_ipa_tcap_range_fail_overlap' time='MASKED'/> : <testcase classname='STP_Tests_TCAP' name='TC_tcap_loadshare_ipa_tcap_range_fail_overlap' time='MASKED'/> : <testcase classname='STP_Tests_TCAP' name='TC_tcap_loadshare_ipa_tcap_range_fail_overlap' time='MASKED'/> : > copy-pasted Ok, I see you're executing the same testcase with different parameters. Not critical, but I think it does not make sense to have duplicate entries here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4340bdf126118c66af861f5a447e90883783920e Gerrit-Change-Number: 41136 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 02 Nov 2025 18:49:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2025

2024

2023

2022

gerrit-log November 2025