November 2025 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-asn1-tcap[master]: add RPM spec file
by pespin 10 Nov '25

10 Nov '25

Attention is currently required from: lynxis lazus, osmith. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41389?usp=email ) Change subject: add RPM spec file ...................................................................... Patch Set 1: (1 comment) File configure.ac: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41389/comment/5669dbec_980… : PS1, Line 72: contrib/libosmo-netif.spec wrong? -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41389?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I579e5809de88ac41f199056a2369e50c27496ac7 Gerrit-Change-Number: 41389 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 10 Nov 2025 12:04:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in libosmo-sigtran[master]: Add VTY command to list TCAP ranges for an AS
by pespin 10 Nov '25

10 Nov '25

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311?usp=email ) Change subject: Add VTY command to list TCAP ranges for an AS ...................................................................... Patch Set 8: (5 comments) File src/Makefile.am: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311/comment/913e2a1d_aa0a2… : PS8, Line 13: ss7_as_loadshare_tcap_vty.h \ tcap_loadshare_vty.{c,h}? This should also be inside a "if BUILD_WITH_TCAP_LOADSHARING" btw. File src/ss7_as_loadshare_tcap_vty.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311/comment/fbc233d7_e8b62… : PS8, Line 6: #ifdef WITH_TCAP_LOADSHARING Drop this, simply only include the header when ifdef BUILD_WITH_TCAP_LOADSHARING File src/ss7_as_loadshare_tcap_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311/comment/e542e0ed_17f62… : PS8, Line 50: "show cs7 instance <0-15> as tcap-ranges name AS_NAME", are we using the same ordering in other vty command? looks weird ot have "as", then "tcap-ranges" and finalyl the "name AS_NAME" referring to the "as" at the start... "show cs7 instance <0-15> tcap-ranges as name AS_NAME" look a lot more ordered to me. File src/ss7_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311/comment/8c03befd_06402… : PS8, Line 42: #include "ss7_as_loadshare_tcap_vty.h" ifdef https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311/comment/eb2573d9_50e45… : PS8, Line 1487: ss7_tcap_vty_init(); ifdef -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8026248d9897aadab5bf13a425269ec1e948dfdf Gerrit-Change-Number: 41311 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 10 Nov 2025 12:03:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmo-sigtran[master]: Add rate counters for loadshare-tcap
by pespin 10 Nov '25

10 Nov '25

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41310?usp=email ) Change subject: Add rate counters for loadshare-tcap ...................................................................... Patch Set 8: (2 comments) File src/ss7_as.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41310/comment/1d8cd378_b629d… : PS8, Line 65: SS7_AS_CTR_RX_TCAP_DECODED, ifdef File src/ss7_as.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41310/comment/3153e28b_7c0e5… : PS8, Line 99: [SS7_AS_CTR_RX_TCAP_DECODED] = { "tcap:decoded", "Number of TCAP-messages decoded successfully (loadshare-tcap)" }, ifdef -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41310?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id67704991feacf54e3123f76e9506dd323b2498b Gerrit-Change-Number: 41310 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 10 Nov 2025 11:58:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in libosmo-sigtran[master]: Add TCAP based loadsharing/routing
by pespin 10 Nov '25

10 Nov '25

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email ) Change subject: Add TCAP based loadsharing/routing ...................................................................... Patch Set 8: Code-Review-1 (50 comments) Patchset: PS8: I'd prefer having src/ss7_as_loadshare_tcap.{c,h} renamed to have a "tcap_" prefix at the start, eg. "tcap_loadshare.c", to have all tcap files together. Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/5466b547_98832… : PS8, Line 13: This TCAP session tracking is similar to IP connection tracking. I guess you mean TCP connection here? File examples/sccp_demo_user.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/4669b36e_046ad… : PS8, Line 30: void *talloc_asn1_ctx; why is this added? File src/ipa.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/288b4d18_84434… : PS8, Line 51: #include "ss7_as_loadshare_tcap.h" #ifdef WITH_TCAP_LOADSHARING https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/7f375404_c2cf6… : PS8, Line 315: /* update TCAP Transaction Tracking (Rx) */ #ifdef WITH_TCAP_LOADSHARING https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/7a2acee7_1fa70… : PS8, Line 316: ss7_asp_tcap_rx_sccp(as, asp, opc, dpc, msg); This function naming is a bit misleading since it's not even known whether there's TCAP in the msg... https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/c23f9387_9807a… : PS8, Line 360: case IPAC_PROTO_OSMO: #ifdef WITH_TCAP_LOADSHARING https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/364ade8c_25d56… : PS8, Line 368: if (hh_ext->proto == IPAC_PROTO_EXT_TCAP_ROUTING) { (probably a switch case here will turn out cleaner together with the ifdef.) File src/m3ua.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/fc0b3dde_fe434… : PS8, Line 50: #include "ss7_as_loadshare_tcap.h" #ifdef WITH_TCAP_LOADSHARINGActually, I don't see this header being used in this file. Please have a look... https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/5ef17596_178eb… : PS8, Line 343: if (!xua) This looks unrelated to this commit? Seems you want to add another commit describing this. File src/ss7_as.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/4e180de7_8a715… : PS8, Line 6: #include <osmocom/core/hashtable.h> #ifdef WITH_TCAP_LOADSHARING https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/2aec4c38_576e3… : PS8, Line 97: /* optimisation: true if tid_ranges contains PCs (not only wildcards) */ #ifdef WITH_TCAP_LOADSHARING https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/a58f0372_d4b76… : PS8, Line 145: /* Should we do load-sharing based on tcap ids? */ #ifdef WITH_TCAP_LOADSHARING File src/ss7_as.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/b16d090f_7d4f9… : PS8, Line 40: #include "ss7_as_loadshare_tcap.h" #ifdef WITH_TCAP_LOADSHARING https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/0bd39052_96eaf… : PS8, Line 139: hash_init(as->tcap.tid_ranges); #ifdef WITH_TCAP_LOADSHARING https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/3ee7de6e_d1a71… : PS8, Line 227: tcap_asp_down(asp); I'm not sure this really belongs here. This function (osmo_ss7_as_del_asp) is to unassign a ASP from an AS, not related to an ASP going down. It's more an administrative configuration than a state change. So either change the function name most probably, or move it somewhere else. And ofc #ifdef WITH_TCAP_LOADSHARING. https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/fa007d58_5f294… : PS8, Line 246: tcap_disable(as); #ifdef WITH_TCAP_LOADSHARING https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/6fe9a695_f0204… : PS8, Line 545: case OSMO_SS7_AS_TMOD_LOADSHARE: #ifdef WITH_TCAP_LOADSHARING we definetly not want to hit this path for 99% of users every time a packet is being routed... https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/930ce3fc_6a579… : PS8, Line 634: extra line not needed. File src/ss7_as_loadshare_tcap.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/e0972887_f8939… : PS8, Line 3: #include <complex.h> I wonder why do we need this here... https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/3b36ee96_ee2e9… : PS8, Line 14: #ifdef WITH_TCAP_LOADSHARING YOu can remove this, simply don't even include it if not requested by configure... File src/ss7_as_loadshare_tcap.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/327be0b0_8aec9… : PS8, Line 61: return osmo_ntohl(*(uint32_t *)src->buf); is this always properly aligned? maybe use osmo_load_32be or however it's called? https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/8e582474_9cfab… : PS8, Line 72: tcapmsg = talloc_zero(as, struct TCAP_TCMessage); Can we avoid talloc-allocating a new chunk for every message? Simply "struct TCAP_TCMessage tcapmsg = {0};" should probably work? If a talloc context is needed, then probably keeping it as a static variable and allocating it once is enough. https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/3d5ac30f_dcb8c… : PS8, Line 138: ssn ^= ((pc >> 24) & 0xff); A point code is 13 bits in ITU iirc, you seem to be dropping 5 bits here. Is this expected? https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/b27aa519_90a51… : PS8, Line 159: static struct osmo_ss7_asp *tcap_hlist_get(struct osmo_ss7_as *as, uint32_t pc, uint8_t ssn, uint32_t tid) const as? https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/d1b111de_c4428… : PS8, Line 273: /** Traffic from the TCAP ASP -> AS -> osmo-stp, only used to update transaction tracking I wonder whether this step is mandatory or should be enabled depending on setup? https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/1ec3f764_9c8a0… : PS8, Line 316: /* TCAP transaction tracking requires point codes */ In theory at some point in the future we can do this also translating from GT to PC afaiu. https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/d8c3a975_7fc4b… : PS8, Line 379: /* FIXME: use UTDS */ This needs to be fixed? https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/cb9b2fd5_78615… : PS8, Line 380: static int sent_back_utds(struct osmo_ss7_as *as, Please add a description for this function, I'm not getting what's its purpose. https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/3125ceba_07bdf… : PS8, Line 473: * \return return is not described. https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/428f89d8_eab42… : PS8, Line 475: static int asp_loadshare_tcap_sccp(struct osmo_ss7_asp **rasp, struct osmo_ss7_as *as, uint32_t opc, uint32_t dpc, imho the EPROTONOSUPPORT should be dropped, and return rasp instead. https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/fec7012f_f0a9a… : PS8, Line 487: /* decode SCCP and convert to a SUA/xUA representation */ I think you have similar code logic in one of the above functions, you may want to see if it makes sense to add a helper function to do all checks and fill data. https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/60f7493c_f5914… : PS8, Line 560: sent_back_utds(as, xua, sua, SCCP_RETURN_CAUSE_SUBSYSTEM_FAILURE); You may want to look at whether it makes more sense to send a routing failure: "sccp_rout_fail_enqueue(inst, xua, SCCP_RETURN_CAUSE_MTP_FAILURE, xua->hdr.msg_class == SUA_MSGC_CO);" https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/3b20b16a_02afe… : PS8, Line 607: * @return 0 on success EPROTONOSUPPORT is not documented here. In case, I'd drop EPROTONOSUPPORT and return asp instead. https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/2043cd0b_7b95e… : PS8, Line 752: LOGPASP(asp, DLSS7, LOGL_ERROR, "TCAP routing message is too small\n"); I think we really want to add a new log category "TCAP" here. https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/283d18cb_a977a… : PS8, Line 921: /** Called when the ASP is going down or free'd Then you are currently calling it fromthe wrong place apparently. File src/ss7_as_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/218178ec_7c44d… : PS8, Line 39: #include "ss7_as_loadshare_tcap.h" #ifdef WITH_TCAP_LOADSHARING https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/10e26bb1_36d73… : PS8, Line 158: tcap_disable(as); #ifdef WITH_TCAP_LOADSHARING https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/3d196d11_0484e… : PS8, Line 165: "traffic-mode (loadshare|loadshare-tcap) [bindings] [sls] [opc-sls] [opc-shift] [<0-2>]", IMHO loadshare-tcap feature should have a separate command to enable/disable it. Leave alone the traffic-mode loadshare one, is already complex enough. Otherwise you are mixing concepts in different protocol layers. Eg: "[no] tcap-loadshare" Then, drop all the tcap_disable/enable() from all "traffic-mode" commands. File src/ss7_asp.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/e722613c_eacce… : PS8, Line 96: bool enabled; is this really needed? Does it make sense to have tcap loadsharing enabled in only some ASPs of the AS? I doubt so. File src/ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/0f7958cc_99510… : PS8, Line 53: #include "ss7_as_loadshare_tcap.h" #ifdef WITH_TCAP_LOADSHARING https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/4f900a11_d2a36… : PS8, Line 1216: tcap_asp_down(asp); nooo way you are calling this here. Put it where it belongs in the FSM. https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/64863fbc_c5846… : PS8, Line 1344: tcap_asp_down(asp); nooo way you are calling this here. Put it where it belongs in the FSM https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/fe6a2bb9_8dddf… : PS8, Line 1435: /*! Received an unknown packet on asp Unrelated to this commit, please submit another one. File src/ss7_internal.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/23fe8af9_75c77… : PS8, Line 9: #include <osmocom/sigtran/mtp_sap.h> why is this now needed here? if needed, please submit another commit. File src/tcap_transaction_tracking.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/2e560cc7_c465a… : PS8, Line 36: struct tcap_trxn_track_entry *tcap_trxn_track_create_entry( We usually have the struct name and then the action, ie. tcap_trxn_track_entry_create() Same applies for all the other APIs. File src/tcap_transaction_tracking.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/6fcfc093_e8bd2… : PS8, Line 122: LOGPASP(entry->asp, DLSS7, LOGL_DEBUG, "Creating tcap cache, entry (own) pc/ssn/tid %u/%u/%u -> %u/%u/%u\n", we always want to log PC in both numeric and configured format. See osmo_ss7_pointcode_print_buf(). https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/d88f79ec_58c02… : PS8, Line 141: if (entry->own_tid.tid_valid) You can probably simplify this strcut removing these "valid" fields by initializing entry->own_tid.list and then checking if it is empty. File src/xua_as_fsm.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/d78c708a_8df17… : PS8, Line 204: asp = ss7_as_select_asp(as, xua); This could actually go in a preparatory patch to simplify this one a bit. File stp/stp_main.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/13b34653_b21f4… : PS8, Line 52: void *talloc_asn1_ctx; Why is this needed? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d Gerrit-Change-Number: 41309 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 10 Nov 2025 11:56:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ci[master]: jobs: libosmo-sigtran: add support for TCAP loadsharing
by fixeria 10 Nov '25

10 Nov '25

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ci/+/41388?usp=email ) Change subject: jobs: libosmo-sigtran: add support for TCAP loadsharing ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41388?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I47c193d8f5ce695fdc6c368eee94d21c5a4b2c6e Gerrit-Change-Number: 41388 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 10 Nov 2025 11:45:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in docker-playground[master]: osmo-stp: add support for tcap-loadsharing
by fixeria 10 Nov '25

10 Nov '25

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/docker-playground/+/41390?usp=email ) Change subject: osmo-stp: add support for tcap-loadsharing ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/docker-playground/+/41390/comment/d098940d_581… : PS1, Line 10: Only build it when running debian. Is this really the case? I see you're also adding a dependency to `dnf install ...`. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41390?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib58f07d28a38109b4dd053479ddbdb1937eda64e Gerrit-Change-Number: 41390 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 10 Nov 2025 11:37:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-dev[master]: gen_makefile: python: run build in venv too
by fixeria 10 Nov '25

10 Nov '25

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/41391?usp=email ) Change subject: gen_makefile: python: run build in venv too ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-dev/+/41391/comment/d9912b35_86b2d10e?usp… : PS1, Line 14: older setuptools versions Older than what version? Maybe add a minimum version to `python-venv-requirements.txt`? -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/41391?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Idbd826d65267c05dcf2d82f7429d53a52686d737 Gerrit-Change-Number: 41391 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Nov 2025 11:34:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: Add test for tcap decoding/encoding
by fixeria 10 Nov '25

10 Nov '25

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41308?usp=email ) Change subject: Add test for tcap decoding/encoding ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: > I don't see the point in having this here (polluting osmo-stp with more unnecessary tcap code) which […] Agreeing with Pau. Unit tests for TCAP codec should be in libosmo-asn1-tcap.git. Otherwise, one can submit a breaking change without even noticing because we don't seem to have any tests there... -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41308?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8a0dbfaaa7182a5a72b279908be09e3adab254a2 Gerrit-Change-Number: 41308 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 10 Nov 2025 11:30:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: build-system: depend on libosmo-asn1-tcap
by fixeria 10 Nov '25

10 Nov '25

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41307?usp=email ) Change subject: build-system: depend on libosmo-asn1-tcap ...................................................................... Patch Set 4: (1 comment) File libosmo-sigtran.pc.in: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41307/comment/56c6c044_bd6f0… : PS4, Line 11: Requires.private: libosmo-netif libosmocore @LIBSCTP_PC@ > Please put it at the start following the dependency order. BTW, why adding `@LIBSCTP_PC@` and not `libosmo-asn1-tcap` here? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41307?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ib485f786217166635377f931ab894e43a0680634 Gerrit-Change-Number: 41307 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 10 Nov 2025 11:28:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: build-system: depend on libosmo-asn1-tcap
by pespin 10 Nov '25

10 Nov '25

Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41307?usp=email ) Change subject: build-system: depend on libosmo-asn1-tcap ...................................................................... Patch Set 4: (1 comment) File libosmo-sigtran.pc.in: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41307/comment/d6552f7c_70e3a… : PS4, Line 11: Requires.private: libosmo-netif libosmocore @LIBSCTP_PC@ Please put it at the start following the dependency order. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41307?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ib485f786217166635377f931ab894e43a0680634 Gerrit-Change-Number: 41307 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 10 Nov 2025 10:55:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log November 2025