Attention is currently required from: fixeria, jolly, laforge.
pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41360?usp=email )
Change subject: mobile app: Indicate ER-GSM band support in MS classmark 3
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41360?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ica13814eddb5293c7d7a2a21dd6a7a437cd1d351
Gerrit-Change-Number: 41360
Gerrit-PatchSet: 5
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 10 Nov 2025 13:35:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria, jolly, laforge.
pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email )
Change subject: Add ER-GSM band support to all relevant applications
......................................................................
Patch Set 4:
(1 comment)
File src/host/layer23/src/common/sysinfo.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/41359/comment/cfb921e7_5417f943?u… :
PS3, Line 406: return gsm48_decode_freq_list(f, cd, len, mask, frqt);
> sounds like libosmocore will require support for eg_gsm in this API?
Just to be sure, did you make sure this API in libosmocore.git master as well as osmocom-bb copy is now supporting the new frequencies?
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I71baa3317df685cf6479b6e20e6ae078911aa24f
Gerrit-Change-Number: 41359
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 10 Nov 2025 13:35:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: jolly.
pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41392?usp=email )
Change subject: gsm/gsm_utils: Support the ER-GSM band (ARFCN 940..954)
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41392?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I2fbddc523e72c6d6134e8a9d8132ad58266ce0db
Gerrit-Change-Number: 41392
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Mon, 10 Nov 2025 13:32:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria, laforge, pespin.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41360?usp=email )
Change subject: mobile app: Indicate ER-GSM band support in MS classmark 3
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmocom-bb/+/41360/comment/4ad0fdb9_58c9dbaa?u… :
PS4, Line 7: Indicate ER-GSM band support in MS classmark 3
> Acknowledged
Done
File src/host/layer23/src/mobile/gsm48_rr.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/41360/comment/e8c9da87_b07b2b14?u… :
PS4, Line 1442: // FIXME: Add setting for the following features
> These bits are not relevant in the context of ER-GSM, they just need to be in the bitmask. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41360?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ica13814eddb5293c7d7a2a21dd6a7a437cd1d351
Gerrit-Change-Number: 41360
Gerrit-PatchSet: 5
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 10 Nov 2025 13:31:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria, laforge, pespin.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41358?usp=email )
Change subject: RSSI app: Use correct BSIC for RACH bursts
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmocom-bb/+/41358/comment/6c54da03_341b6f17?u… :
PS1, Line 10: does not override the BSIC with a wrong value.
> what does "uic" mean here?
Done
https://gerrit.osmocom.org/c/osmocom-bb/+/41358/comment/a6d21cb5_d6b291cb?u… :
PS1, Line 12: Change-Id: I63ed20160d9d45cbc3f70cec8b1c0af262fdde19
> Please add `Fixes: 23d46f003 ("ASCI: Add UIC support to random access burst")` here. […]
Done
File src/target/firmware/apps/rssi/main.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/41358/comment/1a8b544f_5ffe94d4?u… :
PS1, Line 1212: rach_req->uic = 0xff;
> Probably makes sense to add a comment: /* Invalid UIC, so that BSIC is used */
Done
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41358?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I63ed20160d9d45cbc3f70cec8b1c0af262fdde19
Gerrit-Change-Number: 41358
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 10 Nov 2025 13:31:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, laforge, pespin.
Hello Jenkins Builder, fixeria, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bsc/+/41361?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Verified+1 by Jenkins Builder
Change subject: Add ER-GSM band support
......................................................................
Add ER-GSM band support
ER-GSM band expands the R-GSM band by additional 15 channels, starting
from channel 940.
Change-Id: I0a9a2f64d9db65967699453c26ae282c4ddf4558
---
M src/osmo-bsc/bts.c
M src/osmo-bsc/system_information.c
2 files changed, 12 insertions(+), 11 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/61/41361/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41361?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I0a9a2f64d9db65967699453c26ae282c4ddf4558
Gerrit-Change-Number: 41361
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, pespin.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41361?usp=email )
Change subject: Add ER-GSM band support
......................................................................
Patch Set 1:
(2 comments)
File src/osmo-bsc/system_information.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/41361/comment/710e1cbf_620ea62c?usp… :
PS1, Line 548: /* Check presence of R-GSM / E-GSM ARFCNs 940..1023 */
> (E)R-GSM
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/41361/comment/54e8754e_6bcb3a8d?usp… :
PS1, Line 583: if (i >= 940 && min < 940)
> Not mandatory, but sounds like we may want to have all 940 hardcoded in this function into some "con […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41361?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I0a9a2f64d9db65967699453c26ae282c4ddf4558
Gerrit-Change-Number: 41361
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 10 Nov 2025 13:30:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>