osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/41391?usp=email )
Change subject: gen_makefile: python: run build in venv too
......................................................................
gen_makefile: python: run build in venv too
The format of the license field in pyproject.toml was changed from a
"table" to a a string with an SPDX license expression. The pyosmocom
sources have been adjusted to use the new format to appease a warning
("By 2026-Feb-18, you need to update your project and remove deprecated
calls or your builds will no longer be supported."). However now the
build fails with older setuptools versions.
Run the build of python packages in the venv too, to ensure we have a
recent setuptools version.
Related: pyosmocom I8416234ea02f337fabd075cc345af964c1b71adf
Related: osmo-ci Ia8ef3a0301aeaad4691c197ed780e86b497def4a
Related: https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#licen…
Change-Id: Idbd826d65267c05dcf2d82f7429d53a52686d737
---
M gen_makefile.py
M python-venv-requirements.txt
2 files changed, 6 insertions(+), 1 deletion(-)
Approvals:
osmith: Looks good to me, approved
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
diff --git a/gen_makefile.py b/gen_makefile.py
index cfc681b..4ee5290 100755
--- a/gen_makefile.py
+++ b/gen_makefile.py
@@ -435,7 +435,7 @@
.make.{proj}.build: .make.{proj}.configure .make.{proj}.clone $({proj}_files)
@echo "\\n\\n\\n===== $@\\n"
rm -f {build_proj}/*.whl
- python3 \
+ {gen_venv_activate()} && python3 \
-m build \
--no-isolation \
{src_proj} \
diff --git a/python-venv-requirements.txt b/python-venv-requirements.txt
index 2f5ab59..2e8bb5d 100644
--- a/python-venv-requirements.txt
+++ b/python-venv-requirements.txt
@@ -21,3 +21,8 @@
redis==5.0.0
tzlocal==4.3
xmltodict==0.14.2
+
+setuptools>=77.0.0
+build
+poetry
+wheel
--
To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/41391?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-Change-Id: Idbd826d65267c05dcf2d82f7429d53a52686d737
Gerrit-Change-Number: 41391
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/41391?usp=email )
Change subject: gen_makefile: python: run build in venv too
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/41391?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-Change-Id: Idbd826d65267c05dcf2d82f7429d53a52686d737
Gerrit-Change-Number: 41391
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 11 Nov 2025 08:45:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: daniel, fixeria, pespin.
Hello Jenkins Builder, fixeria, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41394?usp=email
to look at the new patch set (#3).
Change subject: Add test to ensure parsing works
......................................................................
Add test to ensure parsing works
Related: SYS#5423
Change-Id: I475afbb6145404934b0838f9b418c105bf65dca0
---
M Makefile.am
M configure.ac
A tests/Makefile.am
A tests/parse/Makefile.am
A tests/parse/tcap_parse_test.c
A tests/parse/tcap_parse_test.ok
A tests/testsuite.at
7 files changed, 136 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-asn1-tcap refs/changes/94/41394/3
--
To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41394?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: I475afbb6145404934b0838f9b418c105bf65dca0
Gerrit-Change-Number: 41394
Gerrit-PatchSet: 3
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Attention is currently required from: daniel, fixeria, pespin.
Jenkins Builder has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41394?usp=email )
Change subject: Add test to ensure parsing works
......................................................................
Patch Set 2:
(1 comment)
File tests/parse/tcap_parse_test.c:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41394/comment/1c44c09e_e48… :
PS2, Line 38: if (rc.code != RC_OK) {
braces {} are not necessary for single statement blocks
--
To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41394?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: I475afbb6145404934b0838f9b418c105bf65dca0
Gerrit-Change-Number: 41394
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 11 Nov 2025 08:42:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: daniel, fixeria, pespin.
Hello Jenkins Builder, fixeria, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41394?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Add test to ensure parsing works
......................................................................
Add test to ensure parsing works
Related: SYS#5423
Change-Id: I475afbb6145404934b0838f9b418c105bf65dca0
---
M Makefile.am
M configure.ac
A tests/Makefile.am
A tests/parse/Makefile.am
A tests/parse/tcap_parse_test.c
A tests/parse/tcap_parse_test.ok
A tests/testsuite.at
7 files changed, 136 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-asn1-tcap refs/changes/94/41394/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41394?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: I475afbb6145404934b0838f9b418c105bf65dca0
Gerrit-Change-Number: 41394
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
daniel has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41308?usp=email )
Change subject: Add test for tcap decoding/encoding
......................................................................
Abandoned
Abandoned in favour of https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41394
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41308?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I8a0dbfaaa7182a5a72b279908be09e3adab254a2
Gerrit-Change-Number: 41308
Gerrit-PatchSet: 7
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Jenkins Builder has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41394?usp=email )
Change subject: Add test to ensure parsing works
......................................................................
Patch Set 1:
(2 comments)
File tests/parse/tcap_parse_test.c:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41394/comment/f9c1d2c5_7fa… :
PS1, Line 20: static int write_stream(const void *buffer, size_t size, void *key) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41394/comment/68e893ad_885… :
PS1, Line 37: if (rc.code != RC_OK) {
braces {} are not necessary for single statement blocks
--
To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41394?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: I475afbb6145404934b0838f9b418c105bf65dca0
Gerrit-Change-Number: 41394
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Tue, 11 Nov 2025 08:40:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: lynxis lazus.
osmith has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41310?usp=email )
Change subject: Add rate counters for loadshare-tcap
......................................................................
Patch Set 9:
(1 comment)
Patchset:
PS8:
> When generating the manuals it's also the matrix job where we also enable tcap, so they should show […]
ack, you made it so in https://gerrit.osmocom.org/c/osmo-ci/+/41388 that manuals only get built when tcap is enabled:
```
combination_filter: >
(WITH_TCAP == "1" && WITH_MANUALS == "1") ||
(WITH_TCAP == "0" && WITH_MANUALS == "0")
```
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41310?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Id67704991feacf54e3123f76e9506dd323b2498b
Gerrit-Change-Number: 41310
Gerrit-PatchSet: 9
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Tue, 11 Nov 2025 07:12:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/41393?usp=email )
Change subject: OBS: sync_obs_projects: fix for OSC 1.12.1
......................................................................
OBS: sync_obs_projects: fix for OSC 1.12.1
Since the Docker image used by sync_obs_projects was changed from Debian
12 to 13, several "osc" commands have in their output:
fatal: not a git repository (or any of the parent directories): .git
Work around this by switching to the temp directory and initializing a
git repository there, with an "origin" remote that osc also expects to
exist.
Fixes: 6ac535b8 ("OBS: set default distro to debian 13")
Change-Id: I1236a065e2998fb46343df3968f7bb4dabeea55a
---
M scripts/obs/sync_obs_projects.py
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
osmith: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
diff --git a/scripts/obs/sync_obs_projects.py b/scripts/obs/sync_obs_projects.py
index d494ed4..a82a47c 100755
--- a/scripts/obs/sync_obs_projects.py
+++ b/scripts/obs/sync_obs_projects.py
@@ -334,6 +334,12 @@
os.makedirs(lib.config.path_temp, exist_ok=True)
+ # OSC 1.12.1 from Debian Trixie fails if the current working dir isn't a
+ # git repository or is missing an "origin" remote
+ os.chdir(lib.config.path_temp)
+ lib.run_cmd(["git", "init"])
+ lib.run_cmd(["git", "remote", "add", "origin", "."])
+
# Get destination OBS projects
lib.osc.set_apiurl(lib.args.to_apiurl, None)
dest_projects = lib.osc.get_projects()
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41393?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I1236a065e2998fb46343df3968f7bb4dabeea55a
Gerrit-Change-Number: 41393
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>