jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41357?usp=email )
Change subject: Omit all-zero octets in MS Classmark 3
......................................................................
Omit all-zero octets in MS Classmark 3
TS 24.008 Clause 10.5.7.1 allows us to omit all-zero octets at the end
of the information element. The decoder will add them if needed.
Older specs tell us to include the supported bands, a5 bits and radio
capability. Therefore we don't omit them, even if their encoded octets
are all-zero.
Change-Id: I3f05893e60f37f349b77fbd15a20b7708c4c3481
---
M src/host/layer23/src/mobile/gsm48_rr.c
1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/57/41357/1
diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c
index 1750c57..c04193c 100644
--- a/src/host/layer23/src/mobile/gsm48_rr.c
+++ b/src/host/layer23/src/mobile/gsm48_rr.c
@@ -1270,6 +1270,7 @@
struct gsm_support *sup = &ms->support;
struct gsm_settings *set = &ms->settings;
struct bitvec bv;
+ int minimum_len;
memset(&bv, 0, sizeof(bv));
bv.data = buf;
@@ -1328,6 +1329,8 @@
bitvec_set_uint(&bv, 0, 4);
bitvec_set_uint(&bv, set->class_900, 4);
}
+ /* These octets above shall be included according to GSM 04.08 Version 5.3.0. */
+ minimum_len = (bv.cur_bit + 7) >> 3;
/* r support */
if (set->r_gsm) {
bitvec_set_bit(&bv, ONE);
@@ -1442,6 +1445,16 @@
*len = (bv.cur_bit + 7) >> 3;
bitvec_fill(&bv, (*len*8) - bv.cur_bit, ZERO);
+ /* Remove all all-zero octets at the end. See the rule in Clause 10.5.7.1:
+ "Typically, the number of spare bits at the end is the minimum to reach an octet boundary.
+ The receiver may add any number of bits set to "0" at the end of the received string
+ if needed for correct decoding."
+ GSM 04.08 Version 5.3.0 states that spare octets after "octet 3" and "octet 3bis" may be omitted.
+ Note that "octet 3" refers to the first value (buf[0]) in this TLV information element.
+ */
+ while (*len > minimum_len && buf[*len - 1] == 0x00)
+ (*len)--;
+
return 0;
}
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41357?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I3f05893e60f37f349b77fbd15a20b7708c4c3481
Gerrit-Change-Number: 41357
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41358?usp=email )
Change subject: RSSI app: Use correct BSIC for RACH bursts
......................................................................
RSSI app: Use correct BSIC for RACH bursts
A regular RACH burst uses the BSIC of the cell. A 'uic' value of 0xff
does not override the BSIC with a wrong value.
Change-Id: I63ed20160d9d45cbc3f70cec8b1c0af262fdde19
---
M src/target/firmware/apps/rssi/main.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/58/41358/1
diff --git a/src/target/firmware/apps/rssi/main.c b/src/target/firmware/apps/rssi/main.c
index 29c5430..b407caf 100644
--- a/src/target/firmware/apps/rssi/main.c
+++ b/src/target/firmware/apps/rssi/main.c
@@ -1209,6 +1209,7 @@
rach_req->ra = rach_ra;
rach_req->offset = 0;
rach_req->combined = (ccch_conf == 1);
+ rach_req->uic = 0xff;
l1a_l23_rx(SC_DLCI_L1A_L23, msg1);
l1a_l23_rx(SC_DLCI_L1A_L23, msg2);
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41358?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I63ed20160d9d45cbc3f70cec8b1c0af262fdde19
Gerrit-Change-Number: 41358
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41354?usp=email )
Change subject: Bump version: 2.1.2.2-a679-dirty → 2.1.3
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
These changes have been merged today, just a few hours ago. For the sake of caution, I would delay tagging a release until we make sure that TTCN-3 tests and master jobs of the related projects are passing.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41354?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: osmith/2.1.3
Gerrit-Change-Id: I0a079e17bf2f5fa286c78a6a67cc675215a3d58e
Gerrit-Change-Number: 41354
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 06 Nov 2025 10:41:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: osmith.
laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41353?usp=email )
Change subject: ipa: fix a minor memleak for unknown IPA packets
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41353?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: osmith/2.1.3
Gerrit-Change-Id: Idb77d3d7dc9db1076b110fb4d17c951b161e77e2
Gerrit-Change-Number: 41353
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 06 Nov 2025 09:35:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes