November 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmocom-bb[master]: Omit all-zero octets in MS Classmark 3
by laforge 06 Nov '25

06 Nov '25

Attention is currently required from: fixeria, jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41357?usp=email ) Change subject: Omit all-zero octets in MS Classmark 3 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41357?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3f05893e60f37f349b77fbd15a20b7708c4c3481 Gerrit-Change-Number: 41357 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Nov 2025 12:21:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: tests/testsuite.at: fix invalid if-endif syntax
by laforge 06 Nov '25

06 Nov '25

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/41362?usp=email ) Change subject: tests/testsuite.at: fix invalid if-endif syntax ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41362?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I81e044dc0bda4674c0d0dc46118d46816712a76c Gerrit-Change-Number: 41362 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Nov 2025 12:20:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: tests/testsuite.at: fix invalid if-endif syntax
by osmith 06 Nov '25

06 Nov '25

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/41362?usp=email ) Change subject: tests/testsuite.at: fix invalid if-endif syntax ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41362?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I81e044dc0bda4674c0d0dc46118d46816712a76c Gerrit-Change-Number: 41362 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Nov 2025 12:18:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: tests/testsuite.at: fix invalid if-endif syntax
by fixeria 06 Nov '25

06 Nov '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41362?usp=email ) Change subject: tests/testsuite.at: fix invalid if-endif syntax ...................................................................... tests/testsuite.at: fix invalid if-endif syntax `make check` currently fails if libosmocore is configured with `--disable-msgfile`. The reason is that the testsuite tries to execte a binary that does not exist. This is happening because the if-endif syntax is invalid and thus ignored. Change-Id: I81e044dc0bda4674c0d0dc46118d46816712a76c --- M tests/testsuite.at 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/62/41362/1 diff --git a/tests/testsuite.at b/tests/testsuite.at index f22ca5a..82758b7 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -81,13 +81,12 @@ AT_CHECK([$abs_top_builddir/tests/gea/gea_test], [0], [expout]) AT_CLEANUP -if ENABLE_MSGFILE AT_SETUP([msgfile]) AT_KEYWORDS([msgfile]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/msgfile/msgfile_test]) cat $abs_srcdir/msgfile/msgfile_test.ok > expout AT_CHECK([$abs_top_builddir/tests/msgfile/msgfile_test $abs_srcdir/msgfile/msgconfig.cfg], [0], [expout]) AT_CLEANUP -endif AT_SETUP([sms]) AT_KEYWORDS([sms]) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41362?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I81e044dc0bda4674c0d0dc46118d46816712a76c Gerrit-Change-Number: 41362 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmocom-bb[master]: Indicate ER-GSM band support in MS classmark 3
by jolly 06 Nov '25

06 Nov '25

Attention is currently required from: fixeria, jolly. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/41360?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Indicate ER-GSM band support in MS classmark 3 ...................................................................... Indicate ER-GSM band support in MS classmark 3 Change-Id: Ica13814eddb5293c7d7a2a21dd6a7a437cd1d351 --- M src/host/layer23/src/mobile/gsm48_rr.c 1 file changed, 79 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/60/41360/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41360?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ica13814eddb5293c7d7a2a21dd6a7a437cd1d351 Gerrit-Change-Number: 41360 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmocom-bb[master]: Indicate ER-GSM band support in MS classmark 3
by Jenkins Builder 06 Nov '25

06 Nov '25

Attention is currently required from: fixeria, jolly. Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41360?usp=email ) Change subject: Indicate ER-GSM band support in MS classmark 3 ...................................................................... Patch Set 2: (1 comment) File src/host/layer23/src/mobile/gsm48_rr.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmocom-bb/+/41360/comment/1427e33e_5ce9e729?u… : PS2, Line 1508: if (set->er_gsm) { braces {} are not necessary for any arm of this statement -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41360?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ica13814eddb5293c7d7a2a21dd6a7a437cd1d351 Gerrit-Change-Number: 41360 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Nov 2025 11:18:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmocom-bb[master]: Add ER-GSM band support to all relevant applications
by jolly 06 Nov '25

06 Nov '25

Attention is currently required from: fixeria, jolly. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Add ER-GSM band support to all relevant applications ...................................................................... Add ER-GSM band support to all relevant applications ER-GSM band expands the R-GSM band by additional 15 channels. Mobile application allows to turn on or off the support of these 15 channels. ER-GSM band is supported by default. Change-Id: I71baa3317df685cf6479b6e20e6ae078911aa24f --- M src/host/layer23/include/osmocom/bb/common/settings.h M src/host/layer23/include/osmocom/bb/common/support.h M src/host/layer23/src/common/settings.c M src/host/layer23/src/common/support.c M src/host/layer23/src/common/sysinfo.c M src/host/layer23/src/misc/bcch_scan.c M src/host/layer23/src/misc/cell_log.c M src/host/layer23/src/mobile/gsm48_rr.c M src/host/layer23/src/mobile/vty_interface.c M src/shared/libosmocore/src/gsm/gsm_utils.c M src/target/firmware/apps/rssi/main.c 11 files changed, 38 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/59/41359/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I71baa3317df685cf6479b6e20e6ae078911aa24f Gerrit-Change-Number: 41359 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: Add ER-GSM band support
by jolly 06 Nov '25

06 Nov '25

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41361?usp=email ) Change subject: Add ER-GSM band support ...................................................................... Add ER-GSM band support ER-GSM band expands the R-GSM band by additional 15 channels, starting from channel 940. Change-Id: I0a9a2f64d9db65967699453c26ae282c4ddf4558 --- M src/osmo-bsc/bts.c M src/osmo-bsc/system_information.c 2 files changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/61/41361/1 diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 2cc6153..77721fb 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -525,9 +525,9 @@ } break; case GSM_BAND_900: - if ((bts->c0->arfcn > 124 && bts->c0->arfcn < 955) || + if ((bts->c0->arfcn > 124 && bts->c0->arfcn < 940) || bts->c0->arfcn > 1023) { - LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM900 channel (%u) must be between 0-124, 955-1023.\n", + LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM900 channel (%u) must be between 0-124, 940-1023.\n", bts->nr, bts->c0->arfcn); return -EINVAL; } diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c index b438a49..41c7b81 100644 --- a/src/osmo-bsc/system_information.c +++ b/src/osmo-bsc/system_information.c @@ -545,8 +545,8 @@ /* Check presence of E-GSM ARFCN 0 */ if (pgsm && bitvec_get_bit_pos(bv, 0) == ONE) pgsm = false; - /* Check presence of R-GSM / E-GSM ARFCNs 955..1023 */ - for (i = 955; pgsm && i <= 1023; i++) { + /* Check presence of R-GSM / E-GSM ARFCNs 940..1023 */ + for (i = 940; pgsm && i <= 1023; i++) { if (bitvec_get_bit_pos(bv, i) == ONE) pgsm = false; } @@ -577,22 +577,22 @@ /* count the arfcns we want to carry */ arfcns += 1; - /* 955..1023 < 0..885 */ + /* 940..1023 < 0..885 */ if (min < 0) min = i; - if (i >= 955 && min < 955) + if (i >= 940 && min < 940) min = i; - if (i >= 955 && min >= 955 && i < min) + if (i >= 940 && min >= 940 && i < min) min = i; - if (i < 955 && min < 955 && i < min) + if (i < 940 && min < 940 && i < min) min = i; if (max < 0) max = i; - if (i < 955 && max >= 955) + if (i < 940 && max >= 940) max = i; - if (i >= 955 && max >= 955 && i > max) + if (i >= 940 && max >= 940 && i > max) max = i; - if (i < 955 && max < 955 && i > max) + if (i < 940 && max < 940 && i > max) max = i; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41361?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0a9a2f64d9db65967699453c26ae282c4ddf4558 Gerrit-Change-Number: 41361 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

1 0

[M] Change in osmocom-bb[master]: Add ER-GSM band support to all relevant applications
by Jenkins Builder 06 Nov '25

06 Nov '25

Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email ) Change subject: Add ER-GSM band support to all relevant applications ...................................................................... Patch Set 1: (5 comments) File src/host/layer23/src/common/settings.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmocom-bb/+/41359/comment/9e504b0c_1a0b247d?u… : PS1, Line 187: for(i = 940; i <= 954; i++) space required before the open parenthesis '(' File src/target/firmware/apps/rssi/main.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmocom-bb/+/41359/comment/6bc36477_69543215?u… : PS1, Line 82: { 940, 124, 885, 128, 8732, 9182 }, /* P,E,(E)R GSM */ code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmocom-bb/+/41359/comment/121462b5_86ff8d43?u… : PS1, Line 82: { 940, 124, 885, 128, 8732, 9182 }, /* P,E,(E)R GSM */ please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmocom-bb/+/41359/comment/9fb1599e_1e9761af?u… : PS1, Line 83: { 512, 885, 251, 940, 17102, 18052 }, /* DCS 1800 */ code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmocom-bb/+/41359/comment/89aa4c5b_daee1dd4?u… : PS1, Line 83: { 512, 885, 251, 940, 17102, 18052 }, /* DCS 1800 */ please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I71baa3317df685cf6479b6e20e6ae078911aa24f Gerrit-Change-Number: 41359 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 06 Nov 2025 10:52:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmocom-bb[master]: Indicate ER-GSM band support in MS classmark 3
by Jenkins Builder 06 Nov '25

06 Nov '25

Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41360?usp=email ) Change subject: Indicate ER-GSM band support in MS classmark 3 ...................................................................... Patch Set 1: (1 comment) File src/host/layer23/src/mobile/gsm48_rr.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmocom-bb/+/41360/comment/5c73b6f4_1d6ad8a4?u… : PS1, Line 1508: if (set->er_gsm) { braces {} are not necessary for any arm of this statement -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41360?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ica13814eddb5293c7d7a2a21dd6a7a437cd1d351 Gerrit-Change-Number: 41360 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 06 Nov 2025 10:51:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2025

2024

2023

2022

gerrit-log November 2025