November 2025 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo-epdg[master]: aaa_diameter_swx: Avoid answering RTR with Success if already deregis...
by pespin 06 Nov '25

06 Nov '25

Attention is currently required from: laforge, osmith, pespin. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41303?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: aaa_diameter_swx: Avoid answering RTR with Success if already deregistering ...................................................................... aaa_diameter_swx: Avoid answering RTR with Success if already deregistering When receiving an SWx RTR on our osmo-epdg (epdg+AAA), we initiate the deregistration against peer nodes on other interfaces and answer with SWx RTA. If a subsequent RTR for the subscriber arrives on the interface while the deregistration is in progress, we'd answer with RTA Result-Code 2001 SUCCESS. Let's instead answer already as if we didn't know about the subscriber, since it will end up being freed in a short span of time and nothing can be done about it. Related: OS#6796 Change-Id: I0ed13e9503ec380ce4331c662ca3eb966ccbda92 --- M src/aaa_diameter_swx_cb.erl M src/aaa_ue_fsm.erl 2 files changed, 21 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/03/41303/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41303?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I0ed13e9503ec380ce4331c662ca3eb966ccbda92 Gerrit-Change-Number: 41303 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in ...osmo-epdg[master]: aaa_ue_fsm: Avoid immediate stop of fsm during 2nd SWx RTR
by pespin 06 Nov '25

06 Nov '25

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41302?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified-1 by Jenkins Builder Change subject: aaa_ue_fsm: Avoid immediate stop of fsm during 2nd SWx RTR ...................................................................... aaa_ue_fsm: Avoid immediate stop of fsm during 2nd SWx RTR During Network Initiated De-Registration by HSS Procedure, if a 2nd RTR arrives for an aaa_ue_fsm which is already in state_dereg_net_initiated_*, let it continue with the ordered tear down consisting of informing peer nodes. Change-Id: I6d564ec1583692a6b6f3f273268b400570b246ff --- M src/aaa_ue_fsm.erl 1 file changed, 34 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/02/41302/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41302?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I6d564ec1583692a6b6f3f273268b400570b246ff Gerrit-Change-Number: 41302 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[osmith/2.1.3]: Bump version: 2.1.2.2-a679-dirty → 2.1.3
by pespin 06 Nov '25

06 Nov '25

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41354?usp=email ) Change subject: Bump version: 2.1.2.2-a679-dirty → 2.1.3 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > These changes have been merged today, just a few hours ago. […] Agree with fixeria. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41354?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: osmith/2.1.3 Gerrit-Change-Id: I0a079e17bf2f5fa286c78a6a67cc675215a3d58e Gerrit-Change-Number: 41354 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Nov 2025 13:30:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in ...osmo-epdg[master]: cosmetic: Fix typo in code documentation
by pespin 06 Nov '25

06 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41301?usp=email ) Change subject: cosmetic: Fix typo in code documentation ...................................................................... cosmetic: Fix typo in code documentation Change-Id: I41da3bcc3b5f982901baa8162d7fd55f35d70485 --- M src/aaa_ue_fsm.erl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/src/aaa_ue_fsm.erl b/src/aaa_ue_fsm.erl index c73f636..64f6cb3 100644 --- a/src/aaa_ue_fsm.erl +++ b/src/aaa_ue_fsm.erl @@ -454,7 +454,7 @@ {next_state, state_dereg_net_initiated_wait_swm_asa, Data}. %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% -%% state_dereg_net_initiated_wait_s6b_asa: +%% state_dereg_net_initiated_wait_swm_asa: %% HSS asked us to do deregistration towards the user. %% S6b (PGW) was already torn down. Now transmit SWm ASR towards ePDG and wait for ASA back. %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41301?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I41da3bcc3b5f982901baa8162d7fd55f35d70485 Gerrit-Change-Number: 41301 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: tests/osmo_io_test: test_segmentation: Use osmo_iofd_close() API
by pespin 06 Nov '25

06 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41299?usp=email ) Change subject: tests/osmo_io_test: test_segmentation: Use osmo_iofd_close() API ...................................................................... tests/osmo_io_test: test_segmentation: Use osmo_iofd_close() API This is saner than doing osmo_iofd_unregister() + manual close(). Change-Id: Id910bfb4e0965700e2d378a513a9bf889b929d44 --- M tests/osmo_io/osmo_io_test.c 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved jolly: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve diff --git a/tests/osmo_io/osmo_io_test.c b/tests/osmo_io/osmo_io_test.c index d3e22aa..693c428 100644 --- a/tests/osmo_io/osmo_io_test.c +++ b/tests/osmo_io/osmo_io_test.c @@ -323,8 +323,7 @@ fflush(stdout); OSMO_ASSERT(file_bytes_write_compl == 12); - osmo_iofd_unregister(iofd); - close(fd[1]); + osmo_iofd_close(iofd); /* Now, re-configure iofd to only read from the pipe. * Reduce the read buffer size, to verify correct segmentation operation: */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41299?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id910bfb4e0965700e2d378a513a9bf889b929d44 Gerrit-Change-Number: 41299 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: tests/osmo_io_test (io_uring): test_segmentation: Fix infinite loop i...
by pespin 06 Nov '25

06 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41297?usp=email ) Change subject: tests/osmo_io_test (io_uring): test_segmentation: Fix infinite loop in read_cb rc=0 ...................................................................... tests/osmo_io_test (io_uring): test_segmentation: Fix infinite loop in read_cb rc=0 Under linux 6.17.6-arch1-1 & liburing 2.12-1, once we finish reading from the pipe (rc=0) because the write peer was closed and data has been consumed, we end up in some sort of infinite loop in the uring due to re-adding a sqe in iofd_uring_handle_recv()->iofd_uring_submit_recv() path and immediatelly consuming a cqe from the uring, without going through the poll() loop. The user is expected to close the fd once rc=0 is received anyway, which was not being done in this test. Doing so successfully unregisters the iofd and fixes the infinite loop. Fixes: 086ee51de416ae5276b4b185c055831e16c0ef85 Change-Id: I47b5fff04c601cd08ab2d46b88336247b2193808 --- M tests/osmo_io/osmo_io_test.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified jolly: Looks good to me, but someone else must approve diff --git a/tests/osmo_io/osmo_io_test.c b/tests/osmo_io/osmo_io_test.c index 693c428..0812ea8 100644 --- a/tests/osmo_io/osmo_io_test.c +++ b/tests/osmo_io/osmo_io_test.c @@ -280,6 +280,7 @@ } else { OSMO_ASSERT(rc == 0); file_eof_read = true; + osmo_iofd_close(iofd); } talloc_free(msg); } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41297?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I47b5fff04c601cd08ab2d46b88336247b2193808 Gerrit-Change-Number: 41297 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: io_uring: Avoid extra reads if iofd becomes unregistered by user
by pespin 06 Nov '25

06 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41300?usp=email ) Change subject: io_uring: Avoid extra reads if iofd becomes unregistered by user ...................................................................... io_uring: Avoid extra reads if iofd becomes unregistered by user The user callback (read_cb, segmentation_cb, etc.) may decide to unregister the iofd instead of closing it. In this scenario, we should avoid calling the callback further until the iofd is registered again. Change-Id: I231d5a16768b730f67089090c244bcc10dc69c3a --- M src/core/osmo_io_uring.c M tests/osmo_io/osmo_io_test.c 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified jolly: Looks good to me, but someone else must approve pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve diff --git a/src/core/osmo_io_uring.c b/src/core/osmo_io_uring.c index 01b8063..e4a87ad 100644 --- a/src/core/osmo_io_uring.c +++ b/src/core/osmo_io_uring.c @@ -359,7 +359,7 @@ } /* Check for every iteration, because iofd might get unregistered/closed during receive function. */ - if (iofd->u.uring.read.enabled && !IOFD_FLAG_ISSET(iofd, IOFD_FLAG_CLOSED)) + if (IOFD_FLAG_ISSET(iofd, IOFD_FLAG_FD_REGISTERED) && iofd->u.uring.read.enabled) iofd_handle_recv(iofd, msg, chunk, msghdr); else msgb_free(msg); @@ -372,7 +372,7 @@ msghdr->msg[idx] = NULL; } - if (iofd->u.uring.read.enabled && !IOFD_FLAG_ISSET(iofd, IOFD_FLAG_CLOSED)) + if (IOFD_FLAG_ISSET(iofd, IOFD_FLAG_FD_REGISTERED) && iofd->u.uring.read.enabled) iofd_uring_submit_recv(iofd, msghdr->action); iofd_msghdr_free(msghdr); diff --git a/tests/osmo_io/osmo_io_test.c b/tests/osmo_io/osmo_io_test.c index 0812ea8..06491a7 100644 --- a/tests/osmo_io/osmo_io_test.c +++ b/tests/osmo_io/osmo_io_test.c @@ -280,7 +280,7 @@ } else { OSMO_ASSERT(rc == 0); file_eof_read = true; - osmo_iofd_close(iofd); + osmo_iofd_unregister(iofd); } talloc_free(msg); } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41300?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I231d5a16768b730f67089090c244bcc10dc69c3a Gerrit-Change-Number: 41300 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: io_uring: Avoid extra reads if iofd becomes unregistered by user
by pespin 06 Nov '25

06 Nov '25

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41300?usp=email ) Change subject: io_uring: Avoid extra reads if iofd becomes unregistered by user ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41300?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I231d5a16768b730f67089090c244bcc10dc69c3a Gerrit-Change-Number: 41300 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Nov 2025 13:01:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmocom-bb[master]: Add ER-GSM band support to all relevant applications
by jolly 06 Nov '25

06 Nov '25

Attention is currently required from: fixeria, jolly, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: Add ER-GSM band support to all relevant applications ...................................................................... Add ER-GSM band support to all relevant applications ER-GSM band expands the R-GSM band by additional 15 channels. Mobile application allows to turn on or off the support of these 15 channels. ER-GSM band is supported by default. Change-Id: I71baa3317df685cf6479b6e20e6ae078911aa24f --- M doc/examples/mobile/mobile.cfg M doc/examples/mobile/multi_ms.cfg M src/host/layer23/include/osmocom/bb/common/settings.h M src/host/layer23/include/osmocom/bb/common/support.h M src/host/layer23/src/common/settings.c M src/host/layer23/src/common/support.c M src/host/layer23/src/common/sysinfo.c M src/host/layer23/src/misc/bcch_scan.c M src/host/layer23/src/misc/cell_log.c M src/host/layer23/src/mobile/gsm48_rr.c M src/host/layer23/src/mobile/vty_interface.c M src/shared/libosmocore/src/gsm/gsm_utils.c M src/target/firmware/apps/rssi/main.c 13 files changed, 41 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/59/41359/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I71baa3317df685cf6479b6e20e6ae078911aa24f Gerrit-Change-Number: 41359 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: tests/testsuite.at: properly skip disabled tests
by fixeria 06 Nov '25

06 Nov '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41364?usp=email ) Change subject: tests/testsuite.at: properly skip disabled tests ...................................................................... tests/testsuite.at: properly skip disabled tests We should not be running these tests unconditionally because the respective binaries are built conditionally and may be missing. Change-Id: I7e9a0c84e510964e5d577e371d41f2023ab20840 --- M tests/testsuite.at 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/64/41364/1 diff --git a/tests/testsuite.at b/tests/testsuite.at index 1c9a97e..bd251f0 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -17,6 +17,7 @@ AT_SETUP([ctrl]) AT_KEYWORDS([ctrl]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/ctrl/ctrl_test]) cat $abs_srcdir/ctrl/ctrl_test.ok > expout AT_CHECK([$abs_top_builddir/tests/ctrl/ctrl_test], [0], [expout], [ignore]) AT_CLEANUP @@ -237,6 +238,7 @@ AT_SETUP([fr]) AT_KEYWORDS([fr]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/fr/fr_test]) cat $abs_srcdir/fr/fr_test.ok > expout cat $abs_srcdir/fr/fr_test.err > experr AT_CHECK([$abs_top_builddir/tests/fr/fr_test], [0], [expout], [experr]) @@ -257,6 +259,7 @@ AT_SETUP([vty]) AT_KEYWORDS([vty]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/vty/vty_test]) cat $abs_srcdir/vty/vty_test.ok > expout cat $abs_srcdir/vty/vty_test.err > experr AT_CHECK([$abs_top_builddir/tests/vty/vty_test $abs_srcdir/vty], [0], [expout], [experr]) @@ -264,18 +267,21 @@ AT_SETUP([gprs-bssgp]) AT_KEYWORDS([gprs-bssgp]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/gb/gprs_bssgp_test]) cat $abs_srcdir/gb/gprs_bssgp_test.ok > expout AT_CHECK([$abs_top_builddir/tests/gb/gprs_bssgp_test], [0], [expout], [ignore]) AT_CLEANUP AT_SETUP([gprs-bssgp-rim]) AT_KEYWORDS([gprs-bssgp-rim]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/gb/gprs_bssgp_rim_test]) cat $abs_srcdir/gb/gprs_bssgp_rim_test.ok > expout AT_CHECK([$abs_top_builddir/tests/gb/gprs_bssgp_rim_test], [0], [expout], [ignore]) AT_CLEANUP AT_SETUP([gprs-ns]) AT_KEYWORDS([gprs-ns]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/gb/gprs_ns_test]) cat $abs_srcdir/gb/gprs_ns_test.ok > expout cat $abs_srcdir/gb/gprs_ns_test.err > experr AT_CHECK([$abs_top_builddir/tests/gb/gprs_ns_test], [0], [expout], [experr]) @@ -283,6 +289,7 @@ AT_SETUP([gprs-ns2]) AT_KEYWORDS([gprs-ns2]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/gb/gprs_ns2_test]) cat $abs_srcdir/gb/gprs_ns2_test.ok > expout cat $abs_srcdir/gb/gprs_ns2_test.err > experr AT_CHECK([$abs_top_builddir/tests/gb/gprs_ns2_test], [0], [expout], [experr]) @@ -290,6 +297,7 @@ AT_SETUP([utils]) AT_KEYWORDS([utils]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/utils/utils_test]) cat $abs_srcdir/utils/utils_test.ok > expout cat $abs_srcdir/utils/utils_test.err > experr AT_CHECK([$abs_top_builddir/tests/utils/utils_test], [0], [expout], [experr]) @@ -297,6 +305,7 @@ AT_SETUP([stats]) AT_KEYWORDS([stats]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/stats/stats_test]) cat $abs_srcdir/stats/stats_test.ok > expout cat $abs_srcdir/stats/stats_test.err > experr AT_CHECK([$abs_top_builddir/tests/stats/stats_test], [0], [expout], [experr]) @@ -310,6 +319,7 @@ AT_SETUP([bssgp-fc]) AT_KEYWORDS([bssgp-fc]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/gb/bssgp_fc_tests]) cat $abs_srcdir/gb/bssgp_fc_tests.ok > expout cat $abs_srcdir/gb/bssgp_fc_tests.err > experr AT_CHECK([$abs_top_srcdir/tests/gb/bssgp_fc_tests.sh $abs_top_builddir/tests/gb], [0], [expout], [experr]) @@ -342,6 +352,7 @@ AT_SETUP([gsup]) AT_KEYWORDS([gsup]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/gsup/gsup_test]) cat $abs_srcdir/gsup/gsup_test.ok > expout cat $abs_srcdir/gsup/gsup_test.err > experr AT_CHECK([$abs_top_builddir/tests/gsup/gsup_test], [0], [expout], [experr]) @@ -349,6 +360,7 @@ AT_SETUP([fsm]) AT_KEYWORDS([fsm]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/fsm/fsm_test]) cat $abs_srcdir/fsm/fsm_test.ok > expout cat $abs_srcdir/fsm/fsm_test.err > experr AT_CHECK([$abs_top_builddir/tests/fsm/fsm_test], [0], [expout], [experr]) @@ -356,6 +368,7 @@ AT_SETUP([fsm_dealloc]) AT_KEYWORDS([fsm_dealloc]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/fsm/fsm_dealloc_test]) cat $abs_srcdir/fsm/fsm_dealloc_test.err > experr AT_CHECK([$abs_top_builddir/tests/fsm/fsm_dealloc_test], [0], [ignore], [experr]) AT_CLEANUP @@ -383,7 +396,7 @@ AT_SETUP([socket_sctp]) AT_KEYWORDS([socket_sctp]) -AT_SKIP_IF([! test -e $abs_top_builddir/tests/socket/socket_sctp_test]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/socket/socket_sctp_test]) cat $abs_srcdir/socket/socket_sctp_test.ok > expout cat $abs_srcdir/socket/socket_sctp_test.err > experr AT_CHECK([$abs_top_builddir/tests/socket/socket_sctp_test], [0], [expout], [experr]) @@ -454,6 +467,7 @@ AT_SETUP([exec]) AT_KEYWORDS([exec]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/exec/exec_test]) cat $abs_srcdir/exec/exec_test.ok > expout cat $abs_srcdir/exec/exec_test.err > experr AT_CHECK([$abs_top_builddir/tests/exec/exec_test], [0], [expout], [experr]) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41364?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7e9a0c84e510964e5d577e371d41f2023ab20840 Gerrit-Change-Number: 41364 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2025

2024

2023

2022

gerrit-log November 2025