November 2025 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-asn1-tcap[master]: Add test to ensure parsing works
by laforge 13 Nov '25

13 Nov '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41394?usp=email ) Change subject: Add test to ensure parsing works ...................................................................... Add test to ensure parsing works Related: SYS#5423 Change-Id: I475afbb6145404934b0838f9b418c105bf65dca0 --- M Makefile.am M configure.ac A tests/Makefile.am A tests/parse/Makefile.am A tests/parse/tcap_parse_test.c A tests/parse/tcap_parse_test.ok A tests/testsuite.at 7 files changed, 136 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/Makefile.am b/Makefile.am index 9e311a6..c165099 100644 --- a/Makefile.am +++ b/Makefile.am @@ -8,7 +8,7 @@ echo $(VERSION) > $(distdir)/.tarball-version INCLUDES = $(all_includes) -I$(top_srcdir)/include/osmocom/tcap -SUBDIRS = src include +SUBDIRS = src tests include pkgconfigdir = $(libdir)/pkgconfig pkgconfig_DATA = libosmo-asn1-tcap.pc diff --git a/configure.ac b/configure.ac index 8e18a0f..5d66205 100644 --- a/configure.ac +++ b/configure.ac @@ -5,6 +5,7 @@ AC_CONFIG_AUX_DIR([.]) AM_INIT_AUTOMAKE([dist-bzip2 subdir-objects]) +AC_CONFIG_TESTDIR(tests) dnl kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) @@ -66,6 +67,8 @@ AC_OUTPUT( libosmo-asn1-tcap.pc src/Makefile + tests/Makefile + tests/parse/Makefile include/Makefile include/osmocom/Makefile include/osmocom/tcap/Makefile diff --git a/tests/Makefile.am b/tests/Makefile.am new file mode 100644 index 0000000..ce671d7 --- /dev/null +++ b/tests/Makefile.am @@ -0,0 +1,40 @@ +SUBDIRS = parse + +# The `:;' works around a Bash 3.2 bug when the output is not writeable. +$(srcdir)/package.m4: $(top_srcdir)/configure.ac + :;{ \ + echo '# Signature of the current package.' && \ + echo 'm4_define([AT_PACKAGE_NAME],' && \ + echo ' [$(PACKAGE_NAME)])' && \ + echo 'm4_define([AT_PACKAGE_TARNAME],' && \ + echo ' [$(PACKAGE_TARNAME)])' && \ + echo 'm4_define([AT_PACKAGE_VERSION],' && \ + echo ' [$(PACKAGE_VERSION)])' && \ + echo 'm4_define([AT_PACKAGE_STRING],' && \ + echo ' [$(PACKAGE_STRING)])' && \ + echo 'm4_define([AT_PACKAGE_BUGREPORT],' && \ + echo ' [$(PACKAGE_BUGREPORT)])'; \ + echo 'm4_define([AT_PACKAGE_URL],' && \ + echo ' [$(PACKAGE_URL)])'; \ + } >'$(srcdir)/package.m4' + +EXTRA_DIST = testsuite.at $(srcdir)/package.m4 $(TESTSUITE) +TESTSUITE = $(srcdir)/testsuite +DISTCLEANFILES = atconfig + +check-local: atconfig $(TESTSUITE) + $(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS) + +installcheck-local: atconfig $(TESTSUITE) + $(SHELL) '$(TESTSUITE)' AUTOTEST_PATH='$(bindir)' \ + $(TESTSUITEFLAGS) + +clean-local: + test ! -f '$(TESTSUITE)' || \ + $(SHELL) '$(TESTSUITE)' --clean + +AUTOM4TE = $(SHELL) $(top_srcdir)/missing --run autom4te +AUTOTEST = $(AUTOM4TE) --language=autotest +$(TESTSUITE): $(srcdir)/testsuite.at $(srcdir)/package.m4 + $(AUTOTEST) -I '$(srcdir)' -o $@.tmp $@.at + mv $@.tmp $@ diff --git a/tests/parse/Makefile.am b/tests/parse/Makefile.am new file mode 100644 index 0000000..d464e2a --- /dev/null +++ b/tests/parse/Makefile.am @@ -0,0 +1,15 @@ +AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_srcdir)/src +AM_CFLAGS = -Wall +AM_LDFLAGS = -static -no-install + +LDADD = $(top_builddir)/src/libosmo-asn1-tcap.la + +check_PROGRAMS = \ + tcap_parse_test \ + $(NULL) + +EXTRA_DIST = \ + tcap_parse_test.ok \ + $(NULL) + +tcap_parse_test_SOURCES = tcap_parse_test.c diff --git a/tests/parse/tcap_parse_test.c b/tests/parse/tcap_parse_test.c new file mode 100644 index 0000000..6a52cea --- /dev/null +++ b/tests/parse/tcap_parse_test.c @@ -0,0 +1,61 @@ +/* TCAP parsing tests */ +#include <complex.h> +#include <stdio.h> +#include <stddef.h> +#include <stdint.h> + +#include <osmocom/tcap/asn_codecs.h> +#include <osmocom/tcap/constr_TYPE.h> +#include <osmocom/tcap/OCTET_STRING.h> +#include <osmocom/tcap/ber_decoder.h> + +#include <osmocom/tcap/asn_internal.h> +#include <osmocom/tcap/TCAP_TCMessage.h> +#include <osmocom/tcap/TCAP_OrigTransactionID.h> +#include <stdlib.h> + + +static const unsigned char pkt1[] = {0x62, 0x06, 0x48, 0x04, 0x00, 0x01, 0x02, 0x03}; + +static int write_stream(const void *buffer, size_t size, void *key) +{ + uint8_t *buf = (uint8_t *)buffer; + for (int i = 0; i < size; i++) + printf("%02X ", buf[i]); + printf("\n"); + return 0; +} + +int main(int argc, char **argv) +{ + asn_dec_rval_t rc; + struct TCAP_TCMessage *tcapmsg; + tcapmsg = calloc(1, sizeof(*tcapmsg)); + + printf("Basic TCAP decode testing.\n"); + + rc = ber_decode(0, &asn_DEF_TCAP_TCMessage, (void **)&tcapmsg, pkt1, sizeof(pkt1)); + if (rc.code != RC_OK) + printf("Broken encoding %u at byte %lu\n", rc.code, rc.consumed); + + asn_fprint(stdout, &asn_DEF_TCAP_TCMessage, tcapmsg); + ASN_STRUCT_FREE(asn_DEF_TCAP_TCMessage, tcapmsg); + + + uint8_t buf[] = {0x00, 0x01, 0x02, 0x03}; + + struct TCAP_TCMessage msg = { + .present = TCAP_TCMessage_PR_begin, + .choice.begin = { + .otid = { + .buf = buf, + .size = 4, + }, + }, + }; + + der_encode(&asn_DEF_TCAP_TCMessage, &msg, write_stream, NULL); + + printf("All tests passed.\n"); + return 0; +} diff --git a/tests/parse/tcap_parse_test.ok b/tests/parse/tcap_parse_test.ok new file mode 100644 index 0000000..6c44530 --- /dev/null +++ b/tests/parse/tcap_parse_test.ok @@ -0,0 +1,8 @@ +Basic TCAP decode testing. +Begin ::= { + otid: 00 01 02 03 +} +62 06 +48 04 +00 01 02 03 +All tests passed. diff --git a/tests/testsuite.at b/tests/testsuite.at new file mode 100644 index 0000000..8c9ce79 --- /dev/null +++ b/tests/testsuite.at @@ -0,0 +1,8 @@ +AT_INIT +AT_BANNER([Regression tests.]) + +AT_SETUP([parse]) +AT_KEYWORDS([parse]) +cat $abs_srcdir/parse/tcap_parse_test.ok > expout +AT_CHECK([$abs_top_builddir/tests/parse/tcap_parse_test], [], [expout], [ignore]) +AT_CLEANUP -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41394?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I475afbb6145404934b0838f9b418c105bf65dca0 Gerrit-Change-Number: 41394 Gerrit-PatchSet: 3 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: Replace ipa_prepend_header() with osmo_ipa_msg_push_header(s)()
by laforge 13 Nov '25

13 Nov '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41401?usp=email ) Change subject: Replace ipa_prepend_header() with osmo_ipa_msg_push_header(s)() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41401?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic0391ad664c43ea52837e42cea0cc0b82dd961ab Gerrit-Change-Number: 41401 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Nov 2025 17:26:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: m3ua: Drop rx packets with unexpected Network Indicator
by laforge 13 Nov '25

13 Nov '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41408?usp=email ) Change subject: m3ua: Drop rx packets with unexpected Network Indicator ...................................................................... Patch Set 2: (1 comment) File src/m3ua.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41408/comment/ff852a45_24fff… : PS2, Line 639: is there actually a requirement in the MTP spec that requests us to do this? It makes sense, but I think I remotely recall that some STPs actually have different routing tables for different NI... -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41408?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I54de65b16949851062914ca5d3362d1e46158b8b Gerrit-Change-Number: 41408 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Nov 2025 17:25:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmo-sigtran[master]: Add per ss7 instance rate_ctr_group
by laforge 13 Nov '25

13 Nov '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41407?usp=email ) Change subject: Add per ss7 instance rate_ctr_group ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41407?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id916307c2465daab3072f850774240969fae3f6e Gerrit-Change-Number: 41407 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Nov 2025 17:24:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: ss7_instance: Introduce API osmo_ss7_instance_get_network_indicator()
by laforge 13 Nov '25

13 Nov '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41409?usp=email ) Change subject: ss7_instance: Introduce API osmo_ss7_instance_get_network_indicator() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41409?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3eb8a562c8f032fe5fd3bfb8282c1a5d9699218c Gerrit-Change-Number: 41409 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Nov 2025 17:23:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: xua_rx_msg: fill xua->mtp.sio with configured network indicator
by laforge 13 Nov '25

13 Nov '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41405?usp=email ) Change subject: xua_rx_msg: fill xua->mtp.sio with configured network indicator ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41405?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I12b2debd62820e917a324da2b15cfb88eebc1bd1 Gerrit-Change-Number: 41405 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Nov 2025 17:23:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: mtp_sap.h: Protect MTP_SIO macro params with parenthesis
by laforge 13 Nov '25

13 Nov '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41404?usp=email ) Change subject: mtp_sap.h: Protect MTP_SIO macro params with parenthesis ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41404?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0ba8139fd5458ff3637eebaaba0d4c0edd080e6a Gerrit-Change-Number: 41404 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Nov 2025 17:23:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: vty: Always write network-indicator
by laforge 13 Nov '25

13 Nov '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41403?usp=email ) Change subject: vty: Always write network-indicator ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41403?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I969ee94c00afa7a77e26c8cf3e9b998b06022641 Gerrit-Change-Number: 41403 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Nov 2025 17:22:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: mtp: Improve Network Indicator definitions
by laforge 13 Nov '25

13 Nov '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41402?usp=email ) Change subject: mtp: Improve Network Indicator definitions ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41402?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0a7e113ac89946e5cf3bec8bec07ad10ee38723d Gerrit-Change-Number: 41402 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Nov 2025 17:22:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: Move osmo_ss7_user_mtp_xfer_req() to proper header
by pespin 13 Nov '25

13 Nov '25

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41406?usp=email ) Change subject: Move osmo_ss7_user_mtp_xfer_req() to proper header ...................................................................... Patch Set 3: Code-Review-2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41406?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibdf9be85eed50ede7719a3f5510705f0c82bf7f9 Gerrit-Change-Number: 41406 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Nov 2025 17:16:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log November 2025