November 2025 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: build-system: depend on libosmo-asn1-tcap
by lynxis lazus 09 Nov '25

09 Nov '25

Attention is currently required from: fixeria, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41307?usp=email ) Change subject: build-system: depend on libosmo-asn1-tcap ...................................................................... Patch Set 3: (4 comments) This change is ready for review. Patchset: PS1: > unresolv it. Done Patchset: PS3: > Also, libosmo-sigtran.pc. […] done File configure.ac: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41307/comment/ef694ae9_03519… : PS2, Line 53: ENABLE_EXT_TESTS > why do you add `ENABLE_EXT_TESTS` here? looks like copy-paste Done File contrib/jenkins.sh: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41307/comment/f2f3f057_cd6ba… : PS3, Line 66: echo " =============================== libosmo-sigtran / tcap-loadsharing ===============================" > You shouldn't test --enable-tcap this way, look at how we test differnet matrix of --enable configs […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41307?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ib485f786217166635377f931ab894e43a0680634 Gerrit-Change-Number: 41307 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 09 Nov 2025 11:31:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmocom-bb[master]: Add ER-GSM band support to all relevant applications
by laforge 09 Nov '25

09 Nov '25

Attention is currently required from: jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email ) Change subject: Add ER-GSM band support to all relevant applications ...................................................................... Patch Set 3: Code-Review-1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I71baa3317df685cf6479b6e20e6ae078911aa24f Gerrit-Change-Number: 41359 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Sat, 08 Nov 2025 13:46:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: tests/testsuite.at: properly skip disabled tests
by laforge 09 Nov '25

09 Nov '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41364?usp=email ) Change subject: tests/testsuite.at: properly skip disabled tests ...................................................................... tests/testsuite.at: properly skip disabled tests We should not be running these tests unconditionally because the respective binaries are built conditionally and may be missing. Change-Id: I7e9a0c84e510964e5d577e371d41f2023ab20840 --- M tests/testsuite.at 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/tests/testsuite.at b/tests/testsuite.at index 1c9a97e..90d6fc4 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -17,6 +17,7 @@ AT_SETUP([ctrl]) AT_KEYWORDS([ctrl]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/ctrl/ctrl_test]) cat $abs_srcdir/ctrl/ctrl_test.ok > expout AT_CHECK([$abs_top_builddir/tests/ctrl/ctrl_test], [0], [expout], [ignore]) AT_CLEANUP @@ -237,6 +238,7 @@ AT_SETUP([fr]) AT_KEYWORDS([fr]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/fr/fr_test]) cat $abs_srcdir/fr/fr_test.ok > expout cat $abs_srcdir/fr/fr_test.err > experr AT_CHECK([$abs_top_builddir/tests/fr/fr_test], [0], [expout], [experr]) @@ -257,6 +259,7 @@ AT_SETUP([vty]) AT_KEYWORDS([vty]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/vty/vty_test]) cat $abs_srcdir/vty/vty_test.ok > expout cat $abs_srcdir/vty/vty_test.err > experr AT_CHECK([$abs_top_builddir/tests/vty/vty_test $abs_srcdir/vty], [0], [expout], [experr]) @@ -264,18 +267,21 @@ AT_SETUP([gprs-bssgp]) AT_KEYWORDS([gprs-bssgp]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/gb/gprs_bssgp_test]) cat $abs_srcdir/gb/gprs_bssgp_test.ok > expout AT_CHECK([$abs_top_builddir/tests/gb/gprs_bssgp_test], [0], [expout], [ignore]) AT_CLEANUP AT_SETUP([gprs-bssgp-rim]) AT_KEYWORDS([gprs-bssgp-rim]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/gb/gprs_bssgp_rim_test]) cat $abs_srcdir/gb/gprs_bssgp_rim_test.ok > expout AT_CHECK([$abs_top_builddir/tests/gb/gprs_bssgp_rim_test], [0], [expout], [ignore]) AT_CLEANUP AT_SETUP([gprs-ns]) AT_KEYWORDS([gprs-ns]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/gb/gprs_ns_test]) cat $abs_srcdir/gb/gprs_ns_test.ok > expout cat $abs_srcdir/gb/gprs_ns_test.err > experr AT_CHECK([$abs_top_builddir/tests/gb/gprs_ns_test], [0], [expout], [experr]) @@ -283,6 +289,7 @@ AT_SETUP([gprs-ns2]) AT_KEYWORDS([gprs-ns2]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/gb/gprs_ns2_test]) cat $abs_srcdir/gb/gprs_ns2_test.ok > expout cat $abs_srcdir/gb/gprs_ns2_test.err > experr AT_CHECK([$abs_top_builddir/tests/gb/gprs_ns2_test], [0], [expout], [experr]) @@ -290,6 +297,7 @@ AT_SETUP([utils]) AT_KEYWORDS([utils]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/utils/utils_test]) cat $abs_srcdir/utils/utils_test.ok > expout cat $abs_srcdir/utils/utils_test.err > experr AT_CHECK([$abs_top_builddir/tests/utils/utils_test], [0], [expout], [experr]) @@ -297,6 +305,7 @@ AT_SETUP([stats]) AT_KEYWORDS([stats]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/stats/stats_test]) cat $abs_srcdir/stats/stats_test.ok > expout cat $abs_srcdir/stats/stats_test.err > experr AT_CHECK([$abs_top_builddir/tests/stats/stats_test], [0], [expout], [experr]) @@ -310,6 +319,7 @@ AT_SETUP([bssgp-fc]) AT_KEYWORDS([bssgp-fc]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/gb/bssgp_fc_test]) cat $abs_srcdir/gb/bssgp_fc_tests.ok > expout cat $abs_srcdir/gb/bssgp_fc_tests.err > experr AT_CHECK([$abs_top_srcdir/tests/gb/bssgp_fc_tests.sh $abs_top_builddir/tests/gb], [0], [expout], [experr]) @@ -342,6 +352,7 @@ AT_SETUP([gsup]) AT_KEYWORDS([gsup]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/gsup/gsup_test]) cat $abs_srcdir/gsup/gsup_test.ok > expout cat $abs_srcdir/gsup/gsup_test.err > experr AT_CHECK([$abs_top_builddir/tests/gsup/gsup_test], [0], [expout], [experr]) @@ -349,6 +360,7 @@ AT_SETUP([fsm]) AT_KEYWORDS([fsm]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/fsm/fsm_test]) cat $abs_srcdir/fsm/fsm_test.ok > expout cat $abs_srcdir/fsm/fsm_test.err > experr AT_CHECK([$abs_top_builddir/tests/fsm/fsm_test], [0], [expout], [experr]) @@ -356,6 +368,7 @@ AT_SETUP([fsm_dealloc]) AT_KEYWORDS([fsm_dealloc]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/fsm/fsm_dealloc_test]) cat $abs_srcdir/fsm/fsm_dealloc_test.err > experr AT_CHECK([$abs_top_builddir/tests/fsm/fsm_dealloc_test], [0], [ignore], [experr]) AT_CLEANUP @@ -383,7 +396,7 @@ AT_SETUP([socket_sctp]) AT_KEYWORDS([socket_sctp]) -AT_SKIP_IF([! test -e $abs_top_builddir/tests/socket/socket_sctp_test]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/socket/socket_sctp_test]) cat $abs_srcdir/socket/socket_sctp_test.ok > expout cat $abs_srcdir/socket/socket_sctp_test.err > experr AT_CHECK([$abs_top_builddir/tests/socket/socket_sctp_test], [0], [expout], [experr]) @@ -454,6 +467,7 @@ AT_SETUP([exec]) AT_KEYWORDS([exec]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/exec/exec_test]) cat $abs_srcdir/exec/exec_test.ok > expout cat $abs_srcdir/exec/exec_test.err > experr AT_CHECK([$abs_top_builddir/tests/exec/exec_test], [0], [expout], [experr]) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41364?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7e9a0c84e510964e5d577e371d41f2023ab20840 Gerrit-Change-Number: 41364 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: tests/testsuite.at: use AT_SKIP_IF for sim_test
by laforge 09 Nov '25

09 Nov '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41363?usp=email ) Change subject: tests/testsuite.at: use AT_SKIP_IF for sim_test ...................................................................... tests/testsuite.at: use AT_SKIP_IF for sim_test Whether to run the given test or not can be determined by presence of the respective `*_test` binary, since we build them conditionally in the `Makefile.am`. Get rid of more complicated logic by using AT_SKIP_IF and checking presence of `tests/sim/sim_test`. Change-Id: Ic90b3a39936888eda6c9d443420c4faa131ac78f --- M .gitignore M configure.ac M tests/Makefile.am D tests/atlocal.in M tests/testsuite.at 5 files changed, 2 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/.gitignore b/.gitignore index b14f67c..907743f 100644 --- a/.gitignore +++ b/.gitignore @@ -61,7 +61,6 @@ #gnu autotest tests/package.m4 tests/atconfig -tests/atlocal tests/osmo-test tests/package.m4 tests/testsuite diff --git a/configure.ac b/configure.ac index 120500f..6a5f0c0 100644 --- a/configure.ac +++ b/configure.ac @@ -650,7 +650,6 @@ src/pseudotalloc/Makefile tapset/Makefile tests/Makefile - tests/atlocal tests/osmo-config-merge/Makefile utils/Makefile utils/osmo-stat-dummy/Makefile diff --git a/tests/Makefile.am b/tests/Makefile.am index 929cade..f98d67c 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -534,7 +534,7 @@ endif endif -DISTCLEANFILES = atconfig atlocal conv/gsm0503_test_vectors.c +DISTCLEANFILES = atconfig conv/gsm0503_test_vectors.c BUILT_SOURCES = conv/gsm0503_test_vectors.c noinst_HEADERS = conv/conv.h diff --git a/tests/atlocal.in b/tests/atlocal.in deleted file mode 100644 index cd27532..0000000 --- a/tests/atlocal.in +++ /dev/null @@ -1 +0,0 @@ -enable_sim_test='@ENABLE_PCSC@' diff --git a/tests/testsuite.at b/tests/testsuite.at index 82758b7..1c9a97e 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -317,7 +317,7 @@ AT_SETUP([sim]) AT_KEYWORDS([sim]) -AT_CHECK([test "x$enable_sim_test" = xyes || exit 77]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/sim/sim_test]) cat $abs_srcdir/sim/sim_test.ok > expout AT_CHECK([$abs_top_builddir/tests/sim/sim_test], [0], [expout], [ignore]) AT_CLEANUP -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41363?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic90b3a39936888eda6c9d443420c4faa131ac78f Gerrit-Change-Number: 41363 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: tests/testsuite.at: fix invalid if-endif syntax
by laforge 09 Nov '25

09 Nov '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41362?usp=email ) Change subject: tests/testsuite.at: fix invalid if-endif syntax ...................................................................... tests/testsuite.at: fix invalid if-endif syntax `make check` currently fails if libosmocore is configured with `--disable-msgfile`. The reason is that the testsuite tries to execte a binary that does not exist. This is happening because the if-endif syntax is invalid and thus ignored. Change-Id: I81e044dc0bda4674c0d0dc46118d46816712a76c --- M tests/testsuite.at 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/tests/testsuite.at b/tests/testsuite.at index f22ca5a..82758b7 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -81,13 +81,12 @@ AT_CHECK([$abs_top_builddir/tests/gea/gea_test], [0], [expout]) AT_CLEANUP -if ENABLE_MSGFILE AT_SETUP([msgfile]) AT_KEYWORDS([msgfile]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/msgfile/msgfile_test]) cat $abs_srcdir/msgfile/msgfile_test.ok > expout AT_CHECK([$abs_top_builddir/tests/msgfile/msgfile_test $abs_srcdir/msgfile/msgconfig.cfg], [0], [expout]) AT_CLEANUP -endif AT_SETUP([sms]) AT_KEYWORDS([sms]) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41362?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I81e044dc0bda4674c0d0dc46118d46816712a76c Gerrit-Change-Number: 41362 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: tests/testsuite.at: fix invalid if-endif syntax
by laforge 09 Nov '25

09 Nov '25

Attention is currently required from: fixeria, lynxis lazus, pespin. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/41362?usp=email ) Change subject: tests/testsuite.at: fix invalid if-endif syntax ...................................................................... Patch Set 1: (1 comment) File tests/testsuite.at: https://gerrit.osmocom.org/c/libosmocore/+/41362/comment/59c6a4e7_c91c38b4?… : PS1, Line 86: AT_SKIP_IF([test ! -e $abs_top_builddir/tests/msgfile/msgfile_test]) > I would like in general spent more time on a different build system, than trying to debug the curren […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41362?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I81e044dc0bda4674c0d0dc46118d46816712a76c Gerrit-Change-Number: 41362 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 08 Nov 2025 13:45:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in libosmocore[master]: tests/testsuite.at: use AT_SKIP_IF for sim_test
by laforge 09 Nov '25

09 Nov '25

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/41363?usp=email ) Change subject: tests/testsuite.at: use AT_SKIP_IF for sim_test ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41363?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic90b3a39936888eda6c9d443420c4faa131ac78f Gerrit-Change-Number: 41363 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 08 Nov 2025 13:44:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: lint/lint_diff: test_ruff: add pyosmocom
by laforge 09 Nov '25

09 Nov '25

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41387?usp=email ) Change subject: lint/lint_diff: test_ruff: add pyosmocom ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41387?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2fdb36c79efbd0f0fb4bdce3cd0045bb35d4cf64 Gerrit-Change-Number: 41387 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 08 Nov 2025 13:43:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...pyosmocom[master]: Fix lint errors: do not use bare except
by laforge 09 Nov '25

09 Nov '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41383?usp=email ) Change subject: Fix lint errors: do not use bare except ...................................................................... Fix lint errors: do not use bare except src/osmocom/construct.py:90:9: E722 Do not use bare `except` | 88 | ad = GsmString(GreedyBytes) 89 | return ad._encode(obj, context, path) 90 | except: | ^^^^^^ E722 91 | ad = Ucs2Adapter(GreedyBytes) 92 | return ad._encode(obj, context, path) Change-Id: Ia5fe852b6d990ad728fc3dedc7012c8fced92e13 --- M src/osmocom/construct.py M src/osmocom/utils.py 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, approved diff --git a/src/osmocom/construct.py b/src/osmocom/construct.py index 693f365..d369bc7 100644 --- a/src/osmocom/construct.py +++ b/src/osmocom/construct.py @@ -89,7 +89,7 @@ try: ad = GsmString(GreedyBytes) return ad._encode(obj, context, path) - except: + except Exception: ad = Ucs2Adapter(GreedyBytes) return ad._encode(obj, context, path) diff --git a/src/osmocom/utils.py b/src/osmocom/utils.py index 347bb93..3991da2 100644 --- a/src/osmocom/utils.py +++ b/src/osmocom/utils.py @@ -209,7 +209,7 @@ try: _try_encode = h2b(string) return True - except: + except Exception: return False ######################################################################### -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41383?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Ia5fe852b6d990ad728fc3dedc7012c8fced92e13 Gerrit-Change-Number: 41383 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in ...pyosmocom[master]: Fix lint errors: unused imports
by laforge 09 Nov '25

09 Nov '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41381?usp=email ) Change subject: Fix lint errors: unused imports ...................................................................... Fix lint errors: unused imports This is the first patch in a series to address everything found with "ruff check", so we can run it in CI (additionally to pylint) and locally as pre-commit hook. Change-Id: Ie71039d05e9a7cc8b65543c9475b35adcb458f7e --- M src/osmocom/construct.py M src/osmocom/gsmtap.py M src/osmocom/gsup/message.py 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/osmocom/construct.py b/src/osmocom/construct.py index 5e062c3..31e2a77 100644 --- a/src/osmocom/construct.py +++ b/src/osmocom/construct.py @@ -4,7 +4,8 @@ import codecs import ipaddress -import gsm0338 +# Not an unused import: registers the gsm0338 codec +import gsm0338 # noqa: F401 # pylint: disable=import-error,no-name-in-module diff --git a/src/osmocom/gsmtap.py b/src/osmocom/gsmtap.py index f21ba03..60d7ee4 100644 --- a/src/osmocom/gsmtap.py +++ b/src/osmocom/gsmtap.py @@ -23,7 +23,6 @@ # import socket -from construct import Optional as COptional from construct import Int8ub, Int8sb, Int32ub, BitStruct, Enum, GreedyBytes, Struct, Switch from construct import this, PaddedString, Flag, BitsInteger, Bytes from osmocom.construct import * diff --git a/src/osmocom/gsup/message.py b/src/osmocom/gsup/message.py index e48cd54..31fab2c 100644 --- a/src/osmocom/gsup/message.py +++ b/src/osmocom/gsup/message.py @@ -30,7 +30,7 @@ from construct import Optional as COptional from osmocom.tlv import TLV_IE, TLV_IE_Collection -from osmocom.construct import TonNpi, Rpad, OsmoRatType +from osmocom.construct import TonNpi, OsmoRatType from osmocom.construct import PaddedBcdAdapter, DnsAdapter, Ipv4Adapter, Ipv6Adapter class GSUP_TLV_IE(TLV_IE): -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41381?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Ie71039d05e9a7cc8b65543c9475b35adcb458f7e Gerrit-Change-Number: 41381 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log November 2025