November 2025 - gerrit-log - lists.osmocom.org

[S] Change in ...pyosmocom[master]: Fix lint errors: remove unnecessary semicolons
by laforge 09 Nov '25

09 Nov '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41382?usp=email ) Change subject: Fix lint errors: remove unnecessary semicolons ...................................................................... Fix lint errors: remove unnecessary semicolons Change-Id: I8c8586476d12461d555a2278ef936256944c9cde --- M src/osmocom/construct.py M tests/test_tlv.py 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmocom/construct.py b/src/osmocom/construct.py index 31e2a77..693f365 100644 --- a/src/osmocom/construct.py +++ b/src/osmocom/construct.py @@ -464,7 +464,7 @@ if self.steps == []: return obj else: - return obj_step_aligned; + return obj_step_aligned class StripHeaderAdapter(Adapter): """ @@ -507,7 +507,7 @@ if self.steps == []: return obj else: - return obj_step_aligned; + return obj_step_aligned def filter_dict(d, exclude_prefix='_'): """filter the input dict to ensure no keys starting with 'exclude_prefix' remain.""" diff --git a/tests/test_tlv.py b/tests/test_tlv.py index 894ef63..3af1e07 100755 --- a/tests/test_tlv.py +++ b/tests/test_tlv.py @@ -45,7 +45,7 @@ self.assertEqual(bertlv_parse_len(b'\x83\x12\x34\x56\x78'), (0x123456, b'\x78')) def test_BerTlvParseOne(self): - res = bertlv_parse_one(b'\x81\x01\x01'); + res = bertlv_parse_one(b'\x81\x01\x01') self.assertEqual(res, ({'tag':1, 'constructed':False, 'class':2}, 1, b'\x01', b'')) class TestComprTlv(unittest.TestCase): @@ -127,7 +127,7 @@ class XC_constr_class(Transcodable): _construct = Int8ub def __init__(self): - super().__init__(); + super().__init__() def test_XC_constr_class(self): """Transcodable derived class with _construct class variable""" @@ -137,7 +137,7 @@ class XC_constr_instance(Transcodable): def __init__(self): - super().__init__(); + super().__init__() self._construct = Int8ub def test_XC_constr_instance(self): @@ -148,7 +148,7 @@ class XC_method_instance(Transcodable): def __init__(self): - super().__init__(); + super().__init__() def _from_bytes(self, do): return ('decoded', do) def _to_bytes(self): -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41382?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I8c8586476d12461d555a2278ef936256944c9cde Gerrit-Change-Number: 41382 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in ...pyosmocom[master]: README: mention the pypi package
by laforge 09 Nov '25

09 Nov '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41380?usp=email ) Change subject: README: mention the pypi package ...................................................................... README: mention the pypi package Make it easy for users to verify that the pyosmocom project from pypi comes from the maintainers of this repository by clicking the URL and finding the "pip install pyosmocom" line in the README. Change-Id: Iac6fcbc1b5f0caa4cf63de5b8effe46d731080bc --- M README.md 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/README.md b/README.md index 1d98601..c97a8ac 100644 --- a/README.md +++ b/README.md @@ -10,3 +10,9 @@ * utilities for common problems found in mobile communications * TLV parsers/encoders * helpers for 'construct' based encoders/decoders + +Releases get published to [pypi](https://pypi.org/project/pyosmocom/) and can +be installed with: +``` +$ pip install pyosmocom +``` -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41380?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Iac6fcbc1b5f0caa4cf63de5b8effe46d731080bc Gerrit-Change-Number: 41380 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in ...pyosmocom[master]: Fix lint errors: test for membership should be `not in`
by laforge 09 Nov '25

09 Nov '25

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41386?usp=email ) Change subject: Fix lint errors: test for membership should be `not in` ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41386?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I2ca3135f1ce38dcc06dc95c38f4b6258a60121cd Gerrit-Change-Number: 41386 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 08 Nov 2025 13:43:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...pyosmocom[master]: Fix lint errors: avoid equality comparisons to `False`
by laforge 09 Nov '25

09 Nov '25

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41385?usp=email ) Change subject: Fix lint errors: avoid equality comparisons to `False` ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41385?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I2ebb33c498b4a7e6229980462aa51b579fa4f782 Gerrit-Change-Number: 41385 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 08 Nov 2025 13:43:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...pyosmocom[master]: Fix lint errors: don't use star imports
by laforge 09 Nov '25

09 Nov '25

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41384?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: Fix lint errors: don't use star imports ...................................................................... Patch Set 2: Code-Review-2 (1 comment) Patchset: PS2: -2 as otherwise it remains submittable and might get overlooked. -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41384?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I0ca76a40d47f72635682de9303ff73e9b2197266 Gerrit-Change-Number: 41384 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 08 Nov 2025 13:42:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in ...pyosmocom[master]: Fix lint errors: don't use star imports
by laforge 09 Nov '25

09 Nov '25

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41384?usp=email ) Change subject: Fix lint errors: don't use star imports ...................................................................... Patch Set 2: Code-Review-1 (1 comment) File tests/test_construct.py: https://gerrit.osmocom.org/c/python/pyosmocom/+/41384/comment/5d22a710_e792… : PS2, Line 8: DnsAdapter, we're not using this parenthesized list with one item per line anywhere else. I'm not sure we should introduce completely different coding style all of a sudden? -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41384?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I0ca76a40d47f72635682de9303ff73e9b2197266 Gerrit-Change-Number: 41384 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 08 Nov 2025 13:42:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...pyosmocom[master]: Fix lint errors: do not use bare except
by laforge 09 Nov '25

09 Nov '25

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41383?usp=email ) Change subject: Fix lint errors: do not use bare except ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41383?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Ia5fe852b6d990ad728fc3dedc7012c8fced92e13 Gerrit-Change-Number: 41383 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 08 Nov 2025 13:40:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...pyosmocom[master]: Fix lint errors: remove unnecessary semicolons
by laforge 09 Nov '25

09 Nov '25

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41382?usp=email ) Change subject: Fix lint errors: remove unnecessary semicolons ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41382?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I8c8586476d12461d555a2278ef936256944c9cde Gerrit-Change-Number: 41382 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 08 Nov 2025 13:40:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...pyosmocom[master]: Fix lint errors: unused imports
by laforge 09 Nov '25

09 Nov '25

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41381?usp=email ) Change subject: Fix lint errors: unused imports ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41381?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Ie71039d05e9a7cc8b65543c9475b35adcb458f7e Gerrit-Change-Number: 41381 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 08 Nov 2025 13:39:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...pyosmocom[master]: README: mention the pypi package
by laforge 09 Nov '25

09 Nov '25

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41380?usp=email ) Change subject: README: mention the pypi package ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41380?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Iac6fcbc1b5f0caa4cf63de5b8effe46d731080bc Gerrit-Change-Number: 41380 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 08 Nov 2025 13:39:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log November 2025