Attention is currently required from: fixeria, laforge, pespin.
daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41400?usp=email )
Change subject: sccplite: Handle MGCP/CTRL over SCCPLite multiplex using MTP-TRANSFER.req/ind
......................................................................
Patch Set 4: Code-Review-1
(2 comments)
File src/osmo-bsc/osmo_bsc_mgcp.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/41400/comment/a4859cb4_f3232fe3?usp… :
PS4, Line 160: msg = msgb_alloc_headroom(1400, 64, "MGCP->IPA");
Is this related to the rest of the patch?
File src/osmo-bsc/osmo_bsc_sigtran.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/41400/comment/40b8ac49_fe1cdd48?usp… :
PS4, Line 466: }
I think you're missing a return/error handling here
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41400?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I567ed206eab1add21836bfd937f3790d3d7a00d7
Gerrit-Change-Number: 41400
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Nov 2025 14:46:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria, laforge, osmith, pespin.
Hello Jenkins Builder, fixeria, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/41444?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by osmith, Verified-1 by Jenkins Builder
Change subject: hnb: Allow setting Iuh tx-queue-max-length per HNB
......................................................................
hnb: Allow setting Iuh tx-queue-max-length per HNB
Related: SYS#7693
Depends: libosmo-netif.git Change-Id Ibc68612bd8dee4f9b8031ce2c3f5c7ff6bb639e3
Change-Id: Ibf69a5a2e6ff8d6829320efe793c6368aa542102
---
M TODO-RELEASE
M include/osmocom/hnbgw/hnb.h
M include/osmocom/hnbgw/hnb_persistent.h
M src/osmo-hnbgw/hnb.c
M src/osmo-hnbgw/hnb_persistent.c
M src/osmo-hnbgw/hnbgw_vty.c
M tests/osmo-hnbgw.vty
7 files changed, 69 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/44/41444/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/41444?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ibf69a5a2e6ff8d6829320efe793c6368aa542102
Gerrit-Change-Number: 41444
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: laforge, osmith.
Hello Jenkins Builder, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/41436?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by osmith, Verified+1 by Jenkins Builder
Change subject: iuh: Allow setting tx-queue-max-length for all HNBs
......................................................................
iuh: Allow setting tx-queue-max-length for all HNBs
Related: SYS#7693
Change-Id: I8bc9e8bae7a4815dc2f2bc9e15401e01948d1748
---
M include/osmocom/hnbgw/hnbgw.h
M src/osmo-hnbgw/hnbgw.c
M src/osmo-hnbgw/hnbgw_vty.c
M src/osmo-hnbgw/osmo_hnbgw_main.c
M tests/osmo-hnbgw.vty
5 files changed, 42 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/36/41436/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/41436?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I8bc9e8bae7a4815dc2f2bc9e15401e01948d1748
Gerrit-Change-Number: 41436
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Attention is currently required from: fixeria, laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/41444?usp=email )
Change subject: hnb: Allow setting Iuh tx-queue-max-length per HNB
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-hnbgw/hnb.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/41444/comment/954a599e_94a1c7b9?u… :
PS1, Line 219: >=
> why would we permit a queue length == 0? Shouldn't it be > 0?
Allowing 0 allows temporarily blocking Tx, which can be useful eg. to test enqueuing a lot, then do bursty traffic, etc. I think it's fine allowing it.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/41444?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ibf69a5a2e6ff8d6829320efe793c6368aa542102
Gerrit-Change-Number: 41444
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Nov 2025 14:31:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>