laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41489?usp=email )
Change subject: s1gw: correct handling of UE CONTEXT RELEASE REQUEST
......................................................................
s1gw: correct handling of UE CONTEXT RELEASE REQUEST
By sending a UE CONTEXT RELEASE REQUEST, the eNB is requesting the
MME to terminate the UE context. This procedure itself does not
terminate the UE context nor the associated E-RABs. Therefore, the
S1GW should not terminate E-RAB FSMs upon receiving this PDU.
This means that we should not be expecting PFCP sesstion(s)
to be deleted in S1GW_ConnHdlr.f_ConnHdlr_ue_ctx_release_req().
Change-Id: Ibbb6da1f2888995608b980e7479758000e94864e
Related: osmo-s1gw.git If467162e871b7989f0578be30c04d1c32c263c99
Related: SYS#7738, SYS#7599
---
M s1gw/S1GW_ConnHdlr.ttcn
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn
index 013d7bf..b850f55 100644
--- a/s1gw/S1GW_ConnHdlr.ttcn
+++ b/s1gw/S1GW_ConnHdlr.ttcn
@@ -1662,7 +1662,6 @@
log("[eNB -> S1GW] -> MME: UE CONTEXT RELEASE REQUEST");
f_ConnHdlr_tx_s1ap_from_enb(ts_S1AP_UeContextReleaseReq(mme_ue_id, enb_ue_id, cause));
- f_ConnHdlr_session_delete(erabs);
log("eNB -> [S1GW -> MME]: UE CONTEXT RELEASE REQUEST");
f_ConnHdlr_rx_s1ap_from_enb(pdu, tr_S1AP_UeContextReleaseReq(mme_ue_id, enb_ue_id, cause));
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41489?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibbb6da1f2888995608b980e7479758000e94864e
Gerrit-Change-Number: 41489
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria, laforge, pespin.
falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41252?usp=email )
Change subject: trau: add AMR TRAU frame interworking facility
......................................................................
Patch Set 18:
(1 comment)
Patchset:
PS18:
> Is there any plan to use any of this in any osmocom program?
Please refer to the recent thread on OpenBSC ML in which I asked for feedback regarding potential integration of tw-e1abis-mgw into Osmocom. As a little update for the present situation, I am still not smart enough to come up with a way to merge the functionality of my new E1 Abis MGW into osmo-mgw, coexisting with all of complex rtpbridge functionality of osmo-mgw in the same process on the same MGCP port. However, the other option which I proposed on the ML, namely creating something like osmo-e1-mgw (or whatever name the community finds appropriate) that would be an Osmo-branded adoption of tw-e1abis-mgw code base, is still a possibility, **if** the community is interested. If the community is interested in the possibility of such integration of improved E1 Abis MGW functionality, then library additions like the present patch under consideration need to go into mainline libosmo*.
The other alternative would be to withdraw the presently proposed patch to libosmotrau and put these functions into a ThemWi library instead. However, that alternative would further preclude the already difficult idea of merging the improved E1 Abis MGW functionality into Osmocom - and I thought the community does desire that functionality...
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41252?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I42706c2f68ed29aff1bf451b37e783983f8de3b0
Gerrit-Change-Number: 41252
Gerrit-PatchSet: 18
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 24 Nov 2025 18:00:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: jolly, laforge.
fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email )
Change subject: Add ER-GSM band support to all relevant applications
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File src/shared/libosmocore/src/gsm/gsm_utils.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/41359/comment/8755699a_fe220cde?u… :
PS3, Line 484: else if (arfcn >= 940 && arfcn <= 1023)
> AFAICT the libosmocore directory changes where not yet split int o a separate commit which contains […]
This actually has been done, see https://gerrit.osmocom.org/c/osmocom-bb/+/41392.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I71baa3317df685cf6479b6e20e6ae078911aa24f
Gerrit-Change-Number: 41359
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 24 Nov 2025 16:16:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>