Attention is currently required from: daniel, fixeria, laforge, osmith.
Hello Jenkins Builder, daniel, fixeria, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41486?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by osmith, Verified+1 by Jenkins Builder
Change subject: RAN_Emulation: Proper operation indication in RANAP_Connect prim to upper layers
......................................................................
RAN_Emulation: Proper operation indication in RANAP_Connect prim to upper layers
Change-Id: Id39c68a0408fdc90304d8089dd200274eb843a8d
---
M hnbgw/ConnHdlr.ttcn
M library/RAN_Emulation.ttcnpp
2 files changed, 29 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/86/41486/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41486?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id39c68a0408fdc90304d8089dd200274eb843a8d
Gerrit-Change-Number: 41486
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Attention is currently required from: daniel, fixeria, laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41486?usp=email )
Change subject: RAN_Emulation: Proper operation indication in RANAP_Connect prim to upper layers
......................................................................
Patch Set 2:
(2 comments)
File library/RAN_Emulation.ttcnpp:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41486/comment/c366a486_c7b7… :
PS2, Line 660: tr_RANAP_Conn_Ind
> The first two params should be `(present)`.
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41486/comment/40b1da08_999e… :
PS2, Line 662: template (omit) RANAP_PDU ranap := omit
> Using `(omit)` in receive templates is wrong, since it does not permit `*`.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41486?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id39c68a0408fdc90304d8089dd200274eb843a8d
Gerrit-Change-Number: 41486
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 24 Nov 2025 11:00:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41485?usp=email )
Change subject: RAN_Emulation: Fix error: CLIENT multiple conns requires explicit addressing
......................................................................
RAN_Emulation: Fix error: CLIENT multiple conns requires explicit addressing
Fixes fynamic test error during HNBGW_Tests.TC_sccp_cr_limit:
Dynamic test case error: Port CLIENT has more than one active connections. Message can be sent on it only with explicit addressing.
Related: SYS#7600
Change-Id: Icb038e041bd5e82f95141e1814571d7c7f75878b
---
M library/RAN_Emulation.ttcnpp
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
fixeria: Looks good to me, but someone else must approve
osmith: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/library/RAN_Emulation.ttcnpp b/library/RAN_Emulation.ttcnpp
index bc691a6..aa98b04 100644
--- a/library/RAN_Emulation.ttcnpp
+++ b/library/RAN_Emulation.ttcnpp
@@ -1081,7 +1081,7 @@
f_handle_userData_RANAP(vc_conn, rconn_ind.userData);
} else {
/* Notify client that we received an SCCP CR without user data */
- CLIENT.send(ts_RANAP_Conn_Req(rconn_ind.callingAddress, rconn_ind.calledAddress, omit));
+ CLIENT.send(ts_RANAP_Conn_Req(rconn_ind.callingAddress, rconn_ind.calledAddress, omit)) to vc_conn;
}
if (g_ran_ops.ranap_connect_ind_auto_res) {
/* confirm connection establishment */
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41485?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Icb038e041bd5e82f95141e1814571d7c7f75878b
Gerrit-Change-Number: 41485
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: daniel, laforge, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41486?usp=email )
Change subject: RAN_Emulation: Proper operation indication in RANAP_Connect prim to upper layers
......................................................................
Patch Set 2:
(2 comments)
File library/RAN_Emulation.ttcnpp:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41486/comment/cdee073c_5afc… :
PS2, Line 660: tr_RANAP_Conn_Ind
The first two params should be `(present)`.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41486/comment/66fba0f8_3203… :
PS2, Line 662: template (omit) RANAP_PDU ranap := omit
Using `(omit)` in receive templates is wrong, since it does not permit `*`.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41486?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id39c68a0408fdc90304d8089dd200274eb843a8d
Gerrit-Change-Number: 41486
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 24 Nov 2025 09:40:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/41483?usp=email )
Change subject: Split UPF into its own object
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/41483?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I624bafe2fa150f7480b6fb44433c34e83154e06c
Gerrit-Change-Number: 41483
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 24 Nov 2025 08:26:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes