November 2025 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: ss7_xua_srv: Make sure we don't accept conns for ASPs configured as t...
by osmith 25 Nov '25

25 Nov '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41501?usp=email ) Change subject: ss7_xua_srv: Make sure we don't accept conns for ASPs configured as transport-role client ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41501?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I955aed3c6cdaa0a7eaa14150eeb7458ee9b41d9d Gerrit-Change-Number: 41501 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Nov 2025 12:43:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: ss7_xua_server_destroy(): Disconnect streams properly
by osmith 25 Nov '25

25 Nov '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41500?usp=email ) Change subject: ss7_xua_server_destroy(): Disconnect streams properly ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41500?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1309015053d2bd22d8fdf6298f8918a47527340e Gerrit-Change-Number: 41500 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Nov 2025 12:42:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: ss7_asp: Do AS-eSLS table cleanup during osmo_ss7_asp_destroy()
by osmith 25 Nov '25

25 Nov '25

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41499?usp=email ) Change subject: ss7_asp: Do AS-eSLS table cleanup during osmo_ss7_asp_destroy() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41499?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2c1b25d3e76703b88111b9935685a58d039b8e23 Gerrit-Change-Number: 41499 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 25 Nov 2025 12:42:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: ss7_xua_srv: Make sure we don't accept conns for ASPs configured as t...
by pespin 25 Nov '25

25 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41501?usp=email ) Change subject: ss7_xua_srv: Make sure we don't accept conns for ASPs configured as transport-role client ...................................................................... ss7_xua_srv: Make sure we don't accept conns for ASPs configured as transport-role client Change-Id: I955aed3c6cdaa0a7eaa14150eeb7458ee9b41d9d --- M src/ss7_xua_srv.c 1 file changed, 17 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/01/41501/1 diff --git a/src/ss7_xua_srv.c b/src/ss7_xua_srv.c index a97b07f..7e55777 100644 --- a/src/ss7_xua_srv.c +++ b/src/ss7_xua_srv.c @@ -75,13 +75,23 @@ LOGP(DLSS7, LOGL_INFO, "%s: New %s connection accepted\n", sock_name, proto_name); asp = ss7_asp_find_by_socket_addr(fd, oxs->cfg.trans_proto); - if (asp && asp->cfg.adm_state == OSMO_SS7_ASP_ADM_S_SHUTDOWN) { - LOGPASP(asp, DLSS7, LOGL_NOTICE, - "Reject incoming new connection from %s for ASP in adm state %s\n", - sock_name, get_value_string(osmo_ss7_asp_admin_state_names, asp->cfg.adm_state)); - close(fd); - talloc_free(sock_name); - return 0; + if (asp) { + if (!asp->cfg.is_server) { + LOGPASP(asp, DLSS7, LOGL_NOTICE, + "Reject incoming new connection from %s for ASP configured as 'transport-role client'\n", + sock_name); + close(fd); + talloc_free(sock_name); + return 0; + } + if (asp->cfg.adm_state == OSMO_SS7_ASP_ADM_S_SHUTDOWN) { + LOGPASP(asp, DLSS7, LOGL_NOTICE, + "Reject incoming new connection from %s for ASP in adm state %s\n", + sock_name, get_value_string(osmo_ss7_asp_admin_state_names, asp->cfg.adm_state)); + close(fd); + talloc_free(sock_name); + return 0; + } } srv = osmo_stream_srv_create2(oxs, link, fd, NULL); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41501?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I955aed3c6cdaa0a7eaa14150eeb7458ee9b41d9d Gerrit-Change-Number: 41501 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: ss7_xua_server_destroy(): Disconnect streams properly
by pespin 25 Nov '25

25 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41500?usp=email ) Change subject: ss7_xua_server_destroy(): Disconnect streams properly ...................................................................... ss7_xua_server_destroy(): Disconnect streams properly destroying ASPs is wrong, since that'd also destroy non-dynamic ASPs, hence erasing the configuration. Instead, close oly the stream, and dynamic ASPs get destroyed as a consequence. Change-Id: I1309015053d2bd22d8fdf6298f8918a47527340e --- M src/ss7_xua_srv.c 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/00/41500/1 diff --git a/src/ss7_xua_srv.c b/src/ss7_xua_srv.c index 077eea0..a97b07f 100644 --- a/src/ss7_xua_srv.c +++ b/src/ss7_xua_srv.c @@ -397,11 +397,13 @@ if (xs->server) { osmo_stream_srv_link_close(xs->server); osmo_stream_srv_link_destroy(xs->server); + xs->server = NULL; } - /* iterate and close all connections established in relation - * with this server */ + + /* iterate and close all connections established in relation with this server. + * Dynamic ASPs in SCTP=server are destroyed when connection is closed. */ llist_for_each_entry_safe(asp, asp2, &xs->asp_list, siblings) - osmo_ss7_asp_destroy(asp); + ss7_asp_disconnect_stream(asp); llist_del(&xs->list); talloc_free(xs); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41500?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1309015053d2bd22d8fdf6298f8918a47527340e Gerrit-Change-Number: 41500 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: ss7_asp: Do AS-eSLS table cleanup during osmo_ss7_asp_destroy()
by pespin 25 Nov '25

25 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41499?usp=email ) Change subject: ss7_asp: Do AS-eSLS table cleanup during osmo_ss7_asp_destroy() ...................................................................... ss7_asp: Do AS-eSLS table cleanup during osmo_ss7_asp_destroy() Use the existing API to cleanly remove the association between ASP and AS. Change-Id: I2c1b25d3e76703b88111b9935685a58d039b8e23 --- M src/ss7_asp.c 1 file changed, 3 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/99/41499/1 diff --git a/src/ss7_asp.c b/src/ss7_asp.c index 644c192..5325de9 100644 --- a/src/ss7_asp.c +++ b/src/ss7_asp.c @@ -760,13 +760,9 @@ llist_del(&asp->siblings); /* unlink from all ASs we are part of */ - llist_for_each_entry(as, &asp->inst->as_list, list) { - unsigned int i; - for (i = 0; i < ARRAY_SIZE(as->cfg.asps); i++) { - if (as->cfg.asps[i] == asp) - as->cfg.asps[i] = NULL; - } - } + llist_for_each_entry(as, &asp->inst->as_list, list) + ss7_as_del_asp(as, asp); + /* unlink from ss7_instance */ asp->inst = NULL; llist_del(&asp->list); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41499?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2c1b25d3e76703b88111b9935685a58d039b8e23 Gerrit-Change-Number: 41499 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: xua_rkm: Avoid unnecesary ASP lookup by name
by osmith 25 Nov '25

25 Nov '25

Attention is currently required from: daniel, fixeria, lynxis lazus, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41498?usp=email ) Change subject: xua_rkm: Avoid unnecesary ASP lookup by name ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41498?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I5ca8f0180a0389d5de7b495cfe9f769985296383 Gerrit-Change-Number: 41498 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 25 Nov 2025 12:05:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: Build libosmo-sigtran with --enable-tcap-loadsharing
by osmith 25 Nov '25

25 Nov '25

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41497?usp=email ) Change subject: testenv: Build libosmo-sigtran with --enable-tcap-loadsharing ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41497?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7b29d00befa94412bef56a4b8e4d788674028b12 Gerrit-Change-Number: 41497 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 25 Nov 2025 12:03:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-dev[master]: all.desp: libosmo-sigtran depends on libosmo-asn1-tcap
by osmith 25 Nov '25

25 Nov '25

Attention is currently required from: daniel, fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-dev/+/41496?usp=email ) Change subject: all.desp: libosmo-sigtran depends on libosmo-asn1-tcap ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/41496?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ibc51a818b859d40ab8a34d9299d0f955cf6d966e Gerrit-Change-Number: 41496 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Nov 2025 12:01:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: xua_rkm: Avoid unnecesary ASP lookup by name
by pespin 25 Nov '25

25 Nov '25

Attention is currently required from: daniel, fixeria, lynxis lazus, osmith, pespin. Hello Jenkins Builder, daniel, fixeria, lynxis lazus, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41498?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: xua_rkm: Avoid unnecesary ASP lookup by name ...................................................................... xua_rkm: Avoid unnecesary ASP lookup by name Change-Id: I5ca8f0180a0389d5de7b495cfe9f769985296383 --- M src/ss7_as.c M src/ss7_as.h M src/xua_rkm.c 3 files changed, 19 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/98/41498/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41498?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I5ca8f0180a0389d5de7b495cfe9f769985296383 Gerrit-Change-Number: 41498 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log November 2025