November 2025 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-pfcp[master]: pfcp_msg: Add osmo_pfcp_ie_node_id_cmp()
by pespin 17 Nov '25

17 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/41452?usp=email ) Change subject: pfcp_msg: Add osmo_pfcp_ie_node_id_cmp() ...................................................................... pfcp_msg: Add osmo_pfcp_ie_node_id_cmp() Related: SYS#7719 Change-Id: Id9bda11078d7d940474389c95d23e90db7bc5bed --- M TODO-RELEASE M include/osmocom/pfcp/pfcp_msg.h M src/libosmo-pfcp/pfcp_msg.c 3 files changed, 25 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/52/41452/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 0ed7189..203a2fd 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +libosmo-pfcp add osmo_pfcp_ie_node_id_cmp() diff --git a/include/osmocom/pfcp/pfcp_msg.h b/include/osmocom/pfcp/pfcp_msg.h index 0023353..2fde3e5 100644 --- a/include/osmocom/pfcp/pfcp_msg.h +++ b/include/osmocom/pfcp/pfcp_msg.h @@ -168,7 +168,7 @@ int osmo_pfcp_ie_node_id_from_osmo_sockaddr(struct osmo_pfcp_ie_node_id *node_id, const struct osmo_sockaddr *os); int osmo_pfcp_ie_node_id_to_osmo_sockaddr(const struct osmo_pfcp_ie_node_id *node_id, struct osmo_sockaddr *os); - +int osmo_pfcp_ie_node_id_cmp(const struct osmo_pfcp_ie_node_id *a, const struct osmo_pfcp_ie_node_id *b); #define OSMO_PFCP_MSG_MEMB(M, OFS) ((OFS) <= 0 ? NULL : (void *)((uint8_t *)(M) + OFS)) static inline enum osmo_pfcp_cause *osmo_pfcp_msg_cause(const struct osmo_pfcp_msg *m) diff --git a/src/libosmo-pfcp/pfcp_msg.c b/src/libosmo-pfcp/pfcp_msg.c index 9c73609..2e0db31 100644 --- a/src/libosmo-pfcp/pfcp_msg.c +++ b/src/libosmo-pfcp/pfcp_msg.c @@ -135,6 +135,29 @@ return 0; } +int osmo_pfcp_ie_node_id_cmp(const struct osmo_pfcp_ie_node_id *a, const struct osmo_pfcp_ie_node_id *b) +{ + if (a == b) + return 0; + if (!a) + return 1; + if (!b) + return -1; + + if (a->type != b->type) + return OSMO_CMP(a->type, b->type); + + switch (a->type) { + case OSMO_PFCP_NODE_ID_T_IPV4: + case OSMO_PFCP_NODE_ID_T_IPV6: + return osmo_sockaddr_cmp(&a->ip, &b->ip); + case OSMO_PFCP_NODE_ID_T_FQDN: + return strncasecmp(&a->fqdn[0], &b->fqdn[0], sizeof(a->fqdn)); + default: + OSMO_ASSERT(0); + } +} + static int pfcp_header_set_message_length(struct osmo_pfcp_header_common *c, unsigned int header_and_payload_len) { if (header_and_payload_len < sizeof(struct osmo_pfcp_header_common)) -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/41452?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Id9bda11078d7d940474389c95d23e90db7bc5bed Gerrit-Change-Number: 41452 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-hnbgw[master]: vty: Drop SS7 route info in 'show cnlink'
by pespin 17 Nov '25

17 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/41451?usp=email ) Change subject: vty: Drop SS7 route info in 'show cnlink' ...................................................................... vty: Drop SS7 route info in 'show cnlink' Route information is nowadays a complex topic which is mostly handled by libosmo-sigtran, and it can be configured and better queried using VTY commands also provided by libosmo-sigtran. This SS7 route information here is not relevant and moreover the API it uses is deprecated. Drop it. Change-Id: I2b029e99da45408f9fed41f9f280d19eb646d548 --- M src/osmo-hnbgw/hnbgw_vty.c 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/51/41451/1 diff --git a/src/osmo-hnbgw/hnbgw_vty.c b/src/osmo-hnbgw/hnbgw_vty.c index f463522..f1b128c 100644 --- a/src/osmo-hnbgw/hnbgw_vty.c +++ b/src/osmo-hnbgw/hnbgw_vty.c @@ -125,7 +125,6 @@ static void _show_cnlink(struct vty *vty, struct hnbgw_cnlink *cnlink) { - struct osmo_ss7_route *rt; struct osmo_ss7_instance *ss7; if (!cnlink) { @@ -158,8 +157,6 @@ hnbgw_cnlink_sccp_addr_to_str(cnlink, &cnlink->remote_addr), VTY_NEWLINE); - rt = osmo_ss7_route_lookup(ss7, cnlink->remote_addr.pc); - vty_out(vty, " SS7 route: %s%s", osmo_ss7_route_name(rt, true), VTY_NEWLINE); vty_out(vty, " RANAP state: %s%s", osmo_fsm_inst_state_name(cnlink->fi), VTY_NEWLINE); } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/41451?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I2b029e99da45408f9fed41f9f280d19eb646d548 Gerrit-Change-Number: 41451 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in pysim[master]: card_key_provider: separate column decryption
by dexter 17 Nov '25

17 Nov '25

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41450?usp=email ) Change subject: card_key_provider: separate column decryption ...................................................................... card_key_provider: separate column decryption The concrete class CardKeyProviderCsv supports the decryption of encrypted CSV columns (fields). However, this kind of mechanmism may also be useful in with other data formats we may implement in the future, so let' slplit the encryption part into a seperate class from which we may inherit. Related: SYS#7725 Change-Id: I180457d4938f526d227c81020e4e03c6b3a57dab --- M pySim/card_key_provider.py 1 file changed, 46 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/50/41450/1 diff --git a/pySim/card_key_provider.py b/pySim/card_key_provider.py index d5541b0..e1fa49e 100644 --- a/pySim/card_key_provider.py +++ b/pySim/card_key_provider.py @@ -10,7 +10,7 @@ operation with pySim-shell. """ -# (C) 2021-2024 by Sysmocom s.f.m.c. GmbH +# (C) 2021-2025 by Sysmocom s.f.m.c. GmbH # All Rights Reserved # # Author: Philipp Maier, Harald Welte @@ -89,33 +89,30 @@ dictionary of {field, value} strings for each requested field from 'fields' """ +class CardKeyFieldDecrypter(abc.ABC): + """ + A Card key field decryptor class that may be used by Card key provider implementations to add support for + a column-based encryption to protect sensitive material (cryptographic key material, ADM keys, etc.). + The sensitive material is encrypted using a "key-encryption key", occasionally also known as "transport key" + before it is stored into a file or database (see also GSMA FS.28). The "transport key" is then used to decrypt + the key material on demand using this class. + """ -class CardKeyProviderCsv(CardKeyProvider): - """Card key provider implementation that allows to query against a specified CSV file. - Supports column-based encryption as it is generally a bad idea to store cryptographic key material in - plaintext. Instead, the key material should be encrypted by a "key-encryption key", occasionally also - known as "transport key" (see GSMA FS.28).""" - IV = b'\x23' * 16 - csv_file = None - filename = None - - def __init__(self, filename: str, transport_keys: dict): + def _set_transport_keys(self, transport_keys: dict): """ + Set transport keys, usually one for each column. In some cases it is also possible to use a single key for multiple + columns (see also CRYPT_GROUPS) + Args: - filename : file name (path) of CSV file containing card-individual key/data transport_keys : a dict indexed by field name, whose values are hex-encoded AES keys for the - respective field (column) of the CSV. This is done so that different fields + respective field (column) of the CSV. This is done so that different fields (columns) can use different transport keys, which is strongly recommended by GSMA FS.28 """ - self.csv_file = open(filename, 'r') - if not self.csv_file: - raise RuntimeError("Could not open CSV file '%s'" % filename) - self.filename = filename - self.transport_keys = self.process_transport_keys(transport_keys) + self.transport_keys = self.__process_transport_keys(transport_keys) @staticmethod - def process_transport_keys(transport_keys: dict): + def __process_transport_keys(transport_keys: dict): """Apply a single transport key to multiple fields/columns, if the name is a group.""" new_dict = {} for name, key in transport_keys.items(): @@ -127,12 +124,41 @@ return new_dict def _decrypt_field(self, field_name: str, encrypted_val: str) -> str: - """decrypt a single field, if we have a transport key for the field of that name.""" + """ + Decrypt a single field. The decryption is only applied if we have a transport key is known under the provided + field name, otherwise the field is treated as plaintext and passed through as it is. + + Args: + field_name : name of the field to decrypt (used to identify which key to use) + encrypted_val : encrypted field value + + Returns: + plaintext field value + """ if not field_name in self.transport_keys: return encrypted_val cipher = AES.new(h2b(self.transport_keys[field_name]), AES.MODE_CBC, self.IV) return b2h(cipher.decrypt(h2b(encrypted_val))) +class CardKeyProviderCsv(CardKeyFieldDecrypter, CardKeyProvider): + """Card key provider implementation that allows to query against a specified CSV file.""" + + IV = b'\x23' * 16 + csv_file = None + filename = None + + def __init__(self, filename: str, transport_keys: dict): + """ + Args: + filename : file name (path) of CSV file containing card-individual key/data + transport_keys : (see class CardKeyFieldDecrypter) + """ + self.csv_file = open(filename, 'r') + if not self.csv_file: + raise RuntimeError("Could not open CSV file '%s'" % filename) + self.filename = filename + self._set_transport_keys(transport_keys) + def get(self, fields: List[str], key: str, value: str) -> Dict[str, str]: super()._verify_get_data(fields, key, value) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41450?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I180457d4938f526d227c81020e4e03c6b3a57dab Gerrit-Change-Number: 41450 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: sccplite: rx mgcp: Make sure payload string is null-terminated
by pespin 17 Nov '25

17 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41449?usp=email ) Change subject: sccplite: rx mgcp: Make sure payload string is null-terminated ...................................................................... sccplite: rx mgcp: Make sure payload string is null-terminated Change-Id: Iac3ea7dd5d89eb9ffb6d5123700e9dc9cdfc2ea2 --- M src/osmo-bsc/osmo_bsc_mgcp.c 1 file changed, 41 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/49/41449/1 diff --git a/src/osmo-bsc/osmo_bsc_mgcp.c b/src/osmo-bsc/osmo_bsc_mgcp.c index 8eee71f..ec0bbe6 100644 --- a/src/osmo-bsc/osmo_bsc_mgcp.c +++ b/src/osmo-bsc/osmo_bsc_mgcp.c @@ -74,8 +74,7 @@ return 0; } -/* We received an IPA-encapsulated MGCP message from a MSC. msg owned by caller. */ -int bsc_sccplite_rx_mgcp(struct bsc_msc_data *msc, struct msgb *msg) +static int _bsc_sccplite_rx_mgcp(struct bsc_msc_data *msc, struct msgb *msg) { struct gsm_subscriber_connection *conn; char rcv_ep_local_name[1024]; @@ -85,11 +84,14 @@ struct mgcp_client *mgcp_cli = NULL; int rc; - LOG_MSC(msc, LOGL_INFO, "Received IPA-encapsulated MGCP: %s\n", msg->l2h); + LOG_MSC(msc, LOGL_INFO, + "Received IPA-encapsulated MGCP: %s\n", (const char *)msgb_l2(msg)); - rc = parse_local_endpoint_name(rcv_ep_local_name, sizeof(rcv_ep_local_name), (const char *)msg->l2h); + rc = parse_local_endpoint_name(rcv_ep_local_name, sizeof(rcv_ep_local_name), + (const char *)msgb_l2(msg)); if (rc < 0) { - LOG_MSC(msc, LOGL_ERROR, "Received IPA-encapsulated MGCP: Failed to parse CIC\n"); + LOG_MSC(msc, LOGL_ERROR, + "Received IPA-encapsulated MGCP: Failed to parse CIC\n"); return rc; } @@ -104,7 +106,8 @@ if (!conn->user_plane.mgw_endpoint) continue; ep_local_name = osmo_mgcpc_ep_local_name(conn->user_plane.mgw_endpoint); - LOGPFSMSL(conn->fi, DMSC, LOGL_DEBUG, "ep_local_name='%s' vs rcv_ep_local_name='%s'\n", + LOGPFSMSL(conn->fi, DMSC, LOGL_DEBUG, + "ep_local_name='%s' vs rcv_ep_local_name='%s'\n", ep_local_name ? : "(null)", rcv_ep_local_name); if (!ep_local_name) continue; @@ -117,7 +120,8 @@ } if (!mgcp_cli) { - LOG_MSC(msc, LOGL_ERROR, "Received IPA-encapsulated MGCP: Failed to find associated MGW\n"); + LOG_MSC(msc, LOGL_ERROR, + "Received IPA-encapsulated MGCP: Failed to find associated MGW\n"); return 0; } @@ -147,6 +151,36 @@ return rc; } +/* We received an IPA-encapsulated MGCP message from MSC. msg owned by caller. */ +int bsc_sccplite_rx_mgcp(struct bsc_msc_data *msc, struct msgb *msg) +{ + int rc; + struct msgb *msg_resized; + + if (msgb_l2len(msg) == 0) { + LOG_MSC(msc, LOGL_NOTICE, "Received empty IPA-encapsulated MGCP\n"); + return -ENODATA; + } + + /* Make sure we have a NULL-terminated string to be on the safe side: */ + if (*((const char *)msgb_l2(msg) + msgb_l2len(msg) - 1) == '\0') + return _bsc_sccplite_rx_mgcp(msc, msg); + + /* If there's extra space available in msgb from lower layers, simply nullify next char: */ + if (msgb_tailroom(msg) > 0) { + *msg->tail = '\0'; + return _bsc_sccplite_rx_mgcp(msc, msg); + } + + /* Otherwise, craft a resized message: */ + msg_resized = msgb_copy_resize(msg, msgb_length(msg)+1, "mgcp-resized"); + OSMO_ASSERT(msgb_tailroom(msg) == 1); + *msg->tail = '\0'; + rc = _bsc_sccplite_rx_mgcp(msc, msg_resized); + msgb_free(msg_resized); + return rc; +} + /* we received some data on the UDP proxy socket from the MGW. Pass it to MSC via IPA */ int bsc_sccplite_mgcp_proxy_cb(struct osmo_fd *ofd, unsigned int what) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41449?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iac3ea7dd5d89eb9ffb6d5123700e9dc9cdfc2ea2 Gerrit-Change-Number: 41449 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in osmo-bsc[master]: sccplite: Handle MGCP/CTRL over SCCPLite multiplex using MTP-TRANSFER...
by daniel 17 Nov '25

17 Nov '25

Attention is currently required from: fixeria, laforge, pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41400?usp=email ) Change subject: sccplite: Handle MGCP/CTRL over SCCPLite multiplex using MTP-TRANSFER.req/ind ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41400?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I567ed206eab1add21836bfd937f3790d3d7a00d7 Gerrit-Change-Number: 41400 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Nov 2025 15:28:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-bsc[master]: sccplite: Handle MGCP/CTRL over SCCPLite multiplex using MTP-TRANSFER...
by osmith 17 Nov '25

17 Nov '25

Attention is currently required from: daniel, fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41400?usp=email ) Change subject: sccplite: Handle MGCP/CTRL over SCCPLite multiplex using MTP-TRANSFER.req/ind ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41400?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I567ed206eab1add21836bfd937f3790d3d7a00d7 Gerrit-Change-Number: 41400 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Nov 2025 15:01:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-bsc[master]: sccplite: Handle MGCP/CTRL over SCCPLite multiplex using MTP-TRANSFER...
by pespin 17 Nov '25

17 Nov '25

Attention is currently required from: daniel, fixeria, laforge, osmith. Hello Jenkins Builder, daniel, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/41400?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by osmith, Code-Review-1 by daniel, Verified-1 by Jenkins Builder Change subject: sccplite: Handle MGCP/CTRL over SCCPLite multiplex using MTP-TRANSFER.req/ind ...................................................................... sccplite: Handle MGCP/CTRL over SCCPLite multiplex using MTP-TRANSFER.req/ind This is needed ie. in SCCPLite, where MGCP and CTRL messages need to be sent/received over the same IPA multiplex TCP conn as the SCCPLite (SCCP/IPA) one towards a given MSC. Prior to this, osmo-bsc-sccplite was doing lots of manual libosmo-sigtran APIs to obtain a route, an AS, and ASP, sending over an ASP, etc. Similary, the rx_unknown callback was added to libosmo-sigtran to hook into the ASP level. Tons of stuff which should really be done properly inside libosmo-sigtran and provided over the existing public SAPs, as this patch proposes. With the proposed approach, an SCCPLite client (eg. osmo-bsc), besides setting up an sccp_user to handle SCCP, also sets an ss7_user (MTP SAP) with the newly introduced new Service Indicator (SI) MTP_SI_NI11_OSMO_IPA to be able to manage the IPA[MGCP/CTRL] traffic towards a given MTP peer (SCCPLite client, ie. MSC). Related: SYS#6880 Depends: libosmo-sigtran.git Change-Id I9fedb26ccd3434fc7f272feb3c45cf4bdb80c7ae Change-Id: I567ed206eab1add21836bfd937f3790d3d7a00d7 --- M TODO-RELEASE M include/osmocom/bsc/bsc_msc_data.h M include/osmocom/bsc/osmo_bsc_sigtran.h M src/osmo-bsc/bsc_ctrl.c M src/osmo-bsc/osmo_bsc_mgcp.c M src/osmo-bsc/osmo_bsc_sigtran.c 6 files changed, 157 insertions(+), 116 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/00/41400/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41400?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I567ed206eab1add21836bfd937f3790d3d7a00d7 Gerrit-Change-Number: 41400 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[S] Change in osmo-hnbgw[master]: iuh: Allow setting tx-queue-max-length for all HNBs
by osmith 17 Nov '25

17 Nov '25

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/41436?usp=email ) Change subject: iuh: Allow setting tx-queue-max-length for all HNBs ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/41436?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I8bc9e8bae7a4815dc2f2bc9e15401e01948d1748 Gerrit-Change-Number: 41436 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Nov 2025 14:57:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in pysim[master]: card_key_provider: add unit-test
by dexter 17 Nov '25

17 Nov '25

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41448?usp=email ) Change subject: card_key_provider: add unit-test ...................................................................... card_key_provider: add unit-test There is no unit-test for the CardKeyProviderCsv class yet. Let's add one to ensure that the CardKeyProviderCsv class keeps working as expected. Related: SYS#7725 Change-Id: I52519847a4c4a13a7bca49985133872b01c4aaab --- A tests/unittests/test_card_key_provider.csv A tests/unittests/test_card_key_provider.py 2 files changed, 89 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/48/41448/1 diff --git a/tests/unittests/test_card_key_provider.csv b/tests/unittests/test_card_key_provider.csv new file mode 100644 index 0000000..a9fdf57 --- /dev/null +++ b/tests/unittests/test_card_key_provider.csv @@ -0,0 +1,5 @@ +"card_type_id","formfactor_id","imsi","iccid","pin1","puk1","pin2","puk2","ki","adm1","adm2","proprietary","kic1","kic2","kic3","kid1","kid2","kid3","kik1","kik2","kik3","msisdn","acc","opc" +"myCardType","3FF","901700000000001","8988211000000000001","1234","12345678","1223","12345678","AAAAAAAAAAA5435425AAAAAAAAAAAAAA","10101010","9999999999999999","proprietary data 01","BBBBBBBBBB3324BBBBBBBB21212BBBBB","CC7654CCCCCCCCCCCCCCCCCCCCCCCCCC","DDDD90DDDDDDDDDDDDDDDDDD767DDDDD","EEEEEE567657567567EEEEEEEEEEEEEE","FFFFFFFFFFFFFFFFFFF56765765FFFFF","11111567811111111111111111111111","22222222222222222227669999222222","33333333333333333333333333333333","44444444444444445234544444444444","55555555555","0001","66666666666666666666666666666666" +"myCardType","3FF","901700000000002","8988211000000000002","1234","12345678","1223","12345678","AAAAAAAAAAAAAAAAAAAAAAAA3425AAAA","10101010","9999999999999999","proprietary data 02","BBBBBB421BBBBBBBBBB12BBBBBBBBBBB","CCCCCCCCCC3456CCCCCCCCCCCCCCCCCC","DDDDDDDDD567657DDDD2DDDDDDDDDDDD","EEEEEEEE56756EEEEEEEEE567657EEEE","FFFFF567657FFFFFFFFFFFFFFFFFFFFF","11111111111146113433411576511111","22222222222223432225765222222222","33333333333333523453333333333333","44425435234444444444446544444444","55555555555","0001","66666666666666266666666666666666" +"myCardType","3FF","901700000000003","8988211000000000003","1234","12345678","1223","12345678","AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA","10101010","9999999999999999","proprietary data 03","BBBBBBB45678BBBB756765BBBBBBBBBB","CCCCCCCCCCCCCC76543CCCC56765CCCC","DDDDDDDDDDDDDDDDDD5676575DDDDDDD","EEEEEEEEEEEEEEEEEE56765EEEEEEEEE","FFFFFFFFFFFFFFF567657FFFFFFFFFFF","11111111119876511111111111111111","22222222222444422222222222576522","33333332543333576733333333333333","44444444444567657567444444444444","55555555555","0001","66666675676575666666666666666666" + diff --git a/tests/unittests/test_card_key_provider.py b/tests/unittests/test_card_key_provider.py new file mode 100644 index 0000000..2897a05 --- /dev/null +++ b/tests/unittests/test_card_key_provider.py @@ -0,0 +1,84 @@ +#!/usr/bin/env python3 + +import unittest +import os +from pySim.card_key_provider import * + +class TestCardKeyProvider(unittest.TestCase): + + def __init__(self, *args, **kwargs): + column_keys = {"KI" : "000424252525535532532A0B0C0D0E0F", + "OPC" : "000102030405065545645645645D0E0F", + "KIC1" : "06410203546406456456450B0C0D0E0F", + "KID1" : "00040267840507667609045645645E0F", + "KIK1" : "0001020307687607668678678C0D0E0F", + "KIC2" : "000142457594860706090A0B0688678F", + "KID2" : "600102030405649468690A0B0C0D648F", + "KIK2" : "00010203330506070496330B08640E0F", + "KIC3" : "000104030405064684686A068C0D0E0F", + "KID3" : "00010243048468070809060B0C0D0E0F", + "KIK3" : "00010204040506070809488B0C0D0E0F"} + + csv_file_path = os.path.dirname(os.path.abspath(__file__)) + "/test_card_key_provider.csv" + card_key_provider_register(CardKeyProviderCsv(csv_file_path, column_keys)) + super(TestCardKeyProvider, self).__init__(*args, **kwargs) + + def test_card_key_provider_get(self): + test_data = [{'EXPECTED' : {'PIN1': '1234', 'PUK1': '12345678', 'PIN2': '1223', 'PUK2': '12345678', + 'KI': '48a6d5f60567d45299e3ba08594009e7', 'ADM1': '10101010', + 'ADM2': '9999999999999999', 'KIC1': '3eb8567fa0b4b1e63bcab13bff5f2702', + 'KIC2': 'fd6c173a5b3f04b563808da24237fb46', + 'KIC3': '66c8c848e5dff69d70689d155d44f323', + 'KID1': 'd78accce870332dced467c173244dd94', + 'KID2': 'b3bf050969747b2d2c9389e127a3d791', + 'KID3': '40a77deb50d260b3041bbde1b5040625', + 'KIK1': '451b503239d818ea34421aa9c2a8887a', + 'KIK2': '967716f5fca8ae179f87f76524d1ae6b', + 'KIK3': '0884db5eee5409a00fc1bbc57ac52541', + 'OPC': '81817574c1961dd272ad080eb2caf279'}, 'ICCID' :"8988211000000000001"}, + {'EXPECTED' : {'PIN1': '1234', 'PUK1': '12345678', 'PIN2': '1223', 'PUK2': '12345678', + 'KI': 'e94d7fa6fb92375dae86744ff6ecef49', 'ADM1': '10101010', + 'ADM2': '9999999999999999', 'KIC1': '79b4e39387c66253da68f653381ded44', + 'KIC2': '560561b5dba89c1da8d1920049e5e4f7', + 'KIC3': '79ff35e84e39305a119af8c79f84e8e5', + 'KID1': '233baf89122159553d67545ecedcf8e0', + 'KID2': '8fc2874164d7a8e40d72c968bc894ab8', + 'KID3': '2e3320f0dda85054d261be920fbfa065', + 'KIK1': 'd51b1b17630103d1672a3e9e0e4827ed', + 'KIK2': 'd01edbc48be555139506b0d7982bf7ff', + 'KIK3': 'a6487a5170849e8e0a03026afea91f5a', + 'OPC': '6b0d19ef28bd12f2daac31828d426939'}, 'ICCID' :"8988211000000000002"}, + {'EXPECTED' : {'PIN1': '1234', 'PUK1': '12345678', 'PIN2': '1223', 'PUK2': '12345678', + 'KI': '3cdec1552ef433a89f327905213c5a6e', 'ADM1': '10101010', + 'ADM2': '9999999999999999', 'KIC1': '72986b13ce505e12653ad42df5cfca13', + 'KIC2': '8f0d1e58b01e833773e5562c4940674d', + 'KIC3': '9c72ba5a14d54f489edbffd3d8802f03', + 'KID1': 'd23a42995df9ca83f74b2cfd22695526', + 'KID2': '5c3a189d12aa1ac6614883d7de5e6c8c', + 'KID3': 'a6ace0d303a2b38a96b418ab83c16725', + 'KIK1': 'bf2319467d859c12527aa598430caef2', + 'KIK2': '6a4c459934bea7e40787976b8881ab01', + 'KIK3': '91cd02c38b5f68a98cc90a1f2299538f', + 'OPC': '6df46814b1697daca003da23808bbbc3'}, 'ICCID' :"8988211000000000003"}] + + for t in test_data: + result = card_key_provider_get(["PIN1","PUK1","PIN2","PUK2","KI","ADM1","ADM2","KIC1", + "KIC2","KIC3","KID1","KID2","KID3","KIK1","KIK2","KIK3","OPC"], + "ICCID", t.get('ICCID')) + if result != t.get('EXPECTED'): + print("\nexpected: ", t.get('EXPECTED'), " for ICCID:", t.get('ICCID'), "\ngot:", result) + self.assertTrue(False) + + def test_card_key_provider_get_field(self): + test_data = [{'EXPECTED' : "3eb8567fa0b4b1e63bcab13bff5f2702", 'ICCID' :"8988211000000000001"}, + {'EXPECTED' : "79b4e39387c66253da68f653381ded44", 'ICCID' :"8988211000000000002"}, + {'EXPECTED' : "72986b13ce505e12653ad42df5cfca13", 'ICCID' :"8988211000000000003"}] + + for t in test_data: + result = card_key_provider_get_field("KIC1", "ICCID", t.get('ICCID')) + if result != t.get('EXPECTED'): + print("\nexpected: ", t.get('EXPECTED'), " for ICCID:", t.get('ICCID'), "\ngot:", result) + self.assertTrue(False) + +if __name__ == "__main__": + unittest.main() -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41448?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I52519847a4c4a13a7bca49985133872b01c4aaab Gerrit-Change-Number: 41448 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[L] Change in osmo-bsc[master]: sccplite: Handle MGCP/CTRL over SCCPLite multiplex using MTP-TRANSFER...
by pespin 17 Nov '25

17 Nov '25

Attention is currently required from: daniel, fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41400?usp=email ) Change subject: sccplite: Handle MGCP/CTRL over SCCPLite multiplex using MTP-TRANSFER.req/ind ...................................................................... Patch Set 4: (2 comments) File src/osmo-bsc/osmo_bsc_mgcp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/41400/comment/bb0d54d5_dbfd71c9?usp… : PS4, Line 160: msg = msgb_alloc_headroom(1400, 64, "MGCP->IPA"); > Is this related to the rest of the patch? Yes, we now need more headroom to prepend the mtp_sap primitive . File src/osmo-bsc/osmo_bsc_sigtran.c: https://gerrit.osmocom.org/c/osmo-bsc/+/41400/comment/f2c4940f_0e25219c?usp… : PS4, Line 466: } > I think you're missing a return/error handling here Indeed, thanks! -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41400?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I567ed206eab1add21836bfd937f3790d3d7a00d7 Gerrit-Change-Number: 41400 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Nov 2025 14:48:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>

1 0

2025

2024

2023

2022

gerrit-log November 2025