November 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bsc[master]: Add ER-GSM band support
by laforge 18 Nov '25

18 Nov '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41361?usp=email ) Change subject: Add ER-GSM band support ...................................................................... Add ER-GSM band support ER-GSM band expands the R-GSM band by additional 15 channels, starting from channel 940. Change-Id: I0a9a2f64d9db65967699453c26ae282c4ddf4558 --- M src/osmo-bsc/bts.c M src/osmo-bsc/system_information.c 2 files changed, 12 insertions(+), 11 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 2cc6153..77721fb 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -525,9 +525,9 @@ } break; case GSM_BAND_900: - if ((bts->c0->arfcn > 124 && bts->c0->arfcn < 955) || + if ((bts->c0->arfcn > 124 && bts->c0->arfcn < 940) || bts->c0->arfcn > 1023) { - LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM900 channel (%u) must be between 0-124, 955-1023.\n", + LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM900 channel (%u) must be between 0-124, 940-1023.\n", bts->nr, bts->c0->arfcn); return -EINVAL; } diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c index b438a49..f801853 100644 --- a/src/osmo-bsc/system_information.c +++ b/src/osmo-bsc/system_information.c @@ -535,6 +535,7 @@ const struct gsm_bts *bts, bool bis, bool ter) { int i, rc, min = -1, max = -1, arfcns = 0; + const int min_arfcn = 940; bool pgsm = false; memset(chan_list, 0, 16); @@ -545,8 +546,8 @@ /* Check presence of E-GSM ARFCN 0 */ if (pgsm && bitvec_get_bit_pos(bv, 0) == ONE) pgsm = false; - /* Check presence of R-GSM / E-GSM ARFCNs 955..1023 */ - for (i = 955; pgsm && i <= 1023; i++) { + /* Check presence of (E)R-GSM / E-GSM ARFCNs 940..1023 */ + for (i = min_arfcn; pgsm && i <= 1023; i++) { if (bitvec_get_bit_pos(bv, i) == ONE) pgsm = false; } @@ -577,22 +578,22 @@ /* count the arfcns we want to carry */ arfcns += 1; - /* 955..1023 < 0..885 */ + /* 940..1023 < 0..885 */ if (min < 0) min = i; - if (i >= 955 && min < 955) + if (i >= min_arfcn && min < min_arfcn) min = i; - if (i >= 955 && min >= 955 && i < min) + if (i >= min_arfcn && min >= min_arfcn && i < min) min = i; - if (i < 955 && min < 955 && i < min) + if (i < min_arfcn && min < min_arfcn && i < min) min = i; if (max < 0) max = i; - if (i < 955 && max >= 955) + if (i < min_arfcn && max >= min_arfcn) max = i; - if (i >= 955 && max >= 955 && i > max) + if (i >= min_arfcn && max >= min_arfcn && i > max) max = i; - if (i < 955 && max < 955 && i > max) + if (i < min_arfcn && max < min_arfcn && i > max) max = i; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41361?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0a9a2f64d9db65967699453c26ae282c4ddf4558 Gerrit-Change-Number: 41361 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: Add ER-GSM band support
by laforge 18 Nov '25

18 Nov '25

Attention is currently required from: fixeria, jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41361?usp=email ) Change subject: Add ER-GSM band support ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41361?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0a9a2f64d9db65967699453c26ae282c4ddf4558 Gerrit-Change-Number: 41361 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Nov 2025 13:45:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...osmo-s1gw[master]: config: Set pfcp_net_inst_* fields as strings
by fixeria 18 Nov '25

18 Nov '25

Attention is currently required from: laforge, lynxis lazus, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email ) Change subject: config: Set pfcp_net_inst_* fields as strings ...................................................................... Patch Set 1: (1 comment) File src/erab_fsm.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461/comment/52ae0991_911e… : PS1, Line 714: fun(X)->enc_net_inst_label(X) end ```suggestion LabelsEnc = lists:map(fun enc_net_inst_label/1, Labels), ``` -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7c2da02945829066d317100556e09e55483bd7e7 Gerrit-Change-Number: 41461 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 18 Nov 2025 13:23:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ttcn3-hacks[master]: hlr: skip more tests for PyHSS
by osmith 18 Nov '25

18 Nov '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41440?usp=email ) Change subject: hlr: skip more tests for PyHSS ...................................................................... hlr: skip more tests for PyHSS Skip more tests that don't make sense for PyHSS, and add comments explaining why these tests are skipped. Change-Id: If893ce854a1c0f873fa3d9544df0e23a7ed95525 --- M hlr/HLR_Tests.ttcn 1 file changed, 29 insertions(+), 9 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/hlr/HLR_Tests.ttcn b/hlr/HLR_Tests.ttcn index c69efc3..6cfc08f 100644 --- a/hlr/HLR_Tests.ttcn +++ b/hlr/HLR_Tests.ttcn @@ -2203,14 +2203,9 @@ execute( TC_gsup_sai_err_invalid_imsi() ); execute( TC_gsup_sai() ); execute( TC_gsup_sai_num_auth_vectors() ); - execute( TC_gsup_sai_eps() ); execute( TC_gsup_ul_unknown_imsi() ); - execute( TC_gsup_ul_unknown_imsi_roaming_not_allowed() ); execute( TC_gsup_sai_err_unknown_imsi() ); execute( TC_gsup_ul() ); - execute( TC_gsup_ul_subscriber_data() ); - execute( TC_vty() ); - execute( TC_vty_msisdn_isd() ); execute( TC_gsup_purge_cs() ); execute( TC_gsup_purge_ps() ); execute( TC_gsup_purge_unknown() ); @@ -2226,22 +2221,47 @@ /* "Structured" Supplementary Services */ execute( TC_mo_sss_reject() ); - execute( TC_gsup_check_imei() ); - execute( TC_gsup_check_imei_invalid_len() ); - execute( TC_gsup_check_imei_unknown_imsi() ); - /* Test features that are only implemented in OsmoHLR */ if (m_hlr_impl == HLR_IMPL_OSMOCOM) { + /* OsmoHLR's subscriber create on demand feature: store the + * IMEI along with new subscribers in the HLR DB */ + execute( TC_gsup_check_imei() ); + execute( TC_gsup_check_imei_invalid_len() ); + execute( TC_gsup_check_imei_unknown_imsi() ); + + /* OsmoHLR can be configured via VTY to send a different + * UpdateLocation Error Cause for unknown subscribers, e.g. + * ROAMING_NOTALLOWED (0x0d) instead of IMSI_UNKNOWN (0x02). + * https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comments/ea58eb77_66cf8c82 */ + execute( TC_gsup_ul_unknown_imsi_roaming_not_allowed() ); + + /* OsmoHLR can be used with osmo_dia2gsup in a 4G network. As + * PyHSS supports diameter natively, it doesn't make sense to + * run it with osmo_dia2gsup. */ + execute( TC_gsup_sai_eps() ); + + /* OsmoHLR + osmo_dia2gsup: check for PDP Info IE in Send + * Authentication Info Request (see SYS#6391 and + * https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35899) */ + execute( TC_gsup_ul_subscriber_data() ); + + /* OsmoHLR's VTY interface */ + execute( TC_vty() ); + execute( TC_vty_msisdn_isd() ); + + /* OsmoHLR's distributed GSM feature: Proxy tests */ execute( TC_gsup_ul_unknown_imsi_via_proxy() ); execute( TC_gsup_ul_via_proxy() ); execute( TC_mo_ussd_iuse_imsi_via_proxy() ); execute( TC_mo_ussd_iuse_msisdn_via_proxy() ); execute( TC_gsup_check_imei_via_proxy() ); + /* OsmoHLR's subscriber create on demand feature */ execute( TC_subscr_create_on_demand_check_imei_early() ); execute( TC_subscr_create_on_demand_ul() ); execute( TC_subscr_create_on_demand_sai() ); + /* OsmoHLR's distributed GSM feature: MS Lookup */ execute( TC_MSLookup_mDNS_service_other_home() ); execute( TC_MSLookup_GSUP_proxy() ); execute( TC_MSLookup_mDNS_service_GSUP_HLR_home() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41440?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If893ce854a1c0f873fa3d9544df0e23a7ed95525 Gerrit-Change-Number: 41440 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ci[master]: jobs/ttcn3: adjust to testenv config rename
by osmith 18 Nov '25

18 Nov '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/41443?usp=email ) Change subject: jobs/ttcn3: adjust to testenv config rename ...................................................................... jobs/ttcn3: adjust to testenv config rename Replace "-c osmo_{hlr,ggsn}…" with "-c osmo". Depends: osmo-ttcn3-hacks I7a64c946ece8ad5bfbf4f7d613634138af6db566 Change-Id: I3766d76a5a6fa8a8de00137fe33e0e747337c66e --- M jobs/ttcn3-testsuites-testenv.yml 1 file changed, 12 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/jobs/ttcn3-testsuites-testenv.yml b/jobs/ttcn3-testsuites-testenv.yml index 70f457f..144377e 100644 --- a/jobs/ttcn3-testsuites-testenv.yml +++ b/jobs/ttcn3-testsuites-testenv.yml @@ -58,7 +58,7 @@ - ttcn3-hlr-test: # ~3 min testsuite: hlr - args: -b osmocom:nightly -c osmo_hlr + args: -b osmocom:nightly -c osmo timer: H 08 * * * - ttcn3-hlr-test-pyhss: # ~3 min @@ -152,23 +152,23 @@ - ttcn3-ggsn-test: # ~15 min testsuite: ggsn - args: -b osmocom:nightly -c osmo_ggsn_* + args: -b osmocom:nightly -c osmo_* timer: H 10 * * * - ttcn3-ggsn-test-kernel: # ~10 min testsuite: ggsn - args: -b osmocom:nightly -c osmo_ggsn_v*_only --debian-kernel + args: -b osmocom:nightly -c osmo_v*_only --debian-kernel timer: H 10 * * * - ttcn3-ggsn-test-kernel-net-next: # ~10 min testsuite: ggsn - args: -b osmocom:nightly -c osmo_ggsn_v*_only --custom-kernel + args: -b osmocom:nightly -c osmo_v*_only --custom-kernel kernel: net-next timer: H 10 * * * - ttcn3-ggsn-test-kernel-torvalds: # ~10 min testsuite: ggsn - args: -b osmocom:nightly -c osmo_ggsn_v*_only --custom-kernel + args: -b osmocom:nightly -c osmo_v*_only --custom-kernel kernel: torvalds timer: H 10 * * * @@ -253,7 +253,7 @@ - ttcn3-hlr-test-latest: # ~3 min testsuite: hlr - args: -b osmocom:latest -c osmo_hlr + args: -b osmocom:latest -c osmo timer: H 12 * * * - ttcn3-hlr-test-pyhss-latest: # ~3 min @@ -323,23 +323,23 @@ - ttcn3-ggsn-test-latest: # ~15 min testsuite: ggsn - args: -b osmocom:latest -c osmo_ggsn_* + args: -b osmocom:latest -c osmo_* timer: H 12 * * * - ttcn3-ggsn-test-kernel-latest: # ~10 min testsuite: ggsn - args: -b osmocom:latest -c osmo_ggsn_v*_only --debian-kernel + args: -b osmocom:latest -c osmo_v*_only --debian-kernel timer: H 12 * * * - ttcn3-ggsn-test-kernel-latest-net-next: # ~10 min testsuite: ggsn - args: -b osmocom:latest -c osmo_ggsn_v*_only --custom-kernel + args: -b osmocom:latest -c osmo_v*_only --custom-kernel kernel: net-next timer: H 12 * * * - ttcn3-ggsn-test-kernel-latest-torvalds: # ~10 min testsuite: ggsn - args: -b osmocom:latest -c osmo_ggsn_v*_only --custom-kernel + args: -b osmocom:latest -c osmo_v*_only --custom-kernel kernel: torvalds timer: H 12 * * * @@ -493,7 +493,7 @@ - ttcn3-hlr-test-asan: # ~3 min testsuite: hlr - args: -b osmocom:nightly:asan -c osmo_hlr + args: -b osmocom:nightly:asan -c osmo timer: H 16 * * * - ttcn3-sip-test-asan: # ~2 min @@ -523,7 +523,7 @@ - ttcn3-ggsn-test-asan: # ~15 min testsuite: ggsn - args: -b osmocom:nightly:asan -c osmo_ggsn_* + args: -b osmocom:nightly:asan -c osmo_* timer: H 16 * * * - ttcn3-stp-test-asan: # ~10 min -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41443?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3766d76a5a6fa8a8de00137fe33e0e747337c66e Gerrit-Change-Number: 41443 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[NoOp] Change in osmo-ttcn3-hacks[master]: Rename testenv_osmo_{hlr|ggsn} to testenv_osmo
by osmith 18 Nov '25

18 Nov '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41442?usp=email ) Change subject: Rename testenv_osmo_{hlr|ggsn} to testenv_osmo ...................................................................... Rename testenv_osmo_{hlr|ggsn} to testenv_osmo The "osmo_hlr" part of testenv_osmo_hlr.cfg looks weird (as it is usually written as osmo-hlr or OsmoHLR), especially when used as "-c osmo_hlr" to select the config. Use the shorter "osmo" instead. Suggested-by: Pau Espin Pedrol <pespin(a)sysmocom.de> Change-Id: I7a64c946ece8ad5bfbf4f7d613634138af6db566 --- R ggsn_tests/testenv_osmo_all.cfg R ggsn_tests/testenv_osmo_v4_only.cfg R ggsn_tests/testenv_osmo_v4v6_only.cfg R ggsn_tests/testenv_osmo_v6_only.cfg R hlr/testenv_osmo.cfg 5 files changed, 0 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/ggsn_tests/testenv_osmo_ggsn_all.cfg b/ggsn_tests/testenv_osmo_all.cfg similarity index 100% rename from ggsn_tests/testenv_osmo_ggsn_all.cfg rename to ggsn_tests/testenv_osmo_all.cfg diff --git a/ggsn_tests/testenv_osmo_ggsn_v4_only.cfg b/ggsn_tests/testenv_osmo_v4_only.cfg similarity index 100% rename from ggsn_tests/testenv_osmo_ggsn_v4_only.cfg rename to ggsn_tests/testenv_osmo_v4_only.cfg diff --git a/ggsn_tests/testenv_osmo_ggsn_v4v6_only.cfg b/ggsn_tests/testenv_osmo_v4v6_only.cfg similarity index 100% rename from ggsn_tests/testenv_osmo_ggsn_v4v6_only.cfg rename to ggsn_tests/testenv_osmo_v4v6_only.cfg diff --git a/ggsn_tests/testenv_osmo_ggsn_v6_only.cfg b/ggsn_tests/testenv_osmo_v6_only.cfg similarity index 100% rename from ggsn_tests/testenv_osmo_ggsn_v6_only.cfg rename to ggsn_tests/testenv_osmo_v6_only.cfg diff --git a/hlr/testenv_osmo_hlr.cfg b/hlr/testenv_osmo.cfg similarity index 100% rename from hlr/testenv_osmo_hlr.cfg rename to hlr/testenv_osmo.cfg -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41442?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7a64c946ece8ad5bfbf4f7d613634138af6db566 Gerrit-Change-Number: 41442 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: 5gc: skip TC_pdu_sess_modification for latest
by osmith 18 Nov '25

18 Nov '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41459?usp=email ) Change subject: 5gc: skip TC_pdu_sess_modification for latest ...................................................................... 5gc: skip TC_pdu_sess_modification for latest Disable this test for latest as it crashes the SMF and results in the testsuite job failing. Change-Id: I1c6078961930c58653bf40320a37179d7d3782a7 --- M 5gc/C5G_Tests.ttcn 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/5gc/C5G_Tests.ttcn b/5gc/C5G_Tests.ttcn index e8c9cd2..84d0c3f 100644 --- a/5gc/C5G_Tests.ttcn +++ b/5gc/C5G_Tests.ttcn @@ -422,7 +422,11 @@ execute( TC_periodic_registration_updating() ); execute( TC_ue_context_release_no_pdu_session() ); execute( TC_ue_context_release_with_pdu_session() ); - execute( TC_pdu_sess_modification() ); + /* Remove "is nightly" check after open5gs > 2.7.6 is released with + * https://github.com/open5gs/open5gs/commit/59391d8d5ce23835456d4cebbd23c52a1… */ + if (Misc_Helpers.f_osmo_repo_is("nightly")) { + execute( TC_pdu_sess_modification() ); + } execute( TC_ng_register_ping4() ); execute( TC_ng_register_ping4_256() ); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41459?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1c6078961930c58653bf40320a37179d7d3782a7 Gerrit-Change-Number: 41459 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in ...osmo-s1gw[master]: config: Set pfcp_net_inst_* fields as strings
by pespin 18 Nov '25

18 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email ) Change subject: config: Set pfcp_net_inst_* fields as strings ...................................................................... config: Set pfcp_net_inst_* fields as strings The encoded format is not user friendly at all, since length of each DNS label (subdomain) needs to be encoded in the bytestring. Related: SYS#7734 Change-Id: I7c2da02945829066d317100556e09e55483bd7e7 --- M config/sys.config M src/erab_fsm.erl 2 files changed, 24 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/61/41461/1 diff --git a/config/sys.config b/config/sys.config index 920a30e..9ad1ca2 100644 --- a/config/sys.config +++ b/config/sys.config @@ -17,8 +17,8 @@ {pfcp_loc_addr, "127.0.1.1"}, %% local address for incoming PFCP PDUs from the UPF {pfcp_rem_addr, "127.0.1.2"} %% remote address for outgoing PFCP PDUs to the UPF %% Optional PFCP Network Instance IEs (omitted if not configured) -%% {pfcp_net_inst_core, << 16#09, "core-side" >>}, %% PFCP Network Instance IE value (to core) -%% {pfcp_net_inst_access, << 16#0a, "radio-side" >>} %% PFCP Network Instance IE value (to access) +%% {pfcp_net_inst_core, "core-side"}, %% PFCP Network Instance IE value (to core) +%% {pfcp_net_inst_access, "radio-side"} %% PFCP Network Instance IE value (to access) %% %% Optional GTP-U KPI configuration %% {gtpu_kpi_enable, true}, %% whether to enable the GTP-U KPI module (default: false) diff --git a/src/erab_fsm.erl b/src/erab_fsm.erl index f5d8efe..4a2be6a 100644 --- a/src/erab_fsm.erl +++ b/src/erab_fsm.erl @@ -84,6 +84,9 @@ modify_cnf_nack. -type rel_kind() :: cmd | ind. +-type bin_fqdn_label() :: << _:8, _:_*8 >>. +-type bin_fqdn() :: [bin_fqdn_label()]. + -record(erab_state, {uid :: term(), %% unique E-RAB identifier from :: undefined | gen_statem:from(), %% destination to use when replying u2c :: undefined | teid_addr(), %% GTP-U params for UPF -> Core @@ -695,12 +698,30 @@ net_inst_param('Access') -> pfcp_net_inst_access. +%% Encode one DNS label from string format into DNS Name Notation +-spec enc_net_inst_label(string()) -> bin_fqdn_label(). +enc_net_inst_label(LabelStr) -> + LabelLen = string:length(LabelStr), + LabelBin = list_to_binary(LabelStr), + << LabelLen:8, LabelBin/binary >>. + + +%% Encode Network Instance IE (3GPP TS 29.244 8.2.4) from string format into DNS Name Notation +%% Example: enc_net_inst("www.foobar.com") -> << 3, 'w', 'w', 'w', 6, 'f', 'o', 'o', 'b', 'a', 'r', 3, 'c', 'o', 'm' >>. +-spec enc_net_inst(string()) -> bin_fqdn(). +enc_net_inst(FQDN) -> + Labels = string:split(FQDN, ".", all), + LabelsEnc = lists:map(fun(X)->enc_net_inst_label(X) end, Labels), + list_to_binary(LabelsEnc). + + %% if configured, add Network Instance IE (optional) -spec add_net_inst(pfcp_ie(), iface()) -> pfcp_ie(). add_net_inst(IE, Iface) -> Param = net_inst_param(Iface), case application:get_env(osmo_s1gw, Param) of - {ok, NI} -> + {ok, NIStr} -> + NI = enc_net_inst(NIStr), IE#{network_instance => NI}; undefined -> IE -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7c2da02945829066d317100556e09e55483bd7e7 Gerrit-Change-Number: 41461 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: card_key_provider: fix sourcecode formatting
by dexter 18 Nov '25

18 Nov '25

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41460?usp=email ) Change subject: card_key_provider: fix sourcecode formatting ...................................................................... card_key_provider: fix sourcecode formatting Change-Id: I5675f9f087086646937ca077d3545d2729ccd812 --- M pySim/card_key_provider.py 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/60/41460/1 diff --git a/pySim/card_key_provider.py b/pySim/card_key_provider.py index d5541b0..9f9dc70 100644 --- a/pySim/card_key_provider.py +++ b/pySim/card_key_provider.py @@ -139,8 +139,7 @@ self.csv_file.seek(0) cr = csv.DictReader(self.csv_file) if not cr: - raise RuntimeError( - "Could not open DictReader for CSV-File '%s'" % self.filename) + raise RuntimeError("Could not open DictReader for CSV-File '%s'" % self.filename) cr.fieldnames = [field.upper() for field in cr.fieldnames] rc = {} @@ -150,8 +149,7 @@ if f in row: rc.update({f: self._decrypt_field(f, row[f])}) else: - raise RuntimeError("CSV-File '%s' lacks column '%s'" % - (self.filename, f)) + raise RuntimeError("CSV-File '%s' lacks column '%s'" % (self.filename, f)) return rc -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41460?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5675f9f087086646937ca077d3545d2729ccd812 Gerrit-Change-Number: 41460 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[NoOp] Change in osmo-ttcn3-hacks[master]: Rename testenv_osmo_{hlr|ggsn} to testenv_osmo
by fixeria 18 Nov '25

18 Nov '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41442?usp=email ) Change subject: Rename testenv_osmo_{hlr|ggsn} to testenv_osmo ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41442?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7a64c946ece8ad5bfbf4f7d613634138af6db566 Gerrit-Change-Number: 41442 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Nov 2025 13:00:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2025

2024

2023

2022

gerrit-log November 2025