November 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-sgsn[master]: pdpctx: Use pdp->teic_own as rate_ctr id
by pespin 19 Nov '25

19 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41458?usp=email ) Change subject: pdpctx: Use pdp->teic_own as rate_ctr id ...................................................................... pdpctx: Use pdp->teic_own as rate_ctr id Otherwise we run into errors due to non-unique ids. Related: SYS#7125 Change-Id: I388d7e4550e874cabc51e016d1a35a1074be7ac3 --- M src/sgsn/pdpctx.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/sgsn/pdpctx.c b/src/sgsn/pdpctx.c index 2c3fb03..1fbddab 100644 --- a/src/sgsn/pdpctx.c +++ b/src/sgsn/pdpctx.c @@ -73,7 +73,7 @@ if (!pctx) return NULL; - pctx->ctrg = rate_ctr_group_alloc(pctx, &pdpctx_ctrg_desc, nsapi); + pctx->ctrg = rate_ctr_group_alloc(pctx, &pdpctx_ctrg_desc, pdp->teic_own); if (!pctx->ctrg) { LOGPDPCTXP(LOGL_ERROR, pctx, "Error allocation counter group\n"); talloc_free(pctx); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41458?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I388d7e4550e874cabc51e016d1a35a1074be7ac3 Gerrit-Change-Number: 41458 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-hnbgw[master]: vty: Drop SS7 route info in 'show cnlink'
by pespin 19 Nov '25

19 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/41451?usp=email ) Change subject: vty: Drop SS7 route info in 'show cnlink' ...................................................................... vty: Drop SS7 route info in 'show cnlink' Route information is nowadays a complex topic which is mostly handled by libosmo-sigtran, and it can be configured and better queried using VTY commands also provided by libosmo-sigtran. This SS7 route information here is not relevant and moreover the API it uses is deprecated. Drop it. Change-Id: I2b029e99da45408f9fed41f9f280d19eb646d548 --- M src/osmo-hnbgw/hnbgw_vty.c 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/src/osmo-hnbgw/hnbgw_vty.c b/src/osmo-hnbgw/hnbgw_vty.c index f463522..f1b128c 100644 --- a/src/osmo-hnbgw/hnbgw_vty.c +++ b/src/osmo-hnbgw/hnbgw_vty.c @@ -125,7 +125,6 @@ static void _show_cnlink(struct vty *vty, struct hnbgw_cnlink *cnlink) { - struct osmo_ss7_route *rt; struct osmo_ss7_instance *ss7; if (!cnlink) { @@ -158,8 +157,6 @@ hnbgw_cnlink_sccp_addr_to_str(cnlink, &cnlink->remote_addr), VTY_NEWLINE); - rt = osmo_ss7_route_lookup(ss7, cnlink->remote_addr.pc); - vty_out(vty, " SS7 route: %s%s", osmo_ss7_route_name(rt, true), VTY_NEWLINE); vty_out(vty, " RANAP state: %s%s", osmo_fsm_inst_state_name(cnlink->fi), VTY_NEWLINE); } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/41451?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I2b029e99da45408f9fed41f9f280d19eb646d548 Gerrit-Change-Number: 41451 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in ...osmo-s1gw[master]: config: Set pfcp_net_inst_* fields as strings
by osmith 19 Nov '25

19 Nov '25

Attention is currently required from: fixeria, laforge, lynxis lazus, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email ) Change subject: config: Set pfcp_net_inst_* fields as strings ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7c2da02945829066d317100556e09e55483bd7e7 Gerrit-Change-Number: 41461 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 19 Nov 2025 07:20:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...osmo-s1gw[master]: config: Set pfcp_net_inst_* fields as strings
by fixeria 18 Nov '25

18 Nov '25

Attention is currently required from: laforge, lynxis lazus, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email ) Change subject: config: Set pfcp_net_inst_* fields as strings ...................................................................... Patch Set 3: (2 comments) File src/erab_fsm.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461/comment/8e9ff65b_f326… : PS1, Line 714: fun(X)->enc_net_inst_label(X) end > ```suggestion […] Done File src/erab_fsm.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461/comment/c97ae609_087d… : PS2, Line 88: bin_fqdn() :: [bin_fqdn_label()]. : > I believe this type spec is wrong and this is making the dialyzer unhappy. […] Done -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7c2da02945829066d317100556e09e55483bd7e7 Gerrit-Change-Number: 41461 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 18 Nov 2025 18:30:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in ...osmo-s1gw[master]: config: Set pfcp_net_inst_* fields as strings
by fixeria 18 Nov '25

18 Nov '25

Attention is currently required from: laforge, lynxis lazus, osmith, pespin. fixeria has uploaded a new patch set (#3) to the change originally created by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email ) The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: config: Set pfcp_net_inst_* fields as strings ...................................................................... config: Set pfcp_net_inst_* fields as strings The encoded format is not user friendly at all, since length of each DNS label (subdomain) needs to be encoded in the bytestring. Related: SYS#7734 Change-Id: I7c2da02945829066d317100556e09e55483bd7e7 --- M config/sys.config M src/erab_fsm.erl 2 files changed, 21 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/61/41461/3 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7c2da02945829066d317100556e09e55483bd7e7 Gerrit-Change-Number: 41461 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-sgsn[master]: pdpctx: Use pdp->teic_own as rate_ctr id
by fixeria 18 Nov '25

18 Nov '25

Attention is currently required from: daniel, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41458?usp=email ) Change subject: pdpctx: Use pdp->teic_own as rate_ctr id ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41458?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I388d7e4550e874cabc51e016d1a35a1074be7ac3 Gerrit-Change-Number: 41458 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Nov 2025 18:17:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-sgsn[master]: Pass pdp_t to sgsn_pdp_ctx_alloc()
by fixeria 18 Nov '25

18 Nov '25

Attention is currently required from: daniel, lynxis lazus, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41457?usp=email ) Change subject: Pass pdp_t to sgsn_pdp_ctx_alloc() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41457?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie7312039fc97f50d09f00661e7c156610f3304b8 Gerrit-Change-Number: 41457 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 18 Nov 2025 18:16:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-pfcp[master]: pfcp_msg: Add osmo_pfcp_ie_node_id_cmp()
by fixeria 18 Nov '25

18 Nov '25

Attention is currently required from: neels, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/41452?usp=email ) Change subject: pfcp_msg: Add osmo_pfcp_ie_node_id_cmp() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/41452?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Id9bda11078d7d940474389c95d23e90db7bc5bed Gerrit-Change-Number: 41452 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Nov 2025 17:15:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-hnbgw[master]: vty: Drop SS7 route info in 'show cnlink'
by fixeria 18 Nov '25

18 Nov '25

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/41451?usp=email ) Change subject: vty: Drop SS7 route info in 'show cnlink' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/41451?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I2b029e99da45408f9fed41f9f280d19eb646d548 Gerrit-Change-Number: 41451 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Nov 2025 17:14:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmocom-bb[master]: mobile app: Indicate ER-GSM band support in MS classmark 3
by fixeria 18 Nov '25

18 Nov '25

Attention is currently required from: jolly, laforge. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41360?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: mobile app: Indicate ER-GSM band support in MS classmark 3 ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Patchset: PS5: BTW, I am not really sure if we want to indicate this band by default. This is needed only in a very specific usage scenarios, and is making the classmark unnecessary long for those who are not playing with GSM-R. In other words, I would keep it disabled by default. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41360?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ica13814eddb5293c7d7a2a21dd6a7a437cd1d351 Gerrit-Change-Number: 41360 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 18 Nov 2025 17:13:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2025

2024

2023

2022

gerrit-log November 2025