November 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: jobs/ttcn3: adjust to testenv config rename
by fixeria 18 Nov '25

18 Nov '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41443?usp=email ) Change subject: jobs/ttcn3: adjust to testenv config rename ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41443?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3766d76a5a6fa8a8de00137fe33e0e747337c66e Gerrit-Change-Number: 41443 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Nov 2025 13:00:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: hlr: skip more tests for PyHSS
by fixeria 18 Nov '25

18 Nov '25

Attention is currently required from: daniel, osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41440?usp=email ) Change subject: hlr: skip more tests for PyHSS ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41440?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If893ce854a1c0f873fa3d9544df0e23a7ed95525 Gerrit-Change-Number: 41440 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Nov 2025 12:59:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: 5gc: skip TC_pdu_sess_modification for latest
by fixeria 18 Nov '25

18 Nov '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41459?usp=email ) Change subject: 5gc: skip TC_pdu_sess_modification for latest ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41459?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1c6078961930c58653bf40320a37179d7d3782a7 Gerrit-Change-Number: 41459 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Nov 2025 12:44:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: 5gc: skip TC_pdu_sess_modification for latest
by osmith 18 Nov '25

18 Nov '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41459?usp=email ) Change subject: 5gc: skip TC_pdu_sess_modification for latest ...................................................................... 5gc: skip TC_pdu_sess_modification for latest Disable this test for latest as it crashes the SMF and results in the testsuite job failing. Change-Id: I1c6078961930c58653bf40320a37179d7d3782a7 --- M 5gc/C5G_Tests.ttcn 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/59/41459/1 diff --git a/5gc/C5G_Tests.ttcn b/5gc/C5G_Tests.ttcn index e8c9cd2..84d0c3f 100644 --- a/5gc/C5G_Tests.ttcn +++ b/5gc/C5G_Tests.ttcn @@ -422,7 +422,11 @@ execute( TC_periodic_registration_updating() ); execute( TC_ue_context_release_no_pdu_session() ); execute( TC_ue_context_release_with_pdu_session() ); - execute( TC_pdu_sess_modification() ); + /* Remove "is nightly" check after open5gs > 2.7.6 is released with + * https://github.com/open5gs/open5gs/commit/59391d8d5ce23835456d4cebbd23c52a1… */ + if (Misc_Helpers.f_osmo_repo_is("nightly")) { + execute( TC_pdu_sess_modification() ); + } execute( TC_ng_register_ping4() ); execute( TC_ng_register_ping4_256() ); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41459?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1c6078961930c58653bf40320a37179d7d3782a7 Gerrit-Change-Number: 41459 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: bssgp: Fix non-uniqe rate_ctr ids
by osmith 18 Nov '25

18 Nov '25

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41456?usp=email ) Change subject: bssgp: Fix non-uniqe rate_ctr ids ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41456?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I782e11a75a8adc10292238fde46bf9c3975d970d Gerrit-Change-Number: 41456 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 18 Nov 2025 10:55:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-sgsn[master]: pdpctx: Use pdp->teic_own as rate_ctr id
by osmith 18 Nov '25

18 Nov '25

Attention is currently required from: daniel, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41458?usp=email ) Change subject: pdpctx: Use pdp->teic_own as rate_ctr id ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41458?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I388d7e4550e874cabc51e016d1a35a1074be7ac3 Gerrit-Change-Number: 41458 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Nov 2025 10:53:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-sgsn[master]: Pass pdp_t to sgsn_pdp_ctx_alloc()
by osmith 18 Nov '25

18 Nov '25

Attention is currently required from: daniel, fixeria, lynxis lazus, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41457?usp=email ) Change subject: Pass pdp_t to sgsn_pdp_ctx_alloc() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41457?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie7312039fc97f50d09f00661e7c156610f3304b8 Gerrit-Change-Number: 41457 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 18 Nov 2025 10:52:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: bssgp: Fix non-uniqe rate_ctr ids
by pespin 18 Nov '25

18 Nov '25

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41456?usp=email ) Change subject: bssgp: Fix non-uniqe rate_ctr ids ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I now see this was already proposed here: https://gerrit.osmocom.org/c/libosmocore/+/13206 I'm not sure I'm following the reasons there though. I clearly see this being fixed by running "./testenv.py run -p sgsn -c generic -t SGSN_Tests_Iu.TC_attach_pdp_act_user_addr_v4raw" before and after the patch... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41456?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I782e11a75a8adc10292238fde46bf9c3975d970d Gerrit-Change-Number: 41456 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 18 Nov 2025 10:30:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-sgsn[master]: Pass pdp_t to sgsn_pdp_ctx_alloc()
by pespin 18 Nov '25

18 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41457?usp=email ) Change subject: Pass pdp_t to sgsn_pdp_ctx_alloc() ...................................................................... Pass pdp_t to sgsn_pdp_ctx_alloc() Refactor sgsn_create_pdp_ctx() to pass the libgtp pdp_t to our pctx. This will be used in follow-up patch to use the teic_own as ID of the rate_ctr. Change-Id: Ie7312039fc97f50d09f00661e7c156610f3304b8 --- M include/osmocom/sgsn/pdpctx.h M src/sgsn/pdpctx.c M src/sgsn/sgsn_libgtp.c 3 files changed, 31 insertions(+), 26 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/57/41457/1 diff --git a/include/osmocom/sgsn/pdpctx.h b/include/osmocom/sgsn/pdpctx.h index a4bbd97..c6a43de 100644 --- a/include/osmocom/sgsn/pdpctx.h +++ b/include/osmocom/sgsn/pdpctx.h @@ -92,6 +92,7 @@ struct sgsn_pdp_ctx *sgsn_pdp_ctx_alloc(struct sgsn_mm_ctx *mm, struct sgsn_ggsn_ctx *ggsn, + struct pdp_t *pdp, uint8_t nsapi); void sgsn_pdp_ctx_terminate(struct sgsn_pdp_ctx *pdp); void sgsn_pdp_ctx_free(struct sgsn_pdp_ctx *pdp); diff --git a/src/sgsn/pdpctx.c b/src/sgsn/pdpctx.c index 7806ada..2c3fb03 100644 --- a/src/sgsn/pdpctx.c +++ b/src/sgsn/pdpctx.c @@ -60,32 +60,40 @@ /* you don't want to use this directly, call sgsn_create_pdp_ctx() */ struct sgsn_pdp_ctx *sgsn_pdp_ctx_alloc(struct sgsn_mm_ctx *mm, struct sgsn_ggsn_ctx *ggsn, + struct pdp_t *pdp, uint8_t nsapi) { - struct sgsn_pdp_ctx *pdp; + struct sgsn_pdp_ctx *pctx; - pdp = sgsn_pdp_ctx_by_nsapi(mm, nsapi); - if (pdp) + pctx = sgsn_pdp_ctx_by_nsapi(mm, nsapi); + if (pctx) return NULL; - pdp = talloc_zero(sgsn, struct sgsn_pdp_ctx); - if (!pdp) + pctx = talloc_zero(sgsn, struct sgsn_pdp_ctx); + if (!pctx) return NULL; - pdp->mm = mm; - pdp->ggsn = ggsn; - pdp->nsapi = nsapi; - pdp->ctrg = rate_ctr_group_alloc(pdp, &pdpctx_ctrg_desc, nsapi); - if (!pdp->ctrg) { - LOGPDPCTXP(LOGL_ERROR, pdp, "Error allocation counter group\n"); - talloc_free(pdp); + pctx->ctrg = rate_ctr_group_alloc(pctx, &pdpctx_ctrg_desc, nsapi); + if (!pctx->ctrg) { + LOGPDPCTXP(LOGL_ERROR, pctx, "Error allocation counter group\n"); + talloc_free(pctx); return NULL; } - llist_add(&pdp->list, &mm->pdp_list); - sgsn_ggsn_ctx_add_pdp(pdp->ggsn, pdp); - llist_add(&pdp->g_list, &sgsn->pdp_list); - return pdp; + pdp->priv = pctx; + pctx->lib = pdp; + pctx->mm = mm; + pctx->ggsn = ggsn; + pctx->nsapi = nsapi; + + /* Back up our own local TEID in case we update the library one with RNC TEID when setting up Direct Tunnel: */ + pctx->sgsn_teid_own = pdp->teid_own; + + llist_add(&pctx->list, &mm->pdp_list); + sgsn_ggsn_ctx_add_pdp(pctx->ggsn, pctx); + llist_add(&pctx->g_list, &sgsn->pdp_list); + + return pctx; } /* diff --git a/src/sgsn/sgsn_libgtp.c b/src/sgsn/sgsn_libgtp.c index e637967..4021bbc 100644 --- a/src/sgsn/sgsn_libgtp.c +++ b/src/sgsn/sgsn_libgtp.c @@ -152,12 +152,6 @@ const uint8_t *qos; int rc; - pctx = sgsn_pdp_ctx_alloc(mmctx, ggsn, nsapi); - if (!pctx) { - LOGP(DGPRS, LOGL_ERROR, "Couldn't allocate PDP Ctx\n"); - return NULL; - } - imsi_ui64 = imsi_str2gtp(mmctx->imsi); rc = gtp_pdp_newpdp(ggsn->gsn, &pdp, imsi_ui64, nsapi, NULL); @@ -165,11 +159,13 @@ LOGP(DGPRS, LOGL_ERROR, "Out of libgtp PDP Contexts\n"); return NULL; } - pdp->priv = pctx; - pctx->lib = pdp; - /* Back up our own local TEID in case we update the library one with RNC TEID when setting up Direct Tunnel: */ - pctx->sgsn_teid_own = pdp->teid_own; + pctx = sgsn_pdp_ctx_alloc(mmctx, ggsn, pdp, nsapi); + if (!pctx) { + LOGP(DGPRS, LOGL_ERROR, "Couldn't allocate PDP Ctx\n"); + pdp_freepdp(pdp); + return NULL; + } //pdp->peer = /* sockaddr_in of GGSN (receive) */ //pdp->ipif = /* not used by library */ -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41457?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie7312039fc97f50d09f00661e7c156610f3304b8 Gerrit-Change-Number: 41457 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-sgsn[master]: pdpctx: Use pdp->teic_own as rate_ctr id
by pespin 18 Nov '25

18 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41458?usp=email ) Change subject: pdpctx: Use pdp->teic_own as rate_ctr id ...................................................................... pdpctx: Use pdp->teic_own as rate_ctr id Otherwise we run into errors due to non-unique ids. Related: SYS#7125 Change-Id: I388d7e4550e874cabc51e016d1a35a1074be7ac3 --- M src/sgsn/pdpctx.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/58/41458/1 diff --git a/src/sgsn/pdpctx.c b/src/sgsn/pdpctx.c index 2c3fb03..1fbddab 100644 --- a/src/sgsn/pdpctx.c +++ b/src/sgsn/pdpctx.c @@ -73,7 +73,7 @@ if (!pctx) return NULL; - pctx->ctrg = rate_ctr_group_alloc(pctx, &pdpctx_ctrg_desc, nsapi); + pctx->ctrg = rate_ctr_group_alloc(pctx, &pdpctx_ctrg_desc, pdp->teic_own); if (!pctx->ctrg) { LOGPDPCTXP(LOGL_ERROR, pctx, "Error allocation counter group\n"); talloc_free(pctx); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41458?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I388d7e4550e874cabc51e016d1a35a1074be7ac3 Gerrit-Change-Number: 41458 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

2025

2024

2023

2022

gerrit-log November 2025