pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41499?usp=email ) Change subject: ss7_asp: Do AS-eSLS table cleanup during osmo_ss7_asp_destroy() ...................................................................... ss7_asp: Do AS-eSLS table cleanup during osmo_ss7_asp_destroy() Use the existing API to cleanly remove the association between ASP and AS. Change-Id: I2c1b25d3e76703b88111b9935685a58d039b8e23 --- M src/ss7_asp.c 1 file changed, 3 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/src/ss7_asp.c b/src/ss7_asp.c index 644c192..5325de9 100644 --- a/src/ss7_asp.c +++ b/src/ss7_asp.c @@ -760,13 +760,9 @@ llist_del(&asp->siblings); /* unlink from all ASs we are part of */ - llist_for_each_entry(as, &asp->inst->as_list, list) { - unsigned int i; - for (i = 0; i < ARRAY_SIZE(as->cfg.asps); i++) { - if (as->cfg.asps[i] == asp) - as->cfg.asps[i] = NULL; - } - } + llist_for_each_entry(as, &asp->inst->as_list, list) + ss7_as_del_asp(as, asp); + /* unlink from ss7_instance */ asp->inst = NULL; llist_del(&asp->list); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41499?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2c1b25d3e76703b88111b9935685a58d039b8e23 Gerrit-Change-Number: 41499 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de>