November 2025 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo-s1gw[master]: config: Set pfcp_net_inst_* fields as strings
by fixeria 18 Nov '25

18 Nov '25

Attention is currently required from: laforge, lynxis lazus, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email ) Change subject: config: Set pfcp_net_inst_* fields as strings ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: > @vyanitskiy@sysmocom. […] Yes, see my other comment. File src/erab_fsm.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461/comment/0a4acf86_d49c… : PS2, Line 88: bin_fqdn() :: [bin_fqdn_label()]. : I believe this type spec is wrong and this is making the dialyzer unhappy. At the end of `enc_net_inst/1` you're calling `list_to_binary/1`, which is expected to return a `binary()`, not a list. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7c2da02945829066d317100556e09e55483bd7e7 Gerrit-Change-Number: 41461 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 18 Nov 2025 17:09:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in pysim[master]: card_key_provider: add unit-test
by fixeria 18 Nov '25

18 Nov '25

Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41448?usp=email ) Change subject: card_key_provider: add unit-test ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41448?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I52519847a4c4a13a7bca49985133872b01c4aaab Gerrit-Change-Number: 41448 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Nov 2025 17:04:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...osmo-s1gw[master]: config: Set pfcp_net_inst_* fields as strings
by pespin 18 Nov '25

18 Nov '25

Attention is currently required from: laforge, lynxis lazus, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email ) Change subject: config: Set pfcp_net_inst_* fields as strings ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: @vyanitskiy@sysmocom.de any idea on how to solve the dyalizer error? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7c2da02945829066d317100556e09e55483bd7e7 Gerrit-Change-Number: 41461 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 18 Nov 2025 16:51:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in ...osmo-s1gw[master]: config: Set pfcp_net_inst_* fields as strings
by pespin 18 Nov '25

18 Nov '25

Attention is currently required from: laforge, lynxis lazus, osmith, pespin. Hello Jenkins Builder, fixeria, laforge, lynxis lazus, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: config: Set pfcp_net_inst_* fields as strings ...................................................................... config: Set pfcp_net_inst_* fields as strings The encoded format is not user friendly at all, since length of each DNS label (subdomain) needs to be encoded in the bytestring. Related: SYS#7734 Change-Id: I7c2da02945829066d317100556e09e55483bd7e7 --- M config/sys.config M src/erab_fsm.erl 2 files changed, 24 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/61/41461/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7c2da02945829066d317100556e09e55483bd7e7 Gerrit-Change-Number: 41461 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in pysim[master]: card_key_provider: add unit-test
by dexter 18 Nov '25

18 Nov '25

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41448?usp=email to look at the new patch set (#4). Change subject: card_key_provider: add unit-test ...................................................................... card_key_provider: add unit-test There is no unit-test for the CardKeyProviderCsv class yet. Let's add one to ensure that the CardKeyProviderCsv class keeps working as expected. Related: SYS#7725 Change-Id: I52519847a4c4a13a7bca49985133872b01c4aaab --- A tests/unittests/test_card_key_provider.csv A tests/unittests/test_card_key_provider.py 2 files changed, 85 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/48/41448/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41448?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I52519847a4c4a13a7bca49985133872b01c4aaab Gerrit-Change-Number: 41448 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in pysim[master]: card_key_provider: separate and refactor CSV column encryption
by dexter 18 Nov '25

18 Nov '25

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41450?usp=email ) Change subject: card_key_provider: separate and refactor CSV column encryption ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41450?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I180457d4938f526d227c81020e4e03c6b3a57dab Gerrit-Change-Number: 41450 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 18 Nov 2025 14:43:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in pysim[master]: card_key_provider: add unit-test
by dexter 18 Nov '25

18 Nov '25

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41448?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: card_key_provider: add unit-test ...................................................................... card_key_provider: add unit-test There is no unit-test for the CardKeyProviderCsv class yet. Let's add one to ensure that the CardKeyProviderCsv class keeps working as expected. Related: SYS#7725 Change-Id: I52519847a4c4a13a7bca49985133872b01c4aaab --- A tests/unittests/test_card_key_provider.csv A tests/unittests/test_card_key_provider.py 2 files changed, 85 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/48/41448/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41448?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I52519847a4c4a13a7bca49985133872b01c4aaab Gerrit-Change-Number: 41448 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in pysim[master]: card_key_provider: add unit-test
by dexter 18 Nov '25

18 Nov '25

Attention is currently required from: fixeria. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41448?usp=email ) Change subject: card_key_provider: add unit-test ...................................................................... Patch Set 3: (2 comments) File tests/unittests/test_card_key_provider.py: https://gerrit.osmocom.org/c/pysim/+/41448/comment/fd3b5f5d_d6280b65?usp=em… : PS1, Line 68: if result != t.get('EXPECTED'): : print("\nexpected: ", t.get('EXPECTED'), " for ICCID:", t.get('ICCID'), "\ngot:", result) : self.assertTrue(False) : > ```suggestion […] Done https://gerrit.osmocom.org/c/pysim/+/41448/comment/394654d3_39b0b359?usp=em… : PS1, Line 79: if result != t.get('EXPECTED'): : print("\nexpected: ", t.get('EXPECTED'), " for ICCID:", t.get('ICCID'), "\ngot:", result) : > ```suggestion […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41448?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I52519847a4c4a13a7bca49985133872b01c4aaab Gerrit-Change-Number: 41448 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Nov 2025 14:42:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: card_key_provider: fix sourcecode formatting
by fixeria 18 Nov '25

18 Nov '25

Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41460?usp=email ) Change subject: card_key_provider: fix sourcecode formatting ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41460?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5675f9f087086646937ca077d3545d2729ccd812 Gerrit-Change-Number: 41460 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Nov 2025 13:49:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in pysim[master]: card_key_provider: add unit-test
by fixeria 18 Nov '25

18 Nov '25

Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41448?usp=email ) Change subject: card_key_provider: add unit-test ...................................................................... Patch Set 1: (2 comments) File tests/unittests/test_card_key_provider.py: https://gerrit.osmocom.org/c/pysim/+/41448/comment/63cea0c8_66d384fa?usp=em… : PS1, Line 68: if result != t.get('EXPECTED'): : print("\nexpected: ", t.get('EXPECTED'), " for ICCID:", t.get('ICCID'), "\ngot:", result) : self.assertTrue(False) : ```suggestion self.assertEqual(result, t.get('EXPECTED')) ``` https://gerrit.osmocom.org/c/pysim/+/41448/comment/85be7056_d75fa882?usp=em… : PS1, Line 79: if result != t.get('EXPECTED'): : print("\nexpected: ", t.get('EXPECTED'), " for ICCID:", t.get('ICCID'), "\ngot:", result) : ```suggestion self.assertEqual(result, t.get('EXPECTED')) ``` -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41448?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I52519847a4c4a13a7bca49985133872b01c4aaab Gerrit-Change-Number: 41448 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Nov 2025 13:48:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2025

2024

2023

2022

gerrit-log November 2025