November 2025 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo-s1gw[master]: s1ap_proxy_test: update TC scenario for test_drop_proc_error
by fixeria 25 Nov '25

25 Nov '25

Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41491?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by pespin Change subject: s1ap_proxy_test: update TC scenario for test_drop_proc_error ...................................................................... s1ap_proxy_test: update TC scenario for test_drop_proc_error A follow-up commit implements handling of late E-RAB setup response. This testcase is going to fail because, by coincidence, currently we simulate the scenario of late INITIAL CONTEXT SETUP RESPONSE and expect the s1ap_proxy to drop the PDU. Change the testcase scenario to simulate an INITIAL CONTEXT SETUP RESPONSE without prior REQUEST instead, so that it won't be affected by the upcoming patch. Take a chance to add asserts for per-eNB metrics. Change-Id: I0b24807c9cf08564b53b9d0e087b797fea66e565 Related: SYS#7738, SYS#7599 --- M test/s1ap_proxy_test.erl 1 file changed, 12 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/91/41491/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41491?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I0b24807c9cf08564b53b9d0e087b797fea66e565 Gerrit-Change-Number: 41491 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmocom-bb[master]: mobile app: Indicate ER-GSM band support in MS classmark 3
by laforge 25 Nov '25

25 Nov '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41360?usp=email ) Change subject: mobile app: Indicate ER-GSM band support in MS classmark 3 ...................................................................... mobile app: Indicate ER-GSM band support in MS classmark 3 Change-Id: Ica13814eddb5293c7d7a2a21dd6a7a437cd1d351 --- M src/host/layer23/src/mobile/gsm48_rr.c 1 file changed, 79 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c index be0889f..25ce840 100644 --- a/src/host/layer23/src/mobile/gsm48_rr.c +++ b/src/host/layer23/src/mobile/gsm48_rr.c @@ -1274,7 +1274,7 @@ memset(&bv, 0, sizeof(bv)); bv.data = buf; - bv.data_len = 12; + bv.data_len = 32; /* spare bit */ bitvec_set_bit(&bv, 0); @@ -1439,7 +1439,84 @@ } else { bitvec_set_bit(&bv, ZERO); } - /* info: The max number of bits are about 80. */ + // TODO: Add setting for the following features + /* Single Band Support */ + bitvec_set_bit(&bv, ZERO); + /* GSM 750 Band */ + bitvec_set_bit(&bv, ZERO); + /* UMTS 1.28 Mcps */ + bitvec_set_bit(&bv, ZERO); + /* Gerand Feature Package 1 */ + bitvec_set_bit(&bv, ZERO); + /* Extendet DTM GPRS Multi Slot Class */ + bitvec_set_bit(&bv, ZERO); + /* High Multislot Capability */ + bitvec_set_bit(&bv, ZERO); + /* 0 */ + bitvec_set_bit(&bv, ZERO); + /* Gerand Feature Package 1 */ + bitvec_set_bit(&bv, ZERO); + /* GMSK Multislot Power Profile */ + bitvec_set_uint(&bv, 0, 2); + /* 8-PSK Multislot Power Profile */ + bitvec_set_uint(&bv, 0, 2); + /* T-GSM 400 Bands */ + bitvec_set_bit(&bv, ZERO); + /* 0 */ + bitvec_set_bit(&bv, ZERO); + /* Downlink Advanced Receiver Performance */ + bitvec_set_uint(&bv, 0, 2); + /* DTM Enancements Capability */ + bitvec_set_bit(&bv, ZERO); + /* DTM GPRS High Multi Slot Class */ + bitvec_set_bit(&bv, ZERO); + /* Repeated ACCH Capability */ + bitvec_set_bit(&bv, ZERO); + /* GSM 710 Associated Radio Capability */ + bitvec_set_bit(&bv, ZERO); + /* T-GSM 810 Associated Radio Capability */ + bitvec_set_bit(&bv, ZERO); + /* Ciphering Mode Setting Capability */ + bitvec_set_bit(&bv, ZERO); + /* Additional Positioning Capabilities */ + bitvec_set_bit(&bv, ZERO); + /* E-UTRAN FDD supported */ + bitvec_set_bit(&bv, ZERO); + /* E-UTRAN TDD supported */ + bitvec_set_bit(&bv, ZERO); + /* E-UTRAN Measurement and Reporting supported */ + bitvec_set_bit(&bv, ZERO); + /* Priorify-based reselection supported */ + bitvec_set_bit(&bv, ZERO); + /* UTRA CSG Cell Reporting */ + bitvec_set_bit(&bv, ZERO); + /* VAMOS Level */ + bitvec_set_uint(&bv, 0, 2); + /* TIGHTER Capability */ + bitvec_set_uint(&bv, 0, 2); + /* Selective Ciphering of Downlink SACCH */ + bitvec_set_bit(&bv, ZERO); + /* CS to PS SRVCC from GERAN to UTRA */ + bitvec_set_uint(&bv, 0, 2); + /* CS to PS SRVCC from GERAN to E-UTRA */ + bitvec_set_uint(&bv, 0, 2); + /* GERAN Network Sharing support */ + bitvec_set_bit(&bv, ZERO); + /* E-UTRA Wideband RSRQ measurements support */ + bitvec_set_bit(&bv, ZERO); + /* GSM ER Band */ + if (set->er_gsm) + bitvec_set_bit(&bv, ONE); + else + bitvec_set_bit(&bv, ZERO); + /* UTRA Multiple Frequency Band indicators support */ + bitvec_set_bit(&bv, ZERO); + /* E-UTRA Multiple Frequency Band indicators support */ + bitvec_set_bit(&bv, ZERO); + /* Extended TSC Set Capability support */ + bitvec_set_bit(&bv, ZERO); + /* Extended EARFCN value rande */ + bitvec_set_bit(&bv, ZERO); /* partial bytes will be padded with zero */ *len = (bv.cur_bit + 7) >> 3; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41360?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ica13814eddb5293c7d7a2a21dd6a7a437cd1d351 Gerrit-Change-Number: 41360 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmocom-bb[master]: Add ER-GSM band support to all relevant applications
by laforge 25 Nov '25

25 Nov '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email ) Change subject: Add ER-GSM band support to all relevant applications ...................................................................... Add ER-GSM band support to all relevant applications ER-GSM band expands the R-GSM band by additional 15 channels. Mobile application allows to turn on or off the support of these 15 channels. ER-GSM band is supported by default. Change-Id: I71baa3317df685cf6479b6e20e6ae078911aa24f --- M doc/examples/mobile/mobile.cfg M doc/examples/mobile/multi_ms.cfg M src/host/layer23/include/osmocom/bb/common/settings.h M src/host/layer23/include/osmocom/bb/common/support.h M src/host/layer23/src/common/settings.c M src/host/layer23/src/common/support.c M src/host/layer23/src/common/sysinfo.c M src/host/layer23/src/misc/bcch_scan.c M src/host/layer23/src/misc/cell_log.c M src/host/layer23/src/mobile/gsm48_rr.c M src/host/layer23/src/mobile/vty_interface.c M src/target/firmware/apps/rssi/main.c 12 files changed, 38 insertions(+), 21 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/doc/examples/mobile/mobile.cfg b/doc/examples/mobile/mobile.cfg index 676c76f..ab84b56 100644 --- a/doc/examples/mobile/mobile.cfg +++ b/doc/examples/mobile/mobile.cfg @@ -42,6 +42,7 @@ p-gsm e-gsm r-gsm + er-gsm no gsm-850 dcs no pcs diff --git a/doc/examples/mobile/multi_ms.cfg b/doc/examples/mobile/multi_ms.cfg index 48cdfb1..4938c57 100644 --- a/doc/examples/mobile/multi_ms.cfg +++ b/doc/examples/mobile/multi_ms.cfg @@ -42,6 +42,7 @@ p-gsm e-gsm r-gsm + er-gsm no gsm-850 dcs no pcs @@ -103,6 +104,7 @@ p-gsm e-gsm r-gsm + er-gsm no gsm-850 dcs no pcs diff --git a/src/host/layer23/include/osmocom/bb/common/settings.h b/src/host/layer23/include/osmocom/bb/common/settings.h index 1d3e53d..6b40120 100644 --- a/src/host/layer23/include/osmocom/bb/common/settings.h +++ b/src/host/layer23/include/osmocom/bb/common/settings.h @@ -239,6 +239,7 @@ uint8_t p_gsm; uint8_t e_gsm; uint8_t r_gsm; + uint8_t er_gsm; uint8_t dcs; uint8_t gsm_850; uint8_t pcs; diff --git a/src/host/layer23/include/osmocom/bb/common/support.h b/src/host/layer23/include/osmocom/bb/common/support.h index b0c71f5..3dcfcab 100644 --- a/src/host/layer23/include/osmocom/bb/common/support.h +++ b/src/host/layer23/include/osmocom/bb/common/support.h @@ -49,6 +49,7 @@ uint8_t p_gsm; uint8_t e_gsm; uint8_t r_gsm; + uint8_t er_gsm; uint8_t dcs; uint8_t gsm_850; uint8_t pcs; diff --git a/src/host/layer23/src/common/settings.c b/src/host/layer23/src/common/settings.c index 6bc5634..4f46bdd 100644 --- a/src/host/layer23/src/common/settings.c +++ b/src/host/layer23/src/common/settings.c @@ -95,6 +95,7 @@ set->p_gsm = sup->p_gsm; set->e_gsm = sup->e_gsm; set->r_gsm = sup->r_gsm; + set->er_gsm = sup->er_gsm; set->dcs = sup->dcs; set->class_900 = sup->class_900; set->class_dcs = sup->class_dcs; @@ -179,9 +180,14 @@ set->freq_map[i >> 3] |= (1 << (i & 7)); set->freq_map[0] |= 1; } - if (set->r_gsm) - for(i = 955; i <= 974; i++) + if (set->r_gsm) { + for (i = 955; i <= 974; i++) set->freq_map[i >> 3] |= (1 << (i & 7)); + } + if (set->er_gsm) { + for (i = 940; i <= 954; i++) + set->freq_map[i >> 3] |= (1 << (i & 7)); + } return 0; } diff --git a/src/host/layer23/src/common/support.c b/src/host/layer23/src/common/support.c index a31b456..3e05371 100644 --- a/src/host/layer23/src/common/support.c +++ b/src/host/layer23/src/common/support.c @@ -62,6 +62,7 @@ sup->p_gsm = 1; /* P-GSM */ sup->e_gsm = 1; /* E-GSM */ sup->r_gsm = 1; /* R-GSM */ + sup->er_gsm = 1; /* ER-GSM */ sup->dcs = 1; sup->gsm_850 = 1; sup->pcs = 1; @@ -113,7 +114,7 @@ { 306, 340, 15, 0 }, /* GSM 480 */ { 438, 511, 25, 0 }, { 128, 251, 30, 0 }, /* GSM 850 */ - { 955, 124, 30, 0 }, /* P,E,R GSM */ + { 940, 124, 30, 0 }, /* P,E,(E)R GSM */ { 512, 885, 40, 0 }, /* DCS 1800 */ { 1024, 1322, 40, 0 }, /* PCS 1900 */ { 0, 0, 0, 0 } @@ -130,10 +131,11 @@ print(priv, "Supported features of MS '%s':\n", sup->ms->name); print(priv, " Phase %d mobile station\n", sup->rev_lev + 1); + print(priv, " ER-GSM : %s\n", SUP_SET(er_gsm)); print(priv, " R-GSM : %s\n", SUP_SET(r_gsm)); print(priv, " E-GSM : %s\n", SUP_SET(e_gsm)); print(priv, " P-GSM : %s\n", SUP_SET(p_gsm)); - if (set->r_gsm || set->e_gsm || set->p_gsm) + if (set->er_gsm || set->r_gsm || set->e_gsm || set->p_gsm) print(priv, " GSM900 Class : %d\n", set->class_900); print(priv, " DCS 1800 : %s\n", SUP_SET(dcs)); if (set->dcs) diff --git a/src/host/layer23/src/common/sysinfo.c b/src/host/layer23/src/common/sysinfo.c index efbc519..1046e78 100644 --- a/src/host/layer23/src/common/sysinfo.c +++ b/src/host/layer23/src/common/sysinfo.c @@ -399,7 +399,7 @@ #if 0 /* only Bit map 0 format for P-GSM */ if ((cd[0] & 0xc0 & mask) != 0x00 && - (set->p_gsm && !set->e_gsm && !set->r_gsm && !set->dcs)) + (set->p_gsm && !set->e_gsm && !set->er_gsm && !set->r_gsm && !set->dcs)) return 0; #endif diff --git a/src/host/layer23/src/misc/bcch_scan.c b/src/host/layer23/src/misc/bcch_scan.c index 69df043..a2381d6 100644 --- a/src/host/layer23/src/misc/bcch_scan.c +++ b/src/host/layer23/src/misc/bcch_scan.c @@ -264,7 +264,7 @@ switch (fps.fps_state) { case FPS_S_PM_GSM900: fps.fps_state = FPS_S_PM_EGSM900; - return l1ctl_tx_pm_req_range(ms, 955, 1023); + return l1ctl_tx_pm_req_range(ms, 940, 1023); case FPS_S_PM_EGSM900: fps.fps_state = FPS_S_PM_GSM1800; return l1ctl_tx_pm_req_range(ms, 512, 885); diff --git a/src/host/layer23/src/misc/cell_log.c b/src/host/layer23/src/misc/cell_log.c index ed4d74d..3e0ae9c 100644 --- a/src/host/layer23/src/misc/cell_log.c +++ b/src/host/layer23/src/misc/cell_log.c @@ -59,7 +59,7 @@ }; /* ranges of bands */ -static uint16_t basic_band_range[][2] = {{0, 124}, {512, 885}, {955, 1023}, {0, 0}}; +static uint16_t basic_band_range[][2] = {{0, 124}, {512, 885}, {940, 1023}, {0, 0}}; uint16_t (*band_range)[][2] = &basic_band_range; #define INFO_FLG_PM 1 diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c index c04193c..be0889f 100644 --- a/src/host/layer23/src/mobile/gsm48_rr.c +++ b/src/host/layer23/src/mobile/gsm48_rr.c @@ -1284,12 +1284,12 @@ else bitvec_set_bit(&bv, ZERO); /* band 2 supported */ - if (set->e_gsm || set->r_gsm) + if (set->e_gsm || set->r_gsm || set->er_gsm) bitvec_set_bit(&bv, ONE); else bitvec_set_bit(&bv, ZERO); /* band 1 supported */ - if (set->p_gsm && !(set->e_gsm || set->r_gsm)) + if (set->p_gsm && !(set->e_gsm || set->r_gsm || set->er_gsm)) bitvec_set_bit(&bv, ONE); else bitvec_set_bit(&bv, ZERO); @@ -1311,15 +1311,15 @@ else bitvec_set_bit(&bv, ZERO); /* radio capability */ - if (!set->dcs && !set->p_gsm && !(set->e_gsm || set->r_gsm)) { - /* Fig. 10.5.7 / TS 24.0008: none of dcs, p, e, r */ + if (!set->dcs && !set->p_gsm && !(set->e_gsm || set->r_gsm || set->er_gsm)) { + /* Fig. 10.5.7 / TS 24.0008: none of dcs, p, e, (e)r */ } else - if (set->dcs && !set->p_gsm && !(set->e_gsm || set->r_gsm)) { + if (set->dcs && !set->p_gsm && !(set->e_gsm || set->r_gsm || set->er_gsm)) { /* dcs only */ bitvec_set_uint(&bv, 0, 4); bitvec_set_uint(&bv, set->class_dcs, 4); } else - if (set->dcs && (set->p_gsm || (set->e_gsm || set->r_gsm))) { + if (set->dcs && (set->p_gsm || (set->e_gsm || set->r_gsm || set->er_gsm))) { /* dcs */ bitvec_set_uint(&bv, set->class_dcs, 4); /* low band */ @@ -1332,7 +1332,7 @@ /* These octets above shall be included according to GSM 04.08 Version 5.3.0. */ minimum_len = (bv.cur_bit + 7) >> 3; /* r support */ - if (set->r_gsm) { + if (set->r_gsm || set->er_gsm) { bitvec_set_bit(&bv, ONE); bitvec_set_uint(&bv, set->class_900, 3); } else { @@ -1388,7 +1388,7 @@ if (set->edge_psk_sup) { bitvec_set_bit(&bv, ONE); bitvec_set_bit(&bv, set->edge_psk_uplink == 1); - if (set->p_gsm || (set->e_gsm || set->r_gsm)) { + if (set->p_gsm || (set->e_gsm || set->r_gsm || set->er_gsm)) { bitvec_set_bit(&bv, ONE); bitvec_set_uint(&bv, set->class_900_edge, 2); } else { @@ -1469,7 +1469,7 @@ cm->a5_1 = !set->a5_1; cm->es_ind = sup->es_ind; cm->rev_lev = sup->rev_lev; - cm->fc = (set->r_gsm || set->e_gsm); + cm->fc = (set->er_gsm || set->r_gsm || set->e_gsm); cm->vgcs = sup->vgcs; cm->vbs = sup->vbs; cm->sm_cap = set->sms_ptp; @@ -1511,7 +1511,7 @@ gsm48_rr_enc_cm2(ms, &cc->cm2, rr->cd_now.arfcn); /* classmark 3 */ - if (set->dcs || set->pcs || set->e_gsm || set->r_gsm || set->gsm_850 + if (set->dcs || set->pcs || set->e_gsm || set->r_gsm || set->er_gsm || set->gsm_850 || set->a5_7 || set->a5_6 || set->a5_5 || set->a5_4 || sup->ms_sup || sup->ucs2_treat diff --git a/src/host/layer23/src/mobile/vty_interface.c b/src/host/layer23/src/mobile/vty_interface.c index eb582d3..b5b3128 100644 --- a/src/host/layer23/src/mobile/vty_interface.c +++ b/src/host/layer23/src/mobile/vty_interface.c @@ -1569,12 +1569,13 @@ SUP_WRITE(p_gsm, "p-gsm"); SUP_WRITE(e_gsm, "e-gsm"); SUP_WRITE(r_gsm, "r-gsm"); + SUP_WRITE(er_gsm, "er-gsm"); SUP_WRITE(gsm_850, "gsm-850"); SUP_WRITE(gsm_480, "gsm-480"); SUP_WRITE(gsm_450, "gsm-450"); SUP_WRITE(dcs, "dcs"); SUP_WRITE(pcs, "pcs"); - if (sup->r_gsm || sup->e_gsm || sup->p_gsm) + if (sup->er_gsm || sup->r_gsm || sup->e_gsm || sup->p_gsm) if (!l23_vty_hide_default || sup->class_900 != set->class_900) vty_out(vty, " class-900 %d%s", set->class_900, VTY_NEWLINE); @@ -2470,6 +2471,7 @@ SUP_EN_DI(p_gsm, "p-gsm", "P-GSM (900)", 1); SUP_EN_DI(e_gsm, "e-gsm", "E-GSM (850)", 1); SUP_EN_DI(r_gsm, "r-gsm", "R-GSM (850)", 1); +SUP_EN_DI(er_gsm, "er-gsm", "ER-GSM (850)", 1); SUP_EN_DI(dcs, "dcs", "DCS (1800)", 1); SUP_EN_DI(gsm_850, "gsm-850", "GSM 850", 1); SUP_EN_DI(pcs, "pcs", "PCS (1900)", 1); @@ -3111,6 +3113,8 @@ install_element(SUPPORT_NODE, &cfg_ms_sup_di_e_gsm_cmd); install_element(SUPPORT_NODE, &cfg_ms_sup_en_r_gsm_cmd); install_element(SUPPORT_NODE, &cfg_ms_sup_di_r_gsm_cmd); + install_element(SUPPORT_NODE, &cfg_ms_sup_en_er_gsm_cmd); + install_element(SUPPORT_NODE, &cfg_ms_sup_di_er_gsm_cmd); install_element(SUPPORT_NODE, &cfg_ms_sup_en_dcs_cmd); install_element(SUPPORT_NODE, &cfg_ms_sup_di_dcs_cmd); install_element(SUPPORT_NODE, &cfg_ms_sup_en_gsm_850_cmd); diff --git a/src/target/firmware/apps/rssi/main.c b/src/target/firmware/apps/rssi/main.c index a871714..c7ad262 100644 --- a/src/target/firmware/apps/rssi/main.c +++ b/src/target/firmware/apps/rssi/main.c @@ -78,9 +78,9 @@ static struct band { int min, max, prev, next, freq_ul, freq_dl; } bands[] = { - { 128, 251, 124, 512, 8242, 8692 }, /* GSM 850 */ - { 955, 124, 885, 128, 8762, 9212 }, /* P,E,R GSM */ - { 512, 885, 251, 955, 17102, 18052 }, /* DCS 1800 */ + { 128, 251, 124, 512, 8242, 8692 }, /* GSM 850 */ + { 940, 124, 885, 128, 8732, 9182 }, /* P,E,(E)R GSM */ + { 512, 885, 251, 940, 17102, 18052 }, /* DCS 1800 */ { 0, 0, 0, 0, 0, 0}, }; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I71baa3317df685cf6479b6e20e6ae078911aa24f Gerrit-Change-Number: 41359 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmocom-bb[master]: mobile app: Indicate ER-GSM band support in MS classmark 3
by laforge 25 Nov '25

25 Nov '25

Attention is currently required from: jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41360?usp=email ) Change subject: mobile app: Indicate ER-GSM band support in MS classmark 3 ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41360?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ica13814eddb5293c7d7a2a21dd6a7a437cd1d351 Gerrit-Change-Number: 41360 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 24 Nov 2025 23:20:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bsc[master]: sigtran: Fix potential null ptr derreference
by laforge 25 Nov '25

25 Nov '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41495?usp=email ) Change subject: sigtran: Fix potential null ptr derreference ...................................................................... sigtran: Fix potential null ptr derreference Related: Coverity CID#551476 Change-Id: Iab7c237dd0ab5d6e916ee0a680559cdf838c509f --- M src/osmo-bsc/osmo_bsc_sigtran.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved osmith: Looks good to me, approved diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c index db8b6f3..1fe7739 100644 --- a/src/osmo-bsc/osmo_bsc_sigtran.c +++ b/src/osmo-bsc/osmo_bsc_sigtran.c @@ -888,12 +888,12 @@ msc->a.mtp_user = osmo_ss7_user_find_by_si(s7i, MTP_SI_NI11_OSMO_IPA); if (!msc->a.mtp_user) { msc->a.mtp_user = osmo_ss7_user_create(s7i, "MGCP/CTRL-IPA"); + if (!msc->a.mtp_user) + return -EINVAL; osmo_ss7_user_set_prim_cb(msc->a.mtp_user, mtp_sap_up); osmo_ss7_user_set_priv(msc->a.mtp_user, s7i); osmo_ss7_user_register(msc->a.mtp_user, MTP_SI_NI11_OSMO_IPA); } - if (!msc->a.mtp_user) - return -EINVAL; } /* Start MSC-Reset procedure */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41495?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iab7c237dd0ab5d6e916ee0a680559cdf838c509f Gerrit-Change-Number: 41495 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-bsc[master]: sigtran: Fix potential null ptr derreference
by laforge 25 Nov '25

25 Nov '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41495?usp=email ) Change subject: sigtran: Fix potential null ptr derreference ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41495?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iab7c237dd0ab5d6e916ee0a680559cdf838c509f Gerrit-Change-Number: 41495 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Nov 2025 23:19:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-pfcp[master]: Introduce API osmo_pfcp_cp_peer_free()
by laforge 25 Nov '25

25 Nov '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/41484?usp=email ) Change subject: Introduce API osmo_pfcp_cp_peer_free() ...................................................................... Introduce API osmo_pfcp_cp_peer_free() Change-Id: I31498c407a8fffd8b47cce8c6bf89dc6e3fcefd2 --- M TODO-RELEASE M include/osmocom/pfcp/pfcp_cp_peer.h M src/libosmo-pfcp/pfcp_cp_peer.c 3 files changed, 9 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index 203a2fd..6bcdfb2 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -8,3 +8,4 @@ # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line libosmo-pfcp add osmo_pfcp_ie_node_id_cmp() +libosmo-pfcp add osmo_pfcp_cp_peer_free() diff --git a/include/osmocom/pfcp/pfcp_cp_peer.h b/include/osmocom/pfcp/pfcp_cp_peer.h index 739526e..ac73bc4 100644 --- a/include/osmocom/pfcp/pfcp_cp_peer.h +++ b/include/osmocom/pfcp/pfcp_cp_peer.h @@ -39,6 +39,7 @@ struct osmo_pfcp_cp_peer *osmo_pfcp_cp_peer_alloc(void *ctx, struct osmo_pfcp_endpoint *ep, const struct osmo_sockaddr *remote_addr); +void osmo_pfcp_cp_peer_free(struct osmo_pfcp_cp_peer *cp_peer); int osmo_pfcp_cp_peer_associate(struct osmo_pfcp_cp_peer *cp_peer); bool osmo_pfcp_cp_peer_is_associated(const struct osmo_pfcp_cp_peer *cp_peer); int osmo_pfcp_cp_peer_set_associated_cb(struct osmo_pfcp_cp_peer *cp_peer, osmo_pfcp_cp_peer_assoc_cb assoc_cb); diff --git a/src/libosmo-pfcp/pfcp_cp_peer.c b/src/libosmo-pfcp/pfcp_cp_peer.c index c88c6d1..403a474 100644 --- a/src/libosmo-pfcp/pfcp_cp_peer.c +++ b/src/libosmo-pfcp/pfcp_cp_peer.c @@ -120,6 +120,13 @@ return cp_peer; } +void osmo_pfcp_cp_peer_free(struct osmo_pfcp_cp_peer *cp_peer) +{ + if (!cp_peer) + return; + osmo_fsm_inst_term(cp_peer->fi, OSMO_FSM_TERM_REGULAR, NULL); +} + int osmo_pfcp_cp_peer_associate(struct osmo_pfcp_cp_peer *cp_peer) { struct osmo_fsm_inst *fi = cp_peer->fi; -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/41484?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I31498c407a8fffd8b47cce8c6bf89dc6e3fcefd2 Gerrit-Change-Number: 41484 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in osmo-hnbgw[master]: Split UPF into its own object
by laforge 25 Nov '25

25 Nov '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/41483?usp=email ) Change subject: Split UPF into its own object ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/41483?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I624bafe2fa150f7480b6fb44433c34e83154e06c Gerrit-Change-Number: 41483 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Nov 2025 23:19:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-abis[master]: trau_frame: fix de/encoding of TRAU-AMR-8k-6k7 format
by laforge 25 Nov '25

25 Nov '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41478?usp=email ) Change subject: trau_frame: fix de/encoding of TRAU-AMR-8k-6k7 format ...................................................................... trau_frame: fix de/encoding of TRAU-AMR-8k-6k7 format There exist 3 TRAU frame types (distinguished by sync pattern) for AMR on 8 kbit/s subslots: Low, 6k7 and 7k4. osmo_trau_frame_encode() and osmo_trau_frame_decode_8k() APIs support all 3 TRAU-AMR-8k frame types since the original 2020 implementation - however, encoding and decoding of 6k7 format was incorrect. Fix it. Correctness of the new implementation is verified by unit tests added with the next patch in this series. Change-Id: Ibb98b0c189ced5248dca217384ca34b6a5f8b210 --- M src/trau/trau_frame.c 1 file changed, 11 insertions(+), 11 deletions(-) Approvals: pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/trau/trau_frame.c b/src/trau/trau_frame.c index 896bc20..d8541c5 100644 --- a/src/trau/trau_frame.c +++ b/src/trau/trau_frame.c @@ -1045,15 +1045,15 @@ /* D8 .. D11 */ memcpy(fr->d_bits + d_idx, trau_bits + 2 * 8 + 4, 4); d_idx += 4; - /* D12 .. D39 */ - for (i = 3; i < 7; i++) { + /* D12 .. D32 */ + for (i = 3; i < 6; i++) { int offset = i * 8; - memcpy(fr->d_bits + d_idx, trau_bits + offset + 2, 7); + memcpy(fr->d_bits + d_idx, trau_bits + offset + 1, 7); d_idx += 7; } - /* D40 .. D137 */ - for (i = 7; i < 20; i+= 2) { + /* D33 .. D137 */ + for (i = 6; i < 20; i += 2) { int offset = i * 8; memcpy(fr->d_bits + d_idx, trau_bits + offset + 1, 15); d_idx += 15; @@ -1074,7 +1074,7 @@ trau_bits[3 * 8] = 1; trau_bits[4 * 8] = 1; trau_bits[5 * 8] = 0; - for (i = 5; i < 20; i += 2) + for (i = 6; i < 20; i += 2) trau_bits[i * 8] = 1; /* D1 .. D7 */ @@ -1085,15 +1085,15 @@ /* D8 .. D11 */ memcpy(trau_bits + 2 * 8 + 4, fr->d_bits + d_idx, 4); d_idx += 4; - /* D12 .. D39 */ - for (i = 3; i < 7; i++) { + /* D12 .. D32 */ + for (i = 3; i < 6; i++) { int offset = i * 8; - memcpy(trau_bits + offset + 2, fr->d_bits + d_idx, 7); + memcpy(trau_bits + offset + 1, fr->d_bits + d_idx, 7); d_idx += 7; } - /* D40 .. D137 */ - for (i = 7; i < 20; i+= 2) { + /* D33 .. D137 */ + for (i = 6; i < 20; i += 2) { int offset = i * 8; memcpy(trau_bits + offset + 1, fr->d_bits + d_idx, 15); d_idx += 15; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41478?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ibb98b0c189ced5248dca217384ca34b6a5f8b210 Gerrit-Change-Number: 41478 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-abis[master]: trau_frame: fix de/encoding of TRAU-AMR-8k-6k7 format
by laforge 25 Nov '25

25 Nov '25

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41478?usp=email ) Change subject: trau_frame: fix de/encoding of TRAU-AMR-8k-6k7 format ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41478?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ibb98b0c189ced5248dca217384ca34b6a5f8b210 Gerrit-Change-Number: 41478 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 24 Nov 2025 23:17:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log November 2025