October 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: ES2Plus_Tests: move [TESTPORT_PARAMETERS] up
by dexter 27 Oct '25

27 Oct '25

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41262?usp=email ) Change subject: ES2Plus_Tests: move [TESTPORT_PARAMETERS] up ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41262?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If0d5ba0dc8d5b1f07215d6ac8c02a36253c200f6 Gerrit-Change-Number: 41262 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Oct 2025 14:24:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: ES2Plus_Tests: remove obvious comment
by dexter 27 Oct '25

27 Oct '25

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41261?usp=email ) Change subject: ES2Plus_Tests: remove obvious comment ...................................................................... ES2Plus_Tests: remove obvious comment Change-Id: I30564ecd89f32ea1830ef1f3bbfcddc4b3f585c4 Related: SYS#7339 --- M smdpp/ES2Plus_Tests.cfg 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved diff --git a/smdpp/ES2Plus_Tests.cfg b/smdpp/ES2Plus_Tests.cfg index f98a65d..1b46c47 100644 --- a/smdpp/ES2Plus_Tests.cfg +++ b/smdpp/ES2Plus_Tests.cfg @@ -13,5 +13,4 @@ [TESTPORT_PARAMETERS] [EXECUTE] -# Execute all ES2+ tests ES2Plus_Tests.control \ No newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41261?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I30564ecd89f32ea1830ef1f3bbfcddc4b3f585c4 Gerrit-Change-Number: 41261 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: ES2Plus_Tests: remove obvious comment
by dexter 27 Oct '25

27 Oct '25

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41261?usp=email ) Change subject: ES2Plus_Tests: remove obvious comment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41261?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I30564ecd89f32ea1830ef1f3bbfcddc4b3f585c4 Gerrit-Change-Number: 41261 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Oct 2025 14:24:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: ES2Plus_Tests: move [TESTPORT_PARAMETERS] up
by dexter 27 Oct '25

27 Oct '25

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41262?usp=email ) Change subject: ES2Plus_Tests: move [TESTPORT_PARAMETERS] up ...................................................................... ES2Plus_Tests: move [TESTPORT_PARAMETERS] up We normally have the [TESTPORT_PARAMETERS] right below [LOGGING] Change-Id: If0d5ba0dc8d5b1f07215d6ac8c02a36253c200f6 Related: SYS#7339 --- M smdpp/ES2Plus_Tests.cfg 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/62/41262/1 diff --git a/smdpp/ES2Plus_Tests.cfg b/smdpp/ES2Plus_Tests.cfg index 1b46c47..591b75b 100644 --- a/smdpp/ES2Plus_Tests.cfg +++ b/smdpp/ES2Plus_Tests.cfg @@ -4,13 +4,13 @@ LogFile := "ES2Plus_Tests.%e.%h.%r.%s" LogSourceInfo := Stack +[TESTPORT_PARAMETERS] + [MODULE_PARAMETERS] # ES2+ specific parameters ES2Plus_Tests.mp_es2plus_server_host := "127.0.0.1" ES2Plus_Tests.mp_es2plus_server_port := 8000 # NIST tests use port 8000 ES2Plus_Tests.mp_operator_id := "test.operator.com" -[TESTPORT_PARAMETERS] - [EXECUTE] ES2Plus_Tests.control \ No newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41262?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If0d5ba0dc8d5b1f07215d6ac8c02a36253c200f6 Gerrit-Change-Number: 41262 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: ES2Plus_Tests: remove obvious comment
by dexter 27 Oct '25

27 Oct '25

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41261?usp=email ) Change subject: ES2Plus_Tests: remove obvious comment ...................................................................... ES2Plus_Tests: remove obvious comment Change-Id: I30564ecd89f32ea1830ef1f3bbfcddc4b3f585c4 Related: SYS#7339 --- M smdpp/ES2Plus_Tests.cfg 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/61/41261/1 diff --git a/smdpp/ES2Plus_Tests.cfg b/smdpp/ES2Plus_Tests.cfg index f98a65d..1b46c47 100644 --- a/smdpp/ES2Plus_Tests.cfg +++ b/smdpp/ES2Plus_Tests.cfg @@ -13,5 +13,4 @@ [TESTPORT_PARAMETERS] [EXECUTE] -# Execute all ES2+ tests ES2Plus_Tests.control \ No newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41261?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I30564ecd89f32ea1830ef1f3bbfcddc4b3f585c4 Gerrit-Change-Number: 41261 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: smdpp_Tests.cfg: remove unused testport parameters
by dexter 27 Oct '25

27 Oct '25

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41263?usp=email ) Change subject: smdpp_Tests.cfg: remove unused testport parameters ...................................................................... smdpp_Tests.cfg: remove unused testport parameters The testsuite uses a custom libcurl based sublayer that handles all the HTTP related tasks. Let's remove the HTTP_server_port related testport parameters. Change-Id: If58675f4243250381d407722c52e8e2384aa4f22 Related: SYS#7339 --- M smdpp/smdpp_Tests.cfg 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/63/41263/1 diff --git a/smdpp/smdpp_Tests.cfg b/smdpp/smdpp_Tests.cfg index 1b34dae..2171d44 100644 --- a/smdpp/smdpp_Tests.cfg +++ b/smdpp/smdpp_Tests.cfg @@ -16,8 +16,6 @@ *.ConsoleMask:=ERROR | TESTCASE | USER | VERDICTOP | WARNING ; [TESTPORT_PARAMETERS] -system.HTTP_server_port.KEYFILE := "../ipad/example_ca/pki/private/alttest.key" -system.HTTP_server_port.CERTIFICATEFILE := "../ipad/example_ca/pki/issued/alttest.crt" [MODULE_PARAMETERS] smdpp_Tests.mp_es9plus_server_port_nist := 8000 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41263?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If58675f4243250381d407722c52e8e2384aa4f22 Gerrit-Change-Number: 41263 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: runtime: check record/file size before write
by laforge 27 Oct '25

27 Oct '25

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41228?usp=email ) Change subject: runtime: check record/file size before write ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File pySim/runtime.py: https://gerrit.osmocom.org/c/pysim/+/41228/comment/2ba2d68d_90ac92c0?usp=em… : PS3, Line 555: warn "from warnings import warn" ist vmtl. noetig, siehe linter output -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41228?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7fa717d803ae79398d2c5daf92a7336be660c5ad Gerrit-Change-Number: 41228 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Oct 2025 14:03:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmocore[master]: AMR codec: add decoder homing frame const patterns
by laforge 27 Oct '25

27 Oct '25

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmocore/+/41257?usp=email ) Change subject: AMR codec: add decoder homing frame const patterns ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41257?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1f8f8ec36cc13270a1d1fa633583107317abe894 Gerrit-Change-Number: 41257 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 27 Oct 2025 13:52:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmocore[master]: AMR codec: add conversion between s-bits and codec parameters
by laforge 27 Oct '25

27 Oct '25

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmocore/+/41256?usp=email ) Change subject: AMR codec: add conversion between s-bits and codec parameters ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41256?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I28eae702204d7f7ff164e17c5e26152a94a12cba Gerrit-Change-Number: 41256 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 27 Oct 2025 13:52:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: Correctly calculate size iofd_msgb_alloc2()
by jolly 27 Oct '25

27 Oct '25

Attention is currently required from: laforge, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/41138?usp=email ) Change subject: Correctly calculate size iofd_msgb_alloc2() ...................................................................... Patch Set 2: (1 comment) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/41138/comment/e92cfa28_468701a5?… : PS2, Line 193: return msgb_alloc_headroom_c(iofd, size + headroom, headroom, "osmo_io_msgb"); > static inline struct msgb *msgb_alloc_headroom_c(const void *ctx, uint16_t size, uint16_t headroom, […] I used some casting to make it clearer that there can't be an overflow. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41138?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I16c1e08fb64a1fafaeee1844fd8c00ecc2861d12 Gerrit-Change-Number: 41138 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Oct 2025 11:08:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0