Attention is currently required from: dexter.
osmith has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41273?usp=email )
Change subject: fixup
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
looks like this can be abandoned, squashed into https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41272/1 apparently
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41273?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1343ebef12c449cd9f8f74dd0c1cb6f14202cb33
Gerrit-Change-Number: 41273
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 Oct 2025 07:07:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: falconia.
fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmocore/+/41256?usp=email )
Change subject: AMR codec: add conversion between s-bits and codec parameters
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41256?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I28eae702204d7f7ff164e17c5e26152a94a12cba
Gerrit-Change-Number: 41256
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Tue, 28 Oct 2025 05:45:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Hoernchen.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41271?usp=email )
Change subject: smdp_Tests: rename and document custom_tls_cert module parameters
......................................................................
Patch Set 1:
(1 comment)
File smdpp/smdpp_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41271/comment/0faff508_7a30… :
PS1, Line 67:
@ewild@sysmocom.de Pleas check this comment. I do not fully understand what the purpose of those module parameters is.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41271?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie37da6986410b663378531f4f0d50d95b3068964
Gerrit-Change-Number: 41271
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 27 Oct 2025 17:15:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41272?usp=email )
Change subject: smdpp_Tests: add comments to mp_es9plus_server_port_ module parameters
......................................................................
smdpp_Tests: add comments to mp_es9plus_server_port_ module parameters
Let's add an explanatory comment to mp_es9plus_server_port_nist and
mp_es9plus_server_port_brp
Related: SYS#7339
Change-Id: I7e3f0292256b21a75da5b756ee9af6ec58318de1
---
M smdpp/smdpp_Tests.ttcn
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/72/41272/1
diff --git a/smdpp/smdpp_Tests.ttcn b/smdpp/smdpp_Tests.ttcn
index fcb542b..0258ed3 100644
--- a/smdpp/smdpp_Tests.ttcn
+++ b/smdpp/smdpp_Tests.ttcn
@@ -71,8 +71,11 @@
boolean mp_es9plus_use_custom_tls_cert := true;
charstring mp_es9plus_custom_tls_cert_path := ""; /* Empty means use cert pool only */
- integer mp_es9plus_server_port_nist := 8000;
- integer mp_es9plus_server_port_brp := 8001;
+ /* Sets the server port of the ES9+ server (SM-DP+, NIST certificates)
+ integer mp_es9plus_server_port_nist := 8000;
+
+ /* Sets the server port of the ES9+ server (SM-DP+, Brainpool certificates)
+ integer mp_es9plus_server_port_brp := 8001;
}
/* C++ handles only crypto, TTCN-3 handles ASN.1 encoding/decoding most of the time */
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41272?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7e3f0292256b21a75da5b756ee9af6ec58318de1
Gerrit-Change-Number: 41272
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41271?usp=email )
Change subject: smdp_Tests: rename and document custom_tls_cert module parameters
......................................................................
smdp_Tests: rename and document custom_tls_cert module parameters
The module parameters mp_use_custom_tls_cert and mp_custom_tls_cert_path
now only relate to ES9+, so let's add an appropriate prefix to make that
clear.
Let's also add an explanatory comment what those module parameters do.
Change-Id: Ie37da6986410b663378531f4f0d50d95b3068964
Related: SYS#7339
---
M smdpp/smdpp_Tests.ttcn
1 file changed, 9 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/71/41271/1
diff --git a/smdpp/smdpp_Tests.ttcn b/smdpp/smdpp_Tests.ttcn
index 2b8768f..fcb542b 100644
--- a/smdpp/smdpp_Tests.ttcn
+++ b/smdpp/smdpp_Tests.ttcn
@@ -65,8 +65,12 @@
* mutual authentication. */
boolean mp_es2plus_use_mutual_tls := true;
- boolean mp_use_custom_tls_cert := true;
- charstring mp_custom_tls_cert_path := ""; // Empty means use cert pool only
+ /* Sets a custom TLS certificate to be used with ES9+. In case the cert path is left empty, the default cert pool
+ * (sgp26/DPtls) that is shipped with this testsuite is used. */
+ /* FIXME: This option has no effect, CA certificates have to be placed into /etc/ssl/certs still. */
+ boolean mp_es9plus_use_custom_tls_cert := true;
+ charstring mp_es9plus_custom_tls_cert_path := ""; /* Empty means use cert pool only */
+
integer mp_es9plus_server_port_nist := 8000;
integer mp_es9plus_server_port_brp := 8001;
}
@@ -551,8 +555,8 @@
// Configure HTTP client
var integer result := ext_RSPClient_configureHttpClient(
g_rsp_client_handle_es9p,
- mp_use_custom_tls_cert,
- mp_custom_tls_cert_path
+ mp_es9plus_use_custom_tls_cert,
+ mp_es9plus_custom_tls_cert_path
);
if (result != 0) {
@@ -561,7 +565,7 @@
return false;
}
- if (mp_use_custom_tls_cert) {
+ if (mp_es9plus_use_custom_tls_cert) {
ext_logInfo("HTTP client configured - custom TLS: true");
} else {
ext_logInfo("HTTP client configured - custom TLS: false");
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41271?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie37da6986410b663378531f4f0d50d95b3068964
Gerrit-Change-Number: 41271
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41273?usp=email )
Change subject: fixup
......................................................................
fixup
Change-Id: I1343ebef12c449cd9f8f74dd0c1cb6f14202cb33
---
M smdpp/smdpp_Tests.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/73/41273/1
diff --git a/smdpp/smdpp_Tests.ttcn b/smdpp/smdpp_Tests.ttcn
index 0258ed3..2aa15dc 100644
--- a/smdpp/smdpp_Tests.ttcn
+++ b/smdpp/smdpp_Tests.ttcn
@@ -71,10 +71,10 @@
boolean mp_es9plus_use_custom_tls_cert := true;
charstring mp_es9plus_custom_tls_cert_path := ""; /* Empty means use cert pool only */
- /* Sets the server port of the ES9+ server (SM-DP+, NIST certificates)
+ /* Sets the server port of the ES9+ server (SM-DP+, NIST certificates) */
integer mp_es9plus_server_port_nist := 8000;
- /* Sets the server port of the ES9+ server (SM-DP+, Brainpool certificates)
+ /* Sets the server port of the ES9+ server (SM-DP+, Brainpool certificates) */
integer mp_es9plus_server_port_brp := 8001;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41273?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1343ebef12c449cd9f8f74dd0c1cb6f14202cb33
Gerrit-Change-Number: 41273
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41269?usp=email )
Change subject: smdpp_Tests.cfg: comment out parameters in config file.
......................................................................
smdpp_Tests.cfg: comment out parameters in config file.
The code in smdpp_Tests.ttcn already provides safe defaults, so we
do not have to repeat those defaults again in smdpp_Tests.cfg.
So let's comment out the parameters. This way we kenn keep them for
illustrative purposes, so that users can use the config file as a
helpful template for the most basic settings.
Related: SYS#7339
Change-Id: I981b683da0312799c2e5b24ac57cd838b071f955
---
M smdpp/smdpp_Tests.cfg
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
dexter: Looks good to me, approved
diff --git a/smdpp/smdpp_Tests.cfg b/smdpp/smdpp_Tests.cfg
index 2171d44..60ad49e 100644
--- a/smdpp/smdpp_Tests.cfg
+++ b/smdpp/smdpp_Tests.cfg
@@ -18,9 +18,9 @@
[TESTPORT_PARAMETERS]
[MODULE_PARAMETERS]
-smdpp_Tests.mp_es9plus_server_port_nist := 8000
-smdpp_Tests.mp_es9plus_server_port_brp := 8001
-smdpp_Tests.mp_es2plus_server_port := 8000
+# smdpp_Tests.mp_es9plus_server_port_nist := 8000
+# smdpp_Tests.mp_es9plus_server_port_brp := 8001
+# smdpp_Tests.mp_es2plus_server_port := 8000
[MAIN_CONTROLLER]
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41269?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I981b683da0312799c2e5b24ac57cd838b071f955
Gerrit-Change-Number: 41269
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>