laforge has submitted this change. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/39454?usp=email )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: utils: h2i(): use list() to convert bytes to integers
......................................................................
utils: h2i(): use list() to convert bytes to integers
Change-Id: Icb0d0803b7ae4e0b3a292ba96f58c26d0ca88abd
---
M src/osmocom/utils.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
lynxis lazus: Looks good to me, approved
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
diff --git a/src/osmocom/utils.py b/src/osmocom/utils.py
index 6c823ec..347bb93 100644
--- a/src/osmocom/utils.py
+++ b/src/osmocom/utils.py
@@ -78,7 +78,7 @@
def h2i(s: Hexstr) -> List[int]:
"""convert from a string of hex nibbles to a list of integers"""
- return [(int(x, 16) << 4)+int(y, 16) for x, y in zip(s[0::2], s[1::2])]
+ return list(h2b(s))
def i2h(s: List[int]) -> hexstr:
--
To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/39454?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: python/pyosmocom
Gerrit-Branch: master
Gerrit-Change-Id: Icb0d0803b7ae4e0b3a292ba96f58c26d0ca88abd
Gerrit-Change-Number: 39454
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: daniel, dexter, fixeria, osmith.
laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41227?usp=email )
Change subject: hlr: pyhss: create/delete subscribers
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File library/PyHSS_REST_Functions.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41227/comment/d68fd0ce_f22a… :
PS2, Line 43: private function f_pyhss_algo(template (omit) charstring algo2g := omit,
> > In that case, the variable in line 84 would always be set to the algo2g value? […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41227?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic924dabbc813459f73d6646ee17b79cb11d39a76
Gerrit-Change-Number: 41227
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 21 Oct 2025 20:30:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Attention is currently required from: fixeria.
laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/39454?usp=email )
Change subject: utils: h2i(): use list() to convert bytes to integers
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/39454?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: python/pyosmocom
Gerrit-Branch: master
Gerrit-Change-Id: Icb0d0803b7ae4e0b3a292ba96f58c26d0ca88abd
Gerrit-Change-Number: 39454
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 21 Oct 2025 20:27:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
laforge has submitted this change. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/39453?usp=email )
Change subject: utils: b2h()/i2h(): use bytes.hex() API
......................................................................
utils: b2h()/i2h(): use bytes.hex() API
Change-Id: Iaef25f614e7a4b1c3eb328e560bf9a300f70ae31
---
M src/osmocom/utils.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
lynxis lazus: Looks good to me, approved
dexter: Looks good to me, approved
diff --git a/src/osmocom/utils.py b/src/osmocom/utils.py
index 5947453..6c823ec 100644
--- a/src/osmocom/utils.py
+++ b/src/osmocom/utils.py
@@ -73,7 +73,7 @@
def b2h(b: bytearray) -> hexstr:
"""convert from a sequence of bytes to a string of hex nibbles"""
- return hexstr(''.join(['%02x' % (x) for x in b]))
+ return hexstr(b.hex())
def h2i(s: Hexstr) -> List[int]:
@@ -83,7 +83,7 @@
def i2h(s: List[int]) -> hexstr:
"""convert from a list of integers to a string of hex nibbles"""
- return hexstr(''.join(['%02x' % (x) for x in s]))
+ return hexstr(bytes(s).hex())
def h2s(s: Hexstr) -> str:
--
To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/39453?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: python/pyosmocom
Gerrit-Branch: master
Gerrit-Change-Id: Iaef25f614e7a4b1c3eb328e560bf9a300f70ae31
Gerrit-Change-Number: 39453
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: falconia, neels, pespin.
laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39869?usp=email )
Change subject: mgw: rtp-patch rfc5993hr: convert to each end's respective format
......................................................................
Patch Set 2: Code-Review+1
(4 comments)
File src/libosmo-mgcp/mgcp_network.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/39869/comment/7a37b698_3f7988da?usp… :
PS2, Line 691: * consider the full RTP chain of a single call:
> The comment by @laforge@osmocom. […]
Done
https://gerrit.osmocom.org/c/osmo-mgw/+/39869/comment/1e1de471_7286ebf5?usp… :
PS2, Line 698: will always be RFC 5993
> > On AoIP, there is no discussion. […]
Done
https://gerrit.osmocom.org/c/osmo-mgw/+/39869/comment/a0cf7996_312b9e4a?usp… :
PS2, Line 1660: strcmp(conn_src->end.cset.codec->subtype_name, "GSM-HR-08") == 0 && conn_src->end.rfc5993_hr_convert) {
> I originally had it split, but the overzealous linter forced me to join into this longer line! See t […]
Done
https://gerrit.osmocom.org/c/osmo-mgw/+/39869/comment/dfea6621_0f340ae1?usp… :
PS2, Line 1661: int rc = examine_rtp_rx_gsmhr(msg, conn_src);
> It is called for every received packet. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39869?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I6b446ad83c540fb8b7e1aae24b78c27010212d64
Gerrit-Change-Number: 39869
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 21 Oct 2025 20:25:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria.
laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email )
Change subject: fixup: rsl: properly initialize MS/BS Power Control state
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
ping? Do we move initialization to the lchan activation or not? If not, we can proceed merging this
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I46c881d5a3959c2542610ed767e0f131d01f9f98
Gerrit-Change-Number: 39830
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 21 Oct 2025 20:20:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No