dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41269?usp=email )
Change subject: smdpp_Tests.cfg: comment out parameters in config file.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41269?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I981b683da0312799c2e5b24ac57cd838b071f955
Gerrit-Change-Number: 41269
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 27 Oct 2025 15:19:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41268?usp=email )
Change subject: ES2Plus_Tests.cfg: comment out parameters in config file.
......................................................................
ES2Plus_Tests.cfg: comment out parameters in config file.
The code in ES2Plus_Tests.ttcn already provides safe defaults, so we
do not have to repeat those defaults again in ES2Plus_Tests.cfg.
So let's comment out the parameters. This way we kenn keep them for
illustrative purposes, so that users can use the config file as a
helpful template for the most basic settings.
Related: SYS#7339
Change-Id: I5677222305d847ba3ac1cdafecdc942ece80aa8c
---
M smdpp/ES2Plus_Tests.cfg
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
dexter: Looks good to me, approved
diff --git a/smdpp/ES2Plus_Tests.cfg b/smdpp/ES2Plus_Tests.cfg
index b2ad3d8..91463c6 100644
--- a/smdpp/ES2Plus_Tests.cfg
+++ b/smdpp/ES2Plus_Tests.cfg
@@ -8,9 +8,11 @@
[MODULE_PARAMETERS]
# ES2+ specific parameters
-ES2Plus_Tests.mp_es2plus_server_fqdn := "127.0.0.1" # Must match the hostname of the server SSL certificate!
-ES2Plus_Tests.mp_es2plus_server_port := 8000
-ES2Plus_Tests.mp_es2plus_operator_id := "test.operator.com"
+# ES2Plus_Tests.mp_es2plus_server_fqdn := "testsmdpplus1.example.com" # Must match the hostname of the server SSL certificate!
+# ES2Plus_Tests.mp_es2plus_server_port := 8000
+# ES2Plus_Tests.mp_es2plus_operator_id := "test.operator.com"
+# ES2Plus_Tests.mp_es2plus_client_cert_path := "/path/to/my/client/cert"
+# ES2Plus_Tests.mp_es2plus_client_key_path := "/path/to/my/client/cert_key"
[EXECUTE]
ES2Plus_Tests.control
\ No newline at end of file
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41268?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5677222305d847ba3ac1cdafecdc942ece80aa8c
Gerrit-Change-Number: 41268
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41268?usp=email )
Change subject: ES2Plus_Tests.cfg: comment out parameters in config file.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41268?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5677222305d847ba3ac1cdafecdc942ece80aa8c
Gerrit-Change-Number: 41268
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 27 Oct 2025 15:10:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41267?usp=email )
Change subject: ES2Plus_Tests.cfg: remove unhelpful comment
......................................................................
ES2Plus_Tests.cfg: remove unhelpful comment
There is no benefit for the user from this comment. The port number
also is often a custom parameter that depends on the actual setup.
Change-Id: Ic7b2d9d665feee211d6dedcf9068a6ce3c993aaf
Related: SYS#7339
---
M smdpp/ES2Plus_Tests.cfg
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
dexter: Looks good to me, approved
diff --git a/smdpp/ES2Plus_Tests.cfg b/smdpp/ES2Plus_Tests.cfg
index 695f54c..b2ad3d8 100644
--- a/smdpp/ES2Plus_Tests.cfg
+++ b/smdpp/ES2Plus_Tests.cfg
@@ -9,7 +9,7 @@
[MODULE_PARAMETERS]
# ES2+ specific parameters
ES2Plus_Tests.mp_es2plus_server_fqdn := "127.0.0.1" # Must match the hostname of the server SSL certificate!
-ES2Plus_Tests.mp_es2plus_server_port := 8000 # NIST tests use port 8000
+ES2Plus_Tests.mp_es2plus_server_port := 8000
ES2Plus_Tests.mp_es2plus_operator_id := "test.operator.com"
[EXECUTE]
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41267?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic7b2d9d665feee211d6dedcf9068a6ce3c993aaf
Gerrit-Change-Number: 41267
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41268?usp=email )
Change subject: ES2Plus_Tests.cfg: comment out parameters in config file.
......................................................................
ES2Plus_Tests.cfg: comment out parameters in config file.
The code in ES2Plus_Tests.ttcn already provides safe defaults, so we
do not have to repeat those defaults again in ES2Plus_Tests.cfg.
So let's comment out the parameters. This way we kenn keep them for
illustrative purposes, so that users can use the config file as a
helpful template for the most basic settings.
Related: SYS#7339
Change-Id: I5677222305d847ba3ac1cdafecdc942ece80aa8c
---
M smdpp/ES2Plus_Tests.cfg
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/68/41268/1
diff --git a/smdpp/ES2Plus_Tests.cfg b/smdpp/ES2Plus_Tests.cfg
index b2ad3d8..91463c6 100644
--- a/smdpp/ES2Plus_Tests.cfg
+++ b/smdpp/ES2Plus_Tests.cfg
@@ -8,9 +8,11 @@
[MODULE_PARAMETERS]
# ES2+ specific parameters
-ES2Plus_Tests.mp_es2plus_server_fqdn := "127.0.0.1" # Must match the hostname of the server SSL certificate!
-ES2Plus_Tests.mp_es2plus_server_port := 8000
-ES2Plus_Tests.mp_es2plus_operator_id := "test.operator.com"
+# ES2Plus_Tests.mp_es2plus_server_fqdn := "testsmdpplus1.example.com" # Must match the hostname of the server SSL certificate!
+# ES2Plus_Tests.mp_es2plus_server_port := 8000
+# ES2Plus_Tests.mp_es2plus_operator_id := "test.operator.com"
+# ES2Plus_Tests.mp_es2plus_client_cert_path := "/path/to/my/client/cert"
+# ES2Plus_Tests.mp_es2plus_client_key_path := "/path/to/my/client/cert_key"
[EXECUTE]
ES2Plus_Tests.control
\ No newline at end of file
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41268?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5677222305d847ba3ac1cdafecdc942ece80aa8c
Gerrit-Change-Number: 41268
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41269?usp=email )
Change subject: smdpp_Tests.cfg: comment out parameters in config file.
......................................................................
smdpp_Tests.cfg: comment out parameters in config file.
The code in smdpp_Tests.ttcn already provides safe defaults, so we
do not have to repeat those defaults again in smdpp_Tests.cfg.
So let's comment out the parameters. This way we kenn keep them for
illustrative purposes, so that users can use the config file as a
helpful template for the most basic settings.
Related: SYS#7339
Change-Id: I981b683da0312799c2e5b24ac57cd838b071f955
---
M smdpp/smdpp_Tests.cfg
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/69/41269/1
diff --git a/smdpp/smdpp_Tests.cfg b/smdpp/smdpp_Tests.cfg
index 2171d44..60ad49e 100644
--- a/smdpp/smdpp_Tests.cfg
+++ b/smdpp/smdpp_Tests.cfg
@@ -18,9 +18,9 @@
[TESTPORT_PARAMETERS]
[MODULE_PARAMETERS]
-smdpp_Tests.mp_es9plus_server_port_nist := 8000
-smdpp_Tests.mp_es9plus_server_port_brp := 8001
-smdpp_Tests.mp_es2plus_server_port := 8000
+# smdpp_Tests.mp_es9plus_server_port_nist := 8000
+# smdpp_Tests.mp_es9plus_server_port_brp := 8001
+# smdpp_Tests.mp_es2plus_server_port := 8000
[MAIN_CONTROLLER]
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41269?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I981b683da0312799c2e5b24ac57cd838b071f955
Gerrit-Change-Number: 41269
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41267?usp=email )
Change subject: ES2Plus_Tests.cfg: remove unhelpful comment
......................................................................
ES2Plus_Tests.cfg: remove unhelpful comment
There is no benefit for the user from this comment. The port number
also is often a custom parameter that depends on the actual setup.
Change-Id: Ic7b2d9d665feee211d6dedcf9068a6ce3c993aaf
Related: SYS#7339
---
M smdpp/ES2Plus_Tests.cfg
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/67/41267/1
diff --git a/smdpp/ES2Plus_Tests.cfg b/smdpp/ES2Plus_Tests.cfg
index 695f54c..b2ad3d8 100644
--- a/smdpp/ES2Plus_Tests.cfg
+++ b/smdpp/ES2Plus_Tests.cfg
@@ -9,7 +9,7 @@
[MODULE_PARAMETERS]
# ES2+ specific parameters
ES2Plus_Tests.mp_es2plus_server_fqdn := "127.0.0.1" # Must match the hostname of the server SSL certificate!
-ES2Plus_Tests.mp_es2plus_server_port := 8000 # NIST tests use port 8000
+ES2Plus_Tests.mp_es2plus_server_port := 8000
ES2Plus_Tests.mp_es2plus_operator_id := "test.operator.com"
[EXECUTE]
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41267?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic7b2d9d665feee211d6dedcf9068a6ce3c993aaf
Gerrit-Change-Number: 41267
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41266?usp=email )
Change subject: ES2Plus_Tests: rename mp_es2plus_server_host to _fqdn
......................................................................
ES2Plus_Tests: rename mp_es2plus_server_host to _fqdn
Let's rename the module parameter mp_es2plus_server_host to
mp_es2plus_server_fqdn. The reason for this is that the suffix "host"
suggests that one may use an arbitrary hostname or IP address. In
this case this is in fact not true. The FQDN must match the hostname
of the SSL server certificate. Apart from that GSMA SGP.22 always
uses the word "FQDN" in their specs.
Change-Id: Idedfcce4d013c32f43307e159c45854a1e6a049b
Related: SYS#7339
---
M smdpp/ES2Plus_Tests.cfg
M smdpp/ES2Plus_Tests.ttcn
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
dexter: Looks good to me, approved
diff --git a/smdpp/ES2Plus_Tests.cfg b/smdpp/ES2Plus_Tests.cfg
index 8be08ff..695f54c 100644
--- a/smdpp/ES2Plus_Tests.cfg
+++ b/smdpp/ES2Plus_Tests.cfg
@@ -8,7 +8,7 @@
[MODULE_PARAMETERS]
# ES2+ specific parameters
-ES2Plus_Tests.mp_es2plus_server_host := "127.0.0.1"
+ES2Plus_Tests.mp_es2plus_server_fqdn := "127.0.0.1" # Must match the hostname of the server SSL certificate!
ES2Plus_Tests.mp_es2plus_server_port := 8000 # NIST tests use port 8000
ES2Plus_Tests.mp_es2plus_operator_id := "test.operator.com"
diff --git a/smdpp/ES2Plus_Tests.ttcn b/smdpp/ES2Plus_Tests.ttcn
index 63e3a64..c6765f4 100644
--- a/smdpp/ES2Plus_Tests.ttcn
+++ b/smdpp/ES2Plus_Tests.ttcn
@@ -47,7 +47,7 @@
// testsuite (libcurl) will also verify the presented server certificate against the related CA. To ensure that
// the server certificate verification is possible, ensure that the related CA certificates are made available in
// /etc/ssl/certs
- charstring mp_es2plus_server_host := "testsmdpplus1.example.com";
+ charstring mp_es2plus_server_fqdn := "testsmdpplus1.example.com";
// Sets the server port of the ES2+ server (SM-DP+).
integer mp_es2plus_server_port := 8000;
@@ -191,7 +191,7 @@
function f_init_es2plus() runs on ES2Plus_ConnHdlr {
// Initialize RSP client using imported function from smdpp_Tests
g_rsp_client_handle := smdpp_Tests.ext_RSPClient_create(
- mp_es2plus_server_host,
+ mp_es2plus_server_fqdn,
mp_es2plus_server_port,
c_es2plus_cert_path,
c_es2plus_cert_name_filter
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41266?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Idedfcce4d013c32f43307e159c45854a1e6a049b
Gerrit-Change-Number: 41266
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>