October 2025 - gerrit-log - lists.osmocom.org

[XS] Change in pysim[master]: commands: do not use b2h with a string
by laforge 21 Oct '25

21 Oct '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/41236?usp=email ) Change subject: commands: do not use b2h with a string ...................................................................... commands: do not use b2h with a string The function h2b expects a bytearray and must not be used on a string. This is also true for nullstrings (''). Related: OS#6869 Change-Id: I0e28e6ec476901bf19aa0f8640e41c74aa6e3aa2 --- M pySim/commands.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/pySim/commands.py b/pySim/commands.py index f069db4..066a2c4 100644 --- a/pySim/commands.py +++ b/pySim/commands.py @@ -141,7 +141,7 @@ Returns: Tuple of (decoded_data, sw) """ - cmd = cmd_constr.build(cmd_data) if cmd_data else '' + cmd = cmd_constr.build(cmd_data) if cmd_data else b'' lc = i2h([len(cmd)]) if cmd_data else '' le = '00' if resp_constr else '' pdu = ''.join([cla, ins, p1, p2, lc, b2h(cmd), le]) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41236?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0e28e6ec476901bf19aa0f8640e41c74aa6e3aa2 Gerrit-Change-Number: 41236 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: commands: do not use b2h with a string
by laforge 21 Oct '25

21 Oct '25

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41236?usp=email ) Change subject: commands: do not use b2h with a string ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41236?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0e28e6ec476901bf19aa0f8640e41c74aa6e3aa2 Gerrit-Change-Number: 41236 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Oct 2025 19:32:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: commands: do not use b2h with a string
by fixeria 21 Oct '25

21 Oct '25

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41236?usp=email ) Change subject: commands: do not use b2h with a string ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41236?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0e28e6ec476901bf19aa0f8640e41c74aa6e3aa2 Gerrit-Change-Number: 41236 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Oct 2025 19:01:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...pyosmocom[master]: utils: b2h()/i2h(): use bytes.hex() API
by dexter 21 Oct '25

21 Oct '25

Attention is currently required from: fixeria. dexter has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/39453?usp=email ) Change subject: utils: b2h()/i2h(): use bytes.hex() API ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: This patch may fix the failing pysim verification: https://gerrit.osmocom.org/c/pysim/+/41236 I hope there is not more of such things, but we will see. This patch I think is correct. Wrong API usage must be fixed in the application that uses pyosmocom. -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/39453?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Iaef25f614e7a4b1c3eb328e560bf9a300f70ae31 Gerrit-Change-Number: 39453 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Oct 2025 15:48:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: commands: do not use b2h with a string
by dexter 21 Oct '25

21 Oct '25

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41236?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: commands: do not use b2h with a string ...................................................................... commands: do not use b2h with a string The function h2b expects a bytearray and must not be used on a string. This is also true for nullstrings (''). Related: OS#6869 Change-Id: I0e28e6ec476901bf19aa0f8640e41c74aa6e3aa2 --- M pySim/commands.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/36/41236/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41236?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0e28e6ec476901bf19aa0f8640e41c74aa6e3aa2 Gerrit-Change-Number: 41236 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: commands: do not use b2h with a string
by dexter 21 Oct '25

21 Oct '25

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41236?usp=email ) Change subject: commands: do not use b2h with a string ...................................................................... commands: do not use b2h with a string The function h2b expects a bytearray and must not be used on a string. This is also true for nullstrings (''). Related: OS#6869 Change-Id: I0e28e6ec476901bf19aa0f8640e41c74aa6e3aa2 --- M pySim/commands.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/36/41236/1 diff --git a/pySim/commands.py b/pySim/commands.py index f069db4..e5ad564 100644 --- a/pySim/commands.py +++ b/pySim/commands.py @@ -141,10 +141,10 @@ Returns: Tuple of (decoded_data, sw) """ - cmd = cmd_constr.build(cmd_data) if cmd_data else '' + cmd = b2h(cmd_constr.build(cmd_data)) if cmd_data else '' lc = i2h([len(cmd)]) if cmd_data else '' le = '00' if resp_constr else '' - pdu = ''.join([cla, ins, p1, p2, lc, b2h(cmd), le]) + pdu = ''.join([cla, ins, p1, p2, lc, cmd, le]) (data, sw) = self.send_apdu(pdu, apply_lchan = apply_lchan) if data: # filter the resulting dict to avoid '_io' members inside -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41236?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0e28e6ec476901bf19aa0f8640e41c74aa6e3aa2 Gerrit-Change-Number: 41236 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: smdpp_Tests: simplify generation of smdpp_ConnHdlrPars (NIST vs. BRP)
by osmith 21 Oct '25

21 Oct '25

Attention is currently required from: dexter. osmith has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41235?usp=email ) Change subject: smdpp_Tests: simplify generation of smdpp_ConnHdlrPars (NIST vs. BRP) ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41235?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied4ffa6ff4b3efbbcfc9204ce8f21ea7ca4becf5 Gerrit-Change-Number: 41235 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Oct 2025 13:27:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: smdpp_Tests: make ES9+ and ES2+ ports configurable
by dexter 21 Oct '25

21 Oct '25

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41234?usp=email ) Change subject: smdpp_Tests: make ES9+ and ES2+ ports configurable ...................................................................... smdpp_Tests: make ES9+ and ES2+ ports configurable Change-Id: I17f2713088c583bec26a0a8cdff40c796e0a490b Related: SYS#7339 --- M smdpp/smdpp_Tests.cfg M smdpp/smdpp_Tests.ttcn 2 files changed, 15 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/smdpp/smdpp_Tests.cfg b/smdpp/smdpp_Tests.cfg index 35f3140..1b34dae 100644 --- a/smdpp/smdpp_Tests.cfg +++ b/smdpp/smdpp_Tests.cfg @@ -20,6 +20,9 @@ system.HTTP_server_port.CERTIFICATEFILE := "../ipad/example_ca/pki/issued/alttest.crt" [MODULE_PARAMETERS] +smdpp_Tests.mp_es9plus_server_port_nist := 8000 +smdpp_Tests.mp_es9plus_server_port_brp := 8001 +smdpp_Tests.mp_es2plus_server_port := 8000 [MAIN_CONTROLLER] diff --git a/smdpp/smdpp_Tests.ttcn b/smdpp/smdpp_Tests.ttcn index 548b33a..d40d6df 100644 --- a/smdpp/smdpp_Tests.ttcn +++ b/smdpp/smdpp_Tests.ttcn @@ -385,8 +385,8 @@ * to match the FQDN in the test SSL certificates. To resolve the server FQDN to an IP address, an entry * in /etc/hosts is sufficient. */ smdp_server_fqdn := "testsmdpplus1.example.com", - smdp_es9p_server_port := 8000, - smdp_es2p_server_port := 8000, + smdp_es9p_server_port := mp_es9plus_server_port_nist, + smdp_es2p_server_port := mp_es2plus_server_port, cert_path := "./sgp26/CertificateIssuer", cert_name_filter := "", // Load all certificates (both NIST and BRP) or "NIST" or "BRP" euicc_cert_path := "./sgp26/eUICC/CERT_EUICC_ECDSA_NIST.der", @@ -408,6 +408,9 @@ modulepar { boolean mp_use_custom_tls_cert := true; charstring mp_custom_tls_cert_path := ""; // Empty means use cert pool only + integer mp_es9plus_server_port_nist := 8000; + integer mp_es9plus_server_port_brp := 8001; + integer mp_es2plus_server_port := 8000; } private altstep as_Tguard() runs on MTC_CT { @@ -5568,7 +5571,7 @@ testcase TC_SM_DP_ES9_InitiateAuthenticationBRP_01_Nominal() runs on MTC_CT { var smdpp_ConnHdlrPars pars := f_init_pars(); - pars.smdp_es9p_server_port := 8001; /* BRP server port */ + pars.smdp_es9p_server_port := mp_es9plus_server_port_brp; /* BRP server port */ pars.cert_name_filter := "BRP"; /* Use Brainpool certificates */ pars.euicc_cert_path := "./sgp26/eUICC/CERT_EUICC_ECDSA_BRP.der"; pars.euicc_key_path := "./sgp26/eUICC/SK_EUICC_ECDSA_BRP.pem"; @@ -5581,7 +5584,7 @@ testcase TC_SM_DP_ES9_AuthenticateClientBRP_01_Nominal() runs on MTC_CT { var smdpp_ConnHdlrPars pars := f_init_pars(); - pars.smdp_es9p_server_port := 8001; /* BRP server port */ + pars.smdp_es9p_server_port := mp_es9plus_server_port_brp; /* BRP server port */ pars.cert_name_filter := "BRP"; /* Use Brainpool certificates */ pars.euicc_cert_path := "./sgp26/eUICC/CERT_EUICC_ECDSA_BRP.der"; pars.euicc_key_path := "./sgp26/eUICC/SK_EUICC_ECDSA_BRP.pem"; @@ -5594,7 +5597,7 @@ testcase TC_SM_DP_ES9_GetBoundProfilePackageBRP_01_Nominal() runs on MTC_CT { var smdpp_ConnHdlrPars pars := f_init_pars(); - pars.smdp_es9p_server_port := 8001; /* BRP server port */ + pars.smdp_es9p_server_port := mp_es9plus_server_port_brp; /* BRP server port */ pars.cert_name_filter := "BRP"; /* Use Brainpool certificates */ pars.euicc_cert_path := "./sgp26/eUICC/CERT_EUICC_ECDSA_BRP.der"; pars.euicc_key_path := "./sgp26/eUICC/SK_EUICC_ECDSA_BRP.pem"; @@ -5607,7 +5610,7 @@ testcase TC_rsp_complete_flow_BRP() runs on MTC_CT { var smdpp_ConnHdlrPars pars := f_init_pars(); - pars.smdp_es9p_server_port := 8001; /* BRP server port */ + pars.smdp_es9p_server_port := mp_es9plus_server_port_brp; /* BRP server port */ pars.cert_name_filter := "BRP"; /* Use Brainpool certificates */ pars.euicc_cert_path := "./sgp26/eUICC/CERT_EUICC_ECDSA_BRP.der"; pars.euicc_key_path := "./sgp26/eUICC/SK_EUICC_ECDSA_BRP.pem"; @@ -5620,7 +5623,7 @@ testcase TC_SM_DP_ES9_HandleNotificationBRP() runs on MTC_CT { var smdpp_ConnHdlrPars pars := f_init_pars(); - pars.smdp_es9p_server_port := 8001; /* BRP server port */ + pars.smdp_es9p_server_port := mp_es9plus_server_port_brp; /* BRP server port */ pars.cert_name_filter := "BRP"; /* Use Brainpool certificates */ pars.euicc_cert_path := "./sgp26/eUICC/CERT_EUICC_ECDSA_BRP.der"; pars.euicc_key_path := "./sgp26/eUICC/SK_EUICC_ECDSA_BRP.pem"; @@ -5633,7 +5636,7 @@ testcase TC_SM_DP_ES9_CancelSession_After_AuthenticateClientBRP() runs on MTC_CT { var smdpp_ConnHdlrPars pars := f_init_pars(); - pars.smdp_es9p_server_port := 8001; /* BRP server port */ + pars.smdp_es9p_server_port := mp_es9plus_server_port_brp; /* BRP server port */ pars.cert_name_filter := "BRP"; /* Use Brainpool certificates */ pars.euicc_cert_path := "./sgp26/eUICC/CERT_EUICC_ECDSA_BRP.der"; pars.euicc_key_path := "./sgp26/eUICC/SK_EUICC_ECDSA_BRP.pem"; @@ -5646,7 +5649,7 @@ testcase TC_SM_DP_ES9_CancelSession_After_GetBoundProfilePackageBRP() runs on MTC_CT { var smdpp_ConnHdlrPars pars := f_init_pars(); - pars.smdp_es9p_server_port := 8001; /* BRP server port */ + pars.smdp_es9p_server_port := mp_es9plus_server_port_brp; /* BRP server port */ pars.cert_name_filter := "BRP"; /* Use Brainpool certificates */ pars.euicc_cert_path := "./sgp26/eUICC/CERT_EUICC_ECDSA_BRP.der"; pars.euicc_key_path := "./sgp26/eUICC/SK_EUICC_ECDSA_BRP.pem"; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41234?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I17f2713088c583bec26a0a8cdff40c796e0a490b Gerrit-Change-Number: 41234 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: smdpp_Tests: make ES9+ and ES2+ ports configurable
by osmith 21 Oct '25

21 Oct '25

Attention is currently required from: dexter. osmith has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41234?usp=email ) Change subject: smdpp_Tests: make ES9+ and ES2+ ports configurable ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41234?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I17f2713088c583bec26a0a8cdff40c796e0a490b Gerrit-Change-Number: 41234 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Oct 2025 13:26:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: smdpp_Tests: make ES9+ and ES2+ ports configurable
by dexter 21 Oct '25

21 Oct '25

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41234?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: smdpp_Tests: make ES9+ and ES2+ ports configurable ...................................................................... smdpp_Tests: make ES9+ and ES2+ ports configurable Change-Id: I17f2713088c583bec26a0a8cdff40c796e0a490b Related: SYS#7339 --- M smdpp/smdpp_Tests.cfg M smdpp/smdpp_Tests.ttcn 2 files changed, 15 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/34/41234/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41234?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I17f2713088c583bec26a0a8cdff40c796e0a490b Gerrit-Change-Number: 41234 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

2025

2024

2023

2022

gerrit-log October 2025