October 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: Correctly calculate size iofd_msgb_alloc2()
by jolly 27 Oct '25

27 Oct '25

Attention is currently required from: jolly, laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41138?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review-1 by pespin, Verified+1 by Jenkins Builder Change subject: Correctly calculate size iofd_msgb_alloc2() ...................................................................... Correctly calculate size iofd_msgb_alloc2() The storage size of 'headroom' must be larger than 16 bits. Otherwise a value above 65535 cannot be stored correctly and cause wrong calculation of msgb size. Related: Coverity CID#548925 Change-Id: I16c1e08fb64a1fafaeee1844fd8c00ecc2861d12 --- M src/core/osmo_io.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/38/41138/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41138?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I16c1e08fb64a1fafaeee1844fd8c00ecc2861d12 Gerrit-Change-Number: 41138 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: ES2Plus_Tests: remove unused module parameter
by dexter 27 Oct '25

27 Oct '25

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41260?usp=email ) Change subject: ES2Plus_Tests: remove unused module parameter ...................................................................... ES2Plus_Tests: remove unused module parameter Change-Id: I98921155d74209ffe97d6981a1d65a4424ef918c Related: SYS#7339 --- M smdpp/ES2Plus_Tests.ttcn 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: dexter: Looks good to me, approved Jenkins Builder: Verified diff --git a/smdpp/ES2Plus_Tests.ttcn b/smdpp/ES2Plus_Tests.ttcn index 1f962cf..fa3f376 100644 --- a/smdpp/ES2Plus_Tests.ttcn +++ b/smdpp/ES2Plus_Tests.ttcn @@ -62,10 +62,6 @@ charstring mp_operator_id := "test.operator.com"; // ES2+ normally uses SSL with client authentication, however for debug purposes it is possible to disable - // SSL entirely. - boolean mp_use_ssl := true; // SSL with mutual TLS authentication enabled - - // ES2+ normally uses SSL with client authentication, however for debug purposes it is possible to disable // mutual authentication. boolean mp_use_mutual_tls := true; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41260?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I98921155d74209ffe97d6981a1d65a4424ef918c Gerrit-Change-Number: 41260 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: ES2Plus_Tests: remove unused module parameter
by dexter 27 Oct '25

27 Oct '25

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41260?usp=email ) Change subject: ES2Plus_Tests: remove unused module parameter ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41260?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I98921155d74209ffe97d6981a1d65a4424ef918c Gerrit-Change-Number: 41260 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Oct 2025 10:59:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: ES2Plus_Tests: remove unused module parameter
by dexter 27 Oct '25

27 Oct '25

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41260?usp=email ) Change subject: ES2Plus_Tests: remove unused module parameter ...................................................................... ES2Plus_Tests: remove unused module parameter Change-Id: I98921155d74209ffe97d6981a1d65a4424ef918c Related: SYS#7339 --- M smdpp/ES2Plus_Tests.ttcn 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/60/41260/1 diff --git a/smdpp/ES2Plus_Tests.ttcn b/smdpp/ES2Plus_Tests.ttcn index 1f962cf..fa3f376 100644 --- a/smdpp/ES2Plus_Tests.ttcn +++ b/smdpp/ES2Plus_Tests.ttcn @@ -62,10 +62,6 @@ charstring mp_operator_id := "test.operator.com"; // ES2+ normally uses SSL with client authentication, however for debug purposes it is possible to disable - // SSL entirely. - boolean mp_use_ssl := true; // SSL with mutual TLS authentication enabled - - // ES2+ normally uses SSL with client authentication, however for debug purposes it is possible to disable // mutual authentication. boolean mp_use_mutual_tls := true; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41260?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I98921155d74209ffe97d6981a1d65a4424ef918c Gerrit-Change-Number: 41260 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: smdpp_Tests: move module parameter up
by dexter 27 Oct '25

27 Oct '25

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41259?usp=email ) Change subject: smdpp_Tests: move module parameter up ...................................................................... smdpp_Tests: move module parameter up The module parameters are somewhere in the middle of the module code. Let's put them to the top to make it easier to find them. Change-Id: I8d0fae934e48eb55d78bfa904be064c2613930a8 Related: SYS#7339 --- M smdpp/smdpp_Tests.ttcn 1 file changed, 9 insertions(+), 8 deletions(-) Approvals: dexter: Looks good to me, approved Jenkins Builder: Verified diff --git a/smdpp/smdpp_Tests.ttcn b/smdpp/smdpp_Tests.ttcn index 119ad08..9c453c2 100644 --- a/smdpp/smdpp_Tests.ttcn +++ b/smdpp/smdpp_Tests.ttcn @@ -34,6 +34,15 @@ import from esx_header_Types_JSON all; import from ES2Plus_Tests all; +/* Module Parameters */ +modulepar { + boolean mp_use_custom_tls_cert := true; + charstring mp_custom_tls_cert_path := ""; // Empty means use cert pool only + integer mp_es9plus_server_port_nist := 8000; + integer mp_es9plus_server_port_brp := 8001; + integer mp_es2plus_server_port := 8000; +} + /* C++ handles only crypto, TTCN-3 handles ASN.1 encoding/decoding most of the time */ /* RSP Client Management */ @@ -418,14 +427,6 @@ return pars; } -modulepar { - boolean mp_use_custom_tls_cert := true; - charstring mp_custom_tls_cert_path := ""; // Empty means use cert pool only - integer mp_es9plus_server_port_nist := 8000; - integer mp_es9plus_server_port_brp := 8001; - integer mp_es2plus_server_port := 8000; -} - private altstep as_Tguard() runs on MTC_CT { [] g_Tguard.timeout { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Tguard timeout"); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41259?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d0fae934e48eb55d78bfa904be064c2613930a8 Gerrit-Change-Number: 41259 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: smdpp_Tests: move module parameter up
by dexter 27 Oct '25

27 Oct '25

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41259?usp=email ) Change subject: smdpp_Tests: move module parameter up ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41259?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d0fae934e48eb55d78bfa904be064c2613930a8 Gerrit-Change-Number: 41259 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Oct 2025 10:47:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: ES2Plus_Tests: fix typo
by dexter 27 Oct '25

27 Oct '25

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41258?usp=email ) Change subject: ES2Plus_Tests: fix typo ...................................................................... ES2Plus_Tests: fix typo Related: SYS#7339 Change-Id: I510a879042977b6ef1cd19e5a66fceeefa42e0c1 --- M smdpp/ES2Plus_Tests.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: dexter: Looks good to me, approved Jenkins Builder: Verified diff --git a/smdpp/ES2Plus_Tests.ttcn b/smdpp/ES2Plus_Tests.ttcn index 3303d7d..1f962cf 100644 --- a/smdpp/ES2Plus_Tests.ttcn +++ b/smdpp/ES2Plus_Tests.ttcn @@ -35,7 +35,7 @@ const charstring c_wrong_key_path := "./sgp26/eUICC/SK_EUICC_ECDSA_NIST.pem"; // The external function ext_RSPClient_create requires a path and a name filter as input to load test certificates. -// While those certfiicates are required for the ES9+ interface related tests (smdpp_Tests.ttcn), for the ES2+ +// While those certificates are required for the ES9+ interface related tests (smdpp_Tests.ttcn), for the ES2+ // interface tests those certificates have no relevance. const charstring c_es2plus_cert_path := "./sgp26/"; const charstring c_es2plus_cert_name_filter := "NIST"; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41258?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I510a879042977b6ef1cd19e5a66fceeefa42e0c1 Gerrit-Change-Number: 41258 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: ES2Plus_Tests: fix typo
by dexter 27 Oct '25

27 Oct '25

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41258?usp=email ) Change subject: ES2Plus_Tests: fix typo ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41258?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I510a879042977b6ef1cd19e5a66fceeefa42e0c1 Gerrit-Change-Number: 41258 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Oct 2025 10:47:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: ES2Plus_Tests: fix typo
by dexter 27 Oct '25

27 Oct '25

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41258?usp=email ) Change subject: ES2Plus_Tests: fix typo ...................................................................... ES2Plus_Tests: fix typo Related: SYS#7339 Change-Id: I510a879042977b6ef1cd19e5a66fceeefa42e0c1 --- M smdpp/ES2Plus_Tests.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/58/41258/1 diff --git a/smdpp/ES2Plus_Tests.ttcn b/smdpp/ES2Plus_Tests.ttcn index 3303d7d..1f962cf 100644 --- a/smdpp/ES2Plus_Tests.ttcn +++ b/smdpp/ES2Plus_Tests.ttcn @@ -35,7 +35,7 @@ const charstring c_wrong_key_path := "./sgp26/eUICC/SK_EUICC_ECDSA_NIST.pem"; // The external function ext_RSPClient_create requires a path and a name filter as input to load test certificates. -// While those certfiicates are required for the ES9+ interface related tests (smdpp_Tests.ttcn), for the ES2+ +// While those certificates are required for the ES9+ interface related tests (smdpp_Tests.ttcn), for the ES2+ // interface tests those certificates have no relevance. const charstring c_es2plus_cert_path := "./sgp26/"; const charstring c_es2plus_cert_name_filter := "NIST"; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41258?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I510a879042977b6ef1cd19e5a66fceeefa42e0c1 Gerrit-Change-Number: 41258 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: smdpp_Tests: move module parameter up
by dexter 27 Oct '25

27 Oct '25

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41259?usp=email ) Change subject: smdpp_Tests: move module parameter up ...................................................................... smdpp_Tests: move module parameter up The module parameters are somewhere in the middle of the module code. Let's put them to the top to make it easier to find them. Change-Id: I8d0fae934e48eb55d78bfa904be064c2613930a8 Related: SYS#7339 --- M smdpp/smdpp_Tests.ttcn 1 file changed, 9 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/59/41259/1 diff --git a/smdpp/smdpp_Tests.ttcn b/smdpp/smdpp_Tests.ttcn index 119ad08..9c453c2 100644 --- a/smdpp/smdpp_Tests.ttcn +++ b/smdpp/smdpp_Tests.ttcn @@ -34,6 +34,15 @@ import from esx_header_Types_JSON all; import from ES2Plus_Tests all; +/* Module Parameters */ +modulepar { + boolean mp_use_custom_tls_cert := true; + charstring mp_custom_tls_cert_path := ""; // Empty means use cert pool only + integer mp_es9plus_server_port_nist := 8000; + integer mp_es9plus_server_port_brp := 8001; + integer mp_es2plus_server_port := 8000; +} + /* C++ handles only crypto, TTCN-3 handles ASN.1 encoding/decoding most of the time */ /* RSP Client Management */ @@ -418,14 +427,6 @@ return pars; } -modulepar { - boolean mp_use_custom_tls_cert := true; - charstring mp_custom_tls_cert_path := ""; // Empty means use cert pool only - integer mp_es9plus_server_port_nist := 8000; - integer mp_es9plus_server_port_brp := 8001; - integer mp_es2plus_server_port := 8000; -} - private altstep as_Tguard() runs on MTC_CT { [] g_Tguard.timeout { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Tguard timeout"); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41259?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d0fae934e48eb55d78bfa904be064c2613930a8 Gerrit-Change-Number: 41259 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0