Attention is currently required from: laforge, neels, pespin.
osmith has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41192?usp=email )
Change subject: fix SCCP_MAX_OPTIONAL_DATA 128
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> I'm looking into why CI fails
CI had failed, because VTY tests were not adjusted (as Pau noted above). I've adjusted it there and also the VTY description that still said 130.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41192?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I841dbb2e8cbc13708ba7f5593f6bdd3b8da4329c
Gerrit-Change-Number: 41192
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 22 Oct 2025 07:57:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Attention is currently required from: laforge, neels, pespin.
osmith has uploaded a new patch set (#2) to the change originally created by neels. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41192?usp=email )
The following approvals got outdated and were removed:
Code-Review+1 by pespin, Code-Review+2 by laforge, Verified-1 by Jenkins Builder
Change subject: fix SCCP_MAX_OPTIONAL_DATA 128
......................................................................
fix SCCP_MAX_OPTIONAL_DATA 128
Related: SYS#7600
Change-Id: I841dbb2e8cbc13708ba7f5593f6bdd3b8da4329c
---
M include/osmocom/sccp/sccp_types.h
M src/sccp_vty.c
M tests/vty/osmo_stp_test.vty
M tests/vty/ss7_asp_test.vty
4 files changed, 26 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/92/41192/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41192?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I841dbb2e8cbc13708ba7f5593f6bdd3b8da4329c
Gerrit-Change-Number: 41192
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: neels.
osmith has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41192?usp=email )
Change subject: fix SCCP_MAX_OPTIONAL_DATA 128
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I would actually say this should als trigger a patch release of (at the very least) the mos recent l […]
ack, I'll prepare the patch release
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41192?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I841dbb2e8cbc13708ba7f5593f6bdd3b8da4329c
Gerrit-Change-Number: 41192
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 22 Oct 2025 07:09:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>