dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41266?usp=email )
Change subject: ES2Plus_Tests: rename mp_es2plus_server_host to _fqdn
......................................................................
ES2Plus_Tests: rename mp_es2plus_server_host to _fqdn
Let's rename the module parameter mp_es2plus_server_host to
mp_es2plus_server_fqdn. The reason for this is that the suffix "host"
suggests that one may use an arbitrary hostname or IP address. In
this case this is in fact not true. The FQDN must match the hostname
of the SSL server certificate. Apart from that GSMA SGP.22 always
uses the word "FQDN" in their specs.
Change-Id: Idedfcce4d013c32f43307e159c45854a1e6a049b
Related: SYS#7339
---
M smdpp/ES2Plus_Tests.cfg
M smdpp/ES2Plus_Tests.ttcn
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/66/41266/1
diff --git a/smdpp/ES2Plus_Tests.cfg b/smdpp/ES2Plus_Tests.cfg
index 8be08ff..695f54c 100644
--- a/smdpp/ES2Plus_Tests.cfg
+++ b/smdpp/ES2Plus_Tests.cfg
@@ -8,7 +8,7 @@
[MODULE_PARAMETERS]
# ES2+ specific parameters
-ES2Plus_Tests.mp_es2plus_server_host := "127.0.0.1"
+ES2Plus_Tests.mp_es2plus_server_fqdn := "127.0.0.1" # Must match the hostname of the server SSL certificate!
ES2Plus_Tests.mp_es2plus_server_port := 8000 # NIST tests use port 8000
ES2Plus_Tests.mp_es2plus_operator_id := "test.operator.com"
diff --git a/smdpp/ES2Plus_Tests.ttcn b/smdpp/ES2Plus_Tests.ttcn
index 63e3a64..c6765f4 100644
--- a/smdpp/ES2Plus_Tests.ttcn
+++ b/smdpp/ES2Plus_Tests.ttcn
@@ -47,7 +47,7 @@
// testsuite (libcurl) will also verify the presented server certificate against the related CA. To ensure that
// the server certificate verification is possible, ensure that the related CA certificates are made available in
// /etc/ssl/certs
- charstring mp_es2plus_server_host := "testsmdpplus1.example.com";
+ charstring mp_es2plus_server_fqdn := "testsmdpplus1.example.com";
// Sets the server port of the ES2+ server (SM-DP+).
integer mp_es2plus_server_port := 8000;
@@ -191,7 +191,7 @@
function f_init_es2plus() runs on ES2Plus_ConnHdlr {
// Initialize RSP client using imported function from smdpp_Tests
g_rsp_client_handle := smdpp_Tests.ext_RSPClient_create(
- mp_es2plus_server_host,
+ mp_es2plus_server_fqdn,
mp_es2plus_server_port,
c_es2plus_cert_path,
c_es2plus_cert_name_filter
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41266?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Idedfcce4d013c32f43307e159c45854a1e6a049b
Gerrit-Change-Number: 41266
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41264?usp=email )
Change subject: ES2Plus_Tests: improve error messages when setting verdict in f_init_es2plus
......................................................................
ES2Plus_Tests: improve error messages when setting verdict in f_init_es2plus
It is not enough to say something has failed, it is also important
to say what exactly and what for.
Related: SYS#7339
Change-Id: I1a4aa85e3b1950eae0f910a14a95afa8e16c9cf6
---
M smdpp/ES2Plus_Tests.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
dexter: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/smdpp/ES2Plus_Tests.ttcn b/smdpp/ES2Plus_Tests.ttcn
index fa3f376..ece4cc1 100644
--- a/smdpp/ES2Plus_Tests.ttcn
+++ b/smdpp/ES2Plus_Tests.ttcn
@@ -198,7 +198,7 @@
);
if (g_rsp_client_handle < 0) {
- setverdict(fail, "Failed to initialize RSP client");
+ setverdict(fail, "Failed to initialize RSP client for ES2+");
mtc.stop;
}
@@ -211,7 +211,7 @@
);
if (result != 0) {
- setverdict(fail, "Failed to set authentication parameters");
+ setverdict(fail, "Failed to set RSP client authentication parameters for ES2+");
mtc.stop;
}
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41264?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1a4aa85e3b1950eae0f910a14a95afa8e16c9cf6
Gerrit-Change-Number: 41264
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41264?usp=email )
Change subject: ES2Plus_Tests: improve error messages when setting verdict in f_init_es2plus
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41264?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1a4aa85e3b1950eae0f910a14a95afa8e16c9cf6
Gerrit-Change-Number: 41264
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 27 Oct 2025 14:29:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41264?usp=email )
Change subject: ES2Plus_Tests: improve error messages when setting verdict in f_init_es2plus
......................................................................
ES2Plus_Tests: improve error messages when setting verdict in f_init_es2plus
It is not enough to say something has failed, it is also important
to say what exactly and what for.
Related: SYS#7339
Change-Id: I1a4aa85e3b1950eae0f910a14a95afa8e16c9cf6
---
M smdpp/ES2Plus_Tests.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/64/41264/1
diff --git a/smdpp/ES2Plus_Tests.ttcn b/smdpp/ES2Plus_Tests.ttcn
index fa3f376..ece4cc1 100644
--- a/smdpp/ES2Plus_Tests.ttcn
+++ b/smdpp/ES2Plus_Tests.ttcn
@@ -198,7 +198,7 @@
);
if (g_rsp_client_handle < 0) {
- setverdict(fail, "Failed to initialize RSP client");
+ setverdict(fail, "Failed to initialize RSP client for ES2+");
mtc.stop;
}
@@ -211,7 +211,7 @@
);
if (result != 0) {
- setverdict(fail, "Failed to set authentication parameters");
+ setverdict(fail, "Failed to set RSP client authentication parameters for ES2+");
mtc.stop;
}
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41264?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1a4aa85e3b1950eae0f910a14a95afa8e16c9cf6
Gerrit-Change-Number: 41264
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>